Re: Review Request: Simplest Image Hosting support for pastebin applet
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1251/ --- (Updated 2009-08-30 11:53:32.697101) Review request for Plasma. Changes --- Updated to last changes and added buddies for all labels in configuration dialog. Warning! Diff is available at http://pastebin.ca/1548163 (couldn't update here, upload fails...). Summary (updated) --- This patch adds support for Simplest Image Hosting (http://simplest-image-hosting.net/) to pastebin applet and additionally adds buddies for labels in configuration dialog. New diff is available here (can't upload new for unknown reason :-/): http://pastebin.ca/1548163 Diffs - /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinConfig.ui 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinServersConfig.ui 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/backends.h 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.h PRE-CREATION Diff: http://reviewboard.kde.org/r/1251/diff Testing (updated) --- Works fine. Thanks, Michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Simplest Image Hosting support for pastebin applet
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1251/ --- (Updated 2009-08-30 12:13:25.327179) Review request for Plasma. Changes --- Finally uploaded new diff... Summary (updated) --- This patch adds support for Simplest Image Hosting (http://simplest-image-hosting.net/) to pastebin applet and additionally adds buddies for labels in configuration dialog. Diffs (updated) - /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt 1017356 /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/backends.h 1017356 /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.h PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 1017356 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 1017356 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinConfig.ui 1017356 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinServersConfig.ui 1017356 Diff: http://reviewboard.kde.org/r/1251/diff Testing --- Works fine. Thanks, Michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Simplest Image Hosting support for pastebin applet
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1251/#review2189 --- Ship it! Do you have an svn account to ship it ? Otherwise just poke me on IRC. - Artur On 2009-08-30 12:13:25, Michal Dutkiewicz wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1251/ --- (Updated 2009-08-30 12:13:25) Review request for Plasma. Summary --- This patch adds support for Simplest Image Hosting (http://simplest-image-hosting.net/) to pastebin applet and additionally adds buddies for labels in configuration dialog. Diffs - /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt 1017356 /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/backends.h 1017356 /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.h PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 1017356 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 1017356 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinConfig.ui 1017356 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinServersConfig.ui 1017356 Diff: http://reviewboard.kde.org/r/1251/diff Testing --- Works fine. Thanks, Michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Simplest Image Hosting support for pastebin applet
On 2009-08-30 16:51:34, Artur de Souza (MoRpHeUz) wrote: Do you have an svn account to ship it ? Otherwise just poke me on IRC. I have one, I'll commit it now. :-) - Michal --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1251/#review2189 --- On 2009-08-30 12:13:25, Michal Dutkiewicz wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1251/ --- (Updated 2009-08-30 12:13:25) Review request for Plasma. Summary --- This patch adds support for Simplest Image Hosting (http://simplest-image-hosting.net/) to pastebin applet and additionally adds buddies for labels in configuration dialog. Diffs - /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt 1017356 /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/backends.h 1017356 /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.h PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 1017356 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 1017356 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinConfig.ui 1017356 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinServersConfig.ui 1017356 Diff: http://reviewboard.kde.org/r/1251/diff Testing --- Works fine. Thanks, Michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Simplest Image Hosting support for pastebin applet
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1251/#review1948 --- hmm, I can't really comment on the nontrivial parts of the code... I don't see anything bad, but I'm also half asleep. getting an error icon on success is bad... /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp http://reviewboard.kde.org/r/1251/#comment1305 42 + 13? /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp http://reviewboard.kde.org/r/1251/#comment1304 why are all these image server classes being cast to themselves? - Chani On 2009-08-09 21:08:23, Michal Dutkiewicz wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1251/ --- (Updated 2009-08-09 21:08:23) Review request for Plasma. Summary --- This patch adds support for Simplest Image Hosting (http://simplest-image-hosting.net/) to pastebin applet. Diffs - /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/backends.h 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.h PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinConfig.ui 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinServersConfig.ui 1008396 Diff: http://reviewboard.kde.org/r/1251/diff Testing --- Works fine except showing error icon even if upload is successful (there is success notification and link is added to history). Thanks, Michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Simplest Image Hosting support for pastebin applet
On 2009-08-10 06:41:57, Chani wrote: /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp, line 43 http://reviewboard.kde.org/r/1251/diff/1/?file=9802#file9802line43 42 + 13? This is taken from Imageshack backend, strange notation indeed. ;-) On 2009-08-10 06:41:57, Chani wrote: /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp, line 101 http://reviewboard.kde.org/r/1251/diff/1/?file=9804#file9804line101 why are all these image server classes being cast to themselves? This is also question to applet developer, I can later create patch that fixes thinks like that and also adds possibility to show error message (at least this backend can show different error messages, API returns codes). - Michal --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1251/#review1948 --- On 2009-08-09 21:08:23, Michal Dutkiewicz wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1251/ --- (Updated 2009-08-09 21:08:23) Review request for Plasma. Summary --- This patch adds support for Simplest Image Hosting (http://simplest-image-hosting.net/) to pastebin applet. Diffs - /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/backends.h 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.h PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinConfig.ui 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinServersConfig.ui 1008396 Diff: http://reviewboard.kde.org/r/1251/diff Testing --- Works fine except showing error icon even if upload is successful (there is success notification and link is added to history). Thanks, Michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Simplest Image Hosting support for pastebin applet
This is kind of unrelated but wouldn't it be a good thing to turn the upload backends into a plasma data engine? I can see other plasmoids making use of uploading pics and even kde apps like ksnapshot but I have no idea whether kde apps can make use of plasma engines. -Pat ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Simplest Image Hosting support for pastebin applet
On Monday 10 August 2009, 03:41 Chani wrote: /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting. cpp http://reviewboard.kde.org/r/1251/#comment1305 42 + 13? If I'm not wrong, this was taken from flickr upload plugin on kipi_plugins. -- Artur Duque de Souza openBossa Research Labs INdT - Instituto Nokia de Tecnologia -- Blog: http://blog.morpheuz.cc PGP: 0xDBEEAAC3 @ wwwkeys.pgp.net -- signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Simplest Image Hosting support for pastebin applet
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1251/#review1950 --- /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp http://reviewboard.kde.org/r/1251/#comment1308 maybe you get the error post icon even after a successful post because it tries to retrieve more data and then you fall in this place. not sure though and right now I don't have the time to test. Check form where postError() is being emited on your backend code. (probably from here) /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp http://reviewboard.kde.org/r/1251/#comment1309 Yes, we can remove all this dummy casts. /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinServersConfig.ui http://reviewboard.kde.org/r/1251/#comment1310 With more plugins being added we need to properly fix this config tab now. We postponed this as much as we could but now we should do it properly. I'll come with something later (plane to tokamak? hehe). - Artur On 2009-08-09 21:08:23, Michal Dutkiewicz wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1251/ --- (Updated 2009-08-09 21:08:23) Review request for Plasma. Summary --- This patch adds support for Simplest Image Hosting (http://simplest-image-hosting.net/) to pastebin applet. Diffs - /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/backends.h 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.h PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinConfig.ui 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinServersConfig.ui 1008396 Diff: http://reviewboard.kde.org/r/1251/diff Testing --- Works fine except showing error icon even if upload is successful (there is success notification and link is added to history). Thanks, Michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Simplest Image Hosting support for pastebin applet
On August 10, 2009 00:13:41 Patrick Aljord wrote: This is kind of unrelated but wouldn't it be a good thing to turn the upload backends into a plasma data engine? I can see other plasmoids making use of uploading pics and even kde apps like ksnapshot but I have no idea whether kde apps can make use of plasma engines. +1 and I believe there was some vague intention to someday make it possible for other apps to access dataengines; I don't think anyone's had time to actively work on it though? -- This message brought to you by eevil bananas and the number 3. www.chani3.com signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Simplest Image Hosting support for pastebin applet
On 2009-08-10 12:00:23, Artur de Souza (MoRpHeUz) wrote: /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp, line 54 http://reviewboard.kde.org/r/1251/diff/1/?file=9802#file9802line54 maybe you get the error post icon even after a successful post because it tries to retrieve more data and then you fall in this place. not sure though and right now I don't have the time to test. Check form where postError() is being emited on your backend code. (probably from here) Thanks for the hint, I'll test it with qDebug(). ;-) On 2009-08-10 12:00:23, Artur de Souza (MoRpHeUz) wrote: /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinServersConfig.ui, line 57 http://reviewboard.kde.org/r/1251/diff/1/?file=9806#file9806line57 With more plugins being added we need to properly fix this config tab now. We postponed this as much as we could but now we should do it properly. I'll come with something later (plane to tokamak? hehe). Yes, this should be done cleaner, maybe it is possible to create kind of service for backends and use them through data engine, as mentioned earlier? - Michal --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1251/#review1950 --- On 2009-08-09 21:08:23, Michal Dutkiewicz wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1251/ --- (Updated 2009-08-09 21:08:23) Review request for Plasma. Summary --- This patch adds support for Simplest Image Hosting (http://simplest-image-hosting.net/) to pastebin applet. Diffs - /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/backends.h 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.h PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinConfig.ui 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinServersConfig.ui 1008396 Diff: http://reviewboard.kde.org/r/1251/diff Testing --- Works fine except showing error icon even if upload is successful (there is success notification and link is added to history). Thanks, Michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Simplest Image Hosting support for pastebin applet
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1251/ --- (Updated 2009-08-10 16:41:16.451067) Review request for Plasma. Changes --- Fixed showing error notification on success. This was indeed second call of that method with empty data (strange, there should be no redirection, there was comment about that in imageshack backend). Summary --- This patch adds support for Simplest Image Hosting (http://simplest-image-hosting.net/) to pastebin applet. Diffs (updated) - /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/backends.h 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.h PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinConfig.ui 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinServersConfig.ui 1008396 Diff: http://reviewboard.kde.org/r/1251/diff Testing --- Works fine except showing error icon even if upload is successful (there is success notification and link is added to history). Thanks, Michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Simplest Image Hosting support for pastebin applet
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1251/#review1964
---
/trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp
http://reviewboard.kde.org/r/1251/#comment1316
Minor but important: not sure if kdeplasma-addons have coding style
guidelines but following kdelibs, if statements should have the { on the
same line :)
- Artur
On 2009-08-10 16:41:16, Michal Dutkiewicz wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1251/
---
(Updated 2009-08-10 16:41:16)
Review request for Plasma.
Summary
---
This patch adds support for Simplest Image Hosting
(http://simplest-image-hosting.net/) to pastebin applet.
Diffs
-
/trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt 1008396
/trunk/KDE/kdeplasma-addons/applets/pastebin/backends/backends.h 1008396
/trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.h
PRE-CREATION
/trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp
PRE-CREATION
/trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 1008396
/trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 1008396
/trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinConfig.ui 1008396
/trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinServersConfig.ui
1008396
Diff: http://reviewboard.kde.org/r/1251/diff
Testing
---
Works fine except showing error icon even if upload is successful (there is
success notification and link is added to history).
Thanks,
Michal
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Simplest Image Hosting support for pastebin applet
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1251/ --- (Updated 2009-08-10 16:56:55.220998) Review request for Plasma. Changes --- Fixed coding style. Summary --- This patch adds support for Simplest Image Hosting (http://simplest-image-hosting.net/) to pastebin applet. Diffs (updated) - /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinConfig.ui 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinServersConfig.ui 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/backends.h 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.h PRE-CREATION Diff: http://reviewboard.kde.org/r/1251/diff Testing --- Works fine except showing error icon even if upload is successful (there is success notification and link is added to history). Thanks, Michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Simplest Image Hosting support for pastebin applet
On 2009-08-10 16:51:06, Artur de Souza (MoRpHeUz) wrote:
/trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp,
line 57
http://reviewboard.kde.org/r/1251/diff/1/?file=9802#file9802line57
Minor but important: not sure if kdeplasma-addons have coding style
guidelines but following kdelibs, if statements should have the { on
the same line :)
Fixed in new diff.
Personally I don't use in my work that coding style (I was using it for some
years, but new line is more readable for me and not only me ;-)).
By the way, I could try to rewrite this applet from scratch and add for example
support for error messages (SIH returns different error messages for example),
that could be passed as signal parameter.
- Michal
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1251/#review1964
---
On 2009-08-10 16:56:55, Michal Dutkiewicz wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1251/
---
(Updated 2009-08-10 16:56:55)
Review request for Plasma.
Summary
---
This patch adds support for Simplest Image Hosting
(http://simplest-image-hosting.net/) to pastebin applet.
Diffs
-
/trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 1008396
/trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 1008396
/trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinConfig.ui 1008396
/trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinServersConfig.ui
1008396
/trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp
PRE-CREATION
/trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt 1008396
/trunk/KDE/kdeplasma-addons/applets/pastebin/backends/backends.h 1008396
/trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.h
PRE-CREATION
Diff: http://reviewboard.kde.org/r/1251/diff
Testing
---
Works fine except showing error icon even if upload is successful (there is
success notification and link is added to history).
Thanks,
Michal
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Simplest Image Hosting support for pastebin applet
On Monday 10 August 2009, 14:00 Michal Dutkiewicz wrote: By the way, I could try to rewrite this applet from scratch and add for example support for error messages (SIH returns different error messages for example), that could be passed as signal parameter. Actually rewriting it to support more features is probably not the best way to go (I've been there once hehe). The correct way should be to separate this and use the plasma infrastructure (dataengines/services) to have the backends. Because every time a new pastebin/imagebin server shows up with a new feature and then we have to update this thing. Also, the way it is now makes it hard to extend. So, if you want to rewrite, let's start by separating the backend's code from the frontend. And then this time we can make it work properly :) What do you think ? Cheers, -- Artur Duque de Souza openBossa Research Labs INdT - Instituto Nokia de Tecnologia -- Blog: http://blog.morpheuz.cc PGP: 0xDBEEAAC3 @ wwwkeys.pgp.net -- signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Simplest Image Hosting support for pastebin applet
On August 10, 2009 08:28:47 Chani wrote: On August 10, 2009 00:13:41 Patrick Aljord wrote: This is kind of unrelated but wouldn't it be a good thing to turn the upload backends into a plasma data engine? I can see other plasmoids making use of uploading pics and even kde apps like ksnapshot but I have no idea whether kde apps can make use of plasma engines. +1 and I believe there was some vague intention to someday make it possible for other apps to access dataengines; I don't think anyone's had time to actively work on it though? correction: any app can of course load dataengines via libplasma, like plasmaengineexplorer does. what they can't do atm is share one engine over several processes; each process runs its own instance of the dataengine. -- This message brought to you by eevil bananas and the number 3. www.chani3.com signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
