Re: Review Request 125187: Stop requiring Frameworks 5.15
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125187/ --- (Updated Sept. 22, 2015, 8:23 a.m.) Status -- This change has been discarded. Review request for Plasma and David Faure. Repository: plasma-workspace Description --- KDesktopFile.readMimeTypes(); hasn't made it into Frameworks 5.14, causing plasma-workspace git master to depend on yet unreleased version of KDE Frameworks to build. David Faure has suggested to use fix like this one until at least Frameworks 5.15 have been released. I don't have commit access, so someone needs to commit this for me. Diffs - applets/icon/plugin/icon_p.cpp 97af67a Diff: https://git.reviewboard.kde.org/r/125187/diff/ Testing --- It builds. Thanks, Armin K. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125187: Stop requiring Frameworks 5.15
> On Sept. 14, 2015, 8:44 a.m., Martin Gräßlin wrote: > > -2, a change for a month in the devel branch doesn't make much sense. > > David Faure wrote: > As you want. You're raising the bar for new contributors, who can't work > on your code using the latest KDE Frameworks release. > > You and me might compile everything, but you'll get more contributors if > you let people work on workspace and apps using a released frameworks (for > which there are distro packages) than if you require them to compile > frameworks first. Just like we don't require Qt from git, we shouldn't > require KF5 from git, I thought this was the general agreement. > > If you're worried about the ifdef, just use the two liner version of the > code forever, I was always a bit dubious about adding a method just for that > anyway. > > Martin Gräßlin wrote: > It's really not that uncommon to depend on latest frameworks in > workspace. It's common that I add things in KWindowSystem to make use of it > in KWin directly. Or lately I used lots of new functionalty from KGlobalAccel > directly. > > Yes it raises the entry level, but it's also rather unlikely that we are > able to a policy forbidding depending on frameworks master without CI checks. > > Sebastian Kügler wrote: > Besides, these occasional devs can use the stable branch en then forward > port? > > Marco Martin wrote: > -2 from here as well for the same reasons > > Ben Cooksley wrote: > Please note that the CI system is shifting towards only allowing usage of > released products. We'll also be imposing a dependency prohibition between > Applications and Plasma so there will no longer be any ability to have > dependencies between the two. > > Aleix Pol Gonzalez wrote: > @Ben: Really? Why? Where was this discussed? > > Martin Gräßlin wrote: > @Ben: where should libraries like kwayland and kdecoration go then? They > do not fit requirements of frameworks but might be useable to applications > (kwayland is a must have library for any wayland integration). > > Ben Cooksley wrote: > That has yet to be resolved. Likely another layer which will be released > as needed by Applications / Plasma which sits in between Frameworks and them > will be added I suspect. No binary compatibility commitments, same licensing > rules as Applications / Plasma, just a logically separate product so it > doesn't cause dependency problems. I don't expect too many libraries or > runtime components to end up there (Dr Konqi might perhaps?). > > Martin Gräßlin wrote: > Honestly: I don't see the point in that except of making everything more > complicated (yet another product which has a dedicated release cycle). If > applications want to depend on workspace libraries: that's fine. They know > what it means. We shouldn't prevent "stupid things" in the CI system. > > Armin K. wrote: > If this patch is to be discarded, kde frameworks dep should be raised to > 5.15, because it won't compile with 5.14 (which it currently requires) > without this change. You're right, thanks. done. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125187/#review85353 --- On Sept. 12, 2015, 9:38 a.m., Armin K. wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125187/ > --- > > (Updated Sept. 12, 2015, 9:38 a.m.) > > > Review request for Plasma and David Faure. > > > Repository: plasma-workspace > > > Description > --- > > KDesktopFile.readMimeTypes(); hasn't made it into Frameworks 5.14, causing > plasma-workspace git master to depend on yet unreleased version of KDE > Frameworks to build. David Faure has suggested to use fix like this one until > at least Frameworks 5.15 have been released. > > I don't have commit access, so someone needs to commit this for me. > > > Diffs > - > > applets/icon/plugin/icon_p.cpp 97af67a > > Diff: https://git.reviewboard.kde.org/r/125187/diff/ > > > Testing > --- > > It builds. > > > Thanks, > > Armin K. > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125187: Stop requiring Frameworks 5.15
> On Sept. 14, 2015, 8:44 a.m., Martin Gräßlin wrote: > > -2, a change for a month in the devel branch doesn't make much sense. > > David Faure wrote: > As you want. You're raising the bar for new contributors, who can't work > on your code using the latest KDE Frameworks release. > > You and me might compile everything, but you'll get more contributors if > you let people work on workspace and apps using a released frameworks (for > which there are distro packages) than if you require them to compile > frameworks first. Just like we don't require Qt from git, we shouldn't > require KF5 from git, I thought this was the general agreement. > > If you're worried about the ifdef, just use the two liner version of the > code forever, I was always a bit dubious about adding a method just for that > anyway. > > Martin Gräßlin wrote: > It's really not that uncommon to depend on latest frameworks in > workspace. It's common that I add things in KWindowSystem to make use of it > in KWin directly. Or lately I used lots of new functionalty from KGlobalAccel > directly. > > Yes it raises the entry level, but it's also rather unlikely that we are > able to a policy forbidding depending on frameworks master without CI checks. > > Sebastian Kügler wrote: > Besides, these occasional devs can use the stable branch en then forward > port? > > Marco Martin wrote: > -2 from here as well for the same reasons > > Ben Cooksley wrote: > Please note that the CI system is shifting towards only allowing usage of > released products. We'll also be imposing a dependency prohibition between > Applications and Plasma so there will no longer be any ability to have > dependencies between the two. > > Aleix Pol Gonzalez wrote: > @Ben: Really? Why? Where was this discussed? > > Martin Gräßlin wrote: > @Ben: where should libraries like kwayland and kdecoration go then? They > do not fit requirements of frameworks but might be useable to applications > (kwayland is a must have library for any wayland integration). > > Ben Cooksley wrote: > That has yet to be resolved. Likely another layer which will be released > as needed by Applications / Plasma which sits in between Frameworks and them > will be added I suspect. No binary compatibility commitments, same licensing > rules as Applications / Plasma, just a logically separate product so it > doesn't cause dependency problems. I don't expect too many libraries or > runtime components to end up there (Dr Konqi might perhaps?). > > Martin Gräßlin wrote: > Honestly: I don't see the point in that except of making everything more > complicated (yet another product which has a dedicated release cycle). If > applications want to depend on workspace libraries: that's fine. They know > what it means. We shouldn't prevent "stupid things" in the CI system. If this patch is to be discarded, kde frameworks dep should be raised to 5.15, because it won't compile with 5.14 (which it currently requires) without this change. - Armin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125187/#review85353 --- On Sept. 12, 2015, 9:38 a.m., Armin K. wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125187/ > --- > > (Updated Sept. 12, 2015, 9:38 a.m.) > > > Review request for Plasma and David Faure. > > > Repository: plasma-workspace > > > Description > --- > > KDesktopFile.readMimeTypes(); hasn't made it into Frameworks 5.14, causing > plasma-workspace git master to depend on yet unreleased version of KDE > Frameworks to build. David Faure has suggested to use fix like this one until > at least Frameworks 5.15 have been released. > > I don't have commit access, so someone needs to commit this for me. > > > Diffs > - > > applets/icon/plugin/icon_p.cpp 97af67a > > Diff: https://git.reviewboard.kde.org/r/125187/diff/ > > > Testing > --- > > It builds. > > > Thanks, > > Armin K. > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125187: Stop requiring Frameworks 5.15
> On Sept. 14, 2015, 10:44 a.m., Martin Gräßlin wrote: > > -2, a change for a month in the devel branch doesn't make much sense. > > David Faure wrote: > As you want. You're raising the bar for new contributors, who can't work > on your code using the latest KDE Frameworks release. > > You and me might compile everything, but you'll get more contributors if > you let people work on workspace and apps using a released frameworks (for > which there are distro packages) than if you require them to compile > frameworks first. Just like we don't require Qt from git, we shouldn't > require KF5 from git, I thought this was the general agreement. > > If you're worried about the ifdef, just use the two liner version of the > code forever, I was always a bit dubious about adding a method just for that > anyway. > > Martin Gräßlin wrote: > It's really not that uncommon to depend on latest frameworks in > workspace. It's common that I add things in KWindowSystem to make use of it > in KWin directly. Or lately I used lots of new functionalty from KGlobalAccel > directly. > > Yes it raises the entry level, but it's also rather unlikely that we are > able to a policy forbidding depending on frameworks master without CI checks. > > Sebastian Kügler wrote: > Besides, these occasional devs can use the stable branch en then forward > port? > > Marco Martin wrote: > -2 from here as well for the same reasons > > Ben Cooksley wrote: > Please note that the CI system is shifting towards only allowing usage of > released products. We'll also be imposing a dependency prohibition between > Applications and Plasma so there will no longer be any ability to have > dependencies between the two. @Ben: Really? Why? Where was this discussed? - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125187/#review85353 --- On Sept. 12, 2015, 11:38 a.m., Armin K. wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125187/ > --- > > (Updated Sept. 12, 2015, 11:38 a.m.) > > > Review request for Plasma and David Faure. > > > Repository: plasma-workspace > > > Description > --- > > KDesktopFile.readMimeTypes(); hasn't made it into Frameworks 5.14, causing > plasma-workspace git master to depend on yet unreleased version of KDE > Frameworks to build. David Faure has suggested to use fix like this one until > at least Frameworks 5.15 have been released. > > I don't have commit access, so someone needs to commit this for me. > > > Diffs > - > > applets/icon/plugin/icon_p.cpp 97af67a > > Diff: https://git.reviewboard.kde.org/r/125187/diff/ > > > Testing > --- > > It builds. > > > Thanks, > > Armin K. > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125187: Stop requiring Frameworks 5.15
> On Sept. 14, 2015, 10:44 a.m., Martin Gräßlin wrote: > > -2, a change for a month in the devel branch doesn't make much sense. > > David Faure wrote: > As you want. You're raising the bar for new contributors, who can't work > on your code using the latest KDE Frameworks release. > > You and me might compile everything, but you'll get more contributors if > you let people work on workspace and apps using a released frameworks (for > which there are distro packages) than if you require them to compile > frameworks first. Just like we don't require Qt from git, we shouldn't > require KF5 from git, I thought this was the general agreement. > > If you're worried about the ifdef, just use the two liner version of the > code forever, I was always a bit dubious about adding a method just for that > anyway. > > Martin Gräßlin wrote: > It's really not that uncommon to depend on latest frameworks in > workspace. It's common that I add things in KWindowSystem to make use of it > in KWin directly. Or lately I used lots of new functionalty from KGlobalAccel > directly. > > Yes it raises the entry level, but it's also rather unlikely that we are > able to a policy forbidding depending on frameworks master without CI checks. > > Sebastian Kügler wrote: > Besides, these occasional devs can use the stable branch en then forward > port? > > Marco Martin wrote: > -2 from here as well for the same reasons > > Ben Cooksley wrote: > Please note that the CI system is shifting towards only allowing usage of > released products. We'll also be imposing a dependency prohibition between > Applications and Plasma so there will no longer be any ability to have > dependencies between the two. > > Aleix Pol Gonzalez wrote: > @Ben: Really? Why? Where was this discussed? @Ben: where should libraries like kwayland and kdecoration go then? They do not fit requirements of frameworks but might be useable to applications (kwayland is a must have library for any wayland integration). - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125187/#review85353 --- On Sept. 12, 2015, 11:38 a.m., Armin K. wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125187/ > --- > > (Updated Sept. 12, 2015, 11:38 a.m.) > > > Review request for Plasma and David Faure. > > > Repository: plasma-workspace > > > Description > --- > > KDesktopFile.readMimeTypes(); hasn't made it into Frameworks 5.14, causing > plasma-workspace git master to depend on yet unreleased version of KDE > Frameworks to build. David Faure has suggested to use fix like this one until > at least Frameworks 5.15 have been released. > > I don't have commit access, so someone needs to commit this for me. > > > Diffs > - > > applets/icon/plugin/icon_p.cpp 97af67a > > Diff: https://git.reviewboard.kde.org/r/125187/diff/ > > > Testing > --- > > It builds. > > > Thanks, > > Armin K. > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125187: Stop requiring Frameworks 5.15
> On Sept. 14, 2015, 8:44 a.m., Martin Gräßlin wrote: > > -2, a change for a month in the devel branch doesn't make much sense. > > David Faure wrote: > As you want. You're raising the bar for new contributors, who can't work > on your code using the latest KDE Frameworks release. > > You and me might compile everything, but you'll get more contributors if > you let people work on workspace and apps using a released frameworks (for > which there are distro packages) than if you require them to compile > frameworks first. Just like we don't require Qt from git, we shouldn't > require KF5 from git, I thought this was the general agreement. > > If you're worried about the ifdef, just use the two liner version of the > code forever, I was always a bit dubious about adding a method just for that > anyway. > > Martin Gräßlin wrote: > It's really not that uncommon to depend on latest frameworks in > workspace. It's common that I add things in KWindowSystem to make use of it > in KWin directly. Or lately I used lots of new functionalty from KGlobalAccel > directly. > > Yes it raises the entry level, but it's also rather unlikely that we are > able to a policy forbidding depending on frameworks master without CI checks. > > Sebastian Kügler wrote: > Besides, these occasional devs can use the stable branch en then forward > port? > > Marco Martin wrote: > -2 from here as well for the same reasons > > Ben Cooksley wrote: > Please note that the CI system is shifting towards only allowing usage of > released products. We'll also be imposing a dependency prohibition between > Applications and Plasma so there will no longer be any ability to have > dependencies between the two. > > Aleix Pol Gonzalez wrote: > @Ben: Really? Why? Where was this discussed? > > Martin Gräßlin wrote: > @Ben: where should libraries like kwayland and kdecoration go then? They > do not fit requirements of frameworks but might be useable to applications > (kwayland is a must have library for any wayland integration). That has yet to be resolved. Likely another layer which will be released as needed by Applications / Plasma which sits in between Frameworks and them will be added I suspect. No binary compatibility commitments, same licensing rules as Applications / Plasma, just a logically separate product so it doesn't cause dependency problems. I don't expect too many libraries or runtime components to end up there (Dr Konqi might perhaps?). - Ben --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125187/#review85353 --- On Sept. 12, 2015, 9:38 a.m., Armin K. wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125187/ > --- > > (Updated Sept. 12, 2015, 9:38 a.m.) > > > Review request for Plasma and David Faure. > > > Repository: plasma-workspace > > > Description > --- > > KDesktopFile.readMimeTypes(); hasn't made it into Frameworks 5.14, causing > plasma-workspace git master to depend on yet unreleased version of KDE > Frameworks to build. David Faure has suggested to use fix like this one until > at least Frameworks 5.15 have been released. > > I don't have commit access, so someone needs to commit this for me. > > > Diffs > - > > applets/icon/plugin/icon_p.cpp 97af67a > > Diff: https://git.reviewboard.kde.org/r/125187/diff/ > > > Testing > --- > > It builds. > > > Thanks, > > Armin K. > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125187: Stop requiring Frameworks 5.15
> On Sept. 14, 2015, 8:44 a.m., Martin Gräßlin wrote: > > -2, a change for a month in the devel branch doesn't make much sense. > > David Faure wrote: > As you want. You're raising the bar for new contributors, who can't work > on your code using the latest KDE Frameworks release. > > You and me might compile everything, but you'll get more contributors if > you let people work on workspace and apps using a released frameworks (for > which there are distro packages) than if you require them to compile > frameworks first. Just like we don't require Qt from git, we shouldn't > require KF5 from git, I thought this was the general agreement. > > If you're worried about the ifdef, just use the two liner version of the > code forever, I was always a bit dubious about adding a method just for that > anyway. > > Martin Gräßlin wrote: > It's really not that uncommon to depend on latest frameworks in > workspace. It's common that I add things in KWindowSystem to make use of it > in KWin directly. Or lately I used lots of new functionalty from KGlobalAccel > directly. > > Yes it raises the entry level, but it's also rather unlikely that we are > able to a policy forbidding depending on frameworks master without CI checks. > > Sebastian Kügler wrote: > Besides, these occasional devs can use the stable branch en then forward > port? > > Marco Martin wrote: > -2 from here as well for the same reasons Please note that the CI system is shifting towards only allowing usage of released products. We'll also be imposing a dependency prohibition between Applications and Plasma so there will no longer be any ability to have dependencies between the two. - Ben --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125187/#review85353 --- On Sept. 12, 2015, 9:38 a.m., Armin K. wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125187/ > --- > > (Updated Sept. 12, 2015, 9:38 a.m.) > > > Review request for Plasma and David Faure. > > > Repository: plasma-workspace > > > Description > --- > > KDesktopFile.readMimeTypes(); hasn't made it into Frameworks 5.14, causing > plasma-workspace git master to depend on yet unreleased version of KDE > Frameworks to build. David Faure has suggested to use fix like this one until > at least Frameworks 5.15 have been released. > > I don't have commit access, so someone needs to commit this for me. > > > Diffs > - > > applets/icon/plugin/icon_p.cpp 97af67a > > Diff: https://git.reviewboard.kde.org/r/125187/diff/ > > > Testing > --- > > It builds. > > > Thanks, > > Armin K. > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125187: Stop requiring Frameworks 5.15
> On Sept. 14, 2015, 10:44 a.m., Martin Gräßlin wrote: > > -2, a change for a month in the devel branch doesn't make much sense. > > David Faure wrote: > As you want. You're raising the bar for new contributors, who can't work > on your code using the latest KDE Frameworks release. > > You and me might compile everything, but you'll get more contributors if > you let people work on workspace and apps using a released frameworks (for > which there are distro packages) than if you require them to compile > frameworks first. Just like we don't require Qt from git, we shouldn't > require KF5 from git, I thought this was the general agreement. > > If you're worried about the ifdef, just use the two liner version of the > code forever, I was always a bit dubious about adding a method just for that > anyway. > > Martin Gräßlin wrote: > It's really not that uncommon to depend on latest frameworks in > workspace. It's common that I add things in KWindowSystem to make use of it > in KWin directly. Or lately I used lots of new functionalty from KGlobalAccel > directly. > > Yes it raises the entry level, but it's also rather unlikely that we are > able to a policy forbidding depending on frameworks master without CI checks. > > Sebastian Kügler wrote: > Besides, these occasional devs can use the stable branch en then forward > port? > > Marco Martin wrote: > -2 from here as well for the same reasons > > Ben Cooksley wrote: > Please note that the CI system is shifting towards only allowing usage of > released products. We'll also be imposing a dependency prohibition between > Applications and Plasma so there will no longer be any ability to have > dependencies between the two. > > Aleix Pol Gonzalez wrote: > @Ben: Really? Why? Where was this discussed? > > Martin Gräßlin wrote: > @Ben: where should libraries like kwayland and kdecoration go then? They > do not fit requirements of frameworks but might be useable to applications > (kwayland is a must have library for any wayland integration). > > Ben Cooksley wrote: > That has yet to be resolved. Likely another layer which will be released > as needed by Applications / Plasma which sits in between Frameworks and them > will be added I suspect. No binary compatibility commitments, same licensing > rules as Applications / Plasma, just a logically separate product so it > doesn't cause dependency problems. I don't expect too many libraries or > runtime components to end up there (Dr Konqi might perhaps?). Honestly: I don't see the point in that except of making everything more complicated (yet another product which has a dedicated release cycle). If applications want to depend on workspace libraries: that's fine. They know what it means. We shouldn't prevent "stupid things" in the CI system. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125187/#review85353 --- On Sept. 12, 2015, 11:38 a.m., Armin K. wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125187/ > --- > > (Updated Sept. 12, 2015, 11:38 a.m.) > > > Review request for Plasma and David Faure. > > > Repository: plasma-workspace > > > Description > --- > > KDesktopFile.readMimeTypes(); hasn't made it into Frameworks 5.14, causing > plasma-workspace git master to depend on yet unreleased version of KDE > Frameworks to build. David Faure has suggested to use fix like this one until > at least Frameworks 5.15 have been released. > > I don't have commit access, so someone needs to commit this for me. > > > Diffs > - > > applets/icon/plugin/icon_p.cpp 97af67a > > Diff: https://git.reviewboard.kde.org/r/125187/diff/ > > > Testing > --- > > It builds. > > > Thanks, > > Armin K. > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125187: Stop requiring Frameworks 5.15
> On Sept. 14, 2015, 8:44 a.m., Martin Gräßlin wrote: > > -2, a change for a month in the devel branch doesn't make much sense. > > David Faure wrote: > As you want. You're raising the bar for new contributors, who can't work > on your code using the latest KDE Frameworks release. > > You and me might compile everything, but you'll get more contributors if > you let people work on workspace and apps using a released frameworks (for > which there are distro packages) than if you require them to compile > frameworks first. Just like we don't require Qt from git, we shouldn't > require KF5 from git, I thought this was the general agreement. > > If you're worried about the ifdef, just use the two liner version of the > code forever, I was always a bit dubious about adding a method just for that > anyway. > > Martin Gräßlin wrote: > It's really not that uncommon to depend on latest frameworks in > workspace. It's common that I add things in KWindowSystem to make use of it > in KWin directly. Or lately I used lots of new functionalty from KGlobalAccel > directly. > > Yes it raises the entry level, but it's also rather unlikely that we are > able to a policy forbidding depending on frameworks master without CI checks. Besides, these occasional devs can use the stable branch en then forward port? - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125187/#review85353 --- On Sept. 12, 2015, 9:38 a.m., Armin K. wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125187/ > --- > > (Updated Sept. 12, 2015, 9:38 a.m.) > > > Review request for Plasma and David Faure. > > > Repository: plasma-workspace > > > Description > --- > > KDesktopFile.readMimeTypes(); hasn't made it into Frameworks 5.14, causing > plasma-workspace git master to depend on yet unreleased version of KDE > Frameworks to build. David Faure has suggested to use fix like this one until > at least Frameworks 5.15 have been released. > > I don't have commit access, so someone needs to commit this for me. > > > Diffs > - > > applets/icon/plugin/icon_p.cpp 97af67a > > Diff: https://git.reviewboard.kde.org/r/125187/diff/ > > > Testing > --- > > It builds. > > > Thanks, > > Armin K. > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125187: Stop requiring Frameworks 5.15
> On Sept. 14, 2015, 8:44 a.m., Martin Gräßlin wrote: > > -2, a change for a month in the devel branch doesn't make much sense. > > David Faure wrote: > As you want. You're raising the bar for new contributors, who can't work > on your code using the latest KDE Frameworks release. > > You and me might compile everything, but you'll get more contributors if > you let people work on workspace and apps using a released frameworks (for > which there are distro packages) than if you require them to compile > frameworks first. Just like we don't require Qt from git, we shouldn't > require KF5 from git, I thought this was the general agreement. > > If you're worried about the ifdef, just use the two liner version of the > code forever, I was always a bit dubious about adding a method just for that > anyway. > > Martin Gräßlin wrote: > It's really not that uncommon to depend on latest frameworks in > workspace. It's common that I add things in KWindowSystem to make use of it > in KWin directly. Or lately I used lots of new functionalty from KGlobalAccel > directly. > > Yes it raises the entry level, but it's also rather unlikely that we are > able to a policy forbidding depending on frameworks master without CI checks. > > Sebastian Kügler wrote: > Besides, these occasional devs can use the stable branch en then forward > port? -2 from here as well for the same reasons - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125187/#review85353 --- On Sept. 12, 2015, 9:38 a.m., Armin K. wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125187/ > --- > > (Updated Sept. 12, 2015, 9:38 a.m.) > > > Review request for Plasma and David Faure. > > > Repository: plasma-workspace > > > Description > --- > > KDesktopFile.readMimeTypes(); hasn't made it into Frameworks 5.14, causing > plasma-workspace git master to depend on yet unreleased version of KDE > Frameworks to build. David Faure has suggested to use fix like this one until > at least Frameworks 5.15 have been released. > > I don't have commit access, so someone needs to commit this for me. > > > Diffs > - > > applets/icon/plugin/icon_p.cpp 97af67a > > Diff: https://git.reviewboard.kde.org/r/125187/diff/ > > > Testing > --- > > It builds. > > > Thanks, > > Armin K. > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125187: Stop requiring Frameworks 5.15
> On Sept. 12, 2015, 10:14 a.m., David Edmundson wrote: > > We depend on git master of frameworks in Plasma master quite often, and our > > build instructions for Plasma include frameworks. > > > > Is this causing a problem somewhere? Well, I just upgraded to newly released frameworks 5.14, which is the required dependency for plasma-workspace and the build failed. At that time, frameworks weren't bumped to 5.15 and the dep couldn't be increased. I wanted to backport the method to my local kconfig build, but David Faure advised me against doing so and instead writing this patch since the class is one liner, so the dep doesn't need to be bumped again. The patch is trivial, and can be reverted once frameworks 5.15 have been released. - Armin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125187/#review85240 --- On Sept. 12, 2015, 9:38 a.m., Armin K. wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125187/ > --- > > (Updated Sept. 12, 2015, 9:38 a.m.) > > > Review request for Plasma and David Faure. > > > Repository: plasma-workspace > > > Description > --- > > KDesktopFile.readMimeTypes(); hasn't made it into Frameworks 5.14, causing > plasma-workspace git master to depend on yet unreleased version of KDE > Frameworks to build. David Faure has suggested to use fix like this one until > at least Frameworks 5.15 have been released. > > I don't have commit access, so someone needs to commit this for me. > > > Diffs > - > > applets/icon/plugin/icon_p.cpp 97af67a > > Diff: https://git.reviewboard.kde.org/r/125187/diff/ > > > Testing > --- > > It builds. > > > Thanks, > > Armin K. > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125187: Stop requiring Frameworks 5.15
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125187/#review85353 --- -2, a change for a month in the devel branch doesn't make much sense. - Martin Gräßlin On Sept. 12, 2015, 11:38 a.m., Armin K. wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125187/ > --- > > (Updated Sept. 12, 2015, 11:38 a.m.) > > > Review request for Plasma and David Faure. > > > Repository: plasma-workspace > > > Description > --- > > KDesktopFile.readMimeTypes(); hasn't made it into Frameworks 5.14, causing > plasma-workspace git master to depend on yet unreleased version of KDE > Frameworks to build. David Faure has suggested to use fix like this one until > at least Frameworks 5.15 have been released. > > I don't have commit access, so someone needs to commit this for me. > > > Diffs > - > > applets/icon/plugin/icon_p.cpp 97af67a > > Diff: https://git.reviewboard.kde.org/r/125187/diff/ > > > Testing > --- > > It builds. > > > Thanks, > > Armin K. > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125187: Stop requiring Frameworks 5.15
> On Sept. 14, 2015, 8:44 a.m., Martin Gräßlin wrote: > > -2, a change for a month in the devel branch doesn't make much sense. As you want. You're raising the bar for new contributors, who can't work on your code using the latest KDE Frameworks release. You and me might compile everything, but you'll get more contributors if you let people work on workspace and apps using a released frameworks (for which there are distro packages) than if you require them to compile frameworks first. Just like we don't require Qt from git, we shouldn't require KF5 from git, I thought this was the general agreement. If you're worried about the ifdef, just use the two liner version of the code forever, I was always a bit dubious about adding a method just for that anyway. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125187/#review85353 --- On Sept. 12, 2015, 9:38 a.m., Armin K. wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125187/ > --- > > (Updated Sept. 12, 2015, 9:38 a.m.) > > > Review request for Plasma and David Faure. > > > Repository: plasma-workspace > > > Description > --- > > KDesktopFile.readMimeTypes(); hasn't made it into Frameworks 5.14, causing > plasma-workspace git master to depend on yet unreleased version of KDE > Frameworks to build. David Faure has suggested to use fix like this one until > at least Frameworks 5.15 have been released. > > I don't have commit access, so someone needs to commit this for me. > > > Diffs > - > > applets/icon/plugin/icon_p.cpp 97af67a > > Diff: https://git.reviewboard.kde.org/r/125187/diff/ > > > Testing > --- > > It builds. > > > Thanks, > > Armin K. > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125187: Stop requiring Frameworks 5.15
> On Sept. 14, 2015, 10:44 a.m., Martin Gräßlin wrote: > > -2, a change for a month in the devel branch doesn't make much sense. > > David Faure wrote: > As you want. You're raising the bar for new contributors, who can't work > on your code using the latest KDE Frameworks release. > > You and me might compile everything, but you'll get more contributors if > you let people work on workspace and apps using a released frameworks (for > which there are distro packages) than if you require them to compile > frameworks first. Just like we don't require Qt from git, we shouldn't > require KF5 from git, I thought this was the general agreement. > > If you're worried about the ifdef, just use the two liner version of the > code forever, I was always a bit dubious about adding a method just for that > anyway. It's really not that uncommon to depend on latest frameworks in workspace. It's common that I add things in KWindowSystem to make use of it in KWin directly. Or lately I used lots of new functionalty from KGlobalAccel directly. Yes it raises the entry level, but it's also rather unlikely that we are able to a policy forbidding depending on frameworks master without CI checks. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125187/#review85353 --- On Sept. 12, 2015, 11:38 a.m., Armin K. wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125187/ > --- > > (Updated Sept. 12, 2015, 11:38 a.m.) > > > Review request for Plasma and David Faure. > > > Repository: plasma-workspace > > > Description > --- > > KDesktopFile.readMimeTypes(); hasn't made it into Frameworks 5.14, causing > plasma-workspace git master to depend on yet unreleased version of KDE > Frameworks to build. David Faure has suggested to use fix like this one until > at least Frameworks 5.15 have been released. > > I don't have commit access, so someone needs to commit this for me. > > > Diffs > - > > applets/icon/plugin/icon_p.cpp 97af67a > > Diff: https://git.reviewboard.kde.org/r/125187/diff/ > > > Testing > --- > > It builds. > > > Thanks, > > Armin K. > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125187: Stop requiring Frameworks 5.15
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125187/#review85240 --- We depend on git master of frameworks in Plasma master quite often, and our build instructions for Plasma include frameworks. Is this causing a problem somewhere? - David Edmundson On Sept. 12, 2015, 9:38 a.m., Armin K. wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125187/ > --- > > (Updated Sept. 12, 2015, 9:38 a.m.) > > > Review request for Plasma and David Faure. > > > Repository: plasma-workspace > > > Description > --- > > KDesktopFile.readMimeTypes(); hasn't made it into Frameworks 5.14, causing > plasma-workspace git master to depend on yet unreleased version of KDE > Frameworks to build. David Faure has suggested to use fix like this one until > at least Frameworks 5.15 have been released. > > I don't have commit access, so someone needs to commit this for me. > > > Diffs > - > > applets/icon/plugin/icon_p.cpp 97af67a > > Diff: https://git.reviewboard.kde.org/r/125187/diff/ > > > Testing > --- > > It builds. > > > Thanks, > > Armin K. > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125187: Stop requiring Frameworks 5.15
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125187/#review85238 --- Ship it! Ship It! - David Faure On Sept. 12, 2015, 9:38 a.m., Armin K. wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125187/ > --- > > (Updated Sept. 12, 2015, 9:38 a.m.) > > > Review request for Plasma and David Faure. > > > Repository: plasma-workspace > > > Description > --- > > KDesktopFile.readMimeTypes(); hasn't made it into Frameworks 5.14, causing > plasma-workspace git master to depend on yet unreleased version of KDE > Frameworks to build. David Faure has suggested to use fix like this one until > at least Frameworks 5.15 have been released. > > I don't have commit access, so someone needs to commit this for me. > > > Diffs > - > > applets/icon/plugin/icon_p.cpp 97af67a > > Diff: https://git.reviewboard.kde.org/r/125187/diff/ > > > Testing > --- > > It builds. > > > Thanks, > > Armin K. > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
