Re: stylesheed folders

2016-08-14 Thread Marco Martin
On Aug 12, 2016 7:31 AM, "kainz.a"  wrote:
>
> I think I will revert the folder stylesheed stuff.
>
> Thanks for your feedback and that you help me find a solution.
>
> As it's nice and I already blog about it where should I store this
feature?

A different theme maybe called experimental or something like that that
only has the folders and fallsback to breeze?

--
Marco Martin


Re: stylesheed folders

2016-08-13 Thread Alessandro Longo

Il 12-08-2016 07:31 kainz.a ha scritto:

I think I will revert the folder stylesheed stuff.

Thanks for your feedback and that you help me find a solution.

As it's nice and I already blog about it where should I store this
feature?

cheers

Andreas


The feature is really nice, but it needs its own colors in System 
Settings > Colors. I would really like if it will be possible to add 
more "system" colors so also the mime-types icons could be customized: 
Breeze currently has a set of colors used for mime-types icons but the 
distro/user could like to set a different "green", a different "red" 
etc. Something like:


Folders color: #012abc
Blue: #49ccc1
Light green: #...
...

So for example a color theme could set less vibrant colors for folders 
and mimetypes, that it's the main complain about Breeze icons.


Anyway I currently don't experience any issue and the colored folders 
look like a big improvement for my setup.


Important note, Andreas: the new folders icons haven't the light 
gradients, so now they look flat, but Breeze is not flat. If the 
colored-folders feature will be kept, it would be better to add the 
light.


--
Alessandro Longo


Re: stylesheed folders

2016-08-11 Thread kainz.a
I think I will revert the folder stylesheed stuff.

Thanks for your feedback and that you help me find a solution.

As it's nice and I already blog about it where should I store this feature?

cheers
Andreas


Re: stylesheed folders

2016-08-11 Thread Marco Martin
On Thursday 11 August 2016 17:48:05 Ivan Čukić wrote:
> What does the window decoration have in common with a folder?
> 
> This is my screenshot:
> https://share.kde.org/index.php/s/l1eQjahyNee0sbO
> 

I liked the idea, but yeah, seeing it in action goes from "extremely cool"
to corner cases where it still really doesn't work, as the above screenshot

-- 
Marco Martin


Re: stylesheed folders

2016-08-11 Thread Ivan Čukić
What does the window decoration have in common with a folder?

This is my screenshot:
https://share.kde.org/index.php/s/l1eQjahyNee0sbO

Cheers,
Ivan


Re: stylesheed folders

2016-08-11 Thread kainz.a
the contrast shouldn't be the problem cause I'd like to use the select
background color (already done) and the select text color (not selected now)

sebas screenshot. look the same at my desktop. it would be a bug that was
shown with the stylesheed stuff.

Yes it is something like cause we can, but also the design of the desktop
is cleaner (without some bugs), cause the window decoration, the plasma
theme task manager, the select something in dolphin the dolphin folder
icons all have the same color.

about colored icons, with the breeze folder icons you didn't see that much
difference between folder icon and blue folder icon also the difference to
folder cyan isn't that big.

I'm not sure if I sould add or remove this feature cause on one hand it is
very nice to have a consistent desktop and on the other hand it's something
new where we don't ask the user and where some bugs need to be fixed.

cheers
Andreas


Re: stylesheed folders

2016-08-11 Thread Ivan Čukić
+1 (for sebas' comment, not for the rainbow folders)

I don't mind the idea of being able to customize folder colours, but I
don't think that it should be done like this - we do not have the
'folder colour' settings in the colour scheme settings, which
means that some other colour will be used to do this (bad idea!).

We have had more than a few problems in plasma theming that came from
"we can use this element for something completely irrelevant, because
it looks pretty with the default theme".

Cheers,
Ivan

p.s. The message with the screenshot of what it looks like for me is
waiting for moderator approval.


Re: stylesheed folders

2016-08-11 Thread Sebastian Kügler
On Thursday, August 11, 2016 12:17:49 PM UTC Sebastian Kügler wrote:

> Did you test this with app-specific color schemes?
> This I assume is only for the default folders, but what about the folder
> icons that are already colored? If I'm using a green folder, and then
> change the highlight color to something green, the contrast between the
> green and normal folders is lost.

Also, folders with overlay previous look weirdly out of place now, see 
attached screenshot. (This could be a caching issue?)
-- 
sebas

http://www.kde.org | http://vizZzion.org

Re: stylesheed folders

2016-08-11 Thread Sebastian Kügler
On Thursday, August 11, 2016 12:58:25 AM UTC kainz.a wrote:
> since a few days you can find in breeze-icons the posibility that folders
> follow the color scheme colors. 
> 
> https://kdeonlinux.wordpress.com/2016/08/08/rainbow-folders/
> 
> As visual changes for folders are very importend for the user (visible in
> dolphin quite often) I'd like to discuss if we should use the stylesheed
> color.
> 
> pro
> + unified layout the plasma theme, window decoration follow the color scheme
> + distros can brand default breeze easy without fork it
> + plasma designer get more power
> + no visual changes for the default color schemes (breeze and breeze-dark)
> 
> con
> - new features mean new bugs (select folder in dolphin)
> - visual changes via update. user can't switch to old blue folders
> 
> feedback is very welcome. please test the new feature it wasn't released in
> kf 5.25 it's only inmaster

I think the point of allowing icons to be styled was to improve contrast for 
monochrome icons. For at least three of the 7 colors you give as example in 
your blog, the contrast is actually reduced, so they're harder to recognize.
The lowest row with the grey overlay looks actually broken to me. 

For folders, I don't see a real usecase other than "because we can". Am I 
missing something?

Did you test this with app-specific color schemes?
This I assume is only for the default folders, but what about the folder icons 
that are already colored? If I'm using a green folder, and then change the 
highlight color to something green, the contrast between the green and normal 
folders is lost.
-- 
sebas

http://www.kde.org | http://vizZzion.org