Re: Review Request: frame plasmoid: allow to add (separate) picture files to slideshow
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4256/ --- (Updated 2010-10-06 12:19:36.340865) Review request for Plasma. Summary --- This patch enhance slideshow in frame plasmoid, after applying user could add separate pictures to slideshow. Currently slideshow could contain only (all) files in chosen directories. Diffs (updated) - /trunk/KDE/kdeplasma-addons/applets/frame/configdialog.cpp 1135431 /trunk/KDE/kdeplasma-addons/applets/frame/frame.h 1135431 /trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp 1135431 /trunk/KDE/kdeplasma-addons/applets/frame/imageSettings.ui 1135431 /trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp 1135431 Diff: http://svn.reviewboard.kde.org/r/4256/diff Testing --- Thanks, michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: frame plasmoid: allow to add (separate) picture files to slideshow
On 2010-09-24 10:33:40, Beat Wolf wrote: freeze is over. what is the status of this patch? Hi, patch isn't still accepted, it waits for a review ... - michal --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4256/#review7750 --- On 2010-10-06 12:19:36, michal seben wrote: --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4256/ --- (Updated 2010-10-06 12:19:36) Review request for Plasma. Summary --- This patch enhance slideshow in frame plasmoid, after applying user could add separate pictures to slideshow. Currently slideshow could contain only (all) files in chosen directories. Diffs - /trunk/KDE/kdeplasma-addons/applets/frame/configdialog.cpp 1135431 /trunk/KDE/kdeplasma-addons/applets/frame/frame.h 1135431 /trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp 1135431 /trunk/KDE/kdeplasma-addons/applets/frame/imageSettings.ui 1135431 /trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp 1135431 Diff: http://svn.reviewboard.kde.org/r/4256/diff Testing --- Thanks, michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: frame plasmoid: allow to add (separate) picture files to slideshow
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4256/#review7995 --- What's the use case for such an addition? The case that does not work in your patch is when you add 1 picture which is the same as a static picture but then you get the slideshow arrows. I am not very keen of adding code for new features without a good use case as it generates bugs and clutters the code (which happened a lot with this applet). It is understood that people will display all files from a folder in a slideshow (or from different folders) and if they don't want this picture they will remove it from the folder. If you want separate pictures from several folders, just copy them in a unique folder and point the slideshow to this folder. For consistency, the Desktop slideshow has no 'Add file' for example. - Anne-Marie On 2010-10-06 12:19:36, michal seben wrote: --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4256/ --- (Updated 2010-10-06 12:19:36) Review request for Plasma. Summary --- This patch enhance slideshow in frame plasmoid, after applying user could add separate pictures to slideshow. Currently slideshow could contain only (all) files in chosen directories. Diffs - /trunk/KDE/kdeplasma-addons/applets/frame/configdialog.cpp 1135431 /trunk/KDE/kdeplasma-addons/applets/frame/frame.h 1135431 /trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp 1135431 /trunk/KDE/kdeplasma-addons/applets/frame/imageSettings.ui 1135431 /trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp 1135431 Diff: http://svn.reviewboard.kde.org/r/4256/diff Testing --- Thanks, michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: frame plasmoid: allow to add (separate) picture files to slideshow
On 2010-10-06 12:45:50, Anne-Marie Mahfouf wrote: What's the use case for such an addition? The case that does not work in your patch is when you add 1 picture which is the same as a static picture but then you get the slideshow arrows. I am not very keen of adding code for new features without a good use case as it generates bugs and clutters the code (which happened a lot with this applet). It is understood that people will display all files from a folder in a slideshow (or from different folders) and if they don't want this picture they will remove it from the folder. If you want separate pictures from several folders, just copy them in a unique folder and point the slideshow to this folder. For consistency, the Desktop slideshow has no 'Add file' for example. hm ... you are right, this patch could be confusing for users, I will discard it thanks - michal --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4256/#review7995 --- On 2010-10-06 12:19:36, michal seben wrote: --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4256/ --- (Updated 2010-10-06 12:19:36) Review request for Plasma. Summary --- This patch enhance slideshow in frame plasmoid, after applying user could add separate pictures to slideshow. Currently slideshow could contain only (all) files in chosen directories. Diffs - /trunk/KDE/kdeplasma-addons/applets/frame/configdialog.cpp 1135431 /trunk/KDE/kdeplasma-addons/applets/frame/frame.h 1135431 /trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp 1135431 /trunk/KDE/kdeplasma-addons/applets/frame/imageSettings.ui 1135431 /trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp 1135431 Diff: http://svn.reviewboard.kde.org/r/4256/diff Testing --- Thanks, michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: frame plasmoid: allow to add (separate) picture files to slideshow
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4256/#review7750 --- freeze is over. what is the status of this patch? - Beat On 2010-06-08 11:26:18, michal seben wrote: --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4256/ --- (Updated 2010-06-08 11:26:18) Review request for Plasma. Summary --- This patch enhance slideshow in frame plasmoid, after applying user could add separate pictures to slideshow. Currently slideshow could contain only (all) files in chosen directories. Diffs - /trunk/KDE/kdeplasma-addons/applets/frame/configdialog.cpp 1135431 /trunk/KDE/kdeplasma-addons/applets/frame/frame.h 1135431 /trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp 1135431 /trunk/KDE/kdeplasma-addons/applets/frame/imageSettings.ui 1135431 /trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp 1135431 Diff: http://svn.reviewboard.kde.org/r/4256/diff Testing --- Thanks, michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: frame plasmoid: allow to add (separate) picture files to slideshow
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4256/ --- Review request for Plasma. Summary --- This patch enhance slideshow in frame plasmoid, after applying user could add separate pictures to slideshow. Currently slideshow could contain only (all) files in chosen directories. Diffs - /trunk/KDE/kdeplasma-addons/applets/frame/configdialog.cpp 1135431 /trunk/KDE/kdeplasma-addons/applets/frame/frame.h 1135431 /trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp 1135431 /trunk/KDE/kdeplasma-addons/applets/frame/imageSettings.ui 1135431 /trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp 1135431 Diff: http://reviewboard.kde.org/r/4256/diff Testing --- Thanks, michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: frame plasmoid: allow to add (separate) picture files to slideshow
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4256/#review6046 --- /trunk/KDE/kdeplasma-addons/applets/frame/imageSettings.ui http://reviewboard.kde.org/r/4256/#comment5637 without reviewing the rest of the commit (will leave that up to the frame plasmoid maintainer), this will have to wait until 4.6 due to changed strings. - Aaron On 2010-06-08 11:26:18, michal seben wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4256/ --- (Updated 2010-06-08 11:26:18) Review request for Plasma. Summary --- This patch enhance slideshow in frame plasmoid, after applying user could add separate pictures to slideshow. Currently slideshow could contain only (all) files in chosen directories. Diffs - /trunk/KDE/kdeplasma-addons/applets/frame/configdialog.cpp 1135431 /trunk/KDE/kdeplasma-addons/applets/frame/frame.h 1135431 /trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp 1135431 /trunk/KDE/kdeplasma-addons/applets/frame/imageSettings.ui 1135431 /trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp 1135431 Diff: http://reviewboard.kde.org/r/4256/diff Testing --- Thanks, michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
