Re: Review Request: plasmoid qalculate - menu button
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103052/#review11445 --- This review has been submitted with commit 24b83a5bddc27ac5b423fc41f238883cb8718893 by Gregor Tätzner to branch master. - Commit Hook On March 6, 2012, 8:54 p.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103052/ --- (Updated March 6, 2012, 8:54 p.m.) Review request for Plasma. Description --- Hey dudes, I implemented a little menu that displays the last 10 results. improvement ideas? I found this task in the plasma task list: http://community.kde.org/Plasma/Tasks#Kalgebra_and_Qalculate_Plasmoid Diffs - applets/qalculate/qalculate_applet.h aee14c0 applets/qalculate/qalculate_applet.cpp 4da9241 applets/qalculate/qalculate_history.h 59185ee applets/qalculate/qalculate_history.cpp 35592a7 applets/qalculate/qalculate_settings.h 4ce4e73 applets/qalculate/qalculate_settings.cpp b62145b Diff: http://git.reviewboard.kde.org/r/103052/diff/ Testing --- seems to work Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: plasmoid qalculate - menu button
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103052/#review11403 --- Ship it! looks good :) - Aaron J. Seigo On March 6, 2012, 8:54 p.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103052/ --- (Updated March 6, 2012, 8:54 p.m.) Review request for Plasma. Description --- Hey dudes, I implemented a little menu that displays the last 10 results. improvement ideas? I found this task in the plasma task list: http://community.kde.org/Plasma/Tasks#Kalgebra_and_Qalculate_Plasmoid Diffs - applets/qalculate/qalculate_applet.h aee14c0 applets/qalculate/qalculate_applet.cpp 4da9241 applets/qalculate/qalculate_history.h 59185ee applets/qalculate/qalculate_history.cpp 35592a7 applets/qalculate/qalculate_settings.h 4ce4e73 applets/qalculate/qalculate_settings.cpp b62145b Diff: http://git.reviewboard.kde.org/r/103052/diff/ Testing --- seems to work Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: plasmoid qalculate - menu button
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103052/ --- (Updated March 6, 2012, 8:54 p.m.) Review request for Plasma. Description --- Hey dudes, I implemented a little menu that displays the last 10 results. improvement ideas? I found this task in the plasma task list: http://community.kde.org/Plasma/Tasks#Kalgebra_and_Qalculate_Plasmoid Diffs - applets/qalculate/qalculate_applet.h aee14c0 applets/qalculate/qalculate_applet.cpp 4da9241 applets/qalculate/qalculate_history.h 59185ee applets/qalculate/qalculate_history.cpp 35592a7 applets/qalculate/qalculate_settings.h 4ce4e73 applets/qalculate/qalculate_settings.cpp b62145b Diff: http://git.reviewboard.kde.org/r/103052/diff/ Testing --- seems to work Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: plasmoid qalculate - menu button
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103052/ --- (Updated Dec. 14, 2011, 6:25 p.m.) Review request for Plasma. Changes --- Well, I fulfilled all three wishes. Please express your frustration in a friendly manner :) Description --- Hey dudes, I implemented a little menu that displays the last 10 results. improvement ideas? I found this task in the plasma task list: http://community.kde.org/Plasma/Tasks#Kalgebra_and_Qalculate_Plasmoid Diffs (updated) - applets/qalculate/qalculate_applet.h aee14c0 applets/qalculate/qalculate_applet.cpp 4da9241 applets/qalculate/qalculate_history.h 59185ee applets/qalculate/qalculate_history.cpp 35592a7 applets/qalculate/qalculate_settings.h 4ce4e73 applets/qalculate/qalculate_settings.cpp b62145b Diff: http://git.reviewboard.kde.org/r/103052/diff/diff Testing --- seems to work Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: plasmoid qalculate - menu button
On Dec. 9, 2011, 2:53 p.m., Aaron J. Seigo wrote: we tried the plasmoid with a couple of people here at the house and comments included: * the history should be remembered between restarts (e.g.: save to config) * instead of showing the result in a tooltip, it should be shown in the plasmoid itself (as if you had typed in the equation; would also make it easy to go back to an older equation and re-edit it) * the history button should be enabled only when there are items in the history * the answer should be selectable for copy/past purposes (that's not the fault of your patch, of course :) very nice improvement already though .. due to feature freeze this can't go in until 4.9 devel opens up (in january), so there remains time to improve this further. thanks for the patch, i look forward to seeing further improvements! :) great feedback! I'll see what I can do! - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103052/#review8821 --- On Dec. 8, 2011, 8:48 p.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103052/ --- (Updated Dec. 8, 2011, 8:48 p.m.) Review request for Plasma. Description --- Hey dudes, I implemented a little menu that displays the last 10 results. improvement ideas? I found this task in the plasma task list: http://community.kde.org/Plasma/Tasks#Kalgebra_and_Qalculate_Plasmoid Diffs - applets/qalculate/qalculate_applet.h aee14c0 applets/qalculate/qalculate_applet.cpp 4da9241 applets/qalculate/qalculate_history.h 59185ee applets/qalculate/qalculate_history.cpp 35592a7 Diff: http://git.reviewboard.kde.org/r/103052/diff/diff Testing --- seems to work Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: plasmoid qalculate - menu button
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103052/#review8821
---
we tried the plasmoid with a couple of people here at the house and comments
included:
* the history should be remembered between restarts (e.g.: save to config)
* instead of showing the result in a tooltip, it should be shown in the
plasmoid itself (as if you had typed in the equation; would also make it easy
to go back to an older equation and re-edit it)
* the history button should be enabled only when there are items in the history
* the answer should be selectable for copy/past purposes (that's not the fault
of your patch, of course :)
very nice improvement already though .. due to feature freeze this can't go in
until 4.9 devel opens up (in january), so there remains time to improve this
further. thanks for the patch, i look forward to seeing further improvements! :)
applets/qalculate/qalculate_applet.cpp
http://git.reviewboard.kde.org/r/103052/#comment7382
should have {}s
applets/qalculate/qalculate_history.h
http://git.reviewboard.kde.org/r/103052/#comment7383
should be const.
- Aaron J. Seigo
On Dec. 8, 2011, 8:48 p.m., Greg T wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103052/
---
(Updated Dec. 8, 2011, 8:48 p.m.)
Review request for Plasma.
Description
---
Hey dudes,
I implemented a little menu that displays the last 10 results. improvement
ideas?
I found this task in the plasma task list:
http://community.kde.org/Plasma/Tasks#Kalgebra_and_Qalculate_Plasmoid
Diffs
-
applets/qalculate/qalculate_applet.h aee14c0
applets/qalculate/qalculate_applet.cpp 4da9241
applets/qalculate/qalculate_history.h 59185ee
applets/qalculate/qalculate_history.cpp 35592a7
Diff: http://git.reviewboard.kde.org/r/103052/diff/diff
Testing
---
seems to work
Thanks,
Greg T
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: plasmoid qalculate - menu button
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103052/ --- (Updated Dec. 8, 2011, 8:48 p.m.) Review request for Plasma. Description --- Hey dudes, I implemented a little menu that displays the last 10 results. improvement ideas? I found this task in the plasma task list: http://community.kde.org/Plasma/Tasks#Kalgebra_and_Qalculate_Plasmoid Diffs (updated) - applets/qalculate/qalculate_applet.h aee14c0 applets/qalculate/qalculate_applet.cpp 4da9241 applets/qalculate/qalculate_history.h 59185ee applets/qalculate/qalculate_history.cpp 35592a7 Diff: http://git.reviewboard.kde.org/r/103052/diff/diff Testing --- seems to work Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: plasmoid qalculate - menu button
On Dec. 6, 2011, 2:16 p.m., Aaron J. Seigo wrote: applets/qalculate/qalculate_applet.cpp, line 143 http://git.reviewboard.kde.org/r/103052/diff/1/?file=40280#file40280line143 this looks wrong. it should be put into a layout somewhere and managed that way. in particular, this will break with larger fonts. I removed that line and changed the sizePolicy - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103052/#review8754 --- On Dec. 8, 2011, 8:48 p.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103052/ --- (Updated Dec. 8, 2011, 8:48 p.m.) Review request for Plasma. Description --- Hey dudes, I implemented a little menu that displays the last 10 results. improvement ideas? I found this task in the plasma task list: http://community.kde.org/Plasma/Tasks#Kalgebra_and_Qalculate_Plasmoid Diffs - applets/qalculate/qalculate_applet.h aee14c0 applets/qalculate/qalculate_applet.cpp 4da9241 applets/qalculate/qalculate_history.h 59185ee applets/qalculate/qalculate_history.cpp 35592a7 Diff: http://git.reviewboard.kde.org/r/103052/diff/diff Testing --- seems to work Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: plasmoid qalculate - menu button
On Dec. 6, 2011, 2:16 p.m., Aaron J. Seigo wrote: applets/qalculate/qalculate_applet.cpp, lines 235-237 http://git.reviewboard.kde.org/r/103052/diff/1/?file=40280#file40280line235 if this is to make m_output appear before m_historyButton in the layout, use insertItem instead of addItem :) yeah good catch :) I suppose that I should mark these things fixed or is that your job? Oh and thanks for reviewing - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103052/#review8754 --- On Dec. 8, 2011, 8:48 p.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103052/ --- (Updated Dec. 8, 2011, 8:48 p.m.) Review request for Plasma. Description --- Hey dudes, I implemented a little menu that displays the last 10 results. improvement ideas? I found this task in the plasma task list: http://community.kde.org/Plasma/Tasks#Kalgebra_and_Qalculate_Plasmoid Diffs - applets/qalculate/qalculate_applet.h aee14c0 applets/qalculate/qalculate_applet.cpp 4da9241 applets/qalculate/qalculate_history.h 59185ee applets/qalculate/qalculate_history.cpp 35592a7 Diff: http://git.reviewboard.kde.org/r/103052/diff/diff Testing --- seems to work Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: plasmoid qalculate - menu button
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103052/#review8754 --- applets/qalculate/qalculate_applet.cpp http://git.reviewboard.kde.org/r/103052/#comment7346 this looks wrong. it should be put into a layout somewhere and managed that way. in particular, this will break with larger fonts. applets/qalculate/qalculate_applet.cpp http://git.reviewboard.kde.org/r/103052/#comment7347 if this is to make m_output appear before m_historyButton in the layout, use insertItem instead of addItem :) - Aaron J. Seigo On Nov. 11, 2011, 5:41 p.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103052/ --- (Updated Nov. 11, 2011, 5:41 p.m.) Review request for Plasma. Description --- Hey dudes, I implemented a little menu that displays the last 10 results. improvement ideas? I found this task in the plasma task list: http://community.kde.org/Plasma/Tasks#Kalgebra_and_Qalculate_Plasmoid Diffs - applets/qalculate/qalculate_applet.h aee14c0 applets/qalculate/qalculate_applet.cpp 4da9241 applets/qalculate/qalculate_history.h 59185ee applets/qalculate/qalculate_history.cpp 35592a7 Diff: http://git.reviewboard.kde.org/r/103052/diff/diff Testing --- seems to work Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: plasmoid qalculate - menu button
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103052/ --- Review request for Plasma. Description --- Hey dudes, I implemented a little menu that displays the last 10 results. improvement ideas? Diffs - applets/qalculate/qalculate_applet.h aee14c0 applets/qalculate/qalculate_applet.cpp 4da9241 applets/qalculate/qalculate_history.h 59185ee applets/qalculate/qalculate_history.cpp 35592a7 Diff: http://git.reviewboard.kde.org/r/103052/diff/diff Testing --- seems to work Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
