Re: Review Request 116625: Oxygen as default font
On March 19, 2014, 1:16 a.m., Commit Hook wrote: This review has been submitted with commit c504562c4dc37828790a51ff33a895a962d9b891 by Sebastian Kügler to branch master. Hrvoje Senjan wrote: i was under the impression that consensus was to go with (only) r116633. at least kdeglobals injection *should not* be needed with frameworkintegration change. or am i missing something? r116633 is not enough, since it only sets the face and size of the font, but not its rendering method. (The XftHint, basically.) We technically don't need to set the face and size here, I just did it for completeness sake, but we can't remove this bit entirely, since the rendering method would otherwise not be set, and the font rendering would be unknown. - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/#review53378 --- On March 19, 2014, 1:16 a.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/ --- (Updated March 19, 2014, 1:16 a.m.) Review request for Plasma and Àlex Fiestas. Repository: kde-workspace Description --- Make Oxygen the default font This has three portions: the fonts itself, installation of them including fontconfig bits, and setting font defaults in kdeglobals. Oxygen Font 0.4 Imported from oxygen-font repository. The startkde portion contains the bits to write out a kdeglobals default file if it doesn't exist with font settings applied. Usually, with install prefix set to /usr, the installed oxygen font is found automatically by fontconfig. If we're installed to a different prefix, we need to point fontconfig at the font. We do that by linking it from either XDG_DATA_HOME or ~/.fonts/ and updating fontconfig with it. The latter is irrelevant for systems that install into /usr. Diffs - CMakeLists.txt 0135bb1f7475862451775928adf5dc20167424e0 fonts/CMakeLists.txt PRE-CREATION fonts/oxygen/COPYING-GPL+FE.txt PRE-CREATION fonts/oxygen/GPL.txt PRE-CREATION fonts/oxygen/Oxygen-Sans-Bold.ttf PRE-CREATION fonts/oxygen/Oxygen-Sans.ttf PRE-CREATION fonts/oxygen/OxygenMono-Regular.ttf PRE-CREATION fonts/oxygen/README PRE-CREATION startkde.cmake 53d1bc6a2098f634c5f386f95e1a1c504b554303 Diff: https://git.reviewboard.kde.org/r/116625/diff/ Testing --- Logged into session with clean config. Font settings are applied correctly throughout. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116625: Oxygen as default font
On March 6, 2014, 2:06 a.m., Hrvoje Senjan wrote: startkde.cmake, line 76 https://git.reviewboard.kde.org/r/116625/diff/1/?file=252390#file252390line76 Why not just change the defaults in frameworkintegration instead of writing directly into users settings? Martin Gräßlin wrote: I also don't like that this seems to be at least parsed with every startup. If it needs to go through our startup and cannot be done in frameworkintegration I think it should be a kconf update script. Sebastian Kügler wrote: You mean the parsing of kdeglobals on startup of apps? That would mean frameworkintegration depends on oxygen-font. I'm not sure that's an acceptable dependency, and I'd like to know for sure that that approach is acceptable before implementing it. CC:ing Alex Fiestas as the maintainer of that. Alex would you be OK with a runtime dependency on Oxygen font in frameworkintegration? So we need at least some bits of this, anyway. We can only set the font face and size, but not the hinting method. We'll also need to fiddle with the fontpathes in startkde, that can't be done (sensibly) in frameworksintegration. I've now moved the face and size setting to frameworksintegration and equipped the oxygen-fonts repo with the necessary cmake foo. I'll update this patch for the necessary work shortly. - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/#review52219 --- On March 19, 2014, 1:16 a.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/ --- (Updated March 19, 2014, 1:16 a.m.) Review request for Plasma and Àlex Fiestas. Repository: kde-workspace Description --- Make Oxygen the default font This has three portions: the fonts itself, installation of them including fontconfig bits, and setting font defaults in kdeglobals. Oxygen Font 0.4 Imported from oxygen-font repository. The startkde portion contains the bits to write out a kdeglobals default file if it doesn't exist with font settings applied. Usually, with install prefix set to /usr, the installed oxygen font is found automatically by fontconfig. If we're installed to a different prefix, we need to point fontconfig at the font. We do that by linking it from either XDG_DATA_HOME or ~/.fonts/ and updating fontconfig with it. The latter is irrelevant for systems that install into /usr. Diffs - CMakeLists.txt 0135bb1f7475862451775928adf5dc20167424e0 fonts/CMakeLists.txt PRE-CREATION fonts/oxygen/COPYING-GPL+FE.txt PRE-CREATION fonts/oxygen/GPL.txt PRE-CREATION fonts/oxygen/Oxygen-Sans-Bold.ttf PRE-CREATION fonts/oxygen/Oxygen-Sans.ttf PRE-CREATION fonts/oxygen/OxygenMono-Regular.ttf PRE-CREATION fonts/oxygen/README PRE-CREATION startkde.cmake 53d1bc6a2098f634c5f386f95e1a1c504b554303 Diff: https://git.reviewboard.kde.org/r/116625/diff/ Testing --- Logged into session with clean config. Font settings are applied correctly throughout. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116625: Oxygen as default font
On March 19, 2014, 1:16 a.m., Commit Hook wrote: This review has been submitted with commit c504562c4dc37828790a51ff33a895a962d9b891 by Sebastian Kügler to branch master. Hrvoje Senjan wrote: i was under the impression that consensus was to go with (only) r116633. at least kdeglobals injection *should not* be needed with frameworkintegration change. or am i missing something? Sebastian Kügler wrote: r116633 is not enough, since it only sets the face and size of the font, but not its rendering method. (The XftHint, basically.) We technically don't need to set the face and size here, I just did it for completeness sake, but we can't remove this bit entirely, since the rendering method would otherwise not be set, and the font rendering would be unknown. (Just realized that I had written an explanation earlier, but hadn't hit publish, I've done that now. Sorry for the confusion.) - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/#review53378 --- On March 19, 2014, 1:16 a.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/ --- (Updated March 19, 2014, 1:16 a.m.) Review request for Plasma and Àlex Fiestas. Repository: kde-workspace Description --- Make Oxygen the default font This has three portions: the fonts itself, installation of them including fontconfig bits, and setting font defaults in kdeglobals. Oxygen Font 0.4 Imported from oxygen-font repository. The startkde portion contains the bits to write out a kdeglobals default file if it doesn't exist with font settings applied. Usually, with install prefix set to /usr, the installed oxygen font is found automatically by fontconfig. If we're installed to a different prefix, we need to point fontconfig at the font. We do that by linking it from either XDG_DATA_HOME or ~/.fonts/ and updating fontconfig with it. The latter is irrelevant for systems that install into /usr. Diffs - CMakeLists.txt 0135bb1f7475862451775928adf5dc20167424e0 fonts/CMakeLists.txt PRE-CREATION fonts/oxygen/COPYING-GPL+FE.txt PRE-CREATION fonts/oxygen/GPL.txt PRE-CREATION fonts/oxygen/Oxygen-Sans-Bold.ttf PRE-CREATION fonts/oxygen/Oxygen-Sans.ttf PRE-CREATION fonts/oxygen/OxygenMono-Regular.ttf PRE-CREATION fonts/oxygen/README PRE-CREATION startkde.cmake 53d1bc6a2098f634c5f386f95e1a1c504b554303 Diff: https://git.reviewboard.kde.org/r/116625/diff/ Testing --- Logged into session with clean config. Font settings are applied correctly throughout. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116625: Oxygen as default font
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/ --- (Updated March 19, 2014, 1:16 a.m.) Status -- This change has been marked as submitted. Review request for Plasma and Àlex Fiestas. Repository: kde-workspace Description --- Make Oxygen the default font This has three portions: the fonts itself, installation of them including fontconfig bits, and setting font defaults in kdeglobals. Oxygen Font 0.4 Imported from oxygen-font repository. The startkde portion contains the bits to write out a kdeglobals default file if it doesn't exist with font settings applied. Usually, with install prefix set to /usr, the installed oxygen font is found automatically by fontconfig. If we're installed to a different prefix, we need to point fontconfig at the font. We do that by linking it from either XDG_DATA_HOME or ~/.fonts/ and updating fontconfig with it. The latter is irrelevant for systems that install into /usr. Diffs - CMakeLists.txt 0135bb1f7475862451775928adf5dc20167424e0 fonts/CMakeLists.txt PRE-CREATION fonts/oxygen/COPYING-GPL+FE.txt PRE-CREATION fonts/oxygen/GPL.txt PRE-CREATION fonts/oxygen/Oxygen-Sans-Bold.ttf PRE-CREATION fonts/oxygen/Oxygen-Sans.ttf PRE-CREATION fonts/oxygen/OxygenMono-Regular.ttf PRE-CREATION fonts/oxygen/README PRE-CREATION startkde.cmake 53d1bc6a2098f634c5f386f95e1a1c504b554303 Diff: https://git.reviewboard.kde.org/r/116625/diff/ Testing --- Logged into session with clean config. Font settings are applied correctly throughout. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116625: Oxygen as default font
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/#review53378 --- This review has been submitted with commit c504562c4dc37828790a51ff33a895a962d9b891 by Sebastian Kügler to branch master. - Commit Hook On March 6, 2014, 10:29 a.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/ --- (Updated March 6, 2014, 10:29 a.m.) Review request for Plasma and Àlex Fiestas. Repository: kde-workspace Description --- Make Oxygen the default font This has three portions: the fonts itself, installation of them including fontconfig bits, and setting font defaults in kdeglobals. Oxygen Font 0.4 Imported from oxygen-font repository. The startkde portion contains the bits to write out a kdeglobals default file if it doesn't exist with font settings applied. Usually, with install prefix set to /usr, the installed oxygen font is found automatically by fontconfig. If we're installed to a different prefix, we need to point fontconfig at the font. We do that by linking it from either XDG_DATA_HOME or ~/.fonts/ and updating fontconfig with it. The latter is irrelevant for systems that install into /usr. Diffs - CMakeLists.txt 0135bb1f7475862451775928adf5dc20167424e0 fonts/CMakeLists.txt PRE-CREATION fonts/oxygen/COPYING-GPL+FE.txt PRE-CREATION fonts/oxygen/GPL.txt PRE-CREATION fonts/oxygen/Oxygen-Sans-Bold.ttf PRE-CREATION fonts/oxygen/Oxygen-Sans.ttf PRE-CREATION fonts/oxygen/OxygenMono-Regular.ttf PRE-CREATION fonts/oxygen/README PRE-CREATION startkde.cmake 53d1bc6a2098f634c5f386f95e1a1c504b554303 Diff: https://git.reviewboard.kde.org/r/116625/diff/ Testing --- Logged into session with clean config. Font settings are applied correctly throughout. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116625: Oxygen as default font
On March 19, 2014, 1:16 a.m., Commit Hook wrote: This review has been submitted with commit c504562c4dc37828790a51ff33a895a962d9b891 by Sebastian Kügler to branch master. i was under the impression that consensus was to go with (only) r116633. at least kdeglobals injection *should not* be needed with frameworkintegration change. or am i missing something? - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/#review53378 --- On March 19, 2014, 1:16 a.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/ --- (Updated March 19, 2014, 1:16 a.m.) Review request for Plasma and Àlex Fiestas. Repository: kde-workspace Description --- Make Oxygen the default font This has three portions: the fonts itself, installation of them including fontconfig bits, and setting font defaults in kdeglobals. Oxygen Font 0.4 Imported from oxygen-font repository. The startkde portion contains the bits to write out a kdeglobals default file if it doesn't exist with font settings applied. Usually, with install prefix set to /usr, the installed oxygen font is found automatically by fontconfig. If we're installed to a different prefix, we need to point fontconfig at the font. We do that by linking it from either XDG_DATA_HOME or ~/.fonts/ and updating fontconfig with it. The latter is irrelevant for systems that install into /usr. Diffs - CMakeLists.txt 0135bb1f7475862451775928adf5dc20167424e0 fonts/CMakeLists.txt PRE-CREATION fonts/oxygen/COPYING-GPL+FE.txt PRE-CREATION fonts/oxygen/GPL.txt PRE-CREATION fonts/oxygen/Oxygen-Sans-Bold.ttf PRE-CREATION fonts/oxygen/Oxygen-Sans.ttf PRE-CREATION fonts/oxygen/OxygenMono-Regular.ttf PRE-CREATION fonts/oxygen/README PRE-CREATION startkde.cmake 53d1bc6a2098f634c5f386f95e1a1c504b554303 Diff: https://git.reviewboard.kde.org/r/116625/diff/ Testing --- Logged into session with clean config. Font settings are applied correctly throughout. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116625: Oxygen as default font
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/#review52895 --- Ship it! Sorry for the delay, good to go. - Àlex Fiestas On March 6, 2014, 10:29 a.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/ --- (Updated March 6, 2014, 10:29 a.m.) Review request for Plasma and Àlex Fiestas. Repository: kde-workspace Description --- Make Oxygen the default font This has three portions: the fonts itself, installation of them including fontconfig bits, and setting font defaults in kdeglobals. Oxygen Font 0.4 Imported from oxygen-font repository. The startkde portion contains the bits to write out a kdeglobals default file if it doesn't exist with font settings applied. Usually, with install prefix set to /usr, the installed oxygen font is found automatically by fontconfig. If we're installed to a different prefix, we need to point fontconfig at the font. We do that by linking it from either XDG_DATA_HOME or ~/.fonts/ and updating fontconfig with it. The latter is irrelevant for systems that install into /usr. Diffs - CMakeLists.txt 0135bb1f7475862451775928adf5dc20167424e0 fonts/CMakeLists.txt PRE-CREATION fonts/oxygen/COPYING-GPL+FE.txt PRE-CREATION fonts/oxygen/GPL.txt PRE-CREATION fonts/oxygen/Oxygen-Sans-Bold.ttf PRE-CREATION fonts/oxygen/Oxygen-Sans.ttf PRE-CREATION fonts/oxygen/OxygenMono-Regular.ttf PRE-CREATION fonts/oxygen/README PRE-CREATION startkde.cmake 53d1bc6a2098f634c5f386f95e1a1c504b554303 Diff: https://git.reviewboard.kde.org/r/116625/diff/ Testing --- Logged into session with clean config. Font settings are applied correctly throughout. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116625: Oxygen as default font
On March 6, 2014, 2:06 a.m., Hrvoje Senjan wrote: startkde.cmake, line 76 https://git.reviewboard.kde.org/r/116625/diff/1/?file=252390#file252390line76 Why not just change the defaults in frameworkintegration instead of writing directly into users settings? Martin Gräßlin wrote: I also don't like that this seems to be at least parsed with every startup. If it needs to go through our startup and cannot be done in frameworkintegration I think it should be a kconf update script. You mean the parsing of kdeglobals on startup of apps? That would mean frameworkintegration depends on oxygen-font. I'm not sure that's an acceptable dependency, and I'd like to know for sure that that approach is acceptable before implementing it. CC:ing Alex Fiestas as the maintainer of that. Alex would you be OK with a runtime dependency on Oxygen font in frameworkintegration? - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/#review52219 --- On March 6, 2014, 1:08 a.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/ --- (Updated March 6, 2014, 1:08 a.m.) Review request for Plasma. Repository: kde-workspace Description --- Make Oxygen the default font This has three portions: the fonts itself, installation of them including fontconfig bits, and setting font defaults in kdeglobals. Oxygen Font 0.4 Imported from oxygen-font repository. The startkde portion contains the bits to write out a kdeglobals default file if it doesn't exist with font settings applied. Usually, with install prefix set to /usr, the installed oxygen font is found automatically by fontconfig. If we're installed to a different prefix, we need to point fontconfig at the font. We do that by linking it from either XDG_DATA_HOME or ~/.fonts/ and updating fontconfig with it. The latter is irrelevant for systems that install into /usr. Diffs - CMakeLists.txt 0135bb1f7475862451775928adf5dc20167424e0 fonts/CMakeLists.txt PRE-CREATION fonts/oxygen/COPYING-GPL+FE.txt PRE-CREATION fonts/oxygen/GPL.txt PRE-CREATION fonts/oxygen/Oxygen-Sans-Bold.ttf PRE-CREATION fonts/oxygen/Oxygen-Sans.ttf PRE-CREATION fonts/oxygen/OxygenMono-Regular.ttf PRE-CREATION fonts/oxygen/README PRE-CREATION startkde.cmake 53d1bc6a2098f634c5f386f95e1a1c504b554303 Diff: https://git.reviewboard.kde.org/r/116625/diff/ Testing --- Logged into session with clean config. Font settings are applied correctly throughout. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116625: Oxygen as default font
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/ --- (Updated March 6, 2014, 10:29 a.m.) Review request for Plasma and Àlex Fiestas. Repository: kde-workspace Description --- Make Oxygen the default font This has three portions: the fonts itself, installation of them including fontconfig bits, and setting font defaults in kdeglobals. Oxygen Font 0.4 Imported from oxygen-font repository. The startkde portion contains the bits to write out a kdeglobals default file if it doesn't exist with font settings applied. Usually, with install prefix set to /usr, the installed oxygen font is found automatically by fontconfig. If we're installed to a different prefix, we need to point fontconfig at the font. We do that by linking it from either XDG_DATA_HOME or ~/.fonts/ and updating fontconfig with it. The latter is irrelevant for systems that install into /usr. Diffs - CMakeLists.txt 0135bb1f7475862451775928adf5dc20167424e0 fonts/CMakeLists.txt PRE-CREATION fonts/oxygen/COPYING-GPL+FE.txt PRE-CREATION fonts/oxygen/GPL.txt PRE-CREATION fonts/oxygen/Oxygen-Sans-Bold.ttf PRE-CREATION fonts/oxygen/Oxygen-Sans.ttf PRE-CREATION fonts/oxygen/OxygenMono-Regular.ttf PRE-CREATION fonts/oxygen/README PRE-CREATION startkde.cmake 53d1bc6a2098f634c5f386f95e1a1c504b554303 Diff: https://git.reviewboard.kde.org/r/116625/diff/ Testing --- Logged into session with clean config. Font settings are applied correctly throughout. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116625: Oxygen as default font
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/#review52240 --- Is the ttf's the sources of the fonts? We shouldn't distribute binaries, no? OTOH, I would say it's fine installing the font from frameworks integration, although it makes little difference since frameworks integration will be offering whatever has been put in the configs. - Aleix Pol Gonzalez On March 6, 2014, 10:29 a.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/ --- (Updated March 6, 2014, 10:29 a.m.) Review request for Plasma and Àlex Fiestas. Repository: kde-workspace Description --- Make Oxygen the default font This has three portions: the fonts itself, installation of them including fontconfig bits, and setting font defaults in kdeglobals. Oxygen Font 0.4 Imported from oxygen-font repository. The startkde portion contains the bits to write out a kdeglobals default file if it doesn't exist with font settings applied. Usually, with install prefix set to /usr, the installed oxygen font is found automatically by fontconfig. If we're installed to a different prefix, we need to point fontconfig at the font. We do that by linking it from either XDG_DATA_HOME or ~/.fonts/ and updating fontconfig with it. The latter is irrelevant for systems that install into /usr. Diffs - CMakeLists.txt 0135bb1f7475862451775928adf5dc20167424e0 fonts/CMakeLists.txt PRE-CREATION fonts/oxygen/COPYING-GPL+FE.txt PRE-CREATION fonts/oxygen/GPL.txt PRE-CREATION fonts/oxygen/Oxygen-Sans-Bold.ttf PRE-CREATION fonts/oxygen/Oxygen-Sans.ttf PRE-CREATION fonts/oxygen/OxygenMono-Regular.ttf PRE-CREATION fonts/oxygen/README PRE-CREATION startkde.cmake 53d1bc6a2098f634c5f386f95e1a1c504b554303 Diff: https://git.reviewboard.kde.org/r/116625/diff/ Testing --- Logged into session with clean config. Font settings are applied correctly throughout. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116625: Oxygen as default font
On March 6, 2014, 11:34 a.m., Aleix Pol Gonzalez wrote: Is the ttf's the sources of the fonts? We shouldn't distribute binaries, no? OTOH, I would say it's fine installing the font from frameworks integration, although it makes little difference since frameworks integration will be offering whatever has been put in the configs. There are sources for the font (in the oxygen-fonts package), but to my knowledge, the preferred format for fonts is actually ttf. This would also be hardcoded as default in the config reading. - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/#review52240 --- On March 6, 2014, 10:29 a.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/ --- (Updated March 6, 2014, 10:29 a.m.) Review request for Plasma and Àlex Fiestas. Repository: kde-workspace Description --- Make Oxygen the default font This has three portions: the fonts itself, installation of them including fontconfig bits, and setting font defaults in kdeglobals. Oxygen Font 0.4 Imported from oxygen-font repository. The startkde portion contains the bits to write out a kdeglobals default file if it doesn't exist with font settings applied. Usually, with install prefix set to /usr, the installed oxygen font is found automatically by fontconfig. If we're installed to a different prefix, we need to point fontconfig at the font. We do that by linking it from either XDG_DATA_HOME or ~/.fonts/ and updating fontconfig with it. The latter is irrelevant for systems that install into /usr. Diffs - CMakeLists.txt 0135bb1f7475862451775928adf5dc20167424e0 fonts/CMakeLists.txt PRE-CREATION fonts/oxygen/COPYING-GPL+FE.txt PRE-CREATION fonts/oxygen/GPL.txt PRE-CREATION fonts/oxygen/Oxygen-Sans-Bold.ttf PRE-CREATION fonts/oxygen/Oxygen-Sans.ttf PRE-CREATION fonts/oxygen/OxygenMono-Regular.ttf PRE-CREATION fonts/oxygen/README PRE-CREATION startkde.cmake 53d1bc6a2098f634c5f386f95e1a1c504b554303 Diff: https://git.reviewboard.kde.org/r/116625/diff/ Testing --- Logged into session with clean config. Font settings are applied correctly throughout. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116625: Oxygen as default font
On March 6, 2014, 12:34 p.m., Aleix Pol Gonzalez wrote: Is the ttf's the sources of the fonts? We shouldn't distribute binaries, no? OTOH, I would say it's fine installing the font from frameworks integration, although it makes little difference since frameworks integration will be offering whatever has been put in the configs. Sebastian Kügler wrote: There are sources for the font (in the oxygen-fonts package), but to my knowledge, the preferred format for fonts is actually ttf. This would also be hardcoded as default in the config reading. There are sources for the font (in the oxygen-fonts package), but to my knowledge, the preferred format for fonts is actually ttf. That's why I suggested to fix the oxygen-font package and runtime depend through CMake. I really don't want us to include binaries in kde-workspace. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/#review52240 --- On March 6, 2014, 11:29 a.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/ --- (Updated March 6, 2014, 11:29 a.m.) Review request for Plasma and Àlex Fiestas. Repository: kde-workspace Description --- Make Oxygen the default font This has three portions: the fonts itself, installation of them including fontconfig bits, and setting font defaults in kdeglobals. Oxygen Font 0.4 Imported from oxygen-font repository. The startkde portion contains the bits to write out a kdeglobals default file if it doesn't exist with font settings applied. Usually, with install prefix set to /usr, the installed oxygen font is found automatically by fontconfig. If we're installed to a different prefix, we need to point fontconfig at the font. We do that by linking it from either XDG_DATA_HOME or ~/.fonts/ and updating fontconfig with it. The latter is irrelevant for systems that install into /usr. Diffs - CMakeLists.txt 0135bb1f7475862451775928adf5dc20167424e0 fonts/CMakeLists.txt PRE-CREATION fonts/oxygen/COPYING-GPL+FE.txt PRE-CREATION fonts/oxygen/GPL.txt PRE-CREATION fonts/oxygen/Oxygen-Sans-Bold.ttf PRE-CREATION fonts/oxygen/Oxygen-Sans.ttf PRE-CREATION fonts/oxygen/OxygenMono-Regular.ttf PRE-CREATION fonts/oxygen/README PRE-CREATION startkde.cmake 53d1bc6a2098f634c5f386f95e1a1c504b554303 Diff: https://git.reviewboard.kde.org/r/116625/diff/ Testing --- Logged into session with clean config. Font settings are applied correctly throughout. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116625: Oxygen as default font
On March 6, 2014, 11:34 a.m., Aleix Pol Gonzalez wrote: Is the ttf's the sources of the fonts? We shouldn't distribute binaries, no? OTOH, I would say it's fine installing the font from frameworks integration, although it makes little difference since frameworks integration will be offering whatever has been put in the configs. Sebastian Kügler wrote: There are sources for the font (in the oxygen-fonts package), but to my knowledge, the preferred format for fonts is actually ttf. This would also be hardcoded as default in the config reading. Martin Gräßlin wrote: There are sources for the font (in the oxygen-fonts package), but to my knowledge, the preferred format for fonts is actually ttf. That's why I suggested to fix the oxygen-font package and runtime depend through CMake. I really don't want us to include binaries in kde-workspace. +1 to what martin said. We need to figure out how we're going to specify the workspaces' dependencies anyway. You can add it to the kde-workspaces wiki [1] so we don't forget. [1] http://community.kde.org/Plasma/Tokamak7/split_proposal - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/#review52240 --- On March 6, 2014, 10:29 a.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/ --- (Updated March 6, 2014, 10:29 a.m.) Review request for Plasma and Àlex Fiestas. Repository: kde-workspace Description --- Make Oxygen the default font This has three portions: the fonts itself, installation of them including fontconfig bits, and setting font defaults in kdeglobals. Oxygen Font 0.4 Imported from oxygen-font repository. The startkde portion contains the bits to write out a kdeglobals default file if it doesn't exist with font settings applied. Usually, with install prefix set to /usr, the installed oxygen font is found automatically by fontconfig. If we're installed to a different prefix, we need to point fontconfig at the font. We do that by linking it from either XDG_DATA_HOME or ~/.fonts/ and updating fontconfig with it. The latter is irrelevant for systems that install into /usr. Diffs - CMakeLists.txt 0135bb1f7475862451775928adf5dc20167424e0 fonts/CMakeLists.txt PRE-CREATION fonts/oxygen/COPYING-GPL+FE.txt PRE-CREATION fonts/oxygen/GPL.txt PRE-CREATION fonts/oxygen/Oxygen-Sans-Bold.ttf PRE-CREATION fonts/oxygen/Oxygen-Sans.ttf PRE-CREATION fonts/oxygen/OxygenMono-Regular.ttf PRE-CREATION fonts/oxygen/README PRE-CREATION startkde.cmake 53d1bc6a2098f634c5f386f95e1a1c504b554303 Diff: https://git.reviewboard.kde.org/r/116625/diff/ Testing --- Logged into session with clean config. Font settings are applied correctly throughout. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 116625: Oxygen as default font
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/ --- Review request for Plasma. Repository: kde-workspace Description --- Make Oxygen the default font This has three portions: the fonts itself, installation of them including fontconfig bits, and setting font defaults in kdeglobals. Oxygen Font 0.4 Imported from oxygen-font repository. The startkde portion contains the bits to write out a kdeglobals default file if it doesn't exist with font settings applied. Usually, with install prefix set to /usr, the installed oxygen font is found automatically by fontconfig. If we're installed to a different prefix, we need to point fontconfig at the font. We do that by linking it from either XDG_DATA_HOME or ~/.fonts/ and updating fontconfig with it. The latter is irrelevant for systems that install into /usr. Diffs - CMakeLists.txt 0135bb1f7475862451775928adf5dc20167424e0 fonts/CMakeLists.txt PRE-CREATION fonts/oxygen/COPYING-GPL+FE.txt PRE-CREATION fonts/oxygen/GPL.txt PRE-CREATION fonts/oxygen/Oxygen-Sans-Bold.ttf PRE-CREATION fonts/oxygen/Oxygen-Sans.ttf PRE-CREATION fonts/oxygen/OxygenMono-Regular.ttf PRE-CREATION fonts/oxygen/README PRE-CREATION startkde.cmake 53d1bc6a2098f634c5f386f95e1a1c504b554303 Diff: https://git.reviewboard.kde.org/r/116625/diff/ Testing --- Logged into session with clean config. Font settings are applied correctly throughout. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116625: Oxygen as default font
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/#review52219 --- startkde.cmake https://git.reviewboard.kde.org/r/116625/#comment37007 Why not just change the defaults in frameworkintegration instead of writing directly into users settings? - Hrvoje Senjan On March 6, 2014, 1:08 a.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/ --- (Updated March 6, 2014, 1:08 a.m.) Review request for Plasma. Repository: kde-workspace Description --- Make Oxygen the default font This has three portions: the fonts itself, installation of them including fontconfig bits, and setting font defaults in kdeglobals. Oxygen Font 0.4 Imported from oxygen-font repository. The startkde portion contains the bits to write out a kdeglobals default file if it doesn't exist with font settings applied. Usually, with install prefix set to /usr, the installed oxygen font is found automatically by fontconfig. If we're installed to a different prefix, we need to point fontconfig at the font. We do that by linking it from either XDG_DATA_HOME or ~/.fonts/ and updating fontconfig with it. The latter is irrelevant for systems that install into /usr. Diffs - CMakeLists.txt 0135bb1f7475862451775928adf5dc20167424e0 fonts/CMakeLists.txt PRE-CREATION fonts/oxygen/COPYING-GPL+FE.txt PRE-CREATION fonts/oxygen/GPL.txt PRE-CREATION fonts/oxygen/Oxygen-Sans-Bold.ttf PRE-CREATION fonts/oxygen/Oxygen-Sans.ttf PRE-CREATION fonts/oxygen/OxygenMono-Regular.ttf PRE-CREATION fonts/oxygen/README PRE-CREATION startkde.cmake 53d1bc6a2098f634c5f386f95e1a1c504b554303 Diff: https://git.reviewboard.kde.org/r/116625/diff/ Testing --- Logged into session with clean config. Font settings are applied correctly throughout. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
