Re: Review Request 117139: Make menu strings conform to KDE's usability guidelines. Capitalize menu words.

2016-09-22 Thread Nikolaos Chatzidakis 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117139/
---

(Updated Sept. 22, 2016, 8:43 p.m.)


Status
--

This change has been discarded.


Review request for Plasma and Shantanu Tushar.


Repository: plasma-mediacenter


Description
---

This patch is created to provide uniform string format to pmc according to our 
Visual Design Group's guidelines ( 
http://techbase.kde.org/Projects/Usability/HIG/Capitalization ). All menu 
strings are converted so words start with capital letter.


Diffs
-

  browsingbackends/localfiles/localmusic/localmusic.desktop ab47666 
  browsingbackends/localfiles/localpictures/localpictures.desktop 4ffe275 
  browsingbackends/localfiles/localvideos/localvideos.desktop 4f22968 
  
browsingbackends/metadatabackends/metadatamusicbackend/metadatamusicbackend.desktop
 93b7c62 
  
browsingbackends/metadatabackends/metadatapicturebackend/metadatapicturebackend.desktop
 a06a168 
  
browsingbackends/metadatabackends/metadatavideobackend/metadatavideobackend.desktop
 9d04068 
  browsingbackends/onlineservices/youtube/youtubebackend.desktop 4b3ba9c 
  browsingbackends/utility/fullscreen/pmcfullscreen.desktop c992932 

Diff: https://git.reviewboard.kde.org/r/117139/diff/


Testing
---


Thanks,

Nikolaos Chatzidakis

Re: Review Request 117139: Make menu strings conform to KDE's usability guidelines. Capitalize menu words.

2016-09-22 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117139/#review99445
---



Closing as this review request is more than 2 years old.

If it still applies to current Plasma. Please reopen. Thanks

- David Edmundson


On March 28, 2014, 5:12 p.m., Nikolaos Chatzidakis wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117139/
> ---
> 
> (Updated March 28, 2014, 5:12 p.m.)
> 
> 
> Review request for Plasma and Shantanu Tushar.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> This patch is created to provide uniform string format to pmc according to 
> our Visual Design Group's guidelines ( 
> http://techbase.kde.org/Projects/Usability/HIG/Capitalization ). All menu 
> strings are converted so words start with capital letter.
> 
> 
> Diffs
> -
> 
>   browsingbackends/localfiles/localmusic/localmusic.desktop ab47666 
>   browsingbackends/localfiles/localpictures/localpictures.desktop 4ffe275 
>   browsingbackends/localfiles/localvideos/localvideos.desktop 4f22968 
>   
> browsingbackends/metadatabackends/metadatamusicbackend/metadatamusicbackend.desktop
>  93b7c62 
>   
> browsingbackends/metadatabackends/metadatapicturebackend/metadatapicturebackend.desktop
>  a06a168 
>   
> browsingbackends/metadatabackends/metadatavideobackend/metadatavideobackend.desktop
>  9d04068 
>   browsingbackends/onlineservices/youtube/youtubebackend.desktop 4b3ba9c 
>   browsingbackends/utility/fullscreen/pmcfullscreen.desktop c992932 
> 
> Diff: https://git.reviewboard.kde.org/r/117139/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Nikolaos Chatzidakis
> 
>

Re: Review Request 117139: Make menu strings conform to KDE's usability guidelines. Capitalize menu words.

2014-07-29 Thread Bhushan Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117139/#review63426
---


Ping, what is status on this?

- Bhushan Shah


On March 28, 2014, 10:42 p.m., Nikolaos Chatzidakis wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117139/
> ---
> 
> (Updated March 28, 2014, 10:42 p.m.)
> 
> 
> Review request for Plasma and Shantanu Tushar.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> This patch is created to provide uniform string format to pmc according to 
> our Visual Design Group's guidelines ( 
> http://techbase.kde.org/Projects/Usability/HIG/Capitalization ). All menu 
> strings are converted so words start with capital letter.
> 
> 
> Diffs
> -
> 
>   
> browsingbackends/metadatabackends/metadatamusicbackend/metadatamusicbackend.desktop
>  93b7c62 
>   browsingbackends/localfiles/localvideos/localvideos.desktop 4f22968 
>   browsingbackends/localfiles/localpictures/localpictures.desktop 4ffe275 
>   browsingbackends/localfiles/localmusic/localmusic.desktop ab47666 
>   
> browsingbackends/metadatabackends/metadatavideobackend/metadatavideobackend.desktop
>  9d04068 
>   browsingbackends/onlineservices/youtube/youtubebackend.desktop 4b3ba9c 
>   browsingbackends/utility/fullscreen/pmcfullscreen.desktop c992932 
>   
> browsingbackends/metadatabackends/metadatapicturebackend/metadatapicturebackend.desktop
>  a06a168 
> 
> Diff: https://git.reviewboard.kde.org/r/117139/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Nikolaos Chatzidakis
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117139: Make menu strings conform to KDE's usability guidelines. Capitalize menu words.

2014-03-28 Thread Sebastian Kügler 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117139/#review54471
---


You changed automatically translated entries, that's not necessary.

You also forgot a bunch of instances, especially all the Comment= entries.


browsingbackends/localfiles/localmusic/localmusic.desktop


Never edit translated names in .desktop files, they're automatically 
translated. Only the Name= field is considered, but not for example Name[nl]=

Different languages have different capitalization patterns, and the HIG is 
just the default for English.

You don't have to remove it, as it'll be overwritten anyway, just could 
save a lot of work next time.



browsingbackends/localfiles/localpictures/localpictures.desktop


missing



browsingbackends/localfiles/localvideos/localvideos.desktop


Browse Pictures
Browse videos 

Spot the inconsistency?



browsingbackends/localfiles/localvideos/localvideos.desktop


Needs capitalization



browsingbackends/metadatabackends/metadatamusicbackend/metadatamusicbackend.desktop


Needs capitalization



browsingbackends/metadatabackends/metadatapicturebackend/metadatapicturebackend.desktop


needs capitalization



browsingbackends/metadatabackends/metadatavideobackend/metadatavideobackend.desktop


All Videos



browsingbackends/metadatabackends/metadatavideobackend/metadatavideobackend.desktop


needs capitalization



browsingbackends/onlineservices/youtube/youtubebackend.desktop


Videos needs a capital



browsingbackends/utility/fullscreen/pmcfullscreen.desktop


Needs capitalization as well


- Sebastian Kügler


On March 28, 2014, 5:12 p.m., Nikolaos Chatzidakis wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117139/
> ---
> 
> (Updated March 28, 2014, 5:12 p.m.)
> 
> 
> Review request for Plasma and Shantanu Tushar.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> This patch is created to provide uniform string format to pmc according to 
> our Visual Design Group's guidelines ( 
> http://techbase.kde.org/Projects/Usability/HIG/Capitalization ). All menu 
> strings are converted so words start with capital letter.
> 
> 
> Diffs
> -
> 
>   
> browsingbackends/metadatabackends/metadatamusicbackend/metadatamusicbackend.desktop
>  93b7c62 
>   browsingbackends/localfiles/localvideos/localvideos.desktop 4f22968 
>   browsingbackends/localfiles/localpictures/localpictures.desktop 4ffe275 
>   browsingbackends/localfiles/localmusic/localmusic.desktop ab47666 
>   
> browsingbackends/metadatabackends/metadatavideobackend/metadatavideobackend.desktop
>  9d04068 
>   browsingbackends/onlineservices/youtube/youtubebackend.desktop 4b3ba9c 
>   browsingbackends/utility/fullscreen/pmcfullscreen.desktop c992932 
>   
> browsingbackends/metadatabackends/metadatapicturebackend/metadatapicturebackend.desktop
>  a06a168 
> 
> Diff: https://git.reviewboard.kde.org/r/117139/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Nikolaos Chatzidakis
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117139: Make menu strings conform to KDE's usability guidelines. Capitalize menu words.

2014-03-28 Thread Nikolaos Chatzidakis 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117139/
---

(Updated March 28, 2014, 5:12 p.m.)


Review request for Plasma and Shantanu Tushar.


Repository: plasma-mediacenter


Description
---

This patch is created to provide uniform string format to pmc according to our 
Visual Design Group's guidelines ( 
http://techbase.kde.org/Projects/Usability/HIG/Capitalization ). All menu 
strings are converted so words start with capital letter.


Diffs
-

  
browsingbackends/metadatabackends/metadatamusicbackend/metadatamusicbackend.desktop
 93b7c62 
  browsingbackends/localfiles/localvideos/localvideos.desktop 4f22968 
  browsingbackends/localfiles/localpictures/localpictures.desktop 4ffe275 
  browsingbackends/localfiles/localmusic/localmusic.desktop ab47666 
  
browsingbackends/metadatabackends/metadatavideobackend/metadatavideobackend.desktop
 9d04068 
  browsingbackends/onlineservices/youtube/youtubebackend.desktop 4b3ba9c 
  browsingbackends/utility/fullscreen/pmcfullscreen.desktop c992932 
  
browsingbackends/metadatabackends/metadatapicturebackend/metadatapicturebackend.desktop
 a06a168 

Diff: https://git.reviewboard.kde.org/r/117139/diff/


Testing
---


Thanks,

Nikolaos Chatzidakis

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 117139: Make menu strings conform to KDE's usability guidelines. Capitalize menu words.

2014-03-28 Thread Nikolaos Chatzidakis 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117139/
---

Review request for Plasma and Shantanu Tushar.


Repository: plasma-mediacenter


Description
---

This patch is created to provide uniform string format to pmc according to our 
Visual Design Group's guidelines ( 
http://techbase.kde.org/Projects/Usability/HIG/Capitalization ). All menu 
strings are converted so words start with capital letter.


Diffs
-

  
browsingbackends/metadatabackends/metadatamusicbackend/metadatamusicbackend.desktop
 93b7c62 
  browsingbackends/localfiles/localvideos/localvideos.desktop 4f22968 
  browsingbackends/localfiles/localpictures/localpictures.desktop 4ffe275 
  browsingbackends/localfiles/localmusic/localmusic.desktop ab47666 
  
browsingbackends/metadatabackends/metadatavideobackend/metadatavideobackend.desktop
 9d04068 
  browsingbackends/onlineservices/youtube/youtubebackend.desktop 4b3ba9c 
  browsingbackends/utility/fullscreen/pmcfullscreen.desktop c992932 
  
browsingbackends/metadatabackends/metadatapicturebackend/metadatapicturebackend.desktop
 a06a168 

Diff: https://git.reviewboard.kde.org/r/117139/diff/


Testing
---


Thanks,

Nikolaos Chatzidakis

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel