Re: Review Request 118254: Plasma-Framework: Add new a shell intrerceptor
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118254/
---
(Updated May 27, 2014, 11:27 a.m.)
Status
--
This change has been discarded.
Review request for Plasma.
Repository: plasma-framework
Description
---
hello,
This patch adds a new interceptor for our shell packages.
Right now we cannot load an svg if the image is inside the /contents/images of
the shell package.
So this patch solves that issue.
Diffs
-
src/plasma/private/packages.cpp fa0fc6a
src/plasmaquick/CMakeLists.txt cc5554a
src/plasmaquick/shellurlinterceptor.h PRE-CREATION
src/plasmaquick/shellurlinterceptor.cpp PRE-CREATION
src/plasmaquick/view.cpp 5aa1102
Diff: https://git.reviewboard.kde.org/r/118254/diff/
Testing
---
*Testing*
org.kde.desktop shell package works without any issue.
*Issues*
The interceptor doesn't return a scheme for the svg component.
PlasmaCore.SvgItem {
svg: PlasmaCore.Svg {
imagePath: "shellpackage:/images/bar.svgz"
}
}
On the above code, the "path.scheme()" from the interceptor never returns
"shellpackage", so it is completely ignored.
But the following one it works
Image {
source: "shellpackage:/images/foo.png"
}
Thanks,
Antonis Tsiapaliokas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118254: Plasma-Framework: Add new a shell intrerceptor
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118254/#review58413
---
This interceptor will fight the KIO interceptor in KDeclarative. We probably
only want one of them.
- Aleix Pol Gonzalez
On May 22, 2014, 10:11 a.m., Antonis Tsiapaliokas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118254/
> ---
>
> (Updated May 22, 2014, 10:11 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> ---
>
> hello,
>
> This patch adds a new interceptor for our shell packages.
> Right now we cannot load an svg if the image is inside the /contents/images
> of the shell package.
> So this patch solves that issue.
>
>
> Diffs
> -
>
> src/plasma/private/packages.cpp fa0fc6a
> src/plasmaquick/CMakeLists.txt cc5554a
> src/plasmaquick/shellurlinterceptor.h PRE-CREATION
> src/plasmaquick/shellurlinterceptor.cpp PRE-CREATION
> src/plasmaquick/view.cpp 5aa1102
>
> Diff: https://git.reviewboard.kde.org/r/118254/diff/
>
>
> Testing
> ---
>
> *Testing*
> org.kde.desktop shell package works without any issue.
>
> *Issues*
>
> The interceptor doesn't return a scheme for the svg component.
>
> PlasmaCore.SvgItem {
> svg: PlasmaCore.Svg {
> imagePath: "shellpackage:/images/bar.svgz"
> }
> }
>
> On the above code, the "path.scheme()" from the interceptor never returns
> "shellpackage", so it is completely ignored.
>
> But the following one it works
>
> Image {
> source: "shellpackage:/images/foo.png"
> }
>
>
> Thanks,
>
> Antonis Tsiapaliokas
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 118254: Plasma-Framework: Add new a shell intrerceptor
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118254/
---
Review request for Plasma.
Repository: plasma-framework
Description
---
hello,
This patch adds a new interceptor for our shell packages.
Right now we cannot load an svg if the image is inside the /contents/images of
the shell package.
So this patch solves that issue.
Diffs
-
src/plasma/private/packages.cpp fa0fc6a
src/plasmaquick/CMakeLists.txt cc5554a
src/plasmaquick/shellurlinterceptor.h PRE-CREATION
src/plasmaquick/shellurlinterceptor.cpp PRE-CREATION
src/plasmaquick/view.cpp 5aa1102
Diff: https://git.reviewboard.kde.org/r/118254/diff/
Testing
---
*Testing*
org.kde.desktop shell package works without any issue.
*Issues*
The interceptor doesn't return a scheme for the svg component.
PlasmaCore.SvgItem {
svg: PlasmaCore.Svg {
imagePath: "shellpackage:/images/bar.svgz"
}
}
On the above code, the "path.scheme()" from the interceptor never returns
"shellpackage", so it is completely ignored.
But the following one it works
Image {
source: "shellpackage:/images/foo.png"
}
Thanks,
Antonis Tsiapaliokas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
