Re: Review Request 120316: standalone application mode for plasmashell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120316/ --- (Updated Sept. 24, 2014, 3:43 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-workspace Description --- This is as alternative to https://git.reviewboard.kde.org/r/120270/ with this approach it becomes possible for the applications to use scripting, even tough makes shellcorona even more complicated. It also introduces a little change in the api between Desktop.qml and desktopview.cpp that i think it makes sense regardless of the other components of the patch (and that should really go in before thursday). One thing I still think I'll try is to use another corona in this case (basically simpleshellcorona from the other review request) so it does not make the code of shellcorona more complex (but will make scripting a bit more complicated) Diffs - shell/CMakeLists.txt e835bf8 shell/desktopview.h 6aeeeb6 shell/desktopview.cpp 08c1c32 shell/main.cpp e737007 shell/scripting/scriptengine.h 6ce8b51 shell/scripting/scriptengine.cpp 5b035ea shell/shellcorona.cpp eeb01af shell/shellmanager.h eef25aa shell/shellmanager.cpp f6472cb shell/standaloneappcorona.h PRE-CREATION shell/standaloneappcorona.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120316/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120316: standalone application mode for plasmashell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120316/ --- (Updated Sept. 23, 2014, 10:29 a.m.) Review request for Plasma. Repository: plasma-workspace Description --- This is as alternative to https://git.reviewboard.kde.org/r/120270/ with this approach it becomes possible for the applications to use scripting, even tough makes shellcorona even more complicated. It also introduces a little change in the api between Desktop.qml and desktopview.cpp that i think it makes sense regardless of the other components of the patch (and that should really go in before thursday). One thing I still think I'll try is to use another corona in this case (basically simpleshellcorona from the other review request) so it does not make the code of shellcorona more complex (but will make scripting a bit more complicated) Diffs (updated) - shell/CMakeLists.txt e835bf8 shell/desktopview.h 6aeeeb6 shell/desktopview.cpp 08c1c32 shell/main.cpp e737007 shell/scripting/scriptengine.h 6ce8b51 shell/scripting/scriptengine.cpp 5b035ea shell/shellcorona.cpp eeb01af shell/shellmanager.h eef25aa shell/shellmanager.cpp f6472cb shell/standaloneappcorona.h PRE-CREATION shell/standaloneappcorona.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120316/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120316: standalone application mode for plasmashell
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120316/#review67282
---
shell/desktopview.cpp
https://git.reviewboard.kde.org/r/120316/#comment46975
why do we have to do this on every focus event when we didn't when it was
the 3 booleans?
shell/desktopview.cpp
https://git.reviewboard.kde.org/r/120316/#comment46972
would probably be best to do
if (!standalone) {
e-ignore();
}
otherwise let the event propogate, rather than having direct handling for
both things.
shell/main.cpp
https://git.reviewboard.kde.org/r/120316/#comment46974
do standalone shells need to respawn?
shell/main.cpp
https://git.reviewboard.kde.org/r/120316/#comment46973
why not just create it on the stack and remove the delete.
Failing that use QScopedPointer
shell/standaloneappcorona.cpp
https://git.reviewboard.kde.org/r/120316/#comment46971
why do this when we change activity?
- David Edmundson
On Sept. 23, 2014, 10:29 a.m., Marco Martin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120316/
---
(Updated Sept. 23, 2014, 10:29 a.m.)
Review request for Plasma.
Repository: plasma-workspace
Description
---
This is as alternative to https://git.reviewboard.kde.org/r/120270/
with this approach it becomes possible for the applications to use scripting,
even tough makes shellcorona even more complicated.
It also introduces a little change in the api between Desktop.qml and
desktopview.cpp that i think it makes sense regardless of the other
components of the patch (and that should really go in before thursday).
One thing I still think I'll try is to use another corona in this case
(basically simpleshellcorona from the other review request) so it does not
make the code of shellcorona more complex (but will make scripting a bit more
complicated)
Diffs
-
shell/CMakeLists.txt e835bf8
shell/desktopview.h 6aeeeb6
shell/desktopview.cpp 08c1c32
shell/main.cpp e737007
shell/scripting/scriptengine.h 6ce8b51
shell/scripting/scriptengine.cpp 5b035ea
shell/shellcorona.cpp eeb01af
shell/shellmanager.h eef25aa
shell/shellmanager.cpp f6472cb
shell/standaloneappcorona.h PRE-CREATION
shell/standaloneappcorona.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/120316/diff/
Testing
---
Thanks,
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120316: standalone application mode for plasmashell
On Sept. 23, 2014, 11:54 a.m., Aleix Pol Gonzalez wrote: What do you mean by scripting here? shell scritping, the stuff to do the default layout - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120316/#review67289 --- On Sept. 23, 2014, 11:23 a.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120316/ --- (Updated Sept. 23, 2014, 11:23 a.m.) Review request for Plasma. Repository: plasma-workspace Description --- This is as alternative to https://git.reviewboard.kde.org/r/120270/ with this approach it becomes possible for the applications to use scripting, even tough makes shellcorona even more complicated. It also introduces a little change in the api between Desktop.qml and desktopview.cpp that i think it makes sense regardless of the other components of the patch (and that should really go in before thursday). One thing I still think I'll try is to use another corona in this case (basically simpleshellcorona from the other review request) so it does not make the code of shellcorona more complex (but will make scripting a bit more complicated) Diffs - shell/CMakeLists.txt e835bf8 shell/desktopview.h 6aeeeb6 shell/desktopview.cpp 08c1c32 shell/main.cpp e737007 shell/scripting/scriptengine.h 6ce8b51 shell/scripting/scriptengine.cpp 5b035ea shell/shellcorona.cpp eeb01af shell/shellmanager.h eef25aa shell/shellmanager.cpp f6472cb shell/standaloneappcorona.h PRE-CREATION shell/standaloneappcorona.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120316/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120316: standalone application mode for plasmashell
On Sept. 23, 2014, 11:54 a.m., Aleix Pol Gonzalez wrote: What do you mean by scripting here? Marco Martin wrote: shell scritping, the stuff to do the default layout So all the refactoring is so the windowed corona gets scripting? What does it need scripting for? - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120316/#review67289 --- On Sept. 23, 2014, 11:23 a.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120316/ --- (Updated Sept. 23, 2014, 11:23 a.m.) Review request for Plasma. Repository: plasma-workspace Description --- This is as alternative to https://git.reviewboard.kde.org/r/120270/ with this approach it becomes possible for the applications to use scripting, even tough makes shellcorona even more complicated. It also introduces a little change in the api between Desktop.qml and desktopview.cpp that i think it makes sense regardless of the other components of the patch (and that should really go in before thursday). One thing I still think I'll try is to use another corona in this case (basically simpleshellcorona from the other review request) so it does not make the code of shellcorona more complex (but will make scripting a bit more complicated) Diffs - shell/CMakeLists.txt e835bf8 shell/desktopview.h 6aeeeb6 shell/desktopview.cpp 08c1c32 shell/main.cpp e737007 shell/scripting/scriptengine.h 6ce8b51 shell/scripting/scriptengine.cpp 5b035ea shell/shellcorona.cpp eeb01af shell/shellmanager.h eef25aa shell/shellmanager.cpp f6472cb shell/standaloneappcorona.h PRE-CREATION shell/standaloneappcorona.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120316/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120316: standalone application mode for plasmashell
On Sept. 23, 2014, 11:54 a.m., Aleix Pol Gonzalez wrote: What do you mean by scripting here? Marco Martin wrote: shell scritping, the stuff to do the default layout Aleix Pol Gonzalez wrote: So all the refactoring is so the windowed corona gets scripting? What does it need scripting for? the mediacenter or whatever needs a default layout too. - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120316/#review67289 --- On Sept. 23, 2014, 11:23 a.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120316/ --- (Updated Sept. 23, 2014, 11:23 a.m.) Review request for Plasma. Repository: plasma-workspace Description --- This is as alternative to https://git.reviewboard.kde.org/r/120270/ with this approach it becomes possible for the applications to use scripting, even tough makes shellcorona even more complicated. It also introduces a little change in the api between Desktop.qml and desktopview.cpp that i think it makes sense regardless of the other components of the patch (and that should really go in before thursday). One thing I still think I'll try is to use another corona in this case (basically simpleshellcorona from the other review request) so it does not make the code of shellcorona more complex (but will make scripting a bit more complicated) Diffs - shell/CMakeLists.txt e835bf8 shell/desktopview.h 6aeeeb6 shell/desktopview.cpp 08c1c32 shell/main.cpp e737007 shell/scripting/scriptengine.h 6ce8b51 shell/scripting/scriptengine.cpp 5b035ea shell/shellcorona.cpp eeb01af shell/shellmanager.h eef25aa shell/shellmanager.cpp f6472cb shell/standaloneappcorona.h PRE-CREATION shell/standaloneappcorona.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120316/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 120316: standalone application mode for plasmashell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120316/ --- Review request for Plasma. Repository: plasma-workspace Description --- This is as alternative to https://git.reviewboard.kde.org/r/120270/ with this approach it becomes possible for the applications to use scripting, even tough makes shellcorona even more complicated. It also introduces a little change in the api between Desktop.qml and desktopview.cpp that i think it makes sense regardless of the other components of the patch (and that should really go in before thursday). One thing I still think I'll try is to use another corona in this case (basically simpleshellcorona from the other review request) so it does not make the code of shellcorona more complex (but will make scripting a bit more complicated) Diffs - shell/desktopview.h 6aeeeb6 shell/desktopview.cpp 08c1c32 shell/main.cpp e737007 shell/shellcorona.cpp eeb01af shell/shellmanager.h eef25aa shell/shellmanager.cpp f6472cb Diff: https://git.reviewboard.kde.org/r/120316/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120316: standalone application mode for plasmashell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120316/ --- (Updated Sept. 22, 2014, 6 p.m.) Review request for Plasma. Changes --- use a different corona for the standalone mode, doesn't overcomplicate it. scriptengine becomes slightly uglier tough Repository: plasma-workspace Description --- This is as alternative to https://git.reviewboard.kde.org/r/120270/ with this approach it becomes possible for the applications to use scripting, even tough makes shellcorona even more complicated. It also introduces a little change in the api between Desktop.qml and desktopview.cpp that i think it makes sense regardless of the other components of the patch (and that should really go in before thursday). One thing I still think I'll try is to use another corona in this case (basically simpleshellcorona from the other review request) so it does not make the code of shellcorona more complex (but will make scripting a bit more complicated) Diffs (updated) - shell/shellmanager.cpp f6472cb shell/standaloneappcorona.h PRE-CREATION shell/standaloneappcorona.cpp PRE-CREATION shell/scripting/scriptengine.cpp 5b035ea shell/shellcorona.cpp eeb01af shell/shellmanager.h eef25aa shell/main.cpp e737007 shell/scripting/scriptengine.h 6ce8b51 shell/CMakeLists.txt e835bf8 shell/desktopview.h 6aeeeb6 shell/desktopview.cpp 08c1c32 Diff: https://git.reviewboard.kde.org/r/120316/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120316: standalone application mode for plasmashell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120316/ --- (Updated Sept. 22, 2014, 6:27 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- This is as alternative to https://git.reviewboard.kde.org/r/120270/ with this approach it becomes possible for the applications to use scripting, even tough makes shellcorona even more complicated. It also introduces a little change in the api between Desktop.qml and desktopview.cpp that i think it makes sense regardless of the other components of the patch (and that should really go in before thursday). One thing I still think I'll try is to use another corona in this case (basically simpleshellcorona from the other review request) so it does not make the code of shellcorona more complex (but will make scripting a bit more complicated) Diffs (updated) - shell/main.cpp e737007 shell/CMakeLists.txt e835bf8 shell/desktopview.h 6aeeeb6 shell/desktopview.cpp 08c1c32 shell/scripting/scriptengine.h 6ce8b51 shell/scripting/scriptengine.cpp 5b035ea shell/shellcorona.cpp eeb01af shell/shellmanager.h eef25aa shell/shellmanager.cpp f6472cb shell/standaloneappcorona.h PRE-CREATION shell/standaloneappcorona.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120316/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
