Review Request 121533: Register actions for activities management
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121533/ --- Review request for Plasma. Bugs: 341856 https://bugs.kde.org/show_bug.cgi?id=341856 Repository: plasma-workspace Description --- In Plasma 4 plasma-desktop registered global shortcuts for activities management Add those actions back Diffs - shell/shellcorona.h 7c25cd4 shell/shellcorona.cpp c416217 Diff: https://git.reviewboard.kde.org/r/121533/diff/ Testing --- all shortcuts, Meta + Q, Meta + Tab and Meta + Shift + Tab works fine Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121533: Register actions for activities management
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121533/ --- (Updated Dec. 15, 2014, 8:53 p.m.) Review request for Plasma. Changes --- use setGlobalShortcut Bugs: 341856 https://bugs.kde.org/show_bug.cgi?id=341856 Repository: plasma-workspace Description --- In Plasma 4 plasma-desktop registered global shortcuts for activities management Add those actions back Diffs (updated) - shell/shellcorona.h 7c25cd4 shell/shellcorona.cpp c416217 Diff: https://git.reviewboard.kde.org/r/121533/diff/ Testing --- all shortcuts, Meta + Q, Meta + Tab and Meta + Shift + Tab works fine Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121533: Register actions for activities management
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121533/#review72063
---
shell/shellcorona.cpp
https://git.reviewboard.kde.org/r/121533/#comment50247
You can just use:
{QKeySequence(Qt::META + Qt::Key_Q)}
shell/shellcorona.cpp
https://git.reviewboard.kde.org/r/121533/#comment50248
You can use KGlobalAccel::setGlobalShortcut() which sets both the default
and active shortcuts, instead of those 2 lines
shell/shellcorona.cpp
https://git.reviewboard.kde.org/r/121533/#comment50249
Ha? :)
shell/shellcorona.cpp
https://git.reviewboard.kde.org/r/121533/#comment50250
const
shell/shellcorona.cpp
https://git.reviewboard.kde.org/r/121533/#comment50251
const
- Lukáš Tinkl
On Pro. 15, 2014, 4:23 odp., Bhushan Shah wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121533/
---
(Updated Pro. 15, 2014, 4:23 odp.)
Review request for Plasma.
Bugs: 341856
https://bugs.kde.org/show_bug.cgi?id=341856
Repository: plasma-workspace
Description
---
In Plasma 4 plasma-desktop registered global shortcuts for activities
management
Add those actions back
Diffs
-
shell/shellcorona.h 7c25cd4
shell/shellcorona.cpp c416217
Diff: https://git.reviewboard.kde.org/r/121533/diff/
Testing
---
all shortcuts, Meta + Q, Meta + Tab and Meta + Shift + Tab works fine
Thanks,
Bhushan Shah
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121533: Register actions for activities management
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121533/#review72064 --- shell/shellcorona.cpp https://git.reviewboard.kde.org/r/121533/#comment50252 too complex: there's a overload taking a QKeySequence: KGlobalAccel::self()-setGlobalShortcut(activityAction, Qt::META + Qt::Key_Q); shell/shellcorona.cpp https://git.reviewboard.kde.org/r/121533/#comment50253 *cough* shell/shellcorona.cpp https://git.reviewboard.kde.org/r/121533/#comment50255 nitpick: const shell/shellcorona.cpp https://git.reviewboard.kde.org/r/121533/#comment50254 nitpick: coding style shell/shellcorona.cpp https://git.reviewboard.kde.org/r/121533/#comment50257 nitpick: const - Martin Gräßlin On Dec. 15, 2014, 4:23 p.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121533/ --- (Updated Dec. 15, 2014, 4:23 p.m.) Review request for Plasma. Bugs: 341856 https://bugs.kde.org/show_bug.cgi?id=341856 Repository: plasma-workspace Description --- In Plasma 4 plasma-desktop registered global shortcuts for activities management Add those actions back Diffs - shell/shellcorona.h 7c25cd4 shell/shellcorona.cpp c416217 Diff: https://git.reviewboard.kde.org/r/121533/diff/ Testing --- all shortcuts, Meta + Q, Meta + Tab and Meta + Shift + Tab works fine Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121533: Register actions for activities management
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121533/ --- (Updated Dec. 15, 2014, 9:11 p.m.) Review request for Plasma. Changes --- fix issues Bugs: 341856 https://bugs.kde.org/show_bug.cgi?id=341856 Repository: plasma-workspace Description --- In Plasma 4 plasma-desktop registered global shortcuts for activities management Add those actions back Diffs (updated) - shell/shellcorona.h 7c25cd4 shell/shellcorona.cpp c416217 Diff: https://git.reviewboard.kde.org/r/121533/diff/ Testing --- all shortcuts, Meta + Q, Meta + Tab and Meta + Shift + Tab works fine Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121533: Register actions for activities management
On Dec. 15, 2014, 8:57 p.m., Lukáš Tinkl wrote: shell/shellcorona.cpp, line 1491 https://git.reviewboard.kde.org/r/121533/diff/1/?file=70#file70line1491 Ha? :) nah On Dec. 15, 2014, 8:57 p.m., Lukáš Tinkl wrote: shell/shellcorona.cpp, line 170 https://git.reviewboard.kde.org/r/121533/diff/1/?file=70#file70line170 You can use KGlobalAccel::setGlobalShortcut() which sets both the default and active shortcuts, instead of those 2 lines mgraesslin had better solution - Bhushan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121533/#review72063 --- On Dec. 15, 2014, 9:11 p.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121533/ --- (Updated Dec. 15, 2014, 9:11 p.m.) Review request for Plasma. Bugs: 341856 https://bugs.kde.org/show_bug.cgi?id=341856 Repository: plasma-workspace Description --- In Plasma 4 plasma-desktop registered global shortcuts for activities management Add those actions back Diffs - shell/shellcorona.h 7c25cd4 shell/shellcorona.cpp c416217 Diff: https://git.reviewboard.kde.org/r/121533/diff/ Testing --- all shortcuts, Meta + Q, Meta + Tab and Meta + Shift + Tab works fine Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121533: Register actions for activities management
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121533/#review72069 --- shell/shellcorona.cpp https://git.reviewboard.kde.org/r/121533/#comment50263 will remove - Bhushan Shah On Dec. 15, 2014, 9:11 p.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121533/ --- (Updated Dec. 15, 2014, 9:11 p.m.) Review request for Plasma. Bugs: 341856 https://bugs.kde.org/show_bug.cgi?id=341856 Repository: plasma-workspace Description --- In Plasma 4 plasma-desktop registered global shortcuts for activities management Add those actions back Diffs - shell/shellcorona.h 7c25cd4 shell/shellcorona.cpp c416217 Diff: https://git.reviewboard.kde.org/r/121533/diff/ Testing --- all shortcuts, Meta + Q, Meta + Tab and Meta + Shift + Tab works fine Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121533: Register actions for activities management
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121533/#review72070 --- Ship it! Ship It! - Martin Gräßlin On Dec. 15, 2014, 4:41 p.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121533/ --- (Updated Dec. 15, 2014, 4:41 p.m.) Review request for Plasma. Bugs: 341856 https://bugs.kde.org/show_bug.cgi?id=341856 Repository: plasma-workspace Description --- In Plasma 4 plasma-desktop registered global shortcuts for activities management Add those actions back Diffs - shell/shellcorona.h 7c25cd4 shell/shellcorona.cpp c416217 Diff: https://git.reviewboard.kde.org/r/121533/diff/ Testing --- all shortcuts, Meta + Q, Meta + Tab and Meta + Shift + Tab works fine Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121533: Register actions for activities management
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121533/ --- (Updated Dec. 15, 2014, 4:15 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Bugs: 341856 https://bugs.kde.org/show_bug.cgi?id=341856 Repository: plasma-workspace Description --- In Plasma 4 plasma-desktop registered global shortcuts for activities management Add those actions back Diffs - shell/shellcorona.h 7c25cd4 shell/shellcorona.cpp c416217 Diff: https://git.reviewboard.kde.org/r/121533/diff/ Testing --- all shortcuts, Meta + Q, Meta + Tab and Meta + Shift + Tab works fine Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
