Re: Review Request 121806: Allow desktop shell to force a window active
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121806/ --- (Updated Jan. 5, 2015, 10:42 vorm.) Status -- This change has been discarded. Review request for Plasma and Martin Gräßlin. Repository: plasma-workspace Description --- This way the Desktop containment can eventually force the widget explorer and activity explorer active so they always accept keyboard input. Currently often you end up with a visibly focussed (ie. blinking cursor) panel but you cannot enter anything. It is in the desktopview and not in some global import to minimize misuse outside the workspace scope. Diffs - shell/desktopview.h ea9e555 shell/desktopview.cpp bbe16f2 Diff: https://git.reviewboard.kde.org/r/121806/diff/ Testing --- In conjunction with a patch plasma-desktop, pressing Meta+Q at any given time causes the activity manager to open and it accepts keyboard events, entering a new activity name, etc works. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121806: Allow desktop shell to force a window active
On Jan. 3, 2015, 3:49 p.m., David Edmundson wrote: Adding a method to one class (DesktopView) to manipulate another an instance of another class (Dialog) whilst using nothing from DesktopView to me seems like poor API. I'd consider Q_INVOKABLE forceActiveFocus() on Plasma::Dialog Kai Uwe Broulik wrote: I know it's not pretty but I don't want to put that in such a prominent position right in Dialog. We already have the gentle requestActivate which KWin's focus stealing prevention will cancel if it would interrupt you. Sure, everyone (like I just did or like Kicker does) could write a KWindowSystem wrapper import but we shouldn't encourage forcing activation, it's fine for the shell but not for everyone. we should consider providing a proper KWindowSystem declarative API which provides access to all the methods. I think that the method has nothing to do in either DesktopView nor in Dialog. From Plasma point ov view it shouldn't be part of the API (after all it's just a workaround for one windowing system). - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121806/#review73024 --- On Jan. 3, 2015, 4:07 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121806/ --- (Updated Jan. 3, 2015, 4:07 p.m.) Review request for Plasma and Martin Gräßlin. Repository: plasma-workspace Description --- This way the Desktop containment can eventually force the widget explorer and activity explorer active so they always accept keyboard input. Currently often you end up with a visibly focussed (ie. blinking cursor) panel but you cannot enter anything. It is in the desktopview and not in some global import to minimize misuse outside the workspace scope. Diffs - shell/desktopview.h ea9e555 shell/desktopview.cpp bbe16f2 Diff: https://git.reviewboard.kde.org/r/121806/diff/ Testing --- In conjunction with a patch plasma-desktop, pressing Meta+Q at any given time causes the activity manager to open and it accepts keyboard events, entering a new activity name, etc works. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121806: Allow desktop shell to force a window active
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121806/ --- (Updated Jan. 3, 2015, 3:07 nachm.) Review request for Plasma and Martin Gräßlin. Repository: plasma-workspace Description --- This way the Desktop containment can eventually force the widget explorer and activity explorer active so they always accept keyboard input. Currently often you end up with a visibly focussed (ie. blinking cursor) panel but you cannot enter anything. It is in the desktopview and not in some global import to minimize misuse outside the workspace scope. Diffs - shell/desktopview.h ea9e555 shell/desktopview.cpp bbe16f2 Diff: https://git.reviewboard.kde.org/r/121806/diff/ Testing --- In conjunction with a patch plasma-desktop, pressing Meta+Q at any given time causes the activity manager to open and it accepts keyboard events, entering a new activity name, etc works. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121806: Allow desktop shell to force a window active
On Jan. 3, 2015, 2:49 nachm., David Edmundson wrote: Adding a method to one class (DesktopView) to manipulate another an instance of another class (Dialog) whilst using nothing from DesktopView to me seems like poor API. I'd consider Q_INVOKABLE forceActiveFocus() on Plasma::Dialog I know it's not pretty but I don't want to put that in such a prominent position right in Dialog. We already have the gentle requestActivate which KWin's focus stealing prevention will cancel if it would interrupt you. Sure, everyone (like I just did or like Kicker does) could write a KWindowSystem wrapper import but we shouldn't encourage forcing activation, it's fine for the shell but not for everyone. - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121806/#review73024 --- On Jan. 3, 2015, 2:35 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121806/ --- (Updated Jan. 3, 2015, 2:35 nachm.) Review request for Plasma. Repository: plasma-workspace Description --- This way the Desktop containment can eventually force the widget explorer and activity explorer active so they always accept keyboard input. Currently often you end up with a visibly focussed (ie. blinking cursor) panel but you cannot enter anything. It is in the desktopview and not in some global import to minimize misuse outside the workspace scope. Diffs - shell/desktopview.h ea9e555 shell/desktopview.cpp bbe16f2 Diff: https://git.reviewboard.kde.org/r/121806/diff/ Testing --- In conjunction with a patch plasma-desktop, pressing Meta+Q at any given time causes the activity manager to open and it accepts keyboard events, entering a new activity name, etc works. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121806: Allow desktop shell to force a window active
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121806/#review73024 --- Adding a method to one class (DesktopView) to manipulate another an instance of another class (Dialog) whilst using nothing from DesktopView to me seems like poor API. I'd consider Q_INVOKABLE forceActiveFocus() on Plasma::Dialog - David Edmundson On Jan. 3, 2015, 2:35 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121806/ --- (Updated Jan. 3, 2015, 2:35 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- This way the Desktop containment can eventually force the widget explorer and activity explorer active so they always accept keyboard input. Currently often you end up with a visibly focussed (ie. blinking cursor) panel but you cannot enter anything. It is in the desktopview and not in some global import to minimize misuse outside the workspace scope. Diffs - shell/desktopview.h ea9e555 shell/desktopview.cpp bbe16f2 Diff: https://git.reviewboard.kde.org/r/121806/diff/ Testing --- In conjunction with a patch plasma-desktop, pressing Meta+Q at any given time causes the activity manager to open and it accepts keyboard events, entering a new activity name, etc works. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121806: Allow desktop shell to force a window active
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121806/#review73020 --- Ship it! Ship It! - Lukáš Tinkl On Led. 3, 2015, 3:35 odp., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121806/ --- (Updated Led. 3, 2015, 3:35 odp.) Review request for Plasma. Repository: plasma-workspace Description --- This way the Desktop containment can eventually force the widget explorer and activity explorer active so they always accept keyboard input. Currently often you end up with a visibly focussed (ie. blinking cursor) panel but you cannot enter anything. It is in the desktopview and not in some global import to minimize misuse outside the workspace scope. Diffs - shell/desktopview.h ea9e555 shell/desktopview.cpp bbe16f2 Diff: https://git.reviewboard.kde.org/r/121806/diff/ Testing --- In conjunction with a patch plasma-desktop, pressing Meta+Q at any given time causes the activity manager to open and it accepts keyboard events, entering a new activity name, etc works. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 121806: Allow desktop shell to force a window active
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121806/ --- Review request for Plasma. Repository: plasma-workspace Description --- This way the Desktop containment can eventually force the widget explorer and activity explorer active so they always accept keyboard input. Currently often you end up with a visibly focussed (ie. blinking cursor) panel but you cannot enter anything. It is in the desktopview and not in some global import to minimize misuse outside the workspace scope. Diffs - shell/desktopview.h ea9e555 shell/desktopview.cpp bbe16f2 Diff: https://git.reviewboard.kde.org/r/121806/diff/ Testing --- In conjunction with a patch plasma-desktop, pressing Meta+Q at any given time causes the activity manager to open and it accepts keyboard events, entering a new activity name, etc works. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
