Re: Review Request 122679: Show Desktop feature: refurbished
On März 30, 2015, 6:02 vorm., Martin Gräßlin wrote: effects/CMakeLists.txt, line 133 https://git.reviewboard.kde.org/r/122679/diff/2/?file=357029#file357029line133 the name looks a little bit mhhh ;-) Thomas Lübking wrote: When thinking about a name that does not sound like a description (Show Desktop by moving windows to corners...) I got a Bad Window request and had a flash on bad children and corners. Maybe the new konqui images had a play in this as well... :-P We could rename is Windows to corners or something - less striking, though ;-) Martin Gräßlin wrote: Maybe something like showingdesktophelper? Thomas Lübking wrote: I'll read that as a joke? =) Window Aperture? Everybody else: feel free to suggest a nice, striking or stupid name. Ok, final threat :-) I'll push this tonight to underrun the 5.3 freeze. The name *will* be Bad, Bad, Windows =) If you want another name (decide! helper is no option), removal of one of the effects or point out remaining wishes, glitches, etc.: please SHOUT! - Thomas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/#review78192 --- On April 4, 2015, 3:28 nachm., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/ --- (Updated April 4, 2015, 3:28 nachm.) Review request for kwin, Plasma, KDE Usability, Martin Gräßlin, Marco Martin, and Vishesh Handa. Bugs: 344083 https://bugs.kde.org/show_bug.cgi?id=344083 Repository: kwin Description --- commit b4e3a736c3643179b5b4ea73f7706918a03483fe Author: Thomas Lübking Date: Mon Mar 30 11:38:54 2015 +0200 add eyeOnScreen effect commit 4aaeeda8fbebded0e915b39a54092c586de179ce Author: Thomas Lübking Date: Mon Mar 30 11:38:38 2015 +0200 support gaussian curve and animationEnded signal in ScriptedEffect commit a1e7f1a2ccefffd42e360bbaae48ecdfaa5b1ff4 Author: Thomas Lübking Date: Sun Mar 29 00:15:57 2015 +0100 Add effect to move windows to corners on showing the desktop commit d92c46e96fe9fb13403b859c5e334b618d45d268 Author: Thomas Lübking Date: Sun Mar 29 00:15:22 2015 +0100 Remove AnimationData wrapper around metadata. Allow to set metadata directly in animation objects commit ed38cf37b26aa15d77c5b73734581055be234233 Author: Thomas Lübking Date: Sun Mar 29 00:13:41 2015 +0100 make window elevation scriptable commit c297fd5c55ba862151265e4b8b65b5ffe6048a8d Author: Thomas Lübking Date: Sun Mar 29 00:12:21 2015 +0100
Re: Review Request 122679: Show Desktop feature: refurbished
On März 30, 2015, 6:02 vorm., Martin Gräßlin wrote: effects/CMakeLists.txt, line 133 https://git.reviewboard.kde.org/r/122679/diff/2/?file=357029#file357029line133 the name looks a little bit mhhh ;-) Thomas Lübking wrote: When thinking about a name that does not sound like a description (Show Desktop by moving windows to corners...) I got a Bad Window request and had a flash on bad children and corners. Maybe the new konqui images had a play in this as well... :-P We could rename is Windows to corners or something - less striking, though ;-) Martin Gräßlin wrote: Maybe something like showingdesktophelper? Thomas Lübking wrote: I'll read that as a joke? =) Window Aperture? Everybody else: feel free to suggest a nice, striking or stupid name. Thomas Lübking wrote: Ok, final threat :-) I'll push this tonight to underrun the 5.3 freeze. The name *will* be Bad, Bad, Windows =) If you want another name (decide! helper is no option), removal of one of the effects or point out remaining wishes, glitches, etc.: please SHOUT! Marco Martin wrote: +1 for merging +I would be ok with Window Aperture, Desktop Dashboard, Show Desktop.. a bit less with bad bad windows ;) Went for Window Aperture Personally I strongly object generic names (eg. Window Adding [Helper] could be fade or scale or a dozen other animations ;-) - Thomas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/#review78192 --- On April 7, 2015, 10:30 nachm., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/ --- (Updated April 7, 2015, 10:30 nachm.) Review request for kwin, Plasma, KDE Usability, Martin Gräßlin, Marco Martin, and Vishesh Handa. Bugs: 344083 https://bugs.kde.org/show_bug.cgi?id=344083 Repository: kwin Description --- commit b4e3a736c3643179b5b4ea73f7706918a03483fe Author: Thomas Lübking Date: Mon Mar 30 11:38:54 2015 +0200 add eyeOnScreen effect commit 4aaeeda8fbebded0e915b39a54092c586de179ce Author: Thomas Lübking Date: Mon Mar 30 11:38:38 2015 +0200 support gaussian curve and animationEnded signal in ScriptedEffect commit a1e7f1a2ccefffd42e360bbaae48ecdfaa5b1ff4 Author: Thomas Lübking Date: Sun Mar 29 00:15:57 2015 +0100 Add effect to move windows to corners on showing the desktop commit d92c46e96fe9fb13403b859c5e334b618d45d268 Author: Thomas Lübking Date: Sun Mar 29 00:15:22 2015 +0100 Remove AnimationData wrapper around metadata. Allow to set metadata directly in animation objects commit ed38cf37b26aa15d77c5b73734581055be234233 Author: Thomas Lübking Date: Sun Mar 29 00:13:41 2015 +0100 make window elevation scriptable commit c297fd5c55ba862151265e4b8b65b5ffe6048a8d
Re: Review Request 122679: Show Desktop feature: refurbished
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/ --- (Updated April 7, 2015, 10:30 p.m.) Status -- This change has been marked as submitted. Review request for kwin, Plasma, KDE Usability, Martin Gräßlin, Marco Martin, and Vishesh Handa. Changes --- Submitted with commit d94f3c85775eced122820960d6516dc6ddd7a048 by Thomas Lübking to branch master. Bugs: 344083 https://bugs.kde.org/show_bug.cgi?id=344083 Repository: kwin Description --- commit b4e3a736c3643179b5b4ea73f7706918a03483fe Author: Thomas Lübking Date: Mon Mar 30 11:38:54 2015 +0200 add eyeOnScreen effect commit 4aaeeda8fbebded0e915b39a54092c586de179ce Author: Thomas Lübking Date: Mon Mar 30 11:38:38 2015 +0200 support gaussian curve and animationEnded signal in ScriptedEffect commit a1e7f1a2ccefffd42e360bbaae48ecdfaa5b1ff4 Author: Thomas Lübking Date: Sun Mar 29 00:15:57 2015 +0100 Add effect to move windows to corners on showing the desktop commit d92c46e96fe9fb13403b859c5e334b618d45d268 Author: Thomas Lübking Date: Sun Mar 29 00:15:22 2015 +0100 Remove AnimationData wrapper around metadata. Allow to set metadata directly in animation objects commit ed38cf37b26aa15d77c5b73734581055be234233 Author: Thomas Lübking Date: Sun Mar 29 00:13:41 2015 +0100 make window elevation scriptable commit c297fd5c55ba862151265e4b8b65b5ffe6048a8d Author: Thomas Lübking Date: Sun Mar 29 00:12:21 2015 +0100 forward showingDesktop signal to effects commit 570a92331f3691c1fb2affa4f853c75d6062f7e3 Author: Thomas Lübking Date: Sun Mar 29 00:08:32 2015 +0100 emit signal when showingDesktop changes commit a1b80b4e310b2c75b4d9811af1d23f699bc658b5 Author: Thomas Lübking Date: Sun Feb 22 16:41:45 2015 +0100 add MinimizeAll script to compensate withdrawn core feature (which though has been hidden so far) commit 983efb916e282d2263b4abcc92f714c06b3bfcc1 Author: Thomas Lübking Date: Wed Feb 18 02:09:00 2015 +0100 break showingDesktop w/ tabbox/PW/DG This is now crucial,
Re: Review Request 122679: Show Desktop feature: refurbished
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/ --- (Updated April 4, 2015, 3:28 nachm.) Review request for kwin, Plasma, KDE Usability, Martin Gräßlin, Marco Martin, and Vishesh Handa. Changes --- * emit showingDesktopChanged *after* changing the stack, so that receivers see what ends above and what not * make effects deal with layers (ie. rely on whether a window is above the desktop in the stack or not) * make eyeOnScreen less seizure prone Bugs: 344083 https://bugs.kde.org/show_bug.cgi?id=344083 Repository: kwin Description --- commit b4e3a736c3643179b5b4ea73f7706918a03483fe Author: Thomas Lübking Date: Mon Mar 30 11:38:54 2015 +0200 add eyeOnScreen effect commit 4aaeeda8fbebded0e915b39a54092c586de179ce Author: Thomas Lübking Date: Mon Mar 30 11:38:38 2015 +0200 support gaussian curve and animationEnded signal in ScriptedEffect commit a1e7f1a2ccefffd42e360bbaae48ecdfaa5b1ff4 Author: Thomas Lübking Date: Sun Mar 29 00:15:57 2015 +0100 Add effect to move windows to corners on showing the desktop commit d92c46e96fe9fb13403b859c5e334b618d45d268 Author: Thomas Lübking Date: Sun Mar 29 00:15:22 2015 +0100 Remove AnimationData wrapper around metadata. Allow to set metadata directly in animation objects commit ed38cf37b26aa15d77c5b73734581055be234233 Author: Thomas Lübking Date: Sun Mar 29 00:13:41 2015 +0100 make window elevation scriptable commit c297fd5c55ba862151265e4b8b65b5ffe6048a8d Author: Thomas Lübking Date: Sun Mar 29 00:12:21 2015 +0100 forward showingDesktop signal to effects commit 570a92331f3691c1fb2affa4f853c75d6062f7e3 Author: Thomas Lübking Date: Sun Mar 29 00:08:32 2015 +0100 emit signal when showingDesktop changes commit a1b80b4e310b2c75b4d9811af1d23f699bc658b5 Author: Thomas Lübking Date: Sun Feb 22 16:41:45 2015 +0100 add MinimizeAll script to compensate withdrawn core feature (which though has been hidden so far) commit 983efb916e282d2263b4abcc92f714c06b3bfcc1 Author: Thomas Lübking Date: Wed Feb 18
Re: Review Request 122679: Show Desktop feature: refurbished
On March 22, 2015, 8:28 p.m., Kai Uwe Broulik wrote: Sorry for being late to the party: UX issues I have with that implementation: - No transition, the windows just disappear (would be cool to have them slide out of the screen or have them stay at the edges of the screen like OSX does it, but that's visuals) - Cannot access plasmoid or containment config windows (or GHNS in widget explorer) - they don't appear in that mode, nor do they exit it - KRunner exits this mode, imho KRunner should be usable from there (usability?) - Panels inaccessible (though usability even proposed hiding them in Dashboard mode, so..) Other than that this would 100% replace my Dashboard usecase, so +1 for the overall idea. Usability team, ping? Thomas Lübking wrote: - No transition Definitively, but another patch (we'll have to wire up a showingDesktop signal and then script something nicely ;-) - Cannot access plasmoid or containment config windows We'll have to require them to either be transient for the desktop or set the keepAbove flag (and interpret that in layers.cpp) to still keep normal docks (panels) hidden - KRunner exits this mode Afaics that's a general (re-occurring ;-) problem w/ krunner, unrelated to this patch. Non-dock type windows that are not in the desktop group break the mode. This applies because krunner is another process than plasmashell (afair the KDE3 runner was part of kdesktop) = KRunner must either become a dock-type (and keepabove or transient) or move itself into the desktops window group (be transient for it or have the same WM_CLIENT_LEADER) However, I put problem in quotation marks, because that rather seems the minimize-all (aka. you wanted to switch the VD ;-) case of cleaning up the workspace (for the very next action will break the mode anyway when you run a new application)?? - Panels inaccessible See above - we can either make dock-type windows (mostly panels) unconditionally visible or require them to setup a special condition (transient for desktop or keep above) The question on what to do here is also the question mostly asked by this RR =) The global behavior (as long as we don't require transiency/keepabove hints from some panels) is very easy to adjust, though. @Usability team, please also see my very first comment for more information on layer control. kdeuser 56 wrote: My use case for the dashboard was mainly, when I had a lot of windows and I wanted to customize plasma: Simply trigger dashboard and cutsomize the Desktop, othwerwise, you would have to use Show Desktop or change to an empty workspace. I really liked what we had in plasma5 till now, because the panels were accessible, why wouldn't they be? What speaks against the panels? They are accesible all the time, why wouldn't that be in dashboard mode too? When the panels are inacessible, I have to treat cutsomization (my main use case), seperately for widgets and panels, something I find an unnecessary barrier. If my opinion is worth anything here, I would vote for accessible panels, dimmed or not. On another note: even when you do not customize stuff, you use the dashboard/show desktop for accessing information on the workspace. Now I trigger dashboard, but want to have a look at a notificaiton too, while I am for example reading my plasma notes. Now I would have to exit the dashboard and reenter it, because the panels are not accessible. I don't think the panels ever distract that much, they should be made inaccessible. Thomas Pfeiffer wrote: Sorry for keeping you waiting for so long. I was very busy recently, and apparently I'm the only one who is currently active on the usability list. So here goes: * Transition: We all agree that we need a transition, but since Thomas said it will be another patch, we won't discuss it here further (just keep it in mind) * Config windows: I'm still for a separate workspace configuration mode (Andrew and I have talked about our plans for that to some Plasma devs, but we yet have to properly introduce our ideas) which would make it unnecessary to show config dialogs on the dashboard (and if we do have a separate mode, I'd indeed vote for _not_ showing them in the dashboard). However, as long as there is no separate config mode, I agree with kdeuser56 that the dashboard is probably the best place available to configure the workspace and therefore config dialogs should be visible there. Just please don't put too much effort into this as it might become obsolete later. * Panels: I'm a bit torn here. The thing is that we have not defined what the dashboard is supposed to be used for. If it is only for glancing at or quickly interacting with desktop widgets, then panels would only be distracting. If it is for
Re: Review Request 122679: Show Desktop feature: refurbished
On März 22, 2015, 8:28 nachm., Kai Uwe Broulik wrote: Sorry for being late to the party: UX issues I have with that implementation: - No transition, the windows just disappear (would be cool to have them slide out of the screen or have them stay at the edges of the screen like OSX does it, but that's visuals) - Cannot access plasmoid or containment config windows (or GHNS in widget explorer) - they don't appear in that mode, nor do they exit it - KRunner exits this mode, imho KRunner should be usable from there (usability?) - Panels inaccessible (though usability even proposed hiding them in Dashboard mode, so..) Other than that this would 100% replace my Dashboard usecase, so +1 for the overall idea. Usability team, ping? Thomas Lübking wrote: - No transition Definitively, but another patch (we'll have to wire up a showingDesktop signal and then script something nicely ;-) - Cannot access plasmoid or containment config windows We'll have to require them to either be transient for the desktop or set the keepAbove flag (and interpret that in layers.cpp) to still keep normal docks (panels) hidden - KRunner exits this mode Afaics that's a general (re-occurring ;-) problem w/ krunner, unrelated to this patch. Non-dock type windows that are not in the desktop group break the mode. This applies because krunner is another process than plasmashell (afair the KDE3 runner was part of kdesktop) = KRunner must either become a dock-type (and keepabove or transient) or move itself into the desktops window group (be transient for it or have the same WM_CLIENT_LEADER) However, I put problem in quotation marks, because that rather seems the minimize-all (aka. you wanted to switch the VD ;-) case of cleaning up the workspace (for the very next action will break the mode anyway when you run a new application)?? - Panels inaccessible See above - we can either make dock-type windows (mostly panels) unconditionally visible or require them to setup a special condition (transient for desktop or keep above) The question on what to do here is also the question mostly asked by this RR =) The global behavior (as long as we don't require transiency/keepabove hints from some panels) is very easy to adjust, though. @Usability team, please also see my very first comment for more information on layer control. kdeuser 56 wrote: My use case for the dashboard was mainly, when I had a lot of windows and I wanted to customize plasma: Simply trigger dashboard and cutsomize the Desktop, othwerwise, you would have to use Show Desktop or change to an empty workspace. I really liked what we had in plasma5 till now, because the panels were accessible, why wouldn't they be? What speaks against the panels? They are accesible all the time, why wouldn't that be in dashboard mode too? When the panels are inacessible, I have to treat cutsomization (my main use case), seperately for widgets and panels, something I find an unnecessary barrier. If my opinion is worth anything here, I would vote for accessible panels, dimmed or not. On another note: even when you do not customize stuff, you use the dashboard/show desktop for accessing information on the workspace. Now I trigger dashboard, but want to have a look at a notificaiton too, while I am for example reading my plasma notes. Now I would have to exit the dashboard and reenter it, because the panels are not accessible. I don't think the panels ever distract that much, they should be made inaccessible. Thomas Pfeiffer wrote: Sorry for keeping you waiting for so long. I was very busy recently, and apparently I'm the only one who is currently active on the usability list. So here goes: * Transition: We all agree that we need a transition, but since Thomas said it will be another patch, we won't discuss it here further (just keep it in mind) * Config windows: I'm still for a separate workspace configuration mode (Andrew and I have talked about our plans for that to some Plasma devs, but we yet have to properly introduce our ideas) which would make it unnecessary to show config dialogs on the dashboard (and if we do have a separate mode, I'd indeed vote for _not_ showing them in the dashboard). However, as long as there is no separate config mode, I agree with kdeuser56 that the dashboard is probably the best place available to configure the workspace and therefore config dialogs should be visible there. Just please don't put too much effort into this as it might become obsolete later. * Panels: I'm a bit torn here. The thing is that we have not defined what the dashboard is supposed to be used for. If it is only for glancing at or quickly interacting with desktop widgets, then panels would only be distracting. If it is for
Re: Review Request 122679: Show Desktop feature: refurbished
On März 30, 2015, 9:13 nachm., Kai Uwe Broulik wrote: Really nice, I love the badbadwindows effect! Is it intended that the windows stay subtly visible a centimeter at the corner of the screen? Imho they should be either completely hidden or stick out further, and less transparent, potentially allowing to click them to exit the effect (don't know whether that's possible easily). The eyeonwindows enter animation is pretty neat actually but the exit animation seems to cause seizures ;) The only issue I've seen so far is when I minimize all windows, then open widget settings or containment settings, the dialog does not appear. When then exiting the badbadwindows effect, the window suddenly appears (probably wasn't registered by the effect) but my panel no longer flies in (should probably stay there anyway since eg. widget explorer still reserve space for it?) until I restart compositing. Is it intended that the windows stay subtly visible Yupp. Hardcoded to 32px (what should probably be not ;-) The idea was to clearly indicate the state (in contrast to just an empty desktop) stick out further, and less transparent Since the purpose is to show the desktop, we'll require a good trade-off here. We must not (visually, they're not there, ie. receive no input) cover eg. TTFKAC (The thing formerly known as cashew) allowing to click them to exit the effect Not easily, I'd rather not make this a fullscreen effect (like present windows) and hope to forward events to the desktop. One could however extend the active screen corners to a) act on click b) be forcefully stolen by effects (for that puropose only?) to allow clicking a scren corner to exit the state. probably wasn't registered by the effect Indeed, this is to be sorted out with final adjustments to the layer handling (the effects need to account for windows they should not manipulate - and panels should either stay or just be faded out, or moved to one direction only) But you're right that windowAdded/Removed should be caught by the effect if we keep windows visible in the corners. - Thomas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/#review78252 --- On März 30, 2015, 9:06 nachm., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/ --- (Updated März 30, 2015, 9:06 nachm.) Review request for kwin, Plasma, KDE Usability, Martin Gräßlin, and Marco Martin. Bugs: 344083 https://bugs.kde.org/show_bug.cgi?id=344083 Repository: kwin Description --- commit b4e3a736c3643179b5b4ea73f7706918a03483fe Author: Thomas Lübking Date: Mon Mar 30 11:38:54 2015 +0200 add eyeOnScreen effect commit 4aaeeda8fbebded0e915b39a54092c586de179ce Author: Thomas Lübking Date: Mon Mar 30 11:38:38 2015 +0200 support gaussian curve and animationEnded signal in ScriptedEffect commit a1e7f1a2ccefffd42e360bbaae48ecdfaa5b1ff4 Author: Thomas Lübking Date: Sun Mar 29 00:15:57 2015 +0100 Add effect to move windows to corners on showing the desktop commit d92c46e96fe9fb13403b859c5e334b618d45d268 Author: Thomas Lübking Date: Sun Mar 29 00:15:22 2015 +0100 Remove AnimationData wrapper around metadata. Allow to set metadata directly in animation objects commit ed38cf37b26aa15d77c5b73734581055be234233
Re: Review Request 122679: Show Desktop feature: refurbished
On März 22, 2015, 8:28 nachm., Kai Uwe Broulik wrote: Sorry for being late to the party: UX issues I have with that implementation: - No transition, the windows just disappear (would be cool to have them slide out of the screen or have them stay at the edges of the screen like OSX does it, but that's visuals) - Cannot access plasmoid or containment config windows (or GHNS in widget explorer) - they don't appear in that mode, nor do they exit it - KRunner exits this mode, imho KRunner should be usable from there (usability?) - Panels inaccessible (though usability even proposed hiding them in Dashboard mode, so..) Other than that this would 100% replace my Dashboard usecase, so +1 for the overall idea. Usability team, ping? Thomas Lübking wrote: - No transition Definitively, but another patch (we'll have to wire up a showingDesktop signal and then script something nicely ;-) - Cannot access plasmoid or containment config windows We'll have to require them to either be transient for the desktop or set the keepAbove flag (and interpret that in layers.cpp) to still keep normal docks (panels) hidden - KRunner exits this mode Afaics that's a general (re-occurring ;-) problem w/ krunner, unrelated to this patch. Non-dock type windows that are not in the desktop group break the mode. This applies because krunner is another process than plasmashell (afair the KDE3 runner was part of kdesktop) = KRunner must either become a dock-type (and keepabove or transient) or move itself into the desktops window group (be transient for it or have the same WM_CLIENT_LEADER) However, I put problem in quotation marks, because that rather seems the minimize-all (aka. you wanted to switch the VD ;-) case of cleaning up the workspace (for the very next action will break the mode anyway when you run a new application)?? - Panels inaccessible See above - we can either make dock-type windows (mostly panels) unconditionally visible or require them to setup a special condition (transient for desktop or keep above) The question on what to do here is also the question mostly asked by this RR =) The global behavior (as long as we don't require transiency/keepabove hints from some panels) is very easy to adjust, though. @Usability team, please also see my very first comment for more information on layer control. kdeuser 56 wrote: My use case for the dashboard was mainly, when I had a lot of windows and I wanted to customize plasma: Simply trigger dashboard and cutsomize the Desktop, othwerwise, you would have to use Show Desktop or change to an empty workspace. I really liked what we had in plasma5 till now, because the panels were accessible, why wouldn't they be? What speaks against the panels? They are accesible all the time, why wouldn't that be in dashboard mode too? When the panels are inacessible, I have to treat cutsomization (my main use case), seperately for widgets and panels, something I find an unnecessary barrier. If my opinion is worth anything here, I would vote for accessible panels, dimmed or not. On another note: even when you do not customize stuff, you use the dashboard/show desktop for accessing information on the workspace. Now I trigger dashboard, but want to have a look at a notificaiton too, while I am for example reading my plasma notes. Now I would have to exit the dashboard and reenter it, because the panels are not accessible. I don't think the panels ever distract that much, they should be made inaccessible. Thomas Pfeiffer wrote: Sorry for keeping you waiting for so long. I was very busy recently, and apparently I'm the only one who is currently active on the usability list. So here goes: * Transition: We all agree that we need a transition, but since Thomas said it will be another patch, we won't discuss it here further (just keep it in mind) * Config windows: I'm still for a separate workspace configuration mode (Andrew and I have talked about our plans for that to some Plasma devs, but we yet have to properly introduce our ideas) which would make it unnecessary to show config dialogs on the dashboard (and if we do have a separate mode, I'd indeed vote for _not_ showing them in the dashboard). However, as long as there is no separate config mode, I agree with kdeuser56 that the dashboard is probably the best place available to configure the workspace and therefore config dialogs should be visible there. Just please don't put too much effort into this as it might become obsolete later. * Panels: I'm a bit torn here. The thing is that we have not defined what the dashboard is supposed to be used for. If it is only for glancing at or quickly interacting with desktop widgets, then panels would only be distracting. If it is for
Re: Review Request 122679: Show Desktop feature: refurbished
On März 30, 2015, 6:02 vorm., Martin Gräßlin wrote: Can we be sure that the change reguarding AnimationData in the ScriptedEffects doesn't break the existing effects? See scriptedeffect.cpp lines 251, 280. The AnimationData pointer was hardcoded to nullptr, metaFromData thus NOOP. There may be scripts creating AnimationData objects, but they won't work ;-) On März 30, 2015, 6:02 vorm., Martin Gräßlin wrote: effects/CMakeLists.txt, line 133 https://git.reviewboard.kde.org/r/122679/diff/2/?file=357029#file357029line133 the name looks a little bit mhhh ;-) When thinking about a name that does not sound like a description (Show Desktop by moving windows to corners...) I got a Bad Window request and had a flash on bad children and corners. Maybe the new konqui images had a play in this as well... :-P We could rename is Windows to corners or something - less striking, though ;-) - Thomas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/#review78192 --- On März 28, 2015, 11:24 nachm., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/ --- (Updated März 28, 2015, 11:24 nachm.) Review request for kwin, Plasma, KDE Usability, Martin Gräßlin, and Marco Martin. Bugs: 344083 https://bugs.kde.org/show_bug.cgi?id=344083 Repository: kwin Description --- commit a1e7f1a2ccefffd42e360bbaae48ecdfaa5b1ff4 Author: Thomas Lübking Date: Sun Mar 29 00:15:57 2015 +0100 Add effect to move windows to corners on showing the desktop commit d92c46e96fe9fb13403b859c5e334b618d45d268 Author: Thomas Lübking Date: Sun Mar 29 00:15:22 2015 +0100 Remove AnimationData wrapper around metadata. Allow to set metadata directly in animation objects commit ed38cf37b26aa15d77c5b73734581055be234233 Author: Thomas Lübking Date: Sun Mar 29 00:13:41 2015 +0100 make window elevation scriptable commit c297fd5c55ba862151265e4b8b65b5ffe6048a8d Author: Thomas Lübking Date: Sun Mar 29 00:12:21 2015 +0100 forward showingDesktop signal to effects commit 570a92331f3691c1fb2affa4f853c75d6062f7e3
Re: Review Request 122679: Show Desktop feature: refurbished
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/#review78192 --- Can we be sure that the change reguarding AnimationData in the ScriptedEffects doesn't break the existing effects? effects/CMakeLists.txt (line 133) https://git.reviewboard.kde.org/r/122679/#comment53574 the name looks a little bit mhhh ;-) - Martin Gräßlin On March 29, 2015, 12:24 a.m., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/ --- (Updated March 29, 2015, 12:24 a.m.) Review request for kwin, Plasma, KDE Usability, Martin Gräßlin, and Marco Martin. Bugs: 344083 https://bugs.kde.org/show_bug.cgi?id=344083 Repository: kwin Description --- commit a1e7f1a2ccefffd42e360bbaae48ecdfaa5b1ff4 Author: Thomas Lübking Date: Sun Mar 29 00:15:57 2015 +0100 Add effect to move windows to corners on showing the desktop commit d92c46e96fe9fb13403b859c5e334b618d45d268 Author: Thomas Lübking Date: Sun Mar 29 00:15:22 2015 +0100 Remove AnimationData wrapper around metadata. Allow to set metadata directly in animation objects commit ed38cf37b26aa15d77c5b73734581055be234233 Author: Thomas Lübking Date: Sun Mar 29 00:13:41 2015 +0100 make window elevation scriptable commit c297fd5c55ba862151265e4b8b65b5ffe6048a8d Author: Thomas Lübking Date: Sun Mar 29 00:12:21 2015 +0100 forward showingDesktop signal to effects commit 570a92331f3691c1fb2affa4f853c75d6062f7e3 Author: Thomas Lübking Date: Sun Mar 29 00:08:32 2015 +0100 emit signal when showingDesktop changes commit a1b80b4e310b2c75b4d9811af1d23f699bc658b5 Author: Thomas Lübking Date: Sun Feb 22 16:41:45 2015 +0100 add MinimizeAll script to compensate withdrawn core feature (which though has been hidden so far) commit 983efb916e282d2263b4abcc92f714c06b3bfcc1
Re: Review Request 122679: Show Desktop feature: refurbished
On March 30, 2015, 8:02 a.m., Martin Gräßlin wrote: effects/CMakeLists.txt, line 133 https://git.reviewboard.kde.org/r/122679/diff/2/?file=357029#file357029line133 the name looks a little bit mhhh ;-) Thomas Lübking wrote: When thinking about a name that does not sound like a description (Show Desktop by moving windows to corners...) I got a Bad Window request and had a flash on bad children and corners. Maybe the new konqui images had a play in this as well... :-P We could rename is Windows to corners or something - less striking, though ;-) Maybe something like showingdesktophelper? - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/#review78192 --- On March 29, 2015, 12:24 a.m., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/ --- (Updated March 29, 2015, 12:24 a.m.) Review request for kwin, Plasma, KDE Usability, Martin Gräßlin, and Marco Martin. Bugs: 344083 https://bugs.kde.org/show_bug.cgi?id=344083 Repository: kwin Description --- commit a1e7f1a2ccefffd42e360bbaae48ecdfaa5b1ff4 Author: Thomas Lübking Date: Sun Mar 29 00:15:57 2015 +0100 Add effect to move windows to corners on showing the desktop commit d92c46e96fe9fb13403b859c5e334b618d45d268 Author: Thomas Lübking Date: Sun Mar 29 00:15:22 2015 +0100 Remove AnimationData wrapper around metadata. Allow to set metadata directly in animation objects commit ed38cf37b26aa15d77c5b73734581055be234233 Author: Thomas Lübking Date: Sun Mar 29 00:13:41 2015 +0100 make window elevation scriptable commit c297fd5c55ba862151265e4b8b65b5ffe6048a8d Author: Thomas Lübking Date: Sun Mar 29 00:12:21 2015 +0100 forward showingDesktop signal to effects commit 570a92331f3691c1fb2affa4f853c75d6062f7e3 Author: Thomas Lübking Date: Sun Mar 29 00:08:32 2015 +0100
Re: Review Request 122679: Show Desktop feature: refurbished
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/#review78200 --- effects/badbadwindows/package/contents/code/main.js (line 5) https://git.reviewboard.kde.org/r/122679/#comment53577 isn't it yours? - Martin Gräßlin On March 29, 2015, 12:24 a.m., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/ --- (Updated March 29, 2015, 12:24 a.m.) Review request for kwin, Plasma, KDE Usability, Martin Gräßlin, and Marco Martin. Bugs: 344083 https://bugs.kde.org/show_bug.cgi?id=344083 Repository: kwin Description --- commit a1e7f1a2ccefffd42e360bbaae48ecdfaa5b1ff4 Author: Thomas Lübking Date: Sun Mar 29 00:15:57 2015 +0100 Add effect to move windows to corners on showing the desktop commit d92c46e96fe9fb13403b859c5e334b618d45d268 Author: Thomas Lübking Date: Sun Mar 29 00:15:22 2015 +0100 Remove AnimationData wrapper around metadata. Allow to set metadata directly in animation objects commit ed38cf37b26aa15d77c5b73734581055be234233 Author: Thomas Lübking Date: Sun Mar 29 00:13:41 2015 +0100 make window elevation scriptable commit c297fd5c55ba862151265e4b8b65b5ffe6048a8d Author: Thomas Lübking Date: Sun Mar 29 00:12:21 2015 +0100 forward showingDesktop signal to effects commit 570a92331f3691c1fb2affa4f853c75d6062f7e3 Author: Thomas Lübking Date: Sun Mar 29 00:08:32 2015 +0100 emit signal when showingDesktop changes commit a1b80b4e310b2c75b4d9811af1d23f699bc658b5 Author: Thomas Lübking Date: Sun Feb 22 16:41:45 2015 +0100 add MinimizeAll script to compensate withdrawn core feature (which though has been hidden so far) commit 983efb916e282d2263b4abcc92f714c06b3bfcc1 Author: Thomas Lübking Date: Wed Feb 18 02:09:00 2015 +0100 break showingDesktop w/ tabbox/PW/DG
Re: Review Request 122679: Show Desktop feature: refurbished
On März 30, 2015, 7:55 vorm., Martin Gräßlin wrote: effects/badbadwindows/package/contents/code/main.js, line 5 https://git.reviewboard.kde.org/r/122679/diff/2/?file=357032#file357032line5 isn't it yours? Yes, had seen that (and fixed it, but didn't finish the eye On Screen patch yesterday) Surprise: I just copy existing effects to generate the filestructure ;-) - Thomas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/#review78200 --- On März 28, 2015, 11:24 nachm., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/ --- (Updated März 28, 2015, 11:24 nachm.) Review request for kwin, Plasma, KDE Usability, Martin Gräßlin, and Marco Martin. Bugs: 344083 https://bugs.kde.org/show_bug.cgi?id=344083 Repository: kwin Description --- commit a1e7f1a2ccefffd42e360bbaae48ecdfaa5b1ff4 Author: Thomas Lübking Date: Sun Mar 29 00:15:57 2015 +0100 Add effect to move windows to corners on showing the desktop commit d92c46e96fe9fb13403b859c5e334b618d45d268 Author: Thomas Lübking Date: Sun Mar 29 00:15:22 2015 +0100 Remove AnimationData wrapper around metadata. Allow to set metadata directly in animation objects commit ed38cf37b26aa15d77c5b73734581055be234233 Author: Thomas Lübking Date: Sun Mar 29 00:13:41 2015 +0100 make window elevation scriptable commit c297fd5c55ba862151265e4b8b65b5ffe6048a8d Author: Thomas Lübking Date: Sun Mar 29 00:12:21 2015 +0100 forward showingDesktop signal to effects commit 570a92331f3691c1fb2affa4f853c75d6062f7e3 Author: Thomas Lübking Date: Sun Mar 29 00:08:32 2015 +0100 emit signal when showingDesktop changes commit a1b80b4e310b2c75b4d9811af1d23f699bc658b5 Author: Thomas Lübking Date: Sun Feb 22 16:41:45 2015 +0100 add MinimizeAll script to
Re: Review Request 122679: Show Desktop feature: refurbished
On März 30, 2015, 6:02 vorm., Martin Gräßlin wrote: effects/CMakeLists.txt, line 133 https://git.reviewboard.kde.org/r/122679/diff/2/?file=357029#file357029line133 the name looks a little bit mhhh ;-) Thomas Lübking wrote: When thinking about a name that does not sound like a description (Show Desktop by moving windows to corners...) I got a Bad Window request and had a flash on bad children and corners. Maybe the new konqui images had a play in this as well... :-P We could rename is Windows to corners or something - less striking, though ;-) Martin Gräßlin wrote: Maybe something like showingdesktophelper? I'll read that as a joke? =) Window Aperture? Everybody else: feel free to suggest a nice, striking or stupid name. - Thomas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/#review78192 --- On März 28, 2015, 11:24 nachm., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/ --- (Updated März 28, 2015, 11:24 nachm.) Review request for kwin, Plasma, KDE Usability, Martin Gräßlin, and Marco Martin. Bugs: 344083 https://bugs.kde.org/show_bug.cgi?id=344083 Repository: kwin Description --- commit a1e7f1a2ccefffd42e360bbaae48ecdfaa5b1ff4 Author: Thomas Lübking Date: Sun Mar 29 00:15:57 2015 +0100 Add effect to move windows to corners on showing the desktop commit d92c46e96fe9fb13403b859c5e334b618d45d268 Author: Thomas Lübking Date: Sun Mar 29 00:15:22 2015 +0100 Remove AnimationData wrapper around metadata. Allow to set metadata directly in animation objects commit ed38cf37b26aa15d77c5b73734581055be234233 Author: Thomas Lübking Date: Sun Mar 29 00:13:41 2015 +0100 make window elevation scriptable commit c297fd5c55ba862151265e4b8b65b5ffe6048a8d Author: Thomas Lübking Date: Sun Mar 29 00:12:21 2015 +0100 forward showingDesktop signal to effects commit 570a92331f3691c1fb2affa4f853c75d6062f7e3 Author: Thomas Lübking
Re: Review Request 122679: Show Desktop feature: refurbished
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/#review78245 --- Was adding the usability group more meant as a heads-up to inform us that things are happening on this front, or are you expecting an actual usability review? In the latter case, we'd need some kind of visualization or at least detailed description of what is happening on the UI side, since we can't read code all that well ;) - Thomas Pfeiffer On March 28, 2015, 11:24 p.m., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/ --- (Updated March 28, 2015, 11:24 p.m.) Review request for kwin, Plasma, KDE Usability, Martin Gräßlin, and Marco Martin. Bugs: 344083 https://bugs.kde.org/show_bug.cgi?id=344083 Repository: kwin Description --- commit a1e7f1a2ccefffd42e360bbaae48ecdfaa5b1ff4 Author: Thomas Lübking Date: Sun Mar 29 00:15:57 2015 +0100 Add effect to move windows to corners on showing the desktop commit d92c46e96fe9fb13403b859c5e334b618d45d268 Author: Thomas Lübking Date: Sun Mar 29 00:15:22 2015 +0100 Remove AnimationData wrapper around metadata. Allow to set metadata directly in animation objects commit ed38cf37b26aa15d77c5b73734581055be234233 Author: Thomas Lübking Date: Sun Mar 29 00:13:41 2015 +0100 make window elevation scriptable commit c297fd5c55ba862151265e4b8b65b5ffe6048a8d Author: Thomas Lübking Date: Sun Mar 29 00:12:21 2015 +0100 forward showingDesktop signal to effects commit 570a92331f3691c1fb2affa4f853c75d6062f7e3 Author: Thomas Lübking Date: Sun Mar 29 00:08:32 2015 +0100 emit signal when showingDesktop changes commit a1b80b4e310b2c75b4d9811af1d23f699bc658b5 Author: Thomas Lübking Date: Sun Feb 22 16:41:45 2015 +0100 add MinimizeAll script to compensate withdrawn core feature (which
Re: Review Request 122679: Show Desktop feature: refurbished
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/ --- (Updated März 30, 2015, 9:06 nachm.) Review request for kwin, Plasma, KDE Usability, Martin Gräßlin, and Marco Martin. Changes --- * Add one more (alternative) effect (to select from here or later or whatever) * Therefore support gaussian curves and forward animationEnded Bugs: 344083 https://bugs.kde.org/show_bug.cgi?id=344083 Repository: kwin Description (updated) --- commit b4e3a736c3643179b5b4ea73f7706918a03483fe Author: Thomas Lübking Date: Mon Mar 30 11:38:54 2015 +0200 add eyeOnScreen effect commit 4aaeeda8fbebded0e915b39a54092c586de179ce Author: Thomas Lübking Date: Mon Mar 30 11:38:38 2015 +0200 support gaussian curve and animationEnded signal in ScriptedEffect commit a1e7f1a2ccefffd42e360bbaae48ecdfaa5b1ff4 Author: Thomas Lübking Date: Sun Mar 29 00:15:57 2015 +0100 Add effect to move windows to corners on showing the desktop commit d92c46e96fe9fb13403b859c5e334b618d45d268 Author: Thomas Lübking Date: Sun Mar 29 00:15:22 2015 +0100 Remove AnimationData wrapper around metadata. Allow to set metadata directly in animation objects commit ed38cf37b26aa15d77c5b73734581055be234233 Author: Thomas Lübking Date: Sun Mar 29 00:13:41 2015 +0100 make window elevation scriptable commit c297fd5c55ba862151265e4b8b65b5ffe6048a8d Author: Thomas Lübking Date: Sun Mar 29 00:12:21 2015 +0100 forward showingDesktop signal to effects commit 570a92331f3691c1fb2affa4f853c75d6062f7e3 Author: Thomas Lübking Date: Sun Mar 29 00:08:32 2015 +0100 emit signal when showingDesktop changes commit a1b80b4e310b2c75b4d9811af1d23f699bc658b5 Author: Thomas Lübking Date: Sun Feb 22 16:41:45 2015 +0100 add MinimizeAll script to compensate withdrawn core feature (which though has been hidden so far) commit 983efb916e282d2263b4abcc92f714c06b3bfcc1 Author: Thomas Lübking Date: Wed Feb 18 02:09:00 2015 +0100 break showingDesktop w/ tabbox/PW/DG This is now crucial, because while before (the
Re: Review Request 122679: Show Desktop feature: refurbished
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/#review78252 --- Really nice, I love the badbadwindows effect! Is it intended that the windows stay subtly visible a centimeter at the corner of the screen? Imho they should be either completely hidden or stick out further, and less transparent, potentially allowing to click them to exit the effect (don't know whether that's possible easily). The eyeonwindows enter animation is pretty neat actually but the exit animation seems to cause seizures ;) The only issue I've seen so far is when I minimize all windows, then open widget settings or containment settings, the dialog does not appear. When then exiting the badbadwindows effect, the window suddenly appears (probably wasn't registered by the effect) but my panel no longer flies in (should probably stay there anyway since eg. widget explorer still reserve space for it?) until I restart compositing. - Kai Uwe Broulik On März 30, 2015, 9:06 nachm., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/ --- (Updated März 30, 2015, 9:06 nachm.) Review request for kwin, Plasma, KDE Usability, Martin Gräßlin, and Marco Martin. Bugs: 344083 https://bugs.kde.org/show_bug.cgi?id=344083 Repository: kwin Description --- commit b4e3a736c3643179b5b4ea73f7706918a03483fe Author: Thomas Lübking Date: Mon Mar 30 11:38:54 2015 +0200 add eyeOnScreen effect commit 4aaeeda8fbebded0e915b39a54092c586de179ce Author: Thomas Lübking Date: Mon Mar 30 11:38:38 2015 +0200 support gaussian curve and animationEnded signal in ScriptedEffect commit a1e7f1a2ccefffd42e360bbaae48ecdfaa5b1ff4 Author: Thomas Lübking Date: Sun Mar 29 00:15:57 2015 +0100 Add effect to move windows to corners on showing the desktop commit d92c46e96fe9fb13403b859c5e334b618d45d268 Author: Thomas Lübking Date: Sun Mar 29 00:15:22 2015 +0100 Remove AnimationData wrapper around metadata. Allow to set metadata directly in animation objects commit ed38cf37b26aa15d77c5b73734581055be234233 Author: Thomas Lübking Date: Sun Mar 29 00:13:41 2015 +0100 make window elevation scriptable commit c297fd5c55ba862151265e4b8b65b5ffe6048a8d Author: Thomas Lübking Date: Sun Mar 29 00:12:21 2015 +0100 forward showingDesktop signal to effects
Re: Review Request 122679: Show Desktop feature: refurbished
On März 30, 2015, 7:12 nachm., Thomas Pfeiffer wrote: Was adding the usability group more meant as a heads-up to inform us that things are happening on this front, or are you expecting an actual usability review? In the latter case, we'd need some kind of visualization or at least detailed description of what is happening on the UI side, since we can't read code all that well ;) The main (only) question for the usability team right now is what do we do with panels: Should the hide or show when showing the desktop (having in mind this to be a dashboard replacement) Related question: what about windows that are marked to keep above? Hybrids (w/ eg. Kais and kdeuser56's comments in mind) are possible as well, ie. we could only show special docks/panels/windows (which however need to indicate relation by marking themselves transient for the desktop or keepabove - techincal detail, though ;-) Also see my very first comment on this. --- Aside this, you may want to comment on the effects, but they're scripts and can easily be adjusted and tried w/o compilation once the usability / visual design folks have the beta installed or so. - Thomas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/#review78245 --- On März 30, 2015, 9:06 nachm., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/ --- (Updated März 30, 2015, 9:06 nachm.) Review request for kwin, Plasma, KDE Usability, Martin Gräßlin, and Marco Martin. Bugs: 344083 https://bugs.kde.org/show_bug.cgi?id=344083 Repository: kwin Description --- commit b4e3a736c3643179b5b4ea73f7706918a03483fe Author: Thomas Lübking Date: Mon Mar 30 11:38:54 2015 +0200 add eyeOnScreen effect commit 4aaeeda8fbebded0e915b39a54092c586de179ce Author: Thomas Lübking Date: Mon Mar 30 11:38:38 2015 +0200 support gaussian curve and animationEnded signal in ScriptedEffect commit a1e7f1a2ccefffd42e360bbaae48ecdfaa5b1ff4 Author: Thomas Lübking Date: Sun Mar 29 00:15:57 2015 +0100 Add effect to move windows to corners on showing the desktop commit d92c46e96fe9fb13403b859c5e334b618d45d268 Author: Thomas Lübking Date: Sun Mar 29 00:15:22 2015 +0100 Remove AnimationData wrapper around metadata. Allow to set metadata directly in animation objects commit ed38cf37b26aa15d77c5b73734581055be234233 Author: Thomas Lübking Date: Sun Mar 29 00:13:41 2015 +0100 make window elevation scriptable commit c297fd5c55ba862151265e4b8b65b5ffe6048a8d Author: Thomas Lübking
Re: Review Request 122679: Show Desktop feature: refurbished
On March 22, 2015, 8:28 p.m., Kai Uwe Broulik wrote: Sorry for being late to the party: UX issues I have with that implementation: - No transition, the windows just disappear (would be cool to have them slide out of the screen or have them stay at the edges of the screen like OSX does it, but that's visuals) - Cannot access plasmoid or containment config windows (or GHNS in widget explorer) - they don't appear in that mode, nor do they exit it - KRunner exits this mode, imho KRunner should be usable from there (usability?) - Panels inaccessible (though usability even proposed hiding them in Dashboard mode, so..) Other than that this would 100% replace my Dashboard usecase, so +1 for the overall idea. Usability team, ping? Thomas Lübking wrote: - No transition Definitively, but another patch (we'll have to wire up a showingDesktop signal and then script something nicely ;-) - Cannot access plasmoid or containment config windows We'll have to require them to either be transient for the desktop or set the keepAbove flag (and interpret that in layers.cpp) to still keep normal docks (panels) hidden - KRunner exits this mode Afaics that's a general (re-occurring ;-) problem w/ krunner, unrelated to this patch. Non-dock type windows that are not in the desktop group break the mode. This applies because krunner is another process than plasmashell (afair the KDE3 runner was part of kdesktop) = KRunner must either become a dock-type (and keepabove or transient) or move itself into the desktops window group (be transient for it or have the same WM_CLIENT_LEADER) However, I put problem in quotation marks, because that rather seems the minimize-all (aka. you wanted to switch the VD ;-) case of cleaning up the workspace (for the very next action will break the mode anyway when you run a new application)?? - Panels inaccessible See above - we can either make dock-type windows (mostly panels) unconditionally visible or require them to setup a special condition (transient for desktop or keep above) The question on what to do here is also the question mostly asked by this RR =) The global behavior (as long as we don't require transiency/keepabove hints from some panels) is very easy to adjust, though. @Usability team, please also see my very first comment for more information on layer control. kdeuser 56 wrote: My use case for the dashboard was mainly, when I had a lot of windows and I wanted to customize plasma: Simply trigger dashboard and cutsomize the Desktop, othwerwise, you would have to use Show Desktop or change to an empty workspace. I really liked what we had in plasma5 till now, because the panels were accessible, why wouldn't they be? What speaks against the panels? They are accesible all the time, why wouldn't that be in dashboard mode too? When the panels are inacessible, I have to treat cutsomization (my main use case), seperately for widgets and panels, something I find an unnecessary barrier. If my opinion is worth anything here, I would vote for accessible panels, dimmed or not. On another note: even when you do not customize stuff, you use the dashboard/show desktop for accessing information on the workspace. Now I trigger dashboard, but want to have a look at a notificaiton too, while I am for example reading my plasma notes. Now I would have to exit the dashboard and reenter it, because the panels are not accessible. I don't think the panels ever distract that much, they should be made inaccessible. Sorry for keeping you waiting for so long. I was very busy recently, and apparently I'm the only one who is currently active on the usability list. So here goes: * Transition: We all agree that we need a transition, but since Thomas said it will be another patch, we won't discuss it here further (just keep it in mind) * Config windows: I'm still for a separate workspace configuration mode (Andrew and I have talked about our plans for that to some Plasma devs, but we yet have to properly introduce our ideas) which would make it unnecessary to show config dialogs on the dashboard (and if we do have a separate mode, I'd indeed vote for _not_ showing them in the dashboard). However, as long as there is no separate config mode, I agree with kdeuser56 that the dashboard is probably the best place available to configure the workspace and therefore config dialogs should be visible there. Just please don't put too much effort into this as it might become obsolete later. * Panels: I'm a bit torn here. The thing is that we have not defined what the dashboard is supposed to be used for. If it is only for glancing at or quickly interacting with desktop widgets, then panels would only be distracting. If it is for interacting with the workspace in general, then of course panels
Re: Review Request 122679: Show Desktop feature: refurbished
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/ --- (Updated März 28, 2015, 11:24 nachm.) Review request for kwin, Plasma, KDE Usability, Martin Gräßlin, and Marco Martin. Changes --- * signal showingDesktop (we cannot rely on testing the state during minimization ;-) * forward that signal to effects * tidy up scripted effects to make required metadata functional * add an effect to push window into corners while showing the desktop Todo: eye On Screen effect (that picks up the behavior of a popular phone OS), but i'll require the gaussian curve in the scripte effects for that ;-) Bugs: 344083 https://bugs.kde.org/show_bug.cgi?id=344083 Repository: kwin Description (updated) --- commit a1e7f1a2ccefffd42e360bbaae48ecdfaa5b1ff4 Author: Thomas Lübking Date: Sun Mar 29 00:15:57 2015 +0100 Add effect to move windows to corners on showing the desktop commit d92c46e96fe9fb13403b859c5e334b618d45d268 Author: Thomas Lübking Date: Sun Mar 29 00:15:22 2015 +0100 Remove AnimationData wrapper around metadata. Allow to set metadata directly in animation objects commit ed38cf37b26aa15d77c5b73734581055be234233 Author: Thomas Lübking Date: Sun Mar 29 00:13:41 2015 +0100 make window elevation scriptable commit c297fd5c55ba862151265e4b8b65b5ffe6048a8d Author: Thomas Lübking Date: Sun Mar 29 00:12:21 2015 +0100 forward showingDesktop signal to effects commit 570a92331f3691c1fb2affa4f853c75d6062f7e3 Author: Thomas Lübking Date: Sun Mar 29 00:08:32 2015 +0100 emit signal when showingDesktop changes commit a1b80b4e310b2c75b4d9811af1d23f699bc658b5 Author: Thomas Lübking Date: Sun Feb 22 16:41:45 2015 +0100 add MinimizeAll script to compensate withdrawn core feature (which though has been hidden so far) commit 983efb916e282d2263b4abcc92f714c06b3bfcc1 Author: Thomas Lübking Date: Wed Feb 18 02:09:00 2015 +0100 break showingDesktop w/ tabbox/PW/DG This is now crucial, because while before (the minimized) windows were conditionally shown, but are now
Re: Review Request 122679: Show Desktop feature: refurbished
On March 22, 2015, 8:28 p.m., Kai Uwe Broulik wrote: Sorry for being late to the party: UX issues I have with that implementation: - No transition, the windows just disappear (would be cool to have them slide out of the screen or have them stay at the edges of the screen like OSX does it, but that's visuals) - Cannot access plasmoid or containment config windows (or GHNS in widget explorer) - they don't appear in that mode, nor do they exit it - KRunner exits this mode, imho KRunner should be usable from there (usability?) - Panels inaccessible (though usability even proposed hiding them in Dashboard mode, so..) Other than that this would 100% replace my Dashboard usecase, so +1 for the overall idea. Usability team, ping? Thomas Lübking wrote: - No transition Definitively, but another patch (we'll have to wire up a showingDesktop signal and then script something nicely ;-) - Cannot access plasmoid or containment config windows We'll have to require them to either be transient for the desktop or set the keepAbove flag (and interpret that in layers.cpp) to still keep normal docks (panels) hidden - KRunner exits this mode Afaics that's a general (re-occurring ;-) problem w/ krunner, unrelated to this patch. Non-dock type windows that are not in the desktop group break the mode. This applies because krunner is another process than plasmashell (afair the KDE3 runner was part of kdesktop) = KRunner must either become a dock-type (and keepabove or transient) or move itself into the desktops window group (be transient for it or have the same WM_CLIENT_LEADER) However, I put problem in quotation marks, because that rather seems the minimize-all (aka. you wanted to switch the VD ;-) case of cleaning up the workspace (for the very next action will break the mode anyway when you run a new application)?? - Panels inaccessible See above - we can either make dock-type windows (mostly panels) unconditionally visible or require them to setup a special condition (transient for desktop or keep above) The question on what to do here is also the question mostly asked by this RR =) The global behavior (as long as we don't require transiency/keepabove hints from some panels) is very easy to adjust, though. @Usability team, please also see my very first comment for more information on layer control. My use case for the dashboard was mainly, when I had a lot of windows and I wanted to customize plasma: Simply trigger dashboard and cutsomize the Desktop, othwerwise, you would have to use Show Desktop or change to an empty workspace. I really liked what we had in plasma5 till now, because the panels were accessible, why wouldn't they be? What speaks against the panels? They are accesible all the time, why wouldn't that be in dashboard mode too? When the panels are inacessible, I have to treat cutsomization (my main use case), seperately for widgets and panels, something I find an unnecessary barrier. If my opinion is worth anything here, I would vote for accessible panels, dimmed or not. On another note: even when you do not customize stuff, you use the dashboard/show desktop for accessing information on the workspace. Now I trigger dashboard, but want to have a look at a notificaiton too, while I am for example reading my plasma notes. Now I would have to exit the dashboard and reenter it, because the panels are not accessible. I don't think the panels ever distract that much, they should be made inaccessible. - kdeuser --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/#review77926 --- On Feb. 26, 2015, 1:16 p.m., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/ --- (Updated Feb. 26, 2015, 1:16 p.m.) Review request for kwin, Plasma, KDE Usability, Martin Gräßlin, and Marco Martin. Bugs: 344083 https://bugs.kde.org/show_bug.cgi?id=344083 Repository: kwin Description --- commit a1b80b4e310b2c75b4d9811af1d23f699bc658b5 Author: Thomas Lübking Date: Sun Feb 22 16:41:45 2015 +0100 add MinimizeAll script to compensate withdrawn core feature (which though has been hidden so far) commit 983efb916e282d2263b4abcc92f714c06b3bfcc1 Author: Thomas Lübking Date: Wed Feb 18 02:09:00 2015 +0100 break showingDesktop w/ tabbox/PW/DG This is now crucial, because while before (the minimized) windows were conditionally shown, but are now always behind the desktop. Also, it makes the tabbox more
Re: Review Request 122679: Show Desktop feature: refurbished
On März 20, 2015, 10:47 vorm., Martin Gräßlin wrote: From my side I would like to see this in 5.3 Unless Marco, Kai or Usabilities have an imminent comment, I'd also propose to push it tomorrow evening and run into functionality bug reports (why does it, why does it not, ...) to get answers to the open questions. - Thomas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/#review77816 --- On Feb. 26, 2015, 1:16 nachm., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/ --- (Updated Feb. 26, 2015, 1:16 nachm.) Review request for kwin, Plasma, KDE Usability, Martin Gräßlin, and Marco Martin. Bugs: 344083 https://bugs.kde.org/show_bug.cgi?id=344083 Repository: kwin Description --- commit a1b80b4e310b2c75b4d9811af1d23f699bc658b5 Author: Thomas Lübking Date: Sun Feb 22 16:41:45 2015 +0100 add MinimizeAll script to compensate withdrawn core feature (which though has been hidden so far) commit 983efb916e282d2263b4abcc92f714c06b3bfcc1 Author: Thomas Lübking Date: Wed Feb 18 02:09:00 2015 +0100 break showingDesktop w/ tabbox/PW/DG This is now crucial, because while before (the minimized) windows were conditionally shown, but are now always behind the desktop. Also, it makes the tabbox more consistent. commit ff531c8e2adc407da00bef88f18d03e3829b25fa Author: Thomas Lübking Date: Wed Feb 18 01:37:45 2015 +0100 implement showingDesktop by raising the desktop window commit 190a0cc022d9935d658a6218d0b3caa79b038563 Author: Thomas Lübking Date: Wed Feb 18 00:09:46 2015 +0100 remove secret showDesktopIsMinimizeAll feature Diffs - client.h f064041 client.cpp 3e834f2 effects/desktopgrid/desktopgrid.cpp 97cb2a3 effects/presentwindows/presentwindows.cpp 07660c2 kwin.kcfg 80ca365 tabbox/tabbox.cpp f81a407 scripts/minimizeall/metadata.desktop PRE-CREATION scripts/minimizeall/contents/code/main.js PRE-CREATION scripts/CMakeLists.txt 34dedb7 options.cpp cdaa851 options.h 67e5868 layers.cpp 91edc04 manage.cpp f302892 workspace.h 4ecac3d workspace.cpp 7cbe81e Diff: https://git.reviewboard.kde.org/r/122679/diff/ Testing --- * The script (though mostly in KWin4, trouble w/ ksycoca5...) * Obviously the supersecret key is now dead ;-) * Been playing around with alternate desktop showing. Thanks, Thomas Lübking ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122679: Show Desktop feature: refurbished
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/#review77926 --- Sorry for being late to the party: UX issues I have with that implementation: - No transition, the windows just disappear (would be cool to have them slide out of the screen or have them stay at the edges of the screen like OSX does it, but that's visuals) - Cannot access plasmoid or containment config windows (or GHNS in widget explorer) - they don't appear in that mode, nor do they exit it - KRunner exits this mode, imho KRunner should be usable from there (usability?) - Panels inaccessible (though usability even proposed hiding them in Dashboard mode, so..) Other than that this would 100% replace my Dashboard usecase, so +1 for the overall idea. Usability team, ping? - Kai Uwe Broulik On Feb. 26, 2015, 1:16 nachm., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/ --- (Updated Feb. 26, 2015, 1:16 nachm.) Review request for kwin, Plasma, KDE Usability, Martin Gräßlin, and Marco Martin. Bugs: 344083 https://bugs.kde.org/show_bug.cgi?id=344083 Repository: kwin Description --- commit a1b80b4e310b2c75b4d9811af1d23f699bc658b5 Author: Thomas Lübking Date: Sun Feb 22 16:41:45 2015 +0100 add MinimizeAll script to compensate withdrawn core feature (which though has been hidden so far) commit 983efb916e282d2263b4abcc92f714c06b3bfcc1 Author: Thomas Lübking Date: Wed Feb 18 02:09:00 2015 +0100 break showingDesktop w/ tabbox/PW/DG This is now crucial, because while before (the minimized) windows were conditionally shown, but are now always behind the desktop. Also, it makes the tabbox more consistent. commit ff531c8e2adc407da00bef88f18d03e3829b25fa Author: Thomas Lübking Date: Wed Feb 18 01:37:45 2015 +0100 implement showingDesktop by raising the desktop window commit 190a0cc022d9935d658a6218d0b3caa79b038563 Author: Thomas Lübking Date: Wed Feb 18 00:09:46 2015 +0100 remove secret showDesktopIsMinimizeAll feature Diffs - client.h f064041 client.cpp 3e834f2 effects/desktopgrid/desktopgrid.cpp 97cb2a3 effects/presentwindows/presentwindows.cpp 07660c2 kwin.kcfg 80ca365 tabbox/tabbox.cpp f81a407 scripts/minimizeall/metadata.desktop PRE-CREATION scripts/minimizeall/contents/code/main.js PRE-CREATION scripts/CMakeLists.txt 34dedb7 options.cpp cdaa851 options.h 67e5868 layers.cpp 91edc04 manage.cpp f302892 workspace.h 4ecac3d workspace.cpp 7cbe81e Diff: https://git.reviewboard.kde.org/r/122679/diff/ Testing --- * The script (though mostly in KWin4, trouble w/ ksycoca5...) * Obviously the supersecret key is now dead ;-) * Been playing around with alternate desktop showing. Thanks, Thomas Lübking ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122679: Show Desktop feature: refurbished
On März 22, 2015, 8:28 nachm., Kai Uwe Broulik wrote: Sorry for being late to the party: UX issues I have with that implementation: - No transition, the windows just disappear (would be cool to have them slide out of the screen or have them stay at the edges of the screen like OSX does it, but that's visuals) - Cannot access plasmoid or containment config windows (or GHNS in widget explorer) - they don't appear in that mode, nor do they exit it - KRunner exits this mode, imho KRunner should be usable from there (usability?) - Panels inaccessible (though usability even proposed hiding them in Dashboard mode, so..) Other than that this would 100% replace my Dashboard usecase, so +1 for the overall idea. Usability team, ping? - No transition Definitively, but another patch (we'll have to wire up a showingDesktop signal and then script something nicely ;-) - Cannot access plasmoid or containment config windows We'll have to require them to either be transient for the desktop or set the keepAbove flag (and interpret that in layers.cpp) to still keep normal docks (panels) hidden - KRunner exits this mode Afaics that's a general (re-occurring ;-) problem w/ krunner, unrelated to this patch. Non-dock type windows that are not in the desktop group break the mode. This applies because krunner is another process than plasmashell (afair the KDE3 runner was part of kdesktop) = KRunner must either become a dock-type (and keepabove or transient) or move itself into the desktops window group (be transient for it or have the same WM_CLIENT_LEADER) However, I put problem in quotation marks, because that rather seems the minimize-all (aka. you wanted to switch the VD ;-) case of cleaning up the workspace (for the very next action will break the mode anyway when you run a new application)?? - Panels inaccessible See above - we can either make dock-type windows (mostly panels) unconditionally visible or require them to setup a special condition (transient for desktop or keep above) The question on what to do here is also the question mostly asked by this RR =) The global behavior (as long as we don't require transiency/keepabove hints from some panels) is very easy to adjust, though. @Usability team, please also see my very first comment for more information on layer control. - Thomas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/#review77926 --- On Feb. 26, 2015, 1:16 nachm., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/ --- (Updated Feb. 26, 2015, 1:16 nachm.) Review request for kwin, Plasma, KDE Usability, Martin Gräßlin, and Marco Martin. Bugs: 344083 https://bugs.kde.org/show_bug.cgi?id=344083 Repository: kwin Description --- commit a1b80b4e310b2c75b4d9811af1d23f699bc658b5 Author: Thomas Lübking Date: Sun Feb 22 16:41:45 2015 +0100 add MinimizeAll script to compensate withdrawn core feature (which though has been hidden so far) commit 983efb916e282d2263b4abcc92f714c06b3bfcc1 Author: Thomas Lübking Date: Wed Feb 18 02:09:00 2015 +0100 break showingDesktop w/ tabbox/PW/DG This is now crucial, because while before (the minimized) windows were conditionally shown, but are now always behind the desktop. Also, it makes the tabbox more consistent. commit ff531c8e2adc407da00bef88f18d03e3829b25fa Author: Thomas Lübking Date: Wed Feb 18 01:37:45 2015 +0100 implement showingDesktop by raising the desktop window commit 190a0cc022d9935d658a6218d0b3caa79b038563 Author: Thomas Lübking Date: Wed Feb 18 00:09:46 2015 +0100 remove secret showDesktopIsMinimizeAll feature Diffs - client.h f064041 client.cpp 3e834f2 effects/desktopgrid/desktopgrid.cpp 97cb2a3 effects/presentwindows/presentwindows.cpp 07660c2 kwin.kcfg 80ca365 tabbox/tabbox.cpp f81a407 scripts/minimizeall/metadata.desktop PRE-CREATION scripts/minimizeall/contents/code/main.js PRE-CREATION scripts/CMakeLists.txt 34dedb7 options.cpp cdaa851 options.h 67e5868 layers.cpp 91edc04 manage.cpp f302892 workspace.h 4ecac3d workspace.cpp 7cbe81e Diff: https://git.reviewboard.kde.org/r/122679/diff/ Testing --- * The script (though mostly in KWin4, trouble w/ ksycoca5...) * Obviously the supersecret key is now dead ;-) * Been playing around with alternate desktop showing. Thanks, Thomas Lübking ___ Plasma-devel mailing list Plasma-devel@kde.org
Re: Review Request 122679: Show Desktop feature: refurbished
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/#review77816 --- Ship it! From my side I would like to see this in 5.3 - Martin Gräßlin On Feb. 26, 2015, 2:16 p.m., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/ --- (Updated Feb. 26, 2015, 2:16 p.m.) Review request for kwin, Plasma, KDE Usability, Martin Gräßlin, and Marco Martin. Bugs: 344083 https://bugs.kde.org/show_bug.cgi?id=344083 Repository: kwin Description --- commit a1b80b4e310b2c75b4d9811af1d23f699bc658b5 Author: Thomas Lübking Date: Sun Feb 22 16:41:45 2015 +0100 add MinimizeAll script to compensate withdrawn core feature (which though has been hidden so far) commit 983efb916e282d2263b4abcc92f714c06b3bfcc1 Author: Thomas Lübking Date: Wed Feb 18 02:09:00 2015 +0100 break showingDesktop w/ tabbox/PW/DG This is now crucial, because while before (the minimized) windows were conditionally shown, but are now always behind the desktop. Also, it makes the tabbox more consistent. commit ff531c8e2adc407da00bef88f18d03e3829b25fa Author: Thomas Lübking Date: Wed Feb 18 01:37:45 2015 +0100 implement showingDesktop by raising the desktop window commit 190a0cc022d9935d658a6218d0b3caa79b038563 Author: Thomas Lübking Date: Wed Feb 18 00:09:46 2015 +0100 remove secret showDesktopIsMinimizeAll feature Diffs - client.h f064041 client.cpp 3e834f2 effects/desktopgrid/desktopgrid.cpp 97cb2a3 effects/presentwindows/presentwindows.cpp 07660c2 kwin.kcfg 80ca365 tabbox/tabbox.cpp f81a407 scripts/minimizeall/metadata.desktop PRE-CREATION scripts/minimizeall/contents/code/main.js PRE-CREATION scripts/CMakeLists.txt 34dedb7 options.cpp cdaa851 options.h 67e5868 layers.cpp 91edc04 manage.cpp f302892 workspace.h 4ecac3d workspace.cpp 7cbe81e Diff: https://git.reviewboard.kde.org/r/122679/diff/ Testing --- * The script (though mostly in KWin4, trouble w/ ksycoca5...) * Obviously the supersecret key is now dead ;-) * Been playing around with alternate desktop showing. Thanks, Thomas Lübking ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122679: Show Desktop feature: refurbished
On Feb. 23, 2015, 8:25 vorm., Martin Gräßlin wrote: effects/presentwindows/presentwindows.cpp, line 1418 https://git.reviewboard.kde.org/r/122679/diff/1/?file=350838#file350838line1418 Maybe: whenever a fullscreen effect is used disable showingDesktoP? Thomas Lübking wrote: That would eg. also affect invoking the cube to alter the VD, would it not? (I do not mean the cubeslide effect) Martin Gräßlin wrote: yes, would also affect cube. That was actually my thought for it. I would expect it to restore windows, otherwise the effect might be a little bit pointless IMHO. You still get the desktop name. While I'm willing to grant you the reason to exit SD w/ entering the cube, I'm really not sure whether setActiveFullscreenEffect (technical detail) should exit SD as unconditional side effect. Eg. one could have a FS effect to paint onto the desktop or whatnot. Also a cube effect to change activities or similar could be added and then there's no real implication to lower *this* desktop again. Assuming EffectsHandler::setActiveFullscreenEffect(Effect *e, quitShowingDesktop = true); one had an apparently pretty unrelated random parameter? - Thomas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/#review76450 --- On Feb. 22, 2015, 3:51 nachm., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/ --- (Updated Feb. 22, 2015, 3:51 nachm.) Review request for kwin, Plasma, Martin Gräßlin, and Marco Martin. Bugs: 344083 https://bugs.kde.org/show_bug.cgi?id=344083 Repository: kwin Description --- commit a1b80b4e310b2c75b4d9811af1d23f699bc658b5 Author: Thomas Lübking Date: Sun Feb 22 16:41:45 2015 +0100 add MinimizeAll script to compensate withdrawn core feature (which though has been hidden so far) commit 983efb916e282d2263b4abcc92f714c06b3bfcc1 Author: Thomas Lübking Date: Wed Feb 18 02:09:00 2015 +0100 break showingDesktop w/ tabbox/PW/DG This is now crucial, because while before (the minimized) windows were conditionally shown, but are now always behind the desktop. Also, it makes the tabbox more consistent. commit ff531c8e2adc407da00bef88f18d03e3829b25fa Author: Thomas Lübking Date: Wed Feb 18 01:37:45 2015 +0100 implement showingDesktop by raising the desktop window commit 190a0cc022d9935d658a6218d0b3caa79b038563 Author: Thomas Lübking Date: Wed Feb 18 00:09:46 2015 +0100 remove secret showDesktopIsMinimizeAll feature Diffs - client.h f064041 client.cpp 3e834f2 effects/desktopgrid/desktopgrid.cpp 97cb2a3 effects/presentwindows/presentwindows.cpp 07660c2 kwin.kcfg 80ca365 tabbox/tabbox.cpp f81a407 scripts/minimizeall/metadata.desktop PRE-CREATION scripts/minimizeall/contents/code/main.js PRE-CREATION scripts/CMakeLists.txt 34dedb7 options.cpp cdaa851 options.h 67e5868 layers.cpp 91edc04 manage.cpp f302892 workspace.h 4ecac3d workspace.cpp 7cbe81e Diff: https://git.reviewboard.kde.org/r/122679/diff/ Testing --- * The script (though mostly in KWin4, trouble w/ ksycoca5...) * Obviously the supersecret key is now dead ;-) * Been playing around with alternate desktop showing. Thanks, Thomas Lübking ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122679: Show Desktop feature: refurbished
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/#review76600 --- I like the idea, it would at least make the show desktop function actually usable. this would/could replace the dashboard as well? - Marco Martin On Feb. 22, 2015, 3:51 p.m., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/ --- (Updated Feb. 22, 2015, 3:51 p.m.) Review request for kwin, Plasma, Martin Gräßlin, and Marco Martin. Bugs: 344083 https://bugs.kde.org/show_bug.cgi?id=344083 Repository: kwin Description --- commit a1b80b4e310b2c75b4d9811af1d23f699bc658b5 Author: Thomas Lübking Date: Sun Feb 22 16:41:45 2015 +0100 add MinimizeAll script to compensate withdrawn core feature (which though has been hidden so far) commit 983efb916e282d2263b4abcc92f714c06b3bfcc1 Author: Thomas Lübking Date: Wed Feb 18 02:09:00 2015 +0100 break showingDesktop w/ tabbox/PW/DG This is now crucial, because while before (the minimized) windows were conditionally shown, but are now always behind the desktop. Also, it makes the tabbox more consistent. commit ff531c8e2adc407da00bef88f18d03e3829b25fa Author: Thomas Lübking Date: Wed Feb 18 01:37:45 2015 +0100 implement showingDesktop by raising the desktop window commit 190a0cc022d9935d658a6218d0b3caa79b038563 Author: Thomas Lübking Date: Wed Feb 18 00:09:46 2015 +0100 remove secret showDesktopIsMinimizeAll feature Diffs - client.h f064041 client.cpp 3e834f2 effects/desktopgrid/desktopgrid.cpp 97cb2a3 effects/presentwindows/presentwindows.cpp 07660c2 kwin.kcfg 80ca365 tabbox/tabbox.cpp f81a407 scripts/minimizeall/metadata.desktop PRE-CREATION scripts/minimizeall/contents/code/main.js PRE-CREATION scripts/CMakeLists.txt 34dedb7 options.cpp cdaa851 options.h 67e5868 layers.cpp 91edc04 manage.cpp f302892 workspace.h 4ecac3d workspace.cpp 7cbe81e Diff: https://git.reviewboard.kde.org/r/122679/diff/ Testing --- * The script (though mostly in KWin4, trouble w/ ksycoca5...) * Obviously the supersecret key is now dead ;-) * Been playing around with alternate desktop showing. Thanks, Thomas Lübking ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122679: Show Desktop feature: refurbished
On Feb. 25, 2015, 2:37 p.m., Marco Martin wrote: I like the idea, it would at least make the show desktop function actually usable. this would/could replace the dashboard as well? this would/could replace the dashboard as well? Yes this should replace dashboard. It is kind of the same functionality and dashboard is currently broken anyway (and the way we had in 4.x doesn't work anymore). - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/#review76600 --- On Feb. 22, 2015, 4:51 p.m., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/ --- (Updated Feb. 22, 2015, 4:51 p.m.) Review request for kwin, Plasma, Martin Gräßlin, and Marco Martin. Bugs: 344083 https://bugs.kde.org/show_bug.cgi?id=344083 Repository: kwin Description --- commit a1b80b4e310b2c75b4d9811af1d23f699bc658b5 Author: Thomas Lübking Date: Sun Feb 22 16:41:45 2015 +0100 add MinimizeAll script to compensate withdrawn core feature (which though has been hidden so far) commit 983efb916e282d2263b4abcc92f714c06b3bfcc1 Author: Thomas Lübking Date: Wed Feb 18 02:09:00 2015 +0100 break showingDesktop w/ tabbox/PW/DG This is now crucial, because while before (the minimized) windows were conditionally shown, but are now always behind the desktop. Also, it makes the tabbox more consistent. commit ff531c8e2adc407da00bef88f18d03e3829b25fa Author: Thomas Lübking Date: Wed Feb 18 01:37:45 2015 +0100 implement showingDesktop by raising the desktop window commit 190a0cc022d9935d658a6218d0b3caa79b038563 Author: Thomas Lübking Date: Wed Feb 18 00:09:46 2015 +0100 remove secret showDesktopIsMinimizeAll feature Diffs - client.h f064041 client.cpp 3e834f2 effects/desktopgrid/desktopgrid.cpp 97cb2a3 effects/presentwindows/presentwindows.cpp 07660c2 kwin.kcfg 80ca365 tabbox/tabbox.cpp f81a407 scripts/minimizeall/metadata.desktop PRE-CREATION scripts/minimizeall/contents/code/main.js PRE-CREATION scripts/CMakeLists.txt 34dedb7 options.cpp cdaa851 options.h 67e5868 layers.cpp 91edc04 manage.cpp f302892 workspace.h 4ecac3d workspace.cpp 7cbe81e Diff: https://git.reviewboard.kde.org/r/122679/diff/ Testing --- * The script (though mostly in KWin4, trouble w/ ksycoca5...) * Obviously the supersecret key is now dead ;-) * Been playing around with alternate desktop showing. Thanks, Thomas Lübking ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122679: Show Desktop feature: refurbished
On Feb. 25, 2015, 1:37 nachm., Marco Martin wrote: I like the idea, it would at least make the show desktop function actually usable. this would/could replace the dashboard as well? Martin Gräßlin wrote: this would/could replace the dashboard as well? Yes this should replace dashboard. It is kind of the same functionality and dashboard is currently broken anyway (and the way we had in 4.x doesn't work anymore). That's why you're attached ;-) Since the state is exported, one could eg. alter the desktop, like adding a synthetic exit dashboard button, a plasmoid config UI, an overlay label or reacting to esc by exiting the state - stuff like that. The main question would be what windows do we want to allow to overlay the desktop, eg. are panels required? KRunner? - Thomas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/#review76600 --- On Feb. 22, 2015, 3:51 nachm., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/ --- (Updated Feb. 22, 2015, 3:51 nachm.) Review request for kwin, Plasma, Martin Gräßlin, and Marco Martin. Bugs: 344083 https://bugs.kde.org/show_bug.cgi?id=344083 Repository: kwin Description --- commit a1b80b4e310b2c75b4d9811af1d23f699bc658b5 Author: Thomas Lübking Date: Sun Feb 22 16:41:45 2015 +0100 add MinimizeAll script to compensate withdrawn core feature (which though has been hidden so far) commit 983efb916e282d2263b4abcc92f714c06b3bfcc1 Author: Thomas Lübking Date: Wed Feb 18 02:09:00 2015 +0100 break showingDesktop w/ tabbox/PW/DG This is now crucial, because while before (the minimized) windows were conditionally shown, but are now always behind the desktop. Also, it makes the tabbox more consistent. commit ff531c8e2adc407da00bef88f18d03e3829b25fa Author: Thomas Lübking Date: Wed Feb 18 01:37:45 2015 +0100 implement showingDesktop by raising the desktop window commit 190a0cc022d9935d658a6218d0b3caa79b038563 Author: Thomas Lübking Date: Wed Feb 18 00:09:46 2015 +0100 remove secret showDesktopIsMinimizeAll feature Diffs - client.h f064041 client.cpp 3e834f2 effects/desktopgrid/desktopgrid.cpp 97cb2a3 effects/presentwindows/presentwindows.cpp 07660c2 kwin.kcfg 80ca365 tabbox/tabbox.cpp f81a407 scripts/minimizeall/metadata.desktop PRE-CREATION scripts/minimizeall/contents/code/main.js PRE-CREATION scripts/CMakeLists.txt 34dedb7 options.cpp cdaa851 options.h 67e5868 layers.cpp 91edc04 manage.cpp f302892 workspace.h 4ecac3d workspace.cpp 7cbe81e Diff: https://git.reviewboard.kde.org/r/122679/diff/ Testing --- * The script (though mostly in KWin4, trouble w/ ksycoca5...) * Obviously the supersecret key is now dead ;-) * Been playing around with alternate desktop showing. Thanks, Thomas Lübking ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122679: Show Desktop feature: refurbished
On Feb. 23, 2015, 9:25 a.m., Martin Gräßlin wrote: effects/presentwindows/presentwindows.cpp, line 1418 https://git.reviewboard.kde.org/r/122679/diff/1/?file=350838#file350838line1418 Maybe: whenever a fullscreen effect is used disable showingDesktoP? Thomas Lübking wrote: That would eg. also affect invoking the cube to alter the VD, would it not? (I do not mean the cubeslide effect) yes, would also affect cube. That was actually my thought for it. I would expect it to restore windows, otherwise the effect might be a little bit pointless IMHO. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/#review76450 --- On Feb. 22, 2015, 4:51 p.m., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/ --- (Updated Feb. 22, 2015, 4:51 p.m.) Review request for kwin, Plasma, Martin Gräßlin, and Marco Martin. Bugs: 344083 https://bugs.kde.org/show_bug.cgi?id=344083 Repository: kwin Description --- commit a1b80b4e310b2c75b4d9811af1d23f699bc658b5 Author: Thomas Lübking Date: Sun Feb 22 16:41:45 2015 +0100 add MinimizeAll script to compensate withdrawn core feature (which though has been hidden so far) commit 983efb916e282d2263b4abcc92f714c06b3bfcc1 Author: Thomas Lübking Date: Wed Feb 18 02:09:00 2015 +0100 break showingDesktop w/ tabbox/PW/DG This is now crucial, because while before (the minimized) windows were conditionally shown, but are now always behind the desktop. Also, it makes the tabbox more consistent. commit ff531c8e2adc407da00bef88f18d03e3829b25fa Author: Thomas Lübking Date: Wed Feb 18 01:37:45 2015 +0100 implement showingDesktop by raising the desktop window commit 190a0cc022d9935d658a6218d0b3caa79b038563 Author: Thomas Lübking Date: Wed Feb 18 00:09:46 2015 +0100 remove secret showDesktopIsMinimizeAll feature Diffs - client.h f064041 client.cpp 3e834f2 effects/desktopgrid/desktopgrid.cpp 97cb2a3 effects/presentwindows/presentwindows.cpp 07660c2 kwin.kcfg 80ca365 tabbox/tabbox.cpp f81a407 scripts/minimizeall/metadata.desktop PRE-CREATION scripts/minimizeall/contents/code/main.js PRE-CREATION scripts/CMakeLists.txt 34dedb7 options.cpp cdaa851 options.h 67e5868 layers.cpp 91edc04 manage.cpp f302892 workspace.h 4ecac3d workspace.cpp 7cbe81e Diff: https://git.reviewboard.kde.org/r/122679/diff/ Testing --- * The script (though mostly in KWin4, trouble w/ ksycoca5...) * Obviously the supersecret key is now dead ;-) * Been playing around with alternate desktop showing. Thanks, Thomas Lübking ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122679: Show Desktop feature: refurbished
On Feb. 25, 2015, 1:37 nachm., Marco Martin wrote: I like the idea, it would at least make the show desktop function actually usable. this would/could replace the dashboard as well? Martin Gräßlin wrote: this would/could replace the dashboard as well? Yes this should replace dashboard. It is kind of the same functionality and dashboard is currently broken anyway (and the way we had in 4.x doesn't work anymore). Thomas Lübking wrote: That's why you're attached ;-) Since the state is exported, one could eg. alter the desktop, like adding a synthetic exit dashboard button, a plasmoid config UI, an overlay label or reacting to esc by exiting the state - stuff like that. The main question would be what windows do we want to allow to overlay the desktop, eg. are panels required? KRunner? I think in 4.x panels were not shown on the dashboard and I also don't see why they should. Maybe add the usability group for further input, they had the idea of fading the panels in dashboard mode - maybe we should just hide them all. Not sure about KRunner, I'd like it to be reachable anywhere anytime. - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/#review76600 --- On Feb. 22, 2015, 3:51 nachm., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/ --- (Updated Feb. 22, 2015, 3:51 nachm.) Review request for kwin, Plasma, Martin Gräßlin, and Marco Martin. Bugs: 344083 https://bugs.kde.org/show_bug.cgi?id=344083 Repository: kwin Description --- commit a1b80b4e310b2c75b4d9811af1d23f699bc658b5 Author: Thomas Lübking Date: Sun Feb 22 16:41:45 2015 +0100 add MinimizeAll script to compensate withdrawn core feature (which though has been hidden so far) commit 983efb916e282d2263b4abcc92f714c06b3bfcc1 Author: Thomas Lübking Date: Wed Feb 18 02:09:00 2015 +0100 break showingDesktop w/ tabbox/PW/DG This is now crucial, because while before (the minimized) windows were conditionally shown, but are now always behind the desktop. Also, it makes the tabbox more consistent. commit ff531c8e2adc407da00bef88f18d03e3829b25fa Author: Thomas Lübking Date: Wed Feb 18 01:37:45 2015 +0100 implement showingDesktop by raising the desktop window commit 190a0cc022d9935d658a6218d0b3caa79b038563 Author: Thomas Lübking Date: Wed Feb 18 00:09:46 2015 +0100 remove secret showDesktopIsMinimizeAll feature Diffs - client.h f064041 client.cpp 3e834f2 effects/desktopgrid/desktopgrid.cpp 97cb2a3 effects/presentwindows/presentwindows.cpp 07660c2 kwin.kcfg 80ca365 tabbox/tabbox.cpp f81a407 scripts/minimizeall/metadata.desktop PRE-CREATION scripts/minimizeall/contents/code/main.js PRE-CREATION scripts/CMakeLists.txt 34dedb7 options.cpp cdaa851 options.h 67e5868 layers.cpp 91edc04 manage.cpp f302892 workspace.h 4ecac3d workspace.cpp 7cbe81e Diff: https://git.reviewboard.kde.org/r/122679/diff/ Testing --- * The script (though mostly in KWin4, trouble w/ ksycoca5...) * Obviously the supersecret key is now dead ;-) * Been playing around with alternate desktop showing. Thanks, Thomas Lübking ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122679: Show Desktop feature: refurbished
On Feb. 23, 2015, 8:25 vorm., Martin Gräßlin wrote: effects/presentwindows/presentwindows.cpp, line 1418 https://git.reviewboard.kde.org/r/122679/diff/1/?file=350838#file350838line1418 Maybe: whenever a fullscreen effect is used disable showingDesktoP? That would eg. also affect invoking the cube to alter the VD, would it not? (I do not mean the cubeslide effect) - Thomas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/#review76450 --- On Feb. 22, 2015, 3:51 nachm., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/ --- (Updated Feb. 22, 2015, 3:51 nachm.) Review request for kwin, Plasma, Martin Gräßlin, and Marco Martin. Bugs: 344083 https://bugs.kde.org/show_bug.cgi?id=344083 Repository: kwin Description --- commit a1b80b4e310b2c75b4d9811af1d23f699bc658b5 Author: Thomas Lübking Date: Sun Feb 22 16:41:45 2015 +0100 add MinimizeAll script to compensate withdrawn core feature (which though has been hidden so far) commit 983efb916e282d2263b4abcc92f714c06b3bfcc1 Author: Thomas Lübking Date: Wed Feb 18 02:09:00 2015 +0100 break showingDesktop w/ tabbox/PW/DG This is now crucial, because while before (the minimized) windows were conditionally shown, but are now always behind the desktop. Also, it makes the tabbox more consistent. commit ff531c8e2adc407da00bef88f18d03e3829b25fa Author: Thomas Lübking Date: Wed Feb 18 01:37:45 2015 +0100 implement showingDesktop by raising the desktop window commit 190a0cc022d9935d658a6218d0b3caa79b038563 Author: Thomas Lübking Date: Wed Feb 18 00:09:46 2015 +0100 remove secret showDesktopIsMinimizeAll feature Diffs - client.h f064041 client.cpp 3e834f2 effects/desktopgrid/desktopgrid.cpp 97cb2a3 effects/presentwindows/presentwindows.cpp 07660c2 kwin.kcfg 80ca365 tabbox/tabbox.cpp f81a407 scripts/minimizeall/metadata.desktop PRE-CREATION scripts/minimizeall/contents/code/main.js PRE-CREATION scripts/CMakeLists.txt 34dedb7 options.cpp cdaa851 options.h 67e5868 layers.cpp 91edc04 manage.cpp f302892 workspace.h 4ecac3d workspace.cpp 7cbe81e Diff: https://git.reviewboard.kde.org/r/122679/diff/ Testing --- * The script (though mostly in KWin4, trouble w/ ksycoca5...) * Obviously the supersecret key is now dead ;-) * Been playing around with alternate desktop showing. Thanks, Thomas Lübking ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122679: Show Desktop feature: refurbished
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/#review76450 --- I like the approach and the red/green ratio :-) effects/presentwindows/presentwindows.cpp https://git.reviewboard.kde.org/r/122679/#comment52661 Maybe: whenever a fullscreen effect is used disable showingDesktoP? - Martin Gräßlin On Feb. 22, 2015, 4:51 p.m., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/ --- (Updated Feb. 22, 2015, 4:51 p.m.) Review request for kwin, Plasma, Martin Gräßlin, and Marco Martin. Bugs: 344083 https://bugs.kde.org/show_bug.cgi?id=344083 Repository: kwin Description --- commit a1b80b4e310b2c75b4d9811af1d23f699bc658b5 Author: Thomas Lübking Date: Sun Feb 22 16:41:45 2015 +0100 add MinimizeAll script to compensate withdrawn core feature (which though has been hidden so far) commit 983efb916e282d2263b4abcc92f714c06b3bfcc1 Author: Thomas Lübking Date: Wed Feb 18 02:09:00 2015 +0100 break showingDesktop w/ tabbox/PW/DG This is now crucial, because while before (the minimized) windows were conditionally shown, but are now always behind the desktop. Also, it makes the tabbox more consistent. commit ff531c8e2adc407da00bef88f18d03e3829b25fa Author: Thomas Lübking Date: Wed Feb 18 01:37:45 2015 +0100 implement showingDesktop by raising the desktop window commit 190a0cc022d9935d658a6218d0b3caa79b038563 Author: Thomas Lübking Date: Wed Feb 18 00:09:46 2015 +0100 remove secret showDesktopIsMinimizeAll feature Diffs - client.h f064041 client.cpp 3e834f2 effects/desktopgrid/desktopgrid.cpp 97cb2a3 effects/presentwindows/presentwindows.cpp 07660c2 kwin.kcfg 80ca365 tabbox/tabbox.cpp f81a407 scripts/minimizeall/metadata.desktop PRE-CREATION scripts/minimizeall/contents/code/main.js PRE-CREATION scripts/CMakeLists.txt 34dedb7 options.cpp cdaa851 options.h 67e5868 layers.cpp 91edc04 manage.cpp f302892 workspace.h 4ecac3d workspace.cpp 7cbe81e Diff: https://git.reviewboard.kde.org/r/122679/diff/ Testing --- * The script (though mostly in KWin4, trouble w/ ksycoca5...) * Obviously the supersecret key is now dead ;-) * Been playing around with alternate desktop showing. Thanks, Thomas Lübking ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122679: Show Desktop feature: refurbished
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/#review76428 --- layers.cpp https://git.reviewboard.kde.org/r/122679/#comment52647 This is the volatile part - mostly a matter of what do we want this to be Possible layers (for showing desktop) - Dock Plasma panels can still cover the desktop, less dash-a-like. Drawback: all KeepAbove windows will be above - Above KeepAbove windows _can_ be brought above, but are not by default. All panels are below. We might alter the panel behavior (depending on transiency for the desktop and/or keep above state) to keep them in sight (if desired) - Fullscreen The Desktop will be the thing on top. Only its transients and override redirect windows (popups, tooltips, etc.) will be visible above. - Thomas Lübking On Feb. 22, 2015, 3:51 nachm., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/ --- (Updated Feb. 22, 2015, 3:51 nachm.) Review request for kwin, Plasma, Martin Gräßlin, and Marco Martin. Bugs: 344083 https://bugs.kde.org/show_bug.cgi?id=344083 Repository: kwin Description --- commit a1b80b4e310b2c75b4d9811af1d23f699bc658b5 Author: Thomas Lübking Date: Sun Feb 22 16:41:45 2015 +0100 add MinimizeAll script to compensate withdrawn core feature (which though has been hidden so far) commit 983efb916e282d2263b4abcc92f714c06b3bfcc1 Author: Thomas Lübking Date: Wed Feb 18 02:09:00 2015 +0100 break showingDesktop w/ tabbox/PW/DG This is now crucial, because while before (the minimized) windows were conditionally shown, but are now always behind the desktop. Also, it makes the tabbox more consistent. commit ff531c8e2adc407da00bef88f18d03e3829b25fa Author: Thomas Lübking Date: Wed Feb 18 01:37:45 2015 +0100 implement showingDesktop by raising the desktop window commit 190a0cc022d9935d658a6218d0b3caa79b038563 Author: Thomas Lübking Date: Wed Feb 18 00:09:46 2015 +0100 remove secret showDesktopIsMinimizeAll feature Diffs - client.h f064041 client.cpp 3e834f2 effects/desktopgrid/desktopgrid.cpp 97cb2a3 effects/presentwindows/presentwindows.cpp 07660c2 kwin.kcfg 80ca365 tabbox/tabbox.cpp f81a407 scripts/minimizeall/metadata.desktop PRE-CREATION scripts/minimizeall/contents/code/main.js PRE-CREATION scripts/CMakeLists.txt 34dedb7 options.cpp cdaa851 options.h 67e5868 layers.cpp 91edc04 manage.cpp f302892 workspace.h 4ecac3d workspace.cpp 7cbe81e Diff: https://git.reviewboard.kde.org/r/122679/diff/ Testing --- * The script (though mostly in KWin4, trouble w/ ksycoca5...) * Obviously the supersecret key is now dead ;-) * Been playing around with alternate desktop showing. Thanks, Thomas Lübking ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 122679: Show Desktop feature: refurbished
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/ --- Review request for kwin, Plasma, Martin Gräßlin, and Marco Martin. Bugs: 344083 https://bugs.kde.org/show_bug.cgi?id=344083 Repository: kwin Description --- commit a1b80b4e310b2c75b4d9811af1d23f699bc658b5 Author: Thomas Lübking Date: Sun Feb 22 16:41:45 2015 +0100 add MinimizeAll script to compensate withdrawn core feature (which though has been hidden so far) commit 983efb916e282d2263b4abcc92f714c06b3bfcc1 Author: Thomas Lübking Date: Wed Feb 18 02:09:00 2015 +0100 break showingDesktop w/ tabbox/PW/DG This is now crucial, because while before (the minimized) windows were conditionally shown, but are now always behind the desktop. Also, it makes the tabbox more consistent. commit ff531c8e2adc407da00bef88f18d03e3829b25fa Author: Thomas Lübking Date: Wed Feb 18 01:37:45 2015 +0100 implement showingDesktop by raising the desktop window commit 190a0cc022d9935d658a6218d0b3caa79b038563 Author: Thomas Lübking Date: Wed Feb 18 00:09:46 2015 +0100 remove secret showDesktopIsMinimizeAll feature Diffs - client.h f064041 client.cpp 3e834f2 effects/desktopgrid/desktopgrid.cpp 97cb2a3 effects/presentwindows/presentwindows.cpp 07660c2 kwin.kcfg 80ca365 tabbox/tabbox.cpp f81a407 scripts/minimizeall/metadata.desktop PRE-CREATION scripts/minimizeall/contents/code/main.js PRE-CREATION scripts/CMakeLists.txt 34dedb7 options.cpp cdaa851 options.h 67e5868 layers.cpp 91edc04 manage.cpp f302892 workspace.h 4ecac3d workspace.cpp 7cbe81e Diff: https://git.reviewboard.kde.org/r/122679/diff/ Testing --- * The script (though mostly in KWin4, trouble w/ ksycoca5...) * Obviously the supersecret key is now dead ;-) * Been playing around with alternate desktop showing. Thanks, Thomas Lübking ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
