Re: Review Request 122886: QML-only KCM base

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122886/
---

(Updated March 23, 2015, 12:04 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit 119510b653a3c02c758d055db2c10db73461b905 by Marco Martin 
to branch master.


Repository: kdeclarative


Description
---

This is a QObject-based fork of KCmodule, with the api slightly adaped to be 
more declarative friendly.
it loads a qml file that then will be able to access its instance as "kcm" or 
as the "KCM" attached property, like what happens in plasmoids (for how 
attached proeprties work, unfortunately only properties of the base class will 
be accessible).
They will be loaded in systemsettings by review 122887


Diffs
-

  src/quickaddons/CMakeLists.txt 3c7a34b 
  src/quickaddons/configmodule.h PRE-CREATION 
  src/quickaddons/configmodule.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/122886/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122886: QML-only KCM base

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122886/#review77964
---

Ship it!


Ship It!

- David Edmundson


On March 13, 2015, 12:04 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122886/
> ---
> 
> (Updated March 13, 2015, 12:04 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> This is a QObject-based fork of KCmodule, with the api slightly adaped to be 
> more declarative friendly.
> it loads a qml file that then will be able to access its instance as "kcm" or 
> as the "KCM" attached property, like what happens in plasmoids (for how 
> attached proeprties work, unfortunately only properties of the base class 
> will be accessible).
> They will be loaded in systemsettings by review 122887
> 
> 
> Diffs
> -
> 
>   src/quickaddons/CMakeLists.txt 3c7a34b 
>   src/quickaddons/configmodule.h PRE-CREATION 
>   src/quickaddons/configmodule.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122886/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122886: QML-only KCM base

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122886/
---

(Updated March 13, 2015, 12:04 p.m.)


Review request for KDE Frameworks and Plasma.


Changes
---

In this version, at least the namespace is KQuickAddons
also, the old include QuickAddons/* is still there just for compatibility, new 
stuff is intended to go in KQuickAddons/*

That's still ugly, but I think at least makes things a bit better for future 
additions (even regardless ConfigModule ends there, which i prefer, or in 
KDeclarative)


Repository: kdeclarative


Description
---

This is a QObject-based fork of KCmodule, with the api slightly adaped to be 
more declarative friendly.
it loads a qml file that then will be able to access its instance as "kcm" or 
as the "KCM" attached property, like what happens in plasmoids (for how 
attached proeprties work, unfortunately only properties of the base class will 
be accessible).
They will be loaded in systemsettings by review 122887


Diffs (updated)
-

  src/quickaddons/CMakeLists.txt 3c7a34b 
  src/quickaddons/configmodule.h PRE-CREATION 
  src/quickaddons/configmodule.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/122886/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122886: QML-only KCM base

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122886/
---

(Updated March 12, 2015, 7 p.m.)


Review request for KDE Frameworks and Plasma.


Repository: kdeclarative


Description
---

This is a QObject-based fork of KCmodule, with the api slightly adaped to be 
more declarative friendly.
it loads a qml file that then will be able to access its instance as "kcm" or 
as the "KCM" attached property, like what happens in plasmoids (for how 
attached proeprties work, unfortunately only properties of the base class will 
be accessible).
They will be loaded in systemsettings by review 122887


Diffs (updated)
-

  src/quickaddons/CMakeLists.txt 3c7a34b 
  src/quickaddons/configmodule.h PRE-CREATION 
  src/quickaddons/configmodule.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/122886/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122886: QML-only KCM base

[Marco Martin]

> On March 10, 2015, 11:30 a.m., Marco Martin wrote:
> > src/quickaddons/configmodule.h, line 43
> > 
> >
> > I don't particularly like the KDeclarative namespace here since the 
> > library is called QuickAddons, but unfortunately that name is terrible, 
> > since makes people think this arrives from Qt (should have been called 
> > KQuickAddons, all old classes in it namespaced etc, that library is a 
> > disaster :/))

I'm almost tempted to re-export everything under KQuickAddons both library and 
namespace, deprecating completely QuickAddons (ConfigModule class would be only 
in kquickaddons, not the old one)


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122886/#review77247
---


On March 12, 2015, 2:55 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122886/
> ---
> 
> (Updated March 12, 2015, 2:55 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> This is a QObject-based fork of KCmodule, with the api slightly adaped to be 
> more declarative friendly.
> it loads a qml file that then will be able to access its instance as "kcm" or 
> as the "KCM" attached property, like what happens in plasmoids (for how 
> attached proeprties work, unfortunately only properties of the base class 
> will be accessible).
> They will be loaded in systemsettings by review 122887
> 
> 
> Diffs
> -
> 
>   src/quickaddons/CMakeLists.txt 3c7a34b 
>   src/quickaddons/configmodule.h PRE-CREATION 
>   src/quickaddons/configmodule.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122886/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122886: QML-only KCM base

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122886/
---

(Updated March 12, 2015, 2:55 p.m.)


Review request for KDE Frameworks and Plasma.


Repository: kdeclarative


Description
---

This is a QObject-based fork of KCmodule, with the api slightly adaped to be 
more declarative friendly.
it loads a qml file that then will be able to access its instance as "kcm" or 
as the "KCM" attached property, like what happens in plasmoids (for how 
attached proeprties work, unfortunately only properties of the base class will 
be accessible).
They will be loaded in systemsettings by review 122887


Diffs (updated)
-

  src/quickaddons/CMakeLists.txt 3c7a34b 
  src/quickaddons/configmodule.h PRE-CREATION 
  src/quickaddons/configmodule.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/122886/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122886: QML-only KCM base

[Marco Martin]

> On March 11, 2015, 2:07 p.m., David Edmundson wrote:
> > src/quickaddons/configmodule.h, line 373
> > 
> >
> > I guess you copy and pasted all these.
> > KConfigXT isn't relevant at all here.

yes, is pretty much KCModule docs :)
I think they are fine-ish, I think needs mostly the addition of how to combine 
that with QML in the general class description seciton.


> On March 11, 2015, 2:07 p.m., David Edmundson wrote:
> > src/quickaddons/configmodule.h, line 338
> > 
> >
> > This documentation tells me nothing, and I'm not sure what this does 
> > from the method name.

eh, I have no idea about this method as well :/
it's a thing exported by KCModule, so here just wrapping it.
it's presumably used for some reason, somewhere, but even from the code it's 
not understandable.
on lxr, seems the only place where is used is KInfoCenter
http://lxr.kde.org/source/kde/workspace/kinfocenter/infocenter.cpp?v=kf5-qt5

(may be worth even just dumping it...)


> On March 11, 2015, 2:07 p.m., David Edmundson wrote:
> > src/quickaddons/configmodule.cpp, line 102
> > 
> >
> > when combined with your other KCModule patch you have a crash.
> > 
> > From KCModule docs:
> > This sets the KAboutData returned by aboutData() The about data is now 
> > owned by KCModule.
> > 
> > So this will result in a double delete.
> > Same for the delete in setAboutData.

hmm, would work actually creating a copy of this about data in the wrapper 
class?


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122886/#review77304
---


On March 10, 2015, 11:28 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122886/
> ---
> 
> (Updated March 10, 2015, 11:28 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> This is a QObject-based fork of KCmodule, with the api slightly adaped to be 
> more declarative friendly.
> it loads a qml file that then will be able to access its instance as "kcm" or 
> as the "KCM" attached property, like what happens in plasmoids (for how 
> attached proeprties work, unfortunately only properties of the base class 
> will be accessible).
> They will be loaded in systemsettings by review 122887
> 
> 
> Diffs
> -
> 
>   src/quickaddons/CMakeLists.txt 3c7a34b 
>   src/quickaddons/configmodule.h PRE-CREATION 
>   src/quickaddons/configmodule.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122886/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122886: QML-only KCM base

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122886/#review77304
---



src/quickaddons/configmodule.h


this should mention packages somewhere.



src/quickaddons/configmodule.h


This documentation tells me nothing, and I'm not sure what this does from 
the method name.



src/quickaddons/configmodule.h


I guess you copy and pasted all these.
KConfigXT isn't relevant at all here.



src/quickaddons/configmodule.cpp


when combined with your other KCModule patch you have a crash.

From KCModule docs:
This sets the KAboutData returned by aboutData() The about data is now 
owned by KCModule.

So this will result in a double delete.
Same for the delete in setAboutData.


- David Edmundson


On March 10, 2015, 11:28 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122886/
> ---
> 
> (Updated March 10, 2015, 11:28 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> This is a QObject-based fork of KCmodule, with the api slightly adaped to be 
> more declarative friendly.
> it loads a qml file that then will be able to access its instance as "kcm" or 
> as the "KCM" attached property, like what happens in plasmoids (for how 
> attached proeprties work, unfortunately only properties of the base class 
> will be accessible).
> They will be loaded in systemsettings by review 122887
> 
> 
> Diffs
> -
> 
>   src/quickaddons/CMakeLists.txt 3c7a34b 
>   src/quickaddons/configmodule.h PRE-CREATION 
>   src/quickaddons/configmodule.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122886/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122886: QML-only KCM base

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122886/
---

(Updated March 11, 2015, 5:05 p.m.)


Review request for KDE Frameworks and Plasma.


Repository: kdeclarative


Description
---

This is a QObject-based fork of KCmodule, with the api slightly adaped to be 
more declarative friendly.
it loads a qml file that then will be able to access its instance as "kcm" or 
as the "KCM" attached property, like what happens in plasmoids (for how 
attached proeprties work, unfortunately only properties of the base class will 
be accessible).
They will be loaded in systemsettings by review 122887


Diffs (updated)
-

  src/quickaddons/CMakeLists.txt 3c7a34b 
  src/quickaddons/configmodule.h PRE-CREATION 
  src/quickaddons/configmodule.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/122886/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122886: QML-only KCM base

[Hrvoje Senjan]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122886/#review77309
---



src/quickaddons/CMakeLists.txt


you need also KF5::Auth as public, the new public header has a kauthaction 
include


- Hrvoje Senjan


On March 10, 2015, 12:28 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122886/
> ---
> 
> (Updated March 10, 2015, 12:28 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> This is a QObject-based fork of KCmodule, with the api slightly adaped to be 
> more declarative friendly.
> it loads a qml file that then will be able to access its instance as "kcm" or 
> as the "KCM" attached property, like what happens in plasmoids (for how 
> attached proeprties work, unfortunately only properties of the base class 
> will be accessible).
> They will be loaded in systemsettings by review 122887
> 
> 
> Diffs
> -
> 
>   src/quickaddons/CMakeLists.txt 3c7a34b 
>   src/quickaddons/configmodule.h PRE-CREATION 
>   src/quickaddons/configmodule.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122886/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122886: QML-only KCM base

[David Edmundson]

> On March 11, 2015, 2:07 p.m., David Edmundson wrote:
> > src/quickaddons/configmodule.cpp, line 102
> > 
> >
> > when combined with your other KCModule patch you have a crash.
> > 
> > From KCModule docs:
> > This sets the KAboutData returned by aboutData() The about data is now 
> > owned by KCModule.
> > 
> > So this will result in a double delete.
> > Same for the delete in setAboutData.
> 
> Marco Martin wrote:
> hmm, would work actually creating a copy of this about data in the 
> wrapper class?
> 
> David Edmundson wrote:
> Yeah, I think that would work.
> 
> Marco Martin wrote:
> thinking about it i'm not sure about the double delete (i don't get a 
> crash after all) since KCModuleQml never gets an aboutdata by its own but 
> just returns this class instance in the reimplementation of virtual 
> aboutData() (so the KCModule instance never gets a valid d->_aboutData), 
> opposed to do a setAboutData(d->configModule->aboutData()) in which would 
> definitely crash

oh, you're right. I got confused as we were signally and proxying everything 
else.
You can close this.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122886/#review77304
---


On March 10, 2015, 11:28 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122886/
> ---
> 
> (Updated March 10, 2015, 11:28 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> This is a QObject-based fork of KCmodule, with the api slightly adaped to be 
> more declarative friendly.
> it loads a qml file that then will be able to access its instance as "kcm" or 
> as the "KCM" attached property, like what happens in plasmoids (for how 
> attached proeprties work, unfortunately only properties of the base class 
> will be accessible).
> They will be loaded in systemsettings by review 122887
> 
> 
> Diffs
> -
> 
>   src/quickaddons/CMakeLists.txt 3c7a34b 
>   src/quickaddons/configmodule.h PRE-CREATION 
>   src/quickaddons/configmodule.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122886/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122886: QML-only KCM base

[Marco Martin]

> On March 11, 2015, 2:07 p.m., David Edmundson wrote:
> > src/quickaddons/configmodule.cpp, line 102
> > 
> >
> > when combined with your other KCModule patch you have a crash.
> > 
> > From KCModule docs:
> > This sets the KAboutData returned by aboutData() The about data is now 
> > owned by KCModule.
> > 
> > So this will result in a double delete.
> > Same for the delete in setAboutData.
> 
> Marco Martin wrote:
> hmm, would work actually creating a copy of this about data in the 
> wrapper class?
> 
> David Edmundson wrote:
> Yeah, I think that would work.

thinking about it i'm not sure about the double delete (i don't get a crash 
after all) since KCModuleQml never gets an aboutdata by its own but just 
returns this class instance in the reimplementation of virtual aboutData() (so 
the KCModule instance never gets a valid d->_aboutData), opposed to do a 
setAboutData(d->configModule->aboutData()) in which would definitely crash


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122886/#review77304
---


On March 10, 2015, 11:28 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122886/
> ---
> 
> (Updated March 10, 2015, 11:28 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> This is a QObject-based fork of KCmodule, with the api slightly adaped to be 
> more declarative friendly.
> it loads a qml file that then will be able to access its instance as "kcm" or 
> as the "KCM" attached property, like what happens in plasmoids (for how 
> attached proeprties work, unfortunately only properties of the base class 
> will be accessible).
> They will be loaded in systemsettings by review 122887
> 
> 
> Diffs
> -
> 
>   src/quickaddons/CMakeLists.txt 3c7a34b 
>   src/quickaddons/configmodule.h PRE-CREATION 
>   src/quickaddons/configmodule.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122886/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122886: QML-only KCM base

[David Edmundson]

> On March 11, 2015, 2:07 p.m., David Edmundson wrote:
> > src/quickaddons/configmodule.cpp, line 102
> > 
> >
> > when combined with your other KCModule patch you have a crash.
> > 
> > From KCModule docs:
> > This sets the KAboutData returned by aboutData() The about data is now 
> > owned by KCModule.
> > 
> > So this will result in a double delete.
> > Same for the delete in setAboutData.
> 
> Marco Martin wrote:
> hmm, would work actually creating a copy of this about data in the 
> wrapper class?

Yeah, I think that would work.


> On March 11, 2015, 2:07 p.m., David Edmundson wrote:
> > src/quickaddons/configmodule.h, line 338
> > 
> >
> > This documentation tells me nothing, and I'm not sure what this does 
> > from the method name.
> 
> Marco Martin wrote:
> eh, I have no idea about this method as well :/
> it's a thing exported by KCModule, so here just wrapping it.
> it's presumably used for some reason, somewhere, but even from the code 
> it's not understandable.
> on lxr, seems the only place where is used is KInfoCenter
> 
> http://lxr.kde.org/source/kde/workspace/kinfocenter/infocenter.cpp?v=kf5-qt5
> 
> (may be worth even just dumping it...)

++ for killing it here. 
Then it becomes not our problem :D


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122886/#review77304
---


On March 10, 2015, 11:28 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122886/
> ---
> 
> (Updated March 10, 2015, 11:28 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> This is a QObject-based fork of KCmodule, with the api slightly adaped to be 
> more declarative friendly.
> it loads a qml file that then will be able to access its instance as "kcm" or 
> as the "KCM" attached property, like what happens in plasmoids (for how 
> attached proeprties work, unfortunately only properties of the base class 
> will be accessible).
> They will be loaded in systemsettings by review 122887
> 
> 
> Diffs
> -
> 
>   src/quickaddons/CMakeLists.txt 3c7a34b 
>   src/quickaddons/configmodule.h PRE-CREATION 
>   src/quickaddons/configmodule.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122886/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122886: QML-only KCM base

[David Edmundson]

> On March 10, 2015, 11:33 a.m., Marco Martin wrote:
> > src/quickaddons/configmodule.cpp, line 167
> > 
> >
> > I didn't test things that need authentication yet (if some good soul 
> > ports a module that uses it would be great)
> > but seems there may be a problem here due to KAuth assuming QWidgets

This is for a custom KDE extension to polkit setWIdForAction that tells the KDE 
polkit agent which window is about to trigger an action so that the window 
manager can do something sensible wrt to focus. So it's not super criticial.

It's also fixable, KAuth only uses it for a window ID, so we can add a QWindow/

Right now it's not a problem, as when used via KCModuleQml, it will call 
KCModule::setAuthAction which changes the parent widget anyway.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122886/#review77248
---


On March 10, 2015, 11:28 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122886/
> ---
> 
> (Updated March 10, 2015, 11:28 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> This is a QObject-based fork of KCmodule, with the api slightly adaped to be 
> more declarative friendly.
> it loads a qml file that then will be able to access its instance as "kcm" or 
> as the "KCM" attached property, like what happens in plasmoids (for how 
> attached proeprties work, unfortunately only properties of the base class 
> will be accessible).
> They will be loaded in systemsettings by review 122887
> 
> 
> Diffs
> -
> 
>   src/quickaddons/CMakeLists.txt 3c7a34b 
>   src/quickaddons/configmodule.h PRE-CREATION 
>   src/quickaddons/configmodule.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122886/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122886: QML-only KCM base

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122886/#review77248
---



src/quickaddons/configmodule.cpp


I didn't test things that need authentication yet (if some good soul ports 
a module that uses it would be great)
but seems there may be a problem here due to KAuth assuming QWidgets


- Marco Martin


On March 10, 2015, 11:28 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122886/
> ---
> 
> (Updated March 10, 2015, 11:28 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> This is a QObject-based fork of KCmodule, with the api slightly adaped to be 
> more declarative friendly.
> it loads a qml file that then will be able to access its instance as "kcm" or 
> as the "KCM" attached property, like what happens in plasmoids (for how 
> attached proeprties work, unfortunately only properties of the base class 
> will be accessible).
> They will be loaded in systemsettings by review 122887
> 
> 
> Diffs
> -
> 
>   src/quickaddons/CMakeLists.txt 3c7a34b 
>   src/quickaddons/configmodule.h PRE-CREATION 
>   src/quickaddons/configmodule.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122886/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122886: QML-only KCM base

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122886/#review77247
---



src/quickaddons/configmodule.h


I don't particularly like the KDeclarative namespace here since the library 
is called QuickAddons, but unfortunately that name is terrible, since makes 
people think this arrives from Qt (should have been called KQuickAddons, all 
old classes in it namespaced etc, that library is a disaster :/))


- Marco Martin


On March 10, 2015, 11:28 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122886/
> ---
> 
> (Updated March 10, 2015, 11:28 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> This is a QObject-based fork of KCmodule, with the api slightly adaped to be 
> more declarative friendly.
> it loads a qml file that then will be able to access its instance as "kcm" or 
> as the "KCM" attached property, like what happens in plasmoids (for how 
> attached proeprties work, unfortunately only properties of the base class 
> will be accessible).
> They will be loaded in systemsettings by review 122887
> 
> 
> Diffs
> -
> 
>   src/quickaddons/CMakeLists.txt 3c7a34b 
>   src/quickaddons/configmodule.h PRE-CREATION 
>   src/quickaddons/configmodule.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122886/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 122886: QML-only KCM base

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122886/
---

Review request for KDE Frameworks and Plasma.


Repository: kdeclarative


Description
---

This is a QObject-based fork of KCmodule, with the api slightly adaped to be 
more declarative friendly.
it loads a qml file that then will be able to access its instance as "kcm" or 
as the "KCM" attached property, like what happens in plasmoids (for how 
attached proeprties work, unfortunately only properties of the base class will 
be accessible).
They will be loaded in systemsettings by review 122887


Diffs
-

  src/quickaddons/CMakeLists.txt 3c7a34b 
  src/quickaddons/configmodule.h PRE-CREATION 
  src/quickaddons/configmodule.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/122886/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel