Re: Review Request 124409: Begin fading the OSD immediately
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/ --- (Updated July 21, 2015, 3:05 p.m.) Status -- This change has been marked as submitted. Review request for Plasma and KDE Usability. Changes --- Submitted with commit ca33e8ee69eab68b024014509675d33f490b91a8 by Kai Uwe Broulik to branch master. Repository: plasma-workspace Description --- This makes the OSD begin fading out over a long period of time immediately after it has shown. Makes the OSD less annoying while currently reading something or watching a video. See https://www.youtube.com/watch?v=HxmpwG-2saE Diffs - lookandfeel/contents/osd/Osd.qml 2288ec1 shell/osd.cpp 0573d51 Diff: https://git.reviewboard.kde.org/r/124409/diff/ Testing --- Works. Quite enjoyable. As suggested by mklapetek Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124409: Begin fading the OSD immediately
On July 21, 2015, 1:36 a.m., Aleix Pol Gonzalez wrote: lookandfeel/contents/osd/Osd.qml, line 48 https://git.reviewboard.kde.org/r/124409/diff/1/?file=386441#file386441line48 This looks like a random wait time... Looking at the video, it seems like a slow animation. Is it intended? Yes. The idea is show and immediately start fading out which is perceived as it's hiding already (as opposed to showing for 2 seconds and doing nothing) but it's hiding slow enough to register the values/read the text. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82738 --- On July 20, 2015, 10:19 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/ --- (Updated July 20, 2015, 10:19 p.m.) Review request for Plasma and KDE Usability. Repository: plasma-workspace Description --- This makes the OSD begin fading out over a long period of time immediately after it has shown. Makes the OSD less annoying while currently reading something or watching a video. See https://www.youtube.com/watch?v=HxmpwG-2saE Diffs - lookandfeel/contents/osd/Osd.qml 2288ec1 shell/osd.cpp 0573d51 Diff: https://git.reviewboard.kde.org/r/124409/diff/ Testing --- Works. Quite enjoyable. As suggested by mklapetek Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124409: Begin fading the OSD immediately
On Juli 21, 2015, 7:03 vorm., Heiko Tietze wrote: Nice presentation, as always. But I'm not so sure that the realization of fading out quickly meets the needs from 'OSD is disturbing'. The second when the OSD is shown is still annoying (interaction during the fading might restart) and those who want to 'read' it need to reactivate the OSD. The issue could be solved by some kind of 'dismiss' or 'don't show again' interaction. Another simple way is to hide immediately on any key down, on mouse click etc. If that all is not possible at the OSD itself, perhaps because of security issues, a dialog (KCM) could help. And last but least please consider to bind this feature to activities. Martin Gräßlin wrote: Another simple way is to hide immediately on any key down, on mouse click etc. If that all is not possible at the OSD itself, perhaps because of security issues For technical reasons the OSD is not able to recognize any (global) key or mouse click events on Wayland and on X11 only with a huge amount of nasty code. Also I don't think that this is a solution to the annoying - if I watch a video and change the volume through kdeconnect I don't have a keyboard. Anyway I would dismiss the annoying argument all together. If I compare to the amount of OSDs my TV, audio receiver is putting on the screen this is a really good OSD. Martin Klapetek wrote: The second when the OSD is shown is still annoying and those who want to 'read' it need to reactivate the OSD I'm confused by that - does that say that the second it is on display is too much (annoying) but not enough to read it? Can you perhaps file a bug and specify exactly what is annoying and we can discuss over there? I tried to point out that we have two goals here: read information and don't disturb. In case of volume the feedback as position on the slider (or kind of progress bar) is perceived in milliseconds but when you got an email you might want to read sender and subject. And if the user is elder it might take more time to grasp what happens. - Heiko --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82745 --- On Juli 20, 2015, 8:19 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/ --- (Updated Juli 20, 2015, 8:19 nachm.) Review request for Plasma and KDE Usability. Repository: plasma-workspace Description --- This makes the OSD begin fading out over a long period of time immediately after it has shown. Makes the OSD less annoying while currently reading something or watching a video. See https://www.youtube.com/watch?v=HxmpwG-2saE Diffs - lookandfeel/contents/osd/Osd.qml 2288ec1 shell/osd.cpp 0573d51 Diff: https://git.reviewboard.kde.org/r/124409/diff/ Testing --- Works. Quite enjoyable. As suggested by mklapetek Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124409: Begin fading the OSD immediately
On July 21, 2015, 8:28 a.m., Martin Gräßlin wrote: This needs quite a bit of testing in real world: how does it behave with changing content underneath (e.g. a video, scrolling web browser), heavy load on the system, heavy load on the compositor, etc. Looks like the upcoming beta is a good candidate for that? ;) - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82743 --- On July 20, 2015, 10:19 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/ --- (Updated July 20, 2015, 10:19 p.m.) Review request for Plasma and KDE Usability. Repository: plasma-workspace Description --- This makes the OSD begin fading out over a long period of time immediately after it has shown. Makes the OSD less annoying while currently reading something or watching a video. See https://www.youtube.com/watch?v=HxmpwG-2saE Diffs - lookandfeel/contents/osd/Osd.qml 2288ec1 shell/osd.cpp 0573d51 Diff: https://git.reviewboard.kde.org/r/124409/diff/ Testing --- Works. Quite enjoyable. As suggested by mklapetek Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124409: Begin fading the OSD immediately
On July 21, 2015, 9:03 a.m., Heiko Tietze wrote: Nice presentation, as always. But I'm not so sure that the realization of fading out quickly meets the needs from 'OSD is disturbing'. The second when the OSD is shown is still annoying (interaction during the fading might restart) and those who want to 'read' it need to reactivate the OSD. The issue could be solved by some kind of 'dismiss' or 'don't show again' interaction. Another simple way is to hide immediately on any key down, on mouse click etc. If that all is not possible at the OSD itself, perhaps because of security issues, a dialog (KCM) could help. And last but least please consider to bind this feature to activities. Martin Gräßlin wrote: Another simple way is to hide immediately on any key down, on mouse click etc. If that all is not possible at the OSD itself, perhaps because of security issues For technical reasons the OSD is not able to recognize any (global) key or mouse click events on Wayland and on X11 only with a huge amount of nasty code. Also I don't think that this is a solution to the annoying - if I watch a video and change the volume through kdeconnect I don't have a keyboard. Anyway I would dismiss the annoying argument all together. If I compare to the amount of OSDs my TV, audio receiver is putting on the screen this is a really good OSD. Martin Klapetek wrote: The second when the OSD is shown is still annoying and those who want to 'read' it need to reactivate the OSD I'm confused by that - does that say that the second it is on display is too much (annoying) but not enough to read it? Can you perhaps file a bug and specify exactly what is annoying and we can discuss over there? Heiko Tietze wrote: I tried to point out that we have two goals here: read information and don't disturb. In case of volume the feedback as position on the slider (or kind of progress bar) is perceived in milliseconds but when you got an email you might want to read sender and subject. And if the user is elder it might take more time to grasp what happens. Ah, you're getting confused OSD with notifications. This does not apply to notifications at all, this is only the volume/brigthness/etc changes. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82745 --- On July 20, 2015, 10:19 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/ --- (Updated July 20, 2015, 10:19 p.m.) Review request for Plasma and KDE Usability. Repository: plasma-workspace Description --- This makes the OSD begin fading out over a long period of time immediately after it has shown. Makes the OSD less annoying while currently reading something or watching a video. See https://www.youtube.com/watch?v=HxmpwG-2saE Diffs - lookandfeel/contents/osd/Osd.qml 2288ec1 shell/osd.cpp 0573d51 Diff: https://git.reviewboard.kde.org/r/124409/diff/ Testing --- Works. Quite enjoyable. As suggested by mklapetek Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124409: Begin fading the OSD immediately
On July 21, 2015, 9:03 a.m., Heiko Tietze wrote: Nice presentation, as always. But I'm not so sure that the realization of fading out quickly meets the needs from 'OSD is disturbing'. The second when the OSD is shown is still annoying (interaction during the fading might restart) and those who want to 'read' it need to reactivate the OSD. The issue could be solved by some kind of 'dismiss' or 'don't show again' interaction. Another simple way is to hide immediately on any key down, on mouse click etc. If that all is not possible at the OSD itself, perhaps because of security issues, a dialog (KCM) could help. And last but least please consider to bind this feature to activities. Another simple way is to hide immediately on any key down, on mouse click etc. If that all is not possible at the OSD itself, perhaps because of security issues For technical reasons the OSD is not able to recognize any (global) key or mouse click events on Wayland and on X11 only with a huge amount of nasty code. Also I don't think that this is a solution to the annoying - if I watch a video and change the volume through kdeconnect I don't have a keyboard. Anyway I would dismiss the annoying argument all together. If I compare to the amount of OSDs my TV, audio receiver is putting on the screen this is a really good OSD. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82745 --- On July 20, 2015, 10:19 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/ --- (Updated July 20, 2015, 10:19 p.m.) Review request for Plasma and KDE Usability. Repository: plasma-workspace Description --- This makes the OSD begin fading out over a long period of time immediately after it has shown. Makes the OSD less annoying while currently reading something or watching a video. See https://www.youtube.com/watch?v=HxmpwG-2saE Diffs - lookandfeel/contents/osd/Osd.qml 2288ec1 shell/osd.cpp 0573d51 Diff: https://git.reviewboard.kde.org/r/124409/diff/ Testing --- Works. Quite enjoyable. As suggested by mklapetek Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124409: Begin fading the OSD immediately
On July 21, 2015, 9:03 a.m., Heiko Tietze wrote: Nice presentation, as always. But I'm not so sure that the realization of fading out quickly meets the needs from 'OSD is disturbing'. The second when the OSD is shown is still annoying (interaction during the fading might restart) and those who want to 'read' it need to reactivate the OSD. The issue could be solved by some kind of 'dismiss' or 'don't show again' interaction. Another simple way is to hide immediately on any key down, on mouse click etc. If that all is not possible at the OSD itself, perhaps because of security issues, a dialog (KCM) could help. And last but least please consider to bind this feature to activities. Martin Gräßlin wrote: Another simple way is to hide immediately on any key down, on mouse click etc. If that all is not possible at the OSD itself, perhaps because of security issues For technical reasons the OSD is not able to recognize any (global) key or mouse click events on Wayland and on X11 only with a huge amount of nasty code. Also I don't think that this is a solution to the annoying - if I watch a video and change the volume through kdeconnect I don't have a keyboard. Anyway I would dismiss the annoying argument all together. If I compare to the amount of OSDs my TV, audio receiver is putting on the screen this is a really good OSD. The second when the OSD is shown is still annoying and those who want to 'read' it need to reactivate the OSD I'm confused by that - does that say that the second it is on display is too much (annoying) but not enough to read it? Can you perhaps file a bug and specify exactly what is annoying and we can discuss over there? - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82745 --- On July 20, 2015, 10:19 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/ --- (Updated July 20, 2015, 10:19 p.m.) Review request for Plasma and KDE Usability. Repository: plasma-workspace Description --- This makes the OSD begin fading out over a long period of time immediately after it has shown. Makes the OSD less annoying while currently reading something or watching a video. See https://www.youtube.com/watch?v=HxmpwG-2saE Diffs - lookandfeel/contents/osd/Osd.qml 2288ec1 shell/osd.cpp 0573d51 Diff: https://git.reviewboard.kde.org/r/124409/diff/ Testing --- Works. Quite enjoyable. As suggested by mklapetek Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124409: Begin fading the OSD immediately
On Juli 21, 2015, 8:46 vorm., Mark Gaiser wrote: lookandfeel/contents/osd/Osd.qml, line 44 https://git.reviewboard.kde.org/r/124409/diff/1/?file=386441#file386441line44 http://doc.qt.io/qt-5/qml-qtquick-opacityanimator.html perhaps? Animators only work within the SceneGraph. For a Window there's no way that could work. - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82755 --- On Juli 20, 2015, 8:19 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/ --- (Updated Juli 20, 2015, 8:19 nachm.) Review request for Plasma and KDE Usability. Repository: plasma-workspace Description --- This makes the OSD begin fading out over a long period of time immediately after it has shown. Makes the OSD less annoying while currently reading something or watching a video. See https://www.youtube.com/watch?v=HxmpwG-2saE Diffs - lookandfeel/contents/osd/Osd.qml 2288ec1 shell/osd.cpp 0573d51 Diff: https://git.reviewboard.kde.org/r/124409/diff/ Testing --- Works. Quite enjoyable. As suggested by mklapetek Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124409: Begin fading the OSD immediately
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82755 --- lookandfeel/contents/osd/Osd.qml (line 44) https://git.reviewboard.kde.org/r/124409/#comment57067 http://doc.qt.io/qt-5/qml-qtquick-opacityanimator.html perhaps? - Mark Gaiser On jul 20, 2015, 8:19 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/ --- (Updated jul 20, 2015, 8:19 p.m.) Review request for Plasma and KDE Usability. Repository: plasma-workspace Description --- This makes the OSD begin fading out over a long period of time immediately after it has shown. Makes the OSD less annoying while currently reading something or watching a video. See https://www.youtube.com/watch?v=HxmpwG-2saE Diffs - lookandfeel/contents/osd/Osd.qml 2288ec1 shell/osd.cpp 0573d51 Diff: https://git.reviewboard.kde.org/r/124409/diff/ Testing --- Works. Quite enjoyable. As suggested by mklapetek Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124409: Begin fading the OSD immediately
On Juli 21, 2015, 7:03 vorm., Heiko Tietze wrote: Nice presentation, as always. But I'm not so sure that the realization of fading out quickly meets the needs from 'OSD is disturbing'. The second when the OSD is shown is still annoying (interaction during the fading might restart) and those who want to 'read' it need to reactivate the OSD. The issue could be solved by some kind of 'dismiss' or 'don't show again' interaction. Another simple way is to hide immediately on any key down, on mouse click etc. If that all is not possible at the OSD itself, perhaps because of security issues, a dialog (KCM) could help. And last but least please consider to bind this feature to activities. Martin Gräßlin wrote: Another simple way is to hide immediately on any key down, on mouse click etc. If that all is not possible at the OSD itself, perhaps because of security issues For technical reasons the OSD is not able to recognize any (global) key or mouse click events on Wayland and on X11 only with a huge amount of nasty code. Also I don't think that this is a solution to the annoying - if I watch a video and change the volume through kdeconnect I don't have a keyboard. Anyway I would dismiss the annoying argument all together. If I compare to the amount of OSDs my TV, audio receiver is putting on the screen this is a really good OSD. Martin Klapetek wrote: The second when the OSD is shown is still annoying and those who want to 'read' it need to reactivate the OSD I'm confused by that - does that say that the second it is on display is too much (annoying) but not enough to read it? Can you perhaps file a bug and specify exactly what is annoying and we can discuss over there? Heiko Tietze wrote: I tried to point out that we have two goals here: read information and don't disturb. In case of volume the feedback as position on the slider (or kind of progress bar) is perceived in milliseconds but when you got an email you might want to read sender and subject. And if the user is elder it might take more time to grasp what happens. Martin Klapetek wrote: Ah, you're getting confused OSD with notifications. This does not apply to notifications at all, this is only the volume/brigthness/etc changes. If you limit the scope to very simple notification the solution might be okay (personally I fully agree with the faster the better). But didn't Martin Graesslin blog about what kind of OSD should be shown on the lock screen including the idea of email like on Android? What's about the information of time left watching a video, perhaps after you forward a few seconds via KDEConnect? - Heiko --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82745 --- On Juli 20, 2015, 8:19 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/ --- (Updated Juli 20, 2015, 8:19 nachm.) Review request for Plasma and KDE Usability. Repository: plasma-workspace Description --- This makes the OSD begin fading out over a long period of time immediately after it has shown. Makes the OSD less annoying while currently reading something or watching a video. See https://www.youtube.com/watch?v=HxmpwG-2saE Diffs - lookandfeel/contents/osd/Osd.qml 2288ec1 shell/osd.cpp 0573d51 Diff: https://git.reviewboard.kde.org/r/124409/diff/ Testing --- Works. Quite enjoyable. As suggested by mklapetek Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124409: Begin fading the OSD immediately
On July 21, 2015, 9:03 a.m., Heiko Tietze wrote: Nice presentation, as always. But I'm not so sure that the realization of fading out quickly meets the needs from 'OSD is disturbing'. The second when the OSD is shown is still annoying (interaction during the fading might restart) and those who want to 'read' it need to reactivate the OSD. The issue could be solved by some kind of 'dismiss' or 'don't show again' interaction. Another simple way is to hide immediately on any key down, on mouse click etc. If that all is not possible at the OSD itself, perhaps because of security issues, a dialog (KCM) could help. And last but least please consider to bind this feature to activities. Martin Gräßlin wrote: Another simple way is to hide immediately on any key down, on mouse click etc. If that all is not possible at the OSD itself, perhaps because of security issues For technical reasons the OSD is not able to recognize any (global) key or mouse click events on Wayland and on X11 only with a huge amount of nasty code. Also I don't think that this is a solution to the annoying - if I watch a video and change the volume through kdeconnect I don't have a keyboard. Anyway I would dismiss the annoying argument all together. If I compare to the amount of OSDs my TV, audio receiver is putting on the screen this is a really good OSD. Martin Klapetek wrote: The second when the OSD is shown is still annoying and those who want to 'read' it need to reactivate the OSD I'm confused by that - does that say that the second it is on display is too much (annoying) but not enough to read it? Can you perhaps file a bug and specify exactly what is annoying and we can discuss over there? Heiko Tietze wrote: I tried to point out that we have two goals here: read information and don't disturb. In case of volume the feedback as position on the slider (or kind of progress bar) is perceived in milliseconds but when you got an email you might want to read sender and subject. And if the user is elder it might take more time to grasp what happens. Martin Klapetek wrote: Ah, you're getting confused OSD with notifications. This does not apply to notifications at all, this is only the volume/brigthness/etc changes. Heiko Tietze wrote: If you limit the scope to very simple notification the solution might be okay (personally I fully agree with the faster the better). But didn't Martin Graesslin blog about what kind of OSD should be shown on the lock screen including the idea of email like on Android? What's about the information of time left watching a video, perhaps after you forward a few seconds via KDEConnect? This is not about lock screen. Email notification on a lock screen needs a completely different solution than OSD. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82745 --- On July 20, 2015, 10:19 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/ --- (Updated July 20, 2015, 10:19 p.m.) Review request for Plasma and KDE Usability. Repository: plasma-workspace Description --- This makes the OSD begin fading out over a long period of time immediately after it has shown. Makes the OSD less annoying while currently reading something or watching a video. See https://www.youtube.com/watch?v=HxmpwG-2saE Diffs - lookandfeel/contents/osd/Osd.qml 2288ec1 shell/osd.cpp 0573d51 Diff: https://git.reviewboard.kde.org/r/124409/diff/ Testing --- Works. Quite enjoyable. As suggested by mklapetek Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124409: Begin fading the OSD immediately
On July 21, 2015, 9:03 a.m., Heiko Tietze wrote: Nice presentation, as always. But I'm not so sure that the realization of fading out quickly meets the needs from 'OSD is disturbing'. The second when the OSD is shown is still annoying (interaction during the fading might restart) and those who want to 'read' it need to reactivate the OSD. The issue could be solved by some kind of 'dismiss' or 'don't show again' interaction. Another simple way is to hide immediately on any key down, on mouse click etc. If that all is not possible at the OSD itself, perhaps because of security issues, a dialog (KCM) could help. And last but least please consider to bind this feature to activities. Martin Gräßlin wrote: Another simple way is to hide immediately on any key down, on mouse click etc. If that all is not possible at the OSD itself, perhaps because of security issues For technical reasons the OSD is not able to recognize any (global) key or mouse click events on Wayland and on X11 only with a huge amount of nasty code. Also I don't think that this is a solution to the annoying - if I watch a video and change the volume through kdeconnect I don't have a keyboard. Anyway I would dismiss the annoying argument all together. If I compare to the amount of OSDs my TV, audio receiver is putting on the screen this is a really good OSD. Martin Klapetek wrote: The second when the OSD is shown is still annoying and those who want to 'read' it need to reactivate the OSD I'm confused by that - does that say that the second it is on display is too much (annoying) but not enough to read it? Can you perhaps file a bug and specify exactly what is annoying and we can discuss over there? Heiko Tietze wrote: I tried to point out that we have two goals here: read information and don't disturb. In case of volume the feedback as position on the slider (or kind of progress bar) is perceived in milliseconds but when you got an email you might want to read sender and subject. And if the user is elder it might take more time to grasp what happens. Martin Klapetek wrote: Ah, you're getting confused OSD with notifications. This does not apply to notifications at all, this is only the volume/brigthness/etc changes. Heiko Tietze wrote: If you limit the scope to very simple notification the solution might be okay (personally I fully agree with the faster the better). But didn't Martin Graesslin blog about what kind of OSD should be shown on the lock screen including the idea of email like on Android? What's about the information of time left watching a video, perhaps after you forward a few seconds via KDEConnect? Martin Gräßlin wrote: This is not about lock screen. Email notification on a lock screen needs a completely different solution than OSD. The OSD currently does four things and four things only - it shows up on volume change, screen brigthness change, keyboard brightness change and keyboard layout change. Everything else is a notification, which is the small bubble in bottom-left part of the screen and is different in every possible aspect than the OSD, which is what this patch adjusts. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82745 --- On July 20, 2015, 10:19 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/ --- (Updated July 20, 2015, 10:19 p.m.) Review request for Plasma and KDE Usability. Repository: plasma-workspace Description --- This makes the OSD begin fading out over a long period of time immediately after it has shown. Makes the OSD less annoying while currently reading something or watching a video. See https://www.youtube.com/watch?v=HxmpwG-2saE Diffs - lookandfeel/contents/osd/Osd.qml 2288ec1 shell/osd.cpp 0573d51 Diff: https://git.reviewboard.kde.org/r/124409/diff/ Testing --- Works. Quite enjoyable. As suggested by mklapetek Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124409: Begin fading the OSD immediately
On Juli 21, 2015, 7:03 vorm., Heiko Tietze wrote: Nice presentation, as always. But I'm not so sure that the realization of fading out quickly meets the needs from 'OSD is disturbing'. The second when the OSD is shown is still annoying (interaction during the fading might restart) and those who want to 'read' it need to reactivate the OSD. The issue could be solved by some kind of 'dismiss' or 'don't show again' interaction. Another simple way is to hide immediately on any key down, on mouse click etc. If that all is not possible at the OSD itself, perhaps because of security issues, a dialog (KCM) could help. And last but least please consider to bind this feature to activities. Martin Gräßlin wrote: Another simple way is to hide immediately on any key down, on mouse click etc. If that all is not possible at the OSD itself, perhaps because of security issues For technical reasons the OSD is not able to recognize any (global) key or mouse click events on Wayland and on X11 only with a huge amount of nasty code. Also I don't think that this is a solution to the annoying - if I watch a video and change the volume through kdeconnect I don't have a keyboard. Anyway I would dismiss the annoying argument all together. If I compare to the amount of OSDs my TV, audio receiver is putting on the screen this is a really good OSD. Martin Klapetek wrote: The second when the OSD is shown is still annoying and those who want to 'read' it need to reactivate the OSD I'm confused by that - does that say that the second it is on display is too much (annoying) but not enough to read it? Can you perhaps file a bug and specify exactly what is annoying and we can discuss over there? Heiko Tietze wrote: I tried to point out that we have two goals here: read information and don't disturb. In case of volume the feedback as position on the slider (or kind of progress bar) is perceived in milliseconds but when you got an email you might want to read sender and subject. And if the user is elder it might take more time to grasp what happens. Martin Klapetek wrote: Ah, you're getting confused OSD with notifications. This does not apply to notifications at all, this is only the volume/brigthness/etc changes. Heiko Tietze wrote: If you limit the scope to very simple notification the solution might be okay (personally I fully agree with the faster the better). But didn't Martin Graesslin blog about what kind of OSD should be shown on the lock screen including the idea of email like on Android? What's about the information of time left watching a video, perhaps after you forward a few seconds via KDEConnect? Martin Gräßlin wrote: This is not about lock screen. Email notification on a lock screen needs a completely different solution than OSD. Martin Klapetek wrote: The OSD currently does four things and four things only - it shows up on volume change, screen brigthness change, keyboard brightness change and keyboard layout change. Everything else is a notification, which is the small bubble in bottom-left part of the screen and is different in every possible aspect than the OSD, which is what this patch adjusts. Okay, thanks for clarification. - Heiko --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82745 --- On Juli 20, 2015, 8:19 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/ --- (Updated Juli 20, 2015, 8:19 nachm.) Review request for Plasma and KDE Usability. Repository: plasma-workspace Description --- This makes the OSD begin fading out over a long period of time immediately after it has shown. Makes the OSD less annoying while currently reading something or watching a video. See https://www.youtube.com/watch?v=HxmpwG-2saE Diffs - lookandfeel/contents/osd/Osd.qml 2288ec1 shell/osd.cpp 0573d51 Diff: https://git.reviewboard.kde.org/r/124409/diff/ Testing --- Works. Quite enjoyable. As suggested by mklapetek Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124409: Begin fading the OSD immediately
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82751 --- Ship it! ...with my maintainer hat on. I would say let's gather feedback from beta and during akademy and if it's bad, we can revert for the release. - Martin Klapetek On July 20, 2015, 10:19 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/ --- (Updated July 20, 2015, 10:19 p.m.) Review request for Plasma and KDE Usability. Repository: plasma-workspace Description --- This makes the OSD begin fading out over a long period of time immediately after it has shown. Makes the OSD less annoying while currently reading something or watching a video. See https://www.youtube.com/watch?v=HxmpwG-2saE Diffs - lookandfeel/contents/osd/Osd.qml 2288ec1 shell/osd.cpp 0573d51 Diff: https://git.reviewboard.kde.org/r/124409/diff/ Testing --- Works. Quite enjoyable. As suggested by mklapetek Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124409: Begin fading the OSD immediately
On Tuesday, July 21, 2015 12:30:34 David Edmundson wrote: On July 21, 2015, 8:07 a.m., Martin Klapetek wrote: ...with my maintainer hat on. I would say let's gather feedback from beta and during akademy and if it's bad, we can revert for the release. +1 to that idea. +another1 -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124409: Begin fading the OSD immediately
On July 21, 2015, 8:07 a.m., Martin Klapetek wrote: ...with my maintainer hat on. I would say let's gather feedback from beta and during akademy and if it's bad, we can revert for the release. +1 to that idea. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82751 --- On July 20, 2015, 8:19 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/ --- (Updated July 20, 2015, 8:19 p.m.) Review request for Plasma and KDE Usability. Repository: plasma-workspace Description --- This makes the OSD begin fading out over a long period of time immediately after it has shown. Makes the OSD less annoying while currently reading something or watching a video. See https://www.youtube.com/watch?v=HxmpwG-2saE Diffs - lookandfeel/contents/osd/Osd.qml 2288ec1 shell/osd.cpp 0573d51 Diff: https://git.reviewboard.kde.org/r/124409/diff/ Testing --- Works. Quite enjoyable. As suggested by mklapetek Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124409: Begin fading the OSD immediately
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82734 --- Ship it! Ship It! - Jens Reuterberg On juli 20, 2015, 8:19 e.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/ --- (Updated juli 20, 2015, 8:19 e.m.) Review request for Plasma and KDE Usability. Repository: plasma-workspace Description --- This makes the OSD begin fading out over a long period of time immediately after it has shown. Makes the OSD less annoying while currently reading something or watching a video. See https://www.youtube.com/watch?v=HxmpwG-2saE Diffs - lookandfeel/contents/osd/Osd.qml 2288ec1 shell/osd.cpp 0573d51 Diff: https://git.reviewboard.kde.org/r/124409/diff/ Testing --- Works. Quite enjoyable. As suggested by mklapetek Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124409: Begin fading the OSD immediately
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82732 --- Nice! +1 from me. - Andrew Lake On July 20, 2015, 8:19 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/ --- (Updated July 20, 2015, 8:19 p.m.) Review request for Plasma and KDE Usability. Repository: plasma-workspace Description --- This makes the OSD begin fading out over a long period of time immediately after it has shown. Makes the OSD less annoying while currently reading something or watching a video. See https://www.youtube.com/watch?v=HxmpwG-2saE Diffs - lookandfeel/contents/osd/Osd.qml 2288ec1 shell/osd.cpp 0573d51 Diff: https://git.reviewboard.kde.org/r/124409/diff/ Testing --- Works. Quite enjoyable. As suggested by mklapetek Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 124409: Begin fading the OSD immediately
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/ --- Review request for Plasma and KDE Usability. Repository: plasma-workspace Description --- This makes the OSD begin fading out over a long period of time immediately after it has shown. Makes the OSD less annoying while currently reading something or watching a video. See https://www.youtube.com/watch?v=HxmpwG-2saE Diffs - lookandfeel/contents/osd/Osd.qml 2288ec1 shell/osd.cpp 0573d51 Diff: https://git.reviewboard.kde.org/r/124409/diff/ Testing --- Works. Quite enjoyable. As suggested by mklapetek Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124409: Begin fading the OSD immediately
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82738 --- lookandfeel/contents/osd/Osd.qml (line 48) https://git.reviewboard.kde.org/r/124409/#comment57055 This looks like a random wait time... Looking at the video, it seems like a slow animation. Is it intended? - Aleix Pol Gonzalez On July 20, 2015, 10:19 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/ --- (Updated July 20, 2015, 10:19 p.m.) Review request for Plasma and KDE Usability. Repository: plasma-workspace Description --- This makes the OSD begin fading out over a long period of time immediately after it has shown. Makes the OSD less annoying while currently reading something or watching a video. See https://www.youtube.com/watch?v=HxmpwG-2saE Diffs - lookandfeel/contents/osd/Osd.qml 2288ec1 shell/osd.cpp 0573d51 Diff: https://git.reviewboard.kde.org/r/124409/diff/ Testing --- Works. Quite enjoyable. As suggested by mklapetek Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel