Re: Review Request 125226: move EventForge from the desktop containment

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125226/
---

(Updated Sept. 17, 2015, 10:40 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Plasma and Eike Hein.


Changes
---

Submitted with commit 133e534b7dfa29f2f39d227ed12a3d9bc04ccb8e by Marco Martin 
to branch master.


Repository: kdeclarative


Description
---

EventForge can cancel the half-managed events of child items
in order to implement the move of them with press and hold,
not having the parent and the children battling for the same
press-move-release event sequence.

API-wise I think it's fine, apart perhaps the EventForge class name
(perhaps MouseEventGrabber is less technically correct, but still more clear?)


Diffs
-

  src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp a33e03f 
  src/qmlcontrols/kquickcontrolsaddons/eventgenerator.cpp PRE-CREATION 
  src/qmlcontrols/kquickcontrolsaddons/eventgenerator.h PRE-CREATION 
  src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 5b711e1 

Diff: https://git.reviewboard.kde.org/r/125226/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125226: move EventForge from the desktop containment

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125226/
---

(Updated Sept. 16, 2015, 6:19 p.m.)


Review request for KDE Frameworks, Plasma and Eike Hein.


Repository: kdeclarative


Description
---

EventForge can cancel the half-managed events of child items
in order to implement the move of them with press and hold,
not having the parent and the children battling for the same
press-move-release event sequence.

API-wise I think it's fine, apart perhaps the EventForge class name
(perhaps MouseEventGrabber is less technically correct, but still more clear?)


Diffs (updated)
-

  src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp a33e03f 
  src/qmlcontrols/kquickcontrolsaddons/eventgenerator.cpp PRE-CREATION 
  src/qmlcontrols/kquickcontrolsaddons/eventgenerator.h PRE-CREATION 
  src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 5b711e1 

Diff: https://git.reviewboard.kde.org/r/125226/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125226: move EventForge from the desktop containment

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125226/
---

(Updated Sept. 16, 2015, 5:40 p.m.)


Review request for KDE Frameworks, Plasma and Eike Hein.


Repository: kdeclarative


Description
---

EventForge can cancel the half-managed events of child items
in order to implement the move of them with press and hold,
not having the parent and the children battling for the same
press-move-release event sequence.

API-wise I think it's fine, apart perhaps the EventForge class name
(perhaps MouseEventGrabber is less technically correct, but still more clear?)


Diffs (updated)
-

  src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp a33e03f 
  src/qmlcontrols/kquickcontrolsaddons/eventgenerator.h PRE-CREATION 
  src/qmlcontrols/kquickcontrolsaddons/eventgenerator.cpp PRE-CREATION 
  src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 5b711e1 

Diff: https://git.reviewboard.kde.org/r/125226/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125226: move EventForge from the desktop containment

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125226/
---

(Updated Sept. 16, 2015, 4:44 p.m.)


Review request for KDE Frameworks, Plasma and Eike Hein.


Repository: kdeclarative


Description
---

EventForge can cancel the half-managed events of child items
in order to implement the move of them with press and hold,
not having the parent and the children battling for the same
press-move-release event sequence.

API-wise I think it's fine, apart perhaps the EventForge class name
(perhaps MouseEventGrabber is less technically correct, but still more clear?)


Diffs (updated)
-

  src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 5b711e1 
  src/qmlcontrols/kquickcontrolsaddons/eventgenerator.h PRE-CREATION 
  src/qmlcontrols/kquickcontrolsaddons/eventgenerator.cpp PRE-CREATION 
  src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp a33e03f 

Diff: https://git.reviewboard.kde.org/r/125226/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125226: move EventForge from the desktop containment

[Marco Martin]

> On Sept. 15, 2015, 9:41 p.m., David Edmundson wrote:
> > src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.cpp, line 259
> > 
> >
> > This adds the same item multiple times.
> > 
> > If you have an item with a child: the first itteration will add it and 
> > the child, then we recurse and add the child again.
> > 
> > I think you can kill the
> > 
> > itemList.append(parentItem->childItems()) 
> > 
> > ?

is probably itemList.append(parentItem); that should be removed, as 
"allChildItems" suggests the child items but not the parent itself


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125226/#review85466
---


On Sept. 16, 2015, 9:12 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125226/
> ---
> 
> (Updated Sept. 16, 2015, 9:12 a.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Eike Hein.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> EventForge can cancel the half-managed events of child items
> in order to implement the move of them with press and hold,
> not having the parent and the children battling for the same
> press-move-release event sequence.
> 
> API-wise I think it's fine, apart perhaps the EventForge class name
> (perhaps MouseEventGrabber is less technically correct, but still more clear?)
> 
> 
> Diffs
> -
> 
>   src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.h a62efb7 
>   src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.cpp d3321a3 
> 
> Diff: https://git.reviewboard.kde.org/r/125226/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125226: move EventForge from the desktop containment

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125226/
---

(Updated Sept. 16, 2015, 9:12 a.m.)


Review request for KDE Frameworks, Plasma and Eike Hein.


Repository: kdeclarative


Description
---

EventForge can cancel the half-managed events of child items
in order to implement the move of them with press and hold,
not having the parent and the children battling for the same
press-move-release event sequence.

API-wise I think it's fine, apart perhaps the EventForge class name
(perhaps MouseEventGrabber is less technically correct, but still more clear?)


Diffs (updated)
-

  src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.h a62efb7 
  src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.cpp d3321a3 

Diff: https://git.reviewboard.kde.org/r/125226/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125226: move EventForge from the desktop containment

[David Edmundson]

> On Sept. 15, 2015, 12:06 a.m., David Edmundson wrote:
> > src/qmlcontrols/kquickcontrolsaddons/eventforge.cpp, line 51
> > 
> >
> > why do people need to do this?
> 
> Eike Hein wrote:
> It basically triggers the onCanceled handler in MouseArea and 
> MouseEventListener, and is used to abort mouse handling in applet items when 
> you enable applet moving via press and hold in the containment. Flickable 
> does similar things internally for flicking the viewport, but Qt only has 
> private API for it (which isn't easily made public); this is the closest 
> approximation using public API.

Don't tell me, tell the .cpp file :)


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125226/#review85410
---


On Sept. 15, 2015, 5:32 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125226/
> ---
> 
> (Updated Sept. 15, 2015, 5:32 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Eike Hein.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> EventForge can cancel the half-managed events of child items
> in order to implement the move of them with press and hold,
> not having the parent and the children battling for the same
> press-move-release event sequence.
> 
> API-wise I think it's fine, apart perhaps the EventForge class name
> (perhaps MouseEventGrabber is less technically correct, but still more clear?)
> 
> 
> Diffs
> -
> 
>   src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.h a62efb7 
>   src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.cpp d3321a3 
> 
> Diff: https://git.reviewboard.kde.org/r/125226/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125226: move EventForge from the desktop containment

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125226/#review85466
---



src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.cpp (line 257)


This adds the same item multiple times.

If you have an item with a child: the first itteration will add it and the 
child, then we recurse and add the child again.

I think you can kill the

itemList.append(parentItem->childItems()) 

?


- David Edmundson


On Sept. 15, 2015, 5:32 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125226/
> ---
> 
> (Updated Sept. 15, 2015, 5:32 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Eike Hein.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> EventForge can cancel the half-managed events of child items
> in order to implement the move of them with press and hold,
> not having the parent and the children battling for the same
> press-move-release event sequence.
> 
> API-wise I think it's fine, apart perhaps the EventForge class name
> (perhaps MouseEventGrabber is less technically correct, but still more clear?)
> 
> 
> Diffs
> -
> 
>   src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.h a62efb7 
>   src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.cpp d3321a3 
> 
> Diff: https://git.reviewboard.kde.org/r/125226/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125226: move EventForge from the desktop containment

[Eike Hein]

> On Sept. 15, 2015, 12:06 a.m., David Edmundson wrote:
> > src/qmlcontrols/kquickcontrolsaddons/eventforge.cpp, line 51
> > 
> >
> > why do people need to do this?

It basically triggers the onCanceled handler in MouseArea and 
MouseEventListener, and is used to abort mouse handling in applet items when 
you enable applet moving via press and hold in the containment. Flickable does 
similar things internally for flicking the viewport, but Qt only has private 
API for it (which isn't easily made public); this is the closest approximation 
using public API.


> On Sept. 15, 2015, 12:06 a.m., David Edmundson wrote:
> > src/qmlcontrols/kquickcontrolsaddons/eventforge.cpp, line 40
> > 
> >
> > we're getting win and not using it. Is that deliberate?

I probably meant to use QQuickWindow::sendEvent


- Eike


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125226/#review85410
---


On Sept. 15, 2015, 5:32 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125226/
> ---
> 
> (Updated Sept. 15, 2015, 5:32 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Eike Hein.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> EventForge can cancel the half-managed events of child items
> in order to implement the move of them with press and hold,
> not having the parent and the children battling for the same
> press-move-release event sequence.
> 
> API-wise I think it's fine, apart perhaps the EventForge class name
> (perhaps MouseEventGrabber is less technically correct, but still more clear?)
> 
> 
> Diffs
> -
> 
>   src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.h a62efb7 
>   src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.cpp d3321a3 
> 
> Diff: https://git.reviewboard.kde.org/r/125226/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125226: move EventForge from the desktop containment

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125226/
---

(Updated Sept. 15, 2015, 5:32 p.m.)


Review request for KDE Frameworks, Plasma and Eike Hein.


Changes
---

fix the logic


Repository: kdeclarative


Description
---

EventForge can cancel the half-managed events of child items
in order to implement the move of them with press and hold,
not having the parent and the children battling for the same
press-move-release event sequence.

API-wise I think it's fine, apart perhaps the EventForge class name
(perhaps MouseEventGrabber is less technically correct, but still more clear?)


Diffs (updated)
-

  src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.h a62efb7 
  src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.cpp d3321a3 

Diff: https://git.reviewboard.kde.org/r/125226/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125226: move EventForge from the desktop containment

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125226/
---

(Updated Sept. 15, 2015, 5:30 p.m.)


Review request for KDE Frameworks, Plasma and Eike Hein.


Changes
---

RFC: this version impements a similar thing in MouseEventListener, that would 
be done automatically, without API.
there may be side effects, but it may make sense if a mouseeventlistener 
manages a pressandhold, it cancels all the events half managed by the children 
so far


Repository: kdeclarative


Description
---

EventForge can cancel the half-managed events of child items
in order to implement the move of them with press and hold,
not having the parent and the children battling for the same
press-move-release event sequence.

API-wise I think it's fine, apart perhaps the EventForge class name
(perhaps MouseEventGrabber is less technically correct, but still more clear?)


Diffs (updated)
-

  src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.h a62efb7 
  src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.cpp d3321a3 

Diff: https://git.reviewboard.kde.org/r/125226/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125226: move EventForge from the desktop containment

[Marco Martin]

On Sept. 15, 2015, 12:06 a.m., Marco Martin wrote:
> > This class feels like it's just working round Qt bugs?
> > 
> > Other than that if this is long-term useful, we should do sendPress(flags 
> > buttons, flags modifiers, x, y) not just whatever AppletAppearance happened 
> > to need (or make it part of makeGrab() if that's all it's for )
> 
> Marco Martin wrote:
> It can be said it work around Qt bugs, so yeah, not too happy it's needed.
> maybe to commit to it slightly less it could be put into the 
> plasma-workspace imports (as to say it can be used only in containments)
> But works around the very way how events are managed in Qt. once a child 
> accepted a press (and maybe some moves) it can't really be interrupted as two 
> items can't accept the same event. So this fakes it by sending fake events to 
> cancel the management cycle initiated by the child on mouyse press. don't 
> think there is really a way about it as is how Qt event management work (and 
> not only in qtquick)
> 
> Marco Martin wrote:
> an alternative API may be
> PressAndHoldManager {
> dragArea: dragAreaItem
> MouseArea {
> id: dragAreaItem
> MouseArea {
> id: itemToDrag
> }
> }
> }
> 
> not sure it it would really work

About putting it in workspace, would probably be a better idea, however this 
may end up being needed in random plasma mobile applications as seems press and 
hold may end up used a lot looking at the talks about higs


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125226/#review85410
---


On Sept. 14, 2015, 5:17 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125226/
> ---
> 
> (Updated Sept. 14, 2015, 5:17 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Eike Hein.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> EventForge can cancel the half-managed events of child items
> in order to implement the move of them with press and hold,
> not having the parent and the children battling for the same
> press-move-release event sequence.
> 
> API-wise I think it's fine, apart perhaps the EventForge class name
> (perhaps MouseEventGrabber is less technically correct, but still more clear?)
> 
> 
> Diffs
> -
> 
>   src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 5b711e1 
>   src/qmlcontrols/kquickcontrolsaddons/eventforge.h PRE-CREATION 
>   src/qmlcontrols/kquickcontrolsaddons/eventforge.cpp PRE-CREATION 
>   src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp a33e03f 
> 
> Diff: https://git.reviewboard.kde.org/r/125226/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125226: move EventForge from the desktop containment

[Marco Martin]

On Sept. 15, 2015, 12:06 a.m., Marco Martin wrote:
> > This class feels like it's just working round Qt bugs?
> > 
> > Other than that if this is long-term useful, we should do sendPress(flags 
> > buttons, flags modifiers, x, y) not just whatever AppletAppearance happened 
> > to need (or make it part of makeGrab() if that's all it's for )
> 
> Marco Martin wrote:
> It can be said it work around Qt bugs, so yeah, not too happy it's needed.
> maybe to commit to it slightly less it could be put into the 
> plasma-workspace imports (as to say it can be used only in containments)
> But works around the very way how events are managed in Qt. once a child 
> accepted a press (and maybe some moves) it can't really be interrupted as two 
> items can't accept the same event. So this fakes it by sending fake events to 
> cancel the management cycle initiated by the child on mouyse press. don't 
> think there is really a way about it as is how Qt event management work (and 
> not only in qtquick)

an alternative API may be
PressAndHoldManager {
dragArea: dragAreaItem
MouseArea {
id: dragAreaItem
MouseArea {
id: itemToDrag
}
}
}

not sure it it would really work


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125226/#review85410
---


On Sept. 14, 2015, 5:17 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125226/
> ---
> 
> (Updated Sept. 14, 2015, 5:17 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Eike Hein.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> EventForge can cancel the half-managed events of child items
> in order to implement the move of them with press and hold,
> not having the parent and the children battling for the same
> press-move-release event sequence.
> 
> API-wise I think it's fine, apart perhaps the EventForge class name
> (perhaps MouseEventGrabber is less technically correct, but still more clear?)
> 
> 
> Diffs
> -
> 
>   src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 5b711e1 
>   src/qmlcontrols/kquickcontrolsaddons/eventforge.h PRE-CREATION 
>   src/qmlcontrols/kquickcontrolsaddons/eventforge.cpp PRE-CREATION 
>   src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp a33e03f 
> 
> Diff: https://git.reviewboard.kde.org/r/125226/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125226: move EventForge from the desktop containment

[Marco Martin]

On Sept. 15, 2015, 12:06 a.m., Marco Martin wrote:
> > This class feels like it's just working round Qt bugs?
> > 
> > Other than that if this is long-term useful, we should do sendPress(flags 
> > buttons, flags modifiers, x, y) not just whatever AppletAppearance happened 
> > to need (or make it part of makeGrab() if that's all it's for )

It can be said it work around Qt bugs, so yeah, not too happy it's needed.
maybe to commit to it slightly less it could be put into the plasma-workspace 
imports (as to say it can be used only in containments)
But works around the very way how events are managed in Qt. once a child 
accepted a press (and maybe some moves) it can't really be interrupted as two 
items can't accept the same event. So this fakes it by sending fake events to 
cancel the management cycle initiated by the child on mouyse press. don't think 
there is really a way about it as is how Qt event management work (and not only 
in qtquick)


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125226/#review85410
---


On Sept. 14, 2015, 5:17 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125226/
> ---
> 
> (Updated Sept. 14, 2015, 5:17 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Eike Hein.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> EventForge can cancel the half-managed events of child items
> in order to implement the move of them with press and hold,
> not having the parent and the children battling for the same
> press-move-release event sequence.
> 
> API-wise I think it's fine, apart perhaps the EventForge class name
> (perhaps MouseEventGrabber is less technically correct, but still more clear?)
> 
> 
> Diffs
> -
> 
>   src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 5b711e1 
>   src/qmlcontrols/kquickcontrolsaddons/eventforge.h PRE-CREATION 
>   src/qmlcontrols/kquickcontrolsaddons/eventforge.cpp PRE-CREATION 
>   src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp a33e03f 
> 
> Diff: https://git.reviewboard.kde.org/r/125226/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125226: move EventForge from the desktop containment

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125226/#review85410
---



src/qmlcontrols/kquickcontrolsaddons/eventforge.h (line 27)


api docs



src/qmlcontrols/kquickcontrolsaddons/eventforge.cpp (line 34)


x, y aren't always int in QtQuick

especially as you use QPointF later



src/qmlcontrols/kquickcontrolsaddons/eventforge.cpp (line 40)


we're getting win and not using it. Is that deliberate?



src/qmlcontrols/kquickcontrolsaddons/eventforge.cpp (line 51)


why do people need to do this?


This class feels like it's just working round Qt bugs?

Other than that if this is long-term useful, we should do sendPress(flags 
buttons, flags modifiers, x, y) not just whatever AppletAppearance happened to 
need (or make it part of makeGrab() if that's all it's for )

- David Edmundson


On Sept. 14, 2015, 5:17 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125226/
> ---
> 
> (Updated Sept. 14, 2015, 5:17 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Eike Hein.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> EventForge can cancel the half-managed events of child items
> in order to implement the move of them with press and hold,
> not having the parent and the children battling for the same
> press-move-release event sequence.
> 
> API-wise I think it's fine, apart perhaps the EventForge class name
> (perhaps MouseEventGrabber is less technically correct, but still more clear?)
> 
> 
> Diffs
> -
> 
>   src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 5b711e1 
>   src/qmlcontrols/kquickcontrolsaddons/eventforge.h PRE-CREATION 
>   src/qmlcontrols/kquickcontrolsaddons/eventforge.cpp PRE-CREATION 
>   src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp a33e03f 
> 
> Diff: https://git.reviewboard.kde.org/r/125226/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125226: move EventForge from the desktop containment

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125226/
---

Review request for KDE Frameworks, Plasma and Eike Hein.


Repository: kdeclarative


Description
---

EventForge can cancel the half-managed events of child items
in order to implement the move of them with press and hold,
not having the parent and the children battling for the same
press-move-release event sequence.

API-wise I think it's fine, apart perhaps the EventForge class name
(perhaps MouseEventGrabber is less technically correct, but still more clear?)


Diffs
-

  src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 5b711e1 
  src/qmlcontrols/kquickcontrolsaddons/eventforge.h PRE-CREATION 
  src/qmlcontrols/kquickcontrolsaddons/eventforge.cpp PRE-CREATION 
  src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp a33e03f 

Diff: https://git.reviewboard.kde.org/r/125226/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel