Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

2016-02-08 Thread Mark Gaiser 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126960/#review92148
---



Kai,

Just wanted to say that this looks great :)
Thank you for making it look better.

- Mark Gaiser


On feb 7, 2016, 11:10 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126960/
> ---
> 
> (Updated feb 7, 2016, 11:10 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Bugs: 336124, 348362 and 358536
> http://bugs.kde.org/show_bug.cgi?id=336124
> http://bugs.kde.org/show_bug.cgi?id=348362
> http://bugs.kde.org/show_bug.cgi?id=358536
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This removes the custom label-based triangles and replaces them with proper 
> ToolButtons using proper icons. It also adds a "Today" button to return to 
> the current day. Also, tooltips that reflect the actual action ("Previous 
> Month", "Previous Year", "Previous Decade", depending on the zoom level) were 
> added.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 3ab16eb 
>   src/declarativeimports/calendar/qml/MonthView.qml c876e3b 
> 
> Diff: https://git.reviewboard.kde.org/r/126960/diff/
> 
> 
> Testing
> ---
> 
> Works.
> 
> The weekday names look a bit awkward now
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/a065dfcf-ca75-4d50-81aa-4d725245344e__Screenshot_20160201_234605.png
> How about this?
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/04/d80b6161-3da3-4669-ba7c-19f62edbf542__Screenshot_20160205_001739.png
> How about this? #2
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/04/73f2ada9-48cd-4b22-8ef2-5d37f2238442__Screenshot_20160205_001754.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

2016-02-07 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126960/
---

(Updated Feb. 7, 2016, 11:10 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and KDE Usability.


Changes
---

Submitted with commit 4ebf130ee66a912a5dac360441a8c0060eab247e by Kai Uwe 
Broulik to branch master.


Bugs: 336124, 348362 and 358536
http://bugs.kde.org/show_bug.cgi?id=336124
http://bugs.kde.org/show_bug.cgi?id=348362
http://bugs.kde.org/show_bug.cgi?id=358536


Repository: plasma-framework


Description
---

This removes the custom label-based triangles and replaces them with proper 
ToolButtons using proper icons. It also adds a "Today" button to return to the 
current day. Also, tooltips that reflect the actual action ("Previous Month", 
"Previous Year", "Previous Decade", depending on the zoom level) were added.


Diffs
-

  src/declarativeimports/calendar/qml/DaysCalendar.qml 3ab16eb 
  src/declarativeimports/calendar/qml/MonthView.qml c876e3b 

Diff: https://git.reviewboard.kde.org/r/126960/diff/


Testing
---

Works.

The weekday names look a bit awkward now


File Attachments


Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/a065dfcf-ca75-4d50-81aa-4d725245344e__Screenshot_20160201_234605.png
How about this?
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/02/04/d80b6161-3da3-4669-ba7c-19f62edbf542__Screenshot_20160205_001739.png
How about this? #2
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/02/04/73f2ada9-48cd-4b22-8ef2-5d37f2238442__Screenshot_20160205_001754.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

2016-02-05 Thread Marco Martin 


> On Feb. 2, 2016, 9:22 a.m., Marco Martin wrote:
> > hmm, i don't think i like the back/forward buttons both at the right, it 
> > looked more nicely symmetric before
> 
> Kai Uwe Broulik wrote:
> It also reduces mouse travel :) Placing the "Previous" button left of the 
> month name would look strange. Not a huge fan of having them where they 
> originally were; the ToolButtons wouldn't fit size- and style-wise.
> 
> Sebastian Kügler wrote:
> FWIW, I'm quite happy with it, visually. :)

btw, I'm happy with the explanations, +1 from me ;)


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126960/#review91926
---


On Feb. 4, 2016, 11:19 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126960/
> ---
> 
> (Updated Feb. 4, 2016, 11:19 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Bugs: 336124, 348362 and 358536
> http://bugs.kde.org/show_bug.cgi?id=336124
> http://bugs.kde.org/show_bug.cgi?id=348362
> http://bugs.kde.org/show_bug.cgi?id=358536
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This removes the custom label-based triangles and replaces them with proper 
> ToolButtons using proper icons. It also adds a "Today" button to return to 
> the current day. Also, tooltips that reflect the actual action ("Previous 
> Month", "Previous Year", "Previous Decade", depending on the zoom level) were 
> added.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 3ab16eb 
>   src/declarativeimports/calendar/qml/MonthView.qml c876e3b 
> 
> Diff: https://git.reviewboard.kde.org/r/126960/diff/
> 
> 
> Testing
> ---
> 
> Works.
> 
> The weekday names look a bit awkward now
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/a065dfcf-ca75-4d50-81aa-4d725245344e__Screenshot_20160201_234605.png
> How about this?
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/04/d80b6161-3da3-4669-ba7c-19f62edbf542__Screenshot_20160205_001739.png
> How about this? #2
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/04/73f2ada9-48cd-4b22-8ef2-5d37f2238442__Screenshot_20160205_001754.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

2016-02-05 Thread Andrew Lake 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126960/#review92078
---


Ship it!




Ship It!

- Andrew Lake


On Feb. 4, 2016, 11:19 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126960/
> ---
> 
> (Updated Feb. 4, 2016, 11:19 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Bugs: 336124, 348362 and 358536
> http://bugs.kde.org/show_bug.cgi?id=336124
> http://bugs.kde.org/show_bug.cgi?id=348362
> http://bugs.kde.org/show_bug.cgi?id=358536
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This removes the custom label-based triangles and replaces them with proper 
> ToolButtons using proper icons. It also adds a "Today" button to return to 
> the current day. Also, tooltips that reflect the actual action ("Previous 
> Month", "Previous Year", "Previous Decade", depending on the zoom level) were 
> added.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 3ab16eb 
>   src/declarativeimports/calendar/qml/MonthView.qml c876e3b 
> 
> Diff: https://git.reviewboard.kde.org/r/126960/diff/
> 
> 
> Testing
> ---
> 
> Works.
> 
> The weekday names look a bit awkward now
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/a065dfcf-ca75-4d50-81aa-4d725245344e__Screenshot_20160201_234605.png
> How about this?
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/04/d80b6161-3da3-4669-ba7c-19f62edbf542__Screenshot_20160205_001739.png
> How about this? #2
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/04/73f2ada9-48cd-4b22-8ef2-5d37f2238442__Screenshot_20160205_001754.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

2016-02-04 Thread Kai Uwe Broulik 


> On Feb. 2, 2016, 12:37 vorm., Andrew Lake wrote:
> > Nice improvement. If the week numbers look ok then +1 from me.

I need some inspiration for how to align the week names, though.

The more I look at it now the better I like it. I tried vertically centering 
them but that looks awful. On the other hand I really don't want to touch the 
grid painting code (eg. reduce the height of that row)


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126960/#review91907
---


On Feb. 1, 2016, 11:12 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126960/
> ---
> 
> (Updated Feb. 1, 2016, 11:12 nachm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Bugs: 336124, 348362 and 358536
> http://bugs.kde.org/show_bug.cgi?id=336124
> http://bugs.kde.org/show_bug.cgi?id=348362
> http://bugs.kde.org/show_bug.cgi?id=358536
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This removes the custom label-based triangles and replaces them with proper 
> ToolButtons using proper icons. It also adds a "Today" button to return to 
> the current day. Also, tooltips that reflect the actual action ("Previous 
> Month", "Previous Year", "Previous Decade", depending on the zoom level) were 
> added.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 3ab16eb 
>   src/declarativeimports/calendar/qml/MonthView.qml c876e3b 
> 
> Diff: https://git.reviewboard.kde.org/r/126960/diff/
> 
> 
> Testing
> ---
> 
> Works.
> 
> The weekday names look a bit awkward now
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/a065dfcf-ca75-4d50-81aa-4d725245344e__Screenshot_20160201_234605.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

2016-02-04 Thread Kai Uwe Broulik 


> On Feb. 4, 2016, 11:24 nachm., Heiko Tietze wrote:
> > File Attachment: How about this? #2 - How about this? #2
> > 
> >
> > Bug 299174 - Remove "week number" from system tray calendar for 
> > improved readability 
> > 
> > https://bugs.kde.org/show_bug.cgi?id=299174
> > 
> > (I disagree with the idea to remove it. But some ideas have been 
> > stressed in this thread.)

You're aware that week numbers in the calendar are optional and turned off by 
default and were only re-introduced after frequent user complaints.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126960/#review92071
---


On Feb. 4, 2016, 11:19 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126960/
> ---
> 
> (Updated Feb. 4, 2016, 11:19 nachm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Bugs: 336124, 348362 and 358536
> http://bugs.kde.org/show_bug.cgi?id=336124
> http://bugs.kde.org/show_bug.cgi?id=348362
> http://bugs.kde.org/show_bug.cgi?id=358536
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This removes the custom label-based triangles and replaces them with proper 
> ToolButtons using proper icons. It also adds a "Today" button to return to 
> the current day. Also, tooltips that reflect the actual action ("Previous 
> Month", "Previous Year", "Previous Decade", depending on the zoom level) were 
> added.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 3ab16eb 
>   src/declarativeimports/calendar/qml/MonthView.qml c876e3b 
> 
> Diff: https://git.reviewboard.kde.org/r/126960/diff/
> 
> 
> Testing
> ---
> 
> Works.
> 
> The weekday names look a bit awkward now
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/a065dfcf-ca75-4d50-81aa-4d725245344e__Screenshot_20160201_234605.png
> How about this?
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/04/d80b6161-3da3-4669-ba7c-19f62edbf542__Screenshot_20160205_001739.png
> How about this? #2
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/04/73f2ada9-48cd-4b22-8ef2-5d37f2238442__Screenshot_20160205_001754.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

2016-02-04 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126960/
---

(Updated Feb. 4, 2016, 11:19 nachm.)


Review request for Plasma and KDE Usability.


Changes
---

Screenshots for larger week day names.


Bugs: 336124, 348362 and 358536
http://bugs.kde.org/show_bug.cgi?id=336124
http://bugs.kde.org/show_bug.cgi?id=348362
http://bugs.kde.org/show_bug.cgi?id=358536


Repository: plasma-framework


Description
---

This removes the custom label-based triangles and replaces them with proper 
ToolButtons using proper icons. It also adds a "Today" button to return to the 
current day. Also, tooltips that reflect the actual action ("Previous Month", 
"Previous Year", "Previous Decade", depending on the zoom level) were added.


Diffs
-

  src/declarativeimports/calendar/qml/DaysCalendar.qml 3ab16eb 
  src/declarativeimports/calendar/qml/MonthView.qml c876e3b 

Diff: https://git.reviewboard.kde.org/r/126960/diff/


Testing
---

Works.

The weekday names look a bit awkward now


File Attachments (updated)


Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/a065dfcf-ca75-4d50-81aa-4d725245344e__Screenshot_20160201_234605.png
How about this?
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/02/04/d80b6161-3da3-4669-ba7c-19f62edbf542__Screenshot_20160205_001739.png
How about this? #2
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/02/04/73f2ada9-48cd-4b22-8ef2-5d37f2238442__Screenshot_20160205_001754.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

2016-02-04 Thread Andreas Kainz 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126960/#review92070
---


Ship it!




Ship It!

- Andreas Kainz


On Feb. 4, 2016, 11:19 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126960/
> ---
> 
> (Updated Feb. 4, 2016, 11:19 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Bugs: 336124, 348362 and 358536
> http://bugs.kde.org/show_bug.cgi?id=336124
> http://bugs.kde.org/show_bug.cgi?id=348362
> http://bugs.kde.org/show_bug.cgi?id=358536
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This removes the custom label-based triangles and replaces them with proper 
> ToolButtons using proper icons. It also adds a "Today" button to return to 
> the current day. Also, tooltips that reflect the actual action ("Previous 
> Month", "Previous Year", "Previous Decade", depending on the zoom level) were 
> added.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 3ab16eb 
>   src/declarativeimports/calendar/qml/MonthView.qml c876e3b 
> 
> Diff: https://git.reviewboard.kde.org/r/126960/diff/
> 
> 
> Testing
> ---
> 
> Works.
> 
> The weekday names look a bit awkward now
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/a065dfcf-ca75-4d50-81aa-4d725245344e__Screenshot_20160201_234605.png
> How about this?
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/04/d80b6161-3da3-4669-ba7c-19f62edbf542__Screenshot_20160205_001739.png
> How about this? #2
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/04/73f2ada9-48cd-4b22-8ef2-5d37f2238442__Screenshot_20160205_001754.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

2016-02-04 Thread Heiko Tietze 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126960/#review92071
---




File Attachment: How about this? #2 - How about this? #2


Bug 299174 - Remove "week number" from system tray calendar for improved 
readability 

https://bugs.kde.org/show_bug.cgi?id=299174

(I disagree with the idea to remove it. But some ideas have been stressed 
in this thread.)


- Heiko Tietze


On Feb. 4, 2016, 11:19 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126960/
> ---
> 
> (Updated Feb. 4, 2016, 11:19 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Bugs: 336124, 348362 and 358536
> http://bugs.kde.org/show_bug.cgi?id=336124
> http://bugs.kde.org/show_bug.cgi?id=348362
> http://bugs.kde.org/show_bug.cgi?id=358536
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This removes the custom label-based triangles and replaces them with proper 
> ToolButtons using proper icons. It also adds a "Today" button to return to 
> the current day. Also, tooltips that reflect the actual action ("Previous 
> Month", "Previous Year", "Previous Decade", depending on the zoom level) were 
> added.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 3ab16eb 
>   src/declarativeimports/calendar/qml/MonthView.qml c876e3b 
> 
> Diff: https://git.reviewboard.kde.org/r/126960/diff/
> 
> 
> Testing
> ---
> 
> Works.
> 
> The weekday names look a bit awkward now
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/a065dfcf-ca75-4d50-81aa-4d725245344e__Screenshot_20160201_234605.png
> How about this?
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/04/d80b6161-3da3-4669-ba7c-19f62edbf542__Screenshot_20160205_001739.png
> How about this? #2
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/04/73f2ada9-48cd-4b22-8ef2-5d37f2238442__Screenshot_20160205_001754.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

2016-02-04 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126960/#review92073
---



This diff doesn't seem to have the week days row changes?

- Martin Klapetek


On Feb. 5, 2016, 12:19 a.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126960/
> ---
> 
> (Updated Feb. 5, 2016, 12:19 a.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Bugs: 336124, 348362 and 358536
> http://bugs.kde.org/show_bug.cgi?id=336124
> http://bugs.kde.org/show_bug.cgi?id=348362
> http://bugs.kde.org/show_bug.cgi?id=358536
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This removes the custom label-based triangles and replaces them with proper 
> ToolButtons using proper icons. It also adds a "Today" button to return to 
> the current day. Also, tooltips that reflect the actual action ("Previous 
> Month", "Previous Year", "Previous Decade", depending on the zoom level) were 
> added.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 3ab16eb 
>   src/declarativeimports/calendar/qml/MonthView.qml c876e3b 
> 
> Diff: https://git.reviewboard.kde.org/r/126960/diff/
> 
> 
> Testing
> ---
> 
> Works.
> 
> The weekday names look a bit awkward now
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/a065dfcf-ca75-4d50-81aa-4d725245344e__Screenshot_20160201_234605.png
> How about this?
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/04/d80b6161-3da3-4669-ba7c-19f62edbf542__Screenshot_20160205_001739.png
> How about this? #2
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/04/73f2ada9-48cd-4b22-8ef2-5d37f2238442__Screenshot_20160205_001754.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

2016-02-02 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126960/#review91926
---



hmm, i don't think i like the back/forward buttons both at the right, it looked 
more nicely symmetric before

- Marco Martin


On Feb. 1, 2016, 11:12 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126960/
> ---
> 
> (Updated Feb. 1, 2016, 11:12 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Bugs: 336124, 348362 and 358536
> http://bugs.kde.org/show_bug.cgi?id=336124
> http://bugs.kde.org/show_bug.cgi?id=348362
> http://bugs.kde.org/show_bug.cgi?id=358536
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This removes the custom label-based triangles and replaces them with proper 
> ToolButtons using proper icons. It also adds a "Today" button to return to 
> the current day. Also, tooltips that reflect the actual action ("Previous 
> Month", "Previous Year", "Previous Decade", depending on the zoom level) were 
> added.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 3ab16eb 
>   src/declarativeimports/calendar/qml/MonthView.qml c876e3b 
> 
> Diff: https://git.reviewboard.kde.org/r/126960/diff/
> 
> 
> Testing
> ---
> 
> Works.
> 
> The weekday names look a bit awkward now
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/a065dfcf-ca75-4d50-81aa-4d725245344e__Screenshot_20160201_234605.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

2016-02-02 Thread Kai Uwe Broulik 


> On Feb. 2, 2016, 9:22 vorm., Marco Martin wrote:
> > hmm, i don't think i like the back/forward buttons both at the right, it 
> > looked more nicely symmetric before

It also reduces mouse travel :) Placing the "Previous" button left of the month 
name would look strange. Not a huge fan of having them where they originally 
were; the ToolButtons wouldn't fit size- and style-wise.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126960/#review91926
---


On Feb. 1, 2016, 11:12 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126960/
> ---
> 
> (Updated Feb. 1, 2016, 11:12 nachm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Bugs: 336124, 348362 and 358536
> http://bugs.kde.org/show_bug.cgi?id=336124
> http://bugs.kde.org/show_bug.cgi?id=348362
> http://bugs.kde.org/show_bug.cgi?id=358536
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This removes the custom label-based triangles and replaces them with proper 
> ToolButtons using proper icons. It also adds a "Today" button to return to 
> the current day. Also, tooltips that reflect the actual action ("Previous 
> Month", "Previous Year", "Previous Decade", depending on the zoom level) were 
> added.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 3ab16eb 
>   src/declarativeimports/calendar/qml/MonthView.qml c876e3b 
> 
> Diff: https://git.reviewboard.kde.org/r/126960/diff/
> 
> 
> Testing
> ---
> 
> Works.
> 
> The weekday names look a bit awkward now
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/a065dfcf-ca75-4d50-81aa-4d725245344e__Screenshot_20160201_234605.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

2016-02-02 Thread Sebastian Kügler 


> On Feb. 2, 2016, 9:22 a.m., Marco Martin wrote:
> > hmm, i don't think i like the back/forward buttons both at the right, it 
> > looked more nicely symmetric before
> 
> Kai Uwe Broulik wrote:
> It also reduces mouse travel :) Placing the "Previous" button left of the 
> month name would look strange. Not a huge fan of having them where they 
> originally were; the ToolButtons wouldn't fit size- and style-wise.

FWIW, I'm quite happy with it, visually. :)


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126960/#review91926
---


On Feb. 1, 2016, 11:12 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126960/
> ---
> 
> (Updated Feb. 1, 2016, 11:12 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Bugs: 336124, 348362 and 358536
> http://bugs.kde.org/show_bug.cgi?id=336124
> http://bugs.kde.org/show_bug.cgi?id=348362
> http://bugs.kde.org/show_bug.cgi?id=358536
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This removes the custom label-based triangles and replaces them with proper 
> ToolButtons using proper icons. It also adds a "Today" button to return to 
> the current day. Also, tooltips that reflect the actual action ("Previous 
> Month", "Previous Year", "Previous Decade", depending on the zoom level) were 
> added.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 3ab16eb 
>   src/declarativeimports/calendar/qml/MonthView.qml c876e3b 
> 
> Diff: https://git.reviewboard.kde.org/r/126960/diff/
> 
> 
> Testing
> ---
> 
> Works.
> 
> The weekday names look a bit awkward now
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/a065dfcf-ca75-4d50-81aa-4d725245344e__Screenshot_20160201_234605.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

2016-02-01 Thread andreas kainz 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126960/#review91904
---



can you add an screenshot with the week names?

- andreas kainz


On Feb. 1, 2016, 11:12 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126960/
> ---
> 
> (Updated Feb. 1, 2016, 11:12 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Bugs: 336124, 348362 and 358536
> http://bugs.kde.org/show_bug.cgi?id=336124
> http://bugs.kde.org/show_bug.cgi?id=348362
> http://bugs.kde.org/show_bug.cgi?id=358536
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This removes the custom label-based triangles and replaces them with proper 
> ToolButtons using proper icons. It also adds a "Today" button to return to 
> the current day. Also, tooltips that reflect the actual action ("Previous 
> Month", "Previous Year", "Previous Decade", depending on the zoom level) were 
> added.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 3ab16eb 
>   src/declarativeimports/calendar/qml/MonthView.qml c876e3b 
> 
> Diff: https://git.reviewboard.kde.org/r/126960/diff/
> 
> 
> Testing
> ---
> 
> Works.
> 
> The weekday names look a bit awkward now
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/a065dfcf-ca75-4d50-81aa-4d725245344e__Screenshot_20160201_234605.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

2016-02-01 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126960/
---

Review request for Plasma and KDE Usability.


Bugs: 336124, 348362 and 358536
http://bugs.kde.org/show_bug.cgi?id=336124
http://bugs.kde.org/show_bug.cgi?id=348362
http://bugs.kde.org/show_bug.cgi?id=358536


Repository: plasma-framework


Description
---

This removes the custom label-based triangles and replaces them with proper 
ToolButtons using proper icons. It also adds a "Today" button to return to the 
current day. Also, tooltips that reflect the actual action ("Previous Month", 
"Previous Year", "Previous Decade", depending on the zoom level) were added.


Diffs
-

  src/declarativeimports/calendar/qml/DaysCalendar.qml 3ab16eb 
  src/declarativeimports/calendar/qml/MonthView.qml c876e3b 

Diff: https://git.reviewboard.kde.org/r/126960/diff/


Testing
---

Works.


File Attachments


Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/a065dfcf-ca75-4d50-81aa-4d725245344e__Screenshot_20160201_234605.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

2016-02-01 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126960/
---

(Updated Feb. 1, 2016, 11:12 nachm.)


Review request for Plasma and KDE Usability.


Bugs: 336124, 348362 and 358536
http://bugs.kde.org/show_bug.cgi?id=336124
http://bugs.kde.org/show_bug.cgi?id=348362
http://bugs.kde.org/show_bug.cgi?id=358536


Repository: plasma-framework


Description
---

This removes the custom label-based triangles and replaces them with proper 
ToolButtons using proper icons. It also adds a "Today" button to return to the 
current day. Also, tooltips that reflect the actual action ("Previous Month", 
"Previous Year", "Previous Decade", depending on the zoom level) were added.


Diffs
-

  src/declarativeimports/calendar/qml/DaysCalendar.qml 3ab16eb 
  src/declarativeimports/calendar/qml/MonthView.qml c876e3b 

Diff: https://git.reviewboard.kde.org/r/126960/diff/


Testing (updated)
---

Works.

The weekday names look a bit awkward now


File Attachments


Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/a065dfcf-ca75-4d50-81aa-4d725245344e__Screenshot_20160201_234605.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

2016-02-01 Thread Andrew Lake 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126960/#review91907
---



Nice improvement. If the week numbers look ok then +1 from me.

- Andrew Lake


On Feb. 1, 2016, 11:12 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126960/
> ---
> 
> (Updated Feb. 1, 2016, 11:12 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Bugs: 336124, 348362 and 358536
> http://bugs.kde.org/show_bug.cgi?id=336124
> http://bugs.kde.org/show_bug.cgi?id=348362
> http://bugs.kde.org/show_bug.cgi?id=358536
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This removes the custom label-based triangles and replaces them with proper 
> ToolButtons using proper icons. It also adds a "Today" button to return to 
> the current day. Also, tooltips that reflect the actual action ("Previous 
> Month", "Previous Year", "Previous Decade", depending on the zoom level) were 
> added.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 3ab16eb 
>   src/declarativeimports/calendar/qml/MonthView.qml c876e3b 
> 
> Diff: https://git.reviewboard.kde.org/r/126960/diff/
> 
> 
> Testing
> ---
> 
> Works.
> 
> The weekday names look a bit awkward now
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/a065dfcf-ca75-4d50-81aa-4d725245344e__Screenshot_20160201_234605.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel