Re: Review Request 128892: Open baloo lmdb database read-only beside in baloo_file/baloo_file_extractor + balooctl (for some commands) + unit tests
> On Sept. 11, 2016, 9:35 p.m., Vishesh Handa wrote: > > This is awesome. Ship it. > > Christoph Cullmann wrote: > Lets hope it is awesome correct. :D - Milian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128892/#review99115 --- On Sept. 11, 2016, 9:39 p.m., Christoph Cullmann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128892/ > --- > > (Updated Sept. 11, 2016, 9:39 p.m.) > > > Review request for KDE Frameworks, Plasma, Boudhayan Gupta, and Vishesh Handa. > > > Repository: baloo > > > Description > --- > > At the moment, any application that uses baloo can corrupt the db. > Now, only the things that need to write to it open it with read-write. > This only works as long as the library exposes only read-only things like > Query/... > > > Diffs > - > > src/engine/database.h 6ccb2a5 > src/engine/database.cpp 6a433c7 > src/file/extractor/app.cpp 0ca7276 > src/lib/file.cpp cbbc912 > src/lib/searchstore.cpp 060a4fd > src/lib/taglistjob.cpp 76ac8ff > src/qml/experimental/monitor.cpp 11c06ae > src/tools/balooctl/main.cpp 2a6b175 > src/tools/balooctl/statuscommand.cpp 1a56c64 > src/tools/balooshow/main.cpp f45f2e0 > > Diff: https://git.reviewboard.kde.org/r/128892/diff/ > > > Testing > --- > > Unit tests still work, balooctl seems to do something. > > > Thanks, > > Christoph Cullmann > >
Re: Review Request 128892: Open baloo lmdb database read-only beside in baloo_file/baloo_file_extractor + balooctl (for some commands) + unit tests
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128892/ --- (Updated Sept. 12, 2016, 12:39 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Plasma, Boudhayan Gupta, and Vishesh Handa. Changes --- Submitted with commit 02047b524a176da447d8c96e15c7e2abae8339ae by Christoph Cullmann to branch master. Repository: baloo Description --- At the moment, any application that uses baloo can corrupt the db. Now, only the things that need to write to it open it with read-write. This only works as long as the library exposes only read-only things like Query/... Diffs - src/engine/database.h 6ccb2a5 src/engine/database.cpp 6a433c7 src/file/extractor/app.cpp 0ca7276 src/lib/file.cpp cbbc912 src/lib/searchstore.cpp 060a4fd src/lib/taglistjob.cpp 76ac8ff src/qml/experimental/monitor.cpp 11c06ae src/tools/balooctl/main.cpp 2a6b175 src/tools/balooctl/statuscommand.cpp 1a56c64 src/tools/balooshow/main.cpp f45f2e0 Diff: https://git.reviewboard.kde.org/r/128892/diff/ Testing --- Unit tests still work, balooctl seems to do something. Thanks, Christoph Cullmann
Re: Review Request 128892: Open baloo lmdb database read-only beside in baloo_file/baloo_file_extractor + balooctl (for some commands) + unit tests
> On Sept. 11, 2016, 9:35 p.m., Vishesh Handa wrote: > > This is awesome. Ship it. Lets hope it is awesome correct. - Christoph --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128892/#review99115 --- On Sept. 11, 2016, 7:19 p.m., Christoph Cullmann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128892/ > --- > > (Updated Sept. 11, 2016, 7:19 p.m.) > > > Review request for KDE Frameworks, Plasma, Boudhayan Gupta, and Vishesh Handa. > > > Repository: baloo > > > Description > --- > > At the moment, any application that uses baloo can corrupt the db. > Now, only the things that need to write to it open it with read-write. > This only works as long as the library exposes only read-only things like > Query/... > > > Diffs > - > > src/engine/database.h 6ccb2a5 > src/engine/database.cpp 6a433c7 > src/file/extractor/app.cpp 0ca7276 > src/lib/file.cpp cbbc912 > src/lib/searchstore.cpp 060a4fd > src/lib/taglistjob.cpp 76ac8ff > src/qml/experimental/monitor.cpp 11c06ae > src/tools/balooctl/main.cpp 2a6b175 > src/tools/balooctl/statuscommand.cpp 1a56c64 > src/tools/balooshow/main.cpp f45f2e0 > > Diff: https://git.reviewboard.kde.org/r/128892/diff/ > > > Testing > --- > > Unit tests still work, balooctl seems to do something. > > > Thanks, > > Christoph Cullmann > >
Re: Review Request 128892: Open baloo lmdb database read-only beside in baloo_file/baloo_file_extractor + balooctl (for some commands) + unit tests
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128892/#review99115 --- Ship it! This is awesome. Ship it. - Vishesh Handa On Sept. 11, 2016, 7:19 p.m., Christoph Cullmann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128892/ > --- > > (Updated Sept. 11, 2016, 7:19 p.m.) > > > Review request for KDE Frameworks, Plasma, Boudhayan Gupta, and Vishesh Handa. > > > Repository: baloo > > > Description > --- > > At the moment, any application that uses baloo can corrupt the db. > Now, only the things that need to write to it open it with read-write. > This only works as long as the library exposes only read-only things like > Query/... > > > Diffs > - > > src/engine/database.h 6ccb2a5 > src/engine/database.cpp 6a433c7 > src/file/extractor/app.cpp 0ca7276 > src/lib/file.cpp cbbc912 > src/lib/searchstore.cpp 060a4fd > src/lib/taglistjob.cpp 76ac8ff > src/qml/experimental/monitor.cpp 11c06ae > src/tools/balooctl/main.cpp 2a6b175 > src/tools/balooctl/statuscommand.cpp 1a56c64 > src/tools/balooshow/main.cpp f45f2e0 > > Diff: https://git.reviewboard.kde.org/r/128892/diff/ > > > Testing > --- > > Unit tests still work, balooctl seems to do something. > > > Thanks, > > Christoph Cullmann > >
Re: Review Request 128892: Open baloo lmdb database read-only beside in baloo_file/baloo_file_extractor + balooctl (for some commands) + unit tests
> On Sept. 11, 2016, 7:19 p.m., Boudhayan Gupta wrote: > > Can you add Vishesh and poke him if possible? This seems like a gigantic > > patch and I'm not sure I understand all of it right now. Hi, I can poke him, sure. Given there is no documentation what the things shall do, I am not 100% sure if that is perfect, myself. On the other side: ATM all things open the database read-write, which imho is VERY bad. - Christoph --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128892/#review99110 --- On Sept. 11, 2016, 7:19 p.m., Christoph Cullmann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128892/ > --- > > (Updated Sept. 11, 2016, 7:19 p.m.) > > > Review request for KDE Frameworks, Plasma, Boudhayan Gupta, and Vishesh Handa. > > > Repository: baloo > > > Description > --- > > At the moment, any application that uses baloo can corrupt the db. > Now, only the things that need to write to it open it with read-write. > This only works as long as the library exposes only read-only things like > Query/... > > > Diffs > - > > src/engine/database.h 6ccb2a5 > src/engine/database.cpp 6a433c7 > src/file/extractor/app.cpp 0ca7276 > src/lib/file.cpp cbbc912 > src/lib/searchstore.cpp 060a4fd > src/lib/taglistjob.cpp 76ac8ff > src/qml/experimental/monitor.cpp 11c06ae > src/tools/balooctl/main.cpp 2a6b175 > src/tools/balooctl/statuscommand.cpp 1a56c64 > src/tools/balooshow/main.cpp f45f2e0 > > Diff: https://git.reviewboard.kde.org/r/128892/diff/ > > > Testing > --- > > Unit tests still work, balooctl seems to do something. > > > Thanks, > > Christoph Cullmann > >
Re: Review Request 128892: Open baloo lmdb database read-only beside in baloo_file/baloo_file_extractor + balooctl (for some commands) + unit tests
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128892/#review99110 --- Can you add Vishesh and poke him if possible? This seems like a gigantic patch and I'm not sure I understand all of it right now. - Boudhayan Gupta On Sept. 12, 2016, 12:42 a.m., Christoph Cullmann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128892/ > --- > > (Updated Sept. 12, 2016, 12:42 a.m.) > > > Review request for KDE Frameworks, Plasma and Boudhayan Gupta. > > > Repository: baloo > > > Description > --- > > At the moment, any application that uses baloo can corrupt the db. > Now, only the things that need to write to it open it with read-write. > This only works as long as the library exposes only read-only things like > Query/... > > > Diffs > - > > src/engine/database.h 6ccb2a5 > src/engine/database.cpp 6a433c7 > src/file/extractor/app.cpp 0ca7276 > src/lib/file.cpp cbbc912 > src/lib/searchstore.cpp 060a4fd > src/lib/taglistjob.cpp 76ac8ff > src/qml/experimental/monitor.cpp 11c06ae > src/tools/balooctl/main.cpp 2a6b175 > src/tools/balooctl/statuscommand.cpp 1a56c64 > src/tools/balooshow/main.cpp f45f2e0 > > Diff: https://git.reviewboard.kde.org/r/128892/diff/ > > > Testing > --- > > Unit tests still work, balooctl seems to do something. > > > Thanks, > > Christoph Cullmann > >
Review Request 128892: Open baloo lmdb database read-only beside in baloo_file/baloo_file_extractor + balooctl (for some commands) + unit tests
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128892/ --- Review request for KDE Frameworks, Plasma and Boudhayan Gupta. Repository: baloo Description --- At the moment, any application that uses baloo can corrupt the db. Now, only the things that need to write to it open it with read-write. This only works as long as the library exposes only read-only things like Query/... Diffs - src/engine/database.h 6ccb2a5 src/engine/database.cpp 6a433c7 src/file/extractor/app.cpp 0ca7276 src/lib/file.cpp cbbc912 src/lib/searchstore.cpp 060a4fd src/lib/taglistjob.cpp 76ac8ff src/qml/experimental/monitor.cpp 11c06ae src/tools/balooctl/main.cpp 2a6b175 src/tools/balooctl/statuscommand.cpp 1a56c64 src/tools/balooshow/main.cpp f45f2e0 Diff: https://git.reviewboard.kde.org/r/128892/diff/ Testing --- Unit tests still work, balooctl seems to do something. Thanks, Christoph Cullmann
