Re: Pastebin Plasmoid Servers
On Sunday 14 November 2010 12:26:07 Nicolas Holvoet wrote: > Hello, > > I would like to configure the Pastebin plasmoid tu use uppix.net to share > pictures instead of imagebin.ca, but i can't find the directory where is > this plasmoid. Can you help me ? > > Thanks, Hi Nicolas, The pastebin plasmoid uses GHNS now (in trunk) and scripting and you can code your own backend and share it via http://kde-files.org/index.php?xcontentmode=677 The trunk dataengine (backend s) code can be browsed via websvn at the following url: http://websvn.kde.org/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/share/ So basically what you need to do is follow this for your new backend and make it available on kde-files.org. Hope this helps (thanks rrix for locating the new folder for the dataengine) Anne-Marie ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Pastebin Plasmoid Servers
Hello, I would like to configure the Pastebin plasmoid tu use uppix.net to share pictures instead of imagebin.ca, but i can't find the directory where is this plasmoid. Can you help me ? Thanks, ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: pastebin plasmoid.
On Friday 30 October 2009, 08:59 goodha...@gmail.com wrote: > Hello. Is it possible to tune plasmoid to return direct link to images? What do you mean by that ? The url to just the image ? Probably not as it would not be fair enough with the service provider as it "survives" with the ads it has on the webpage and visiting the webpage to see the picture helps them. Cheers, -- Artur Duque de Souza openBossa INdT - Instituto Nokia de Tecnologia -- Blog: http://blog.morpheuz.cc PGP: 0xDBEEAAC3 @ wwwkeys.pgp.net -- signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
pastebin plasmoid.
Hello. Is it possible to tune plasmoid to return direct link to images? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: adds private imagebin to the pastebin plasmoid This is my first patch, it just adds "posting private picture to imagebin.ca from the pastebin plasmoid" as the title says, it needs
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1248/ --- (Updated 2009-08-09 23:07:05.234126) Review request for Plasma. Changes --- oops, removed servers config page Summary --- This is my first patch, it just adds "posting private picture to imagebin.ca from the pastebin plasmoid" as the title says, it needs to be applied from kdeplasma-addons, hope it works for you. Diffs (updated) - /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinConfig.ui 1008583 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 1008583 /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/imagebinca.h 1008583 /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/imagebinca.cpp 1008583 Diff: http://reviewboard.kde.org/r/1248/diff Testing --- Screenshots --- now in the main config page http://reviewboard.kde.org/r/1248/s/169/ Thanks, patcito ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: adds private imagebin to the pastebin plasmoid This is my first patch, it just adds "posting private picture to imagebin.ca from the pastebin plasmoid" as the title says, it needs
> On 2009-08-09 22:59:47, Chani wrote: > > looks good, only thing I can think of is we might want to hide the privacy > > option when imageshack is selected, since it doesn't apply to that site. > > > > I assume you need someone to commit this for you? I've gotta run now, > > someone please take care of that :) Hiding the privacy will be for next week I think :/ Otherwise you can commit as is for now, thanks for you help. By the way is there a minimum amount of patches I have to send before I can ask/get an svn account? :) > On 2009-08-09 22:59:47, Chani wrote: > > /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt, line 12 > > <http://reviewboard.kde.org/r/1248/diff/2/?file=9813#file9813line12> > > > > looks like you deleted this by accident heh, yep fixed, thanks. - patcito --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1248/#review1945 --- On 2009-08-09 22:00:52, patcito wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1248/ > --- > > (Updated 2009-08-09 22:00:52) > > > Review request for Plasma. > > > Summary > --- > > This is my first patch, it just adds "posting private picture to > imagebin.ca from the pastebin plasmoid" as the title says, it needs to > be applied from kdeplasma-addons, hope it works for you. > > > Diffs > - > > /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt 1008583 > /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/imagebinca.h 1008583 > /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/imagebinca.cpp > 1008583 > /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 1008583 > /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinConfig.ui 1008583 > > Diff: http://reviewboard.kde.org/r/1248/diff > > > Testing > --- > > > Screenshots > --- > > now in the main config page > http://reviewboard.kde.org/r/1248/s/169/ > > > Thanks, > > patcito > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: adds private imagebin to the pastebin plasmoid This is my first patch, it just adds "posting private picture to imagebin.ca from the pastebin plasmoid" as the title says, it needs
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1248/#review1945 --- Ship it! looks good, only thing I can think of is we might want to hide the privacy option when imageshack is selected, since it doesn't apply to that site. I assume you need someone to commit this for you? I've gotta run now, someone please take care of that :) /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt <http://reviewboard.kde.org/r/1248/#comment1302> looks like you deleted this by accident - Chani On 2009-08-09 22:00:52, patcito wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1248/ > --- > > (Updated 2009-08-09 22:00:52) > > > Review request for Plasma. > > > Summary > --- > > This is my first patch, it just adds "posting private picture to > imagebin.ca from the pastebin plasmoid" as the title says, it needs to > be applied from kdeplasma-addons, hope it works for you. > > > Diffs > - > > /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt 1008583 > /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/imagebinca.h 1008583 > /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/imagebinca.cpp > 1008583 > /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 1008583 > /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinConfig.ui 1008583 > > Diff: http://reviewboard.kde.org/r/1248/diff > > > Testing > --- > > > Screenshots > --- > > now in the main config page > http://reviewboard.kde.org/r/1248/s/169/ > > > Thanks, > > patcito > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: adds private imagebin to the pastebin plasmoid This is my first patch, it just adds "posting private picture to imagebin.ca from the pastebin plasmoid" as the title says, it needs
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1248/ --- (Updated 2009-08-09 22:00:52.198524) Review request for Plasma. Changes --- now in the main config page Summary --- This is my first patch, it just adds "posting private picture to imagebin.ca from the pastebin plasmoid" as the title says, it needs to be applied from kdeplasma-addons, hope it works for you. Diffs - /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt 1008583 /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/imagebinca.h 1008583 /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/imagebinca.cpp 1008583 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 1008583 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinConfig.ui 1008583 Diff: http://reviewboard.kde.org/r/1248/diff Testing --- Screenshots (updated) --- now in the main config page http://reviewboard.kde.org/r/1248/s/169/ Thanks, patcito ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: adds private imagebin to the pastebin plasmoid This is my first patch, it just adds "posting private picture to imagebin.ca from the pastebin plasmoid" as the title says, it needs
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1248/ --- (Updated 2009-08-09 21:57:43.218738) Review request for Plasma. Changes --- I added Chani's suggestions. Summary --- This is my first patch, it just adds "posting private picture to imagebin.ca from the pastebin plasmoid" as the title says, it needs to be applied from kdeplasma-addons, hope it works for you. Diffs (updated) - /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt 1008583 /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/imagebinca.h 1008583 /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/imagebinca.cpp 1008583 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 1008583 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinConfig.ui 1008583 Diff: http://reviewboard.kde.org/r/1248/diff Testing --- Screenshots --- servers options config http://reviewboard.kde.org/r/1248/s/168/ Thanks, patcito ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: adds private imagebin to the pastebin plasmoid This is my first patch, it just adds "posting private picture to imagebin.ca from the pastebin plasmoid" as the title says, it needs
> On 2009-08-09 20:59:45, Chani wrote: > > hmm. I just noticed it's only for imagebin.ca not imageshack.us - are you > > able to make it work for both servers? :) (if you can, then let's use the > > same config option, i don't see any reason to make users set image privacy > > twice.) I may be wrong but I think that on imageshack.us all pictures are private, they don't appear on the front page, you actually have to know the URL (which is the same as the private option for imagebin.ca). > On 2009-08-09 20:59:45, Chani wrote: > > /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt, line 3 > > <http://reviewboard.kde.org/r/1248/diff/1/?file=9780#file9780line3> > > > > not sure what this is doing here. slipped in by accident? I was trying to compile from that directory at first so I added that, I'll remove it. > On 2009-08-09 20:59:45, Chani wrote: > > /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt, line 16 > > <http://reviewboard.kde.org/r/1248/diff/1/?file=9780#file9780line16> > > > > ehh... I still feel like the config could go on the main page. Ok, I'll move it there. > On 2009-08-09 20:59:45, Chani wrote: > > /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/imagebinca.cpp, line > > 38 > > <http://reviewboard.kde.org/r/1248/diff/1/?file=9782#file9782line38> > > > > 0 not "0" Fixing. > On 2009-08-09 20:59:45, Chani wrote: > > /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp, line 471 > > <http://reviewboard.kde.org/r/1248/diff/1/?file=9784#file9784line471> > > > > use 0 not "0" so that it doesn't have to convert from a string Fixing too. - patcito --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1248/#review1940 --- On 2009-08-09 20:13:23, patcito wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1248/ > --- > > (Updated 2009-08-09 20:13:23) > > > Review request for Plasma. > > > Summary > --- > > This is my first patch, it just adds "posting private picture to > imagebin.ca from the pastebin plasmoid" as the title says, it needs to > be applied from kdeplasma-addons, hope it works for you. > > > Diffs > - > > /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt 1008583 > /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/imagebinca.h 1008583 > /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/imagebinca.cpp > 1008583 > /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 1008583 > /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 1008583 > > /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinServersOptionsConfig.ui > PRE-CREATION > > Diff: http://reviewboard.kde.org/r/1248/diff > > > Testing > --- > > > Screenshots > --- > > servers options config > http://reviewboard.kde.org/r/1248/s/168/ > > > Thanks, > > patcito > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: adds private imagebin to the pastebin plasmoid This is my first patch, it just adds "posting private picture to imagebin.ca from the pastebin plasmoid" as the title says, it needs
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1248/#review1940 --- Ship it! hmm. I just noticed it's only for imagebin.ca not imageshack.us - are you able to make it work for both servers? :) (if you can, then let's use the same config option, i don't see any reason to make users set image privacy twice.) /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt <http://reviewboard.kde.org/r/1248/#comment1289> not sure what this is doing here. slipped in by accident? /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt <http://reviewboard.kde.org/r/1248/#comment1293> ehh... I still feel like the config could go on the main page. /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/imagebinca.cpp <http://reviewboard.kde.org/r/1248/#comment1288> 0 not "0" /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp <http://reviewboard.kde.org/r/1248/#comment1287> use 0 not "0" so that it doesn't have to convert from a string /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp <http://reviewboard.kde.org/r/1248/#comment1294> "Server Options" :) - Chani On 2009-08-09 20:13:23, patcito wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1248/ > --- > > (Updated 2009-08-09 20:13:23) > > > Review request for Plasma. > > > Summary > --- > > This is my first patch, it just adds "posting private picture to > imagebin.ca from the pastebin plasmoid" as the title says, it needs to > be applied from kdeplasma-addons, hope it works for you. > > > Diffs > - > > /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt 1008583 > /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/imagebinca.h 1008583 > /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/imagebinca.cpp > 1008583 > /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 1008583 > /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 1008583 > > /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinServersOptionsConfig.ui > PRE-CREATION > > Diff: http://reviewboard.kde.org/r/1248/diff > > > Testing > --- > > > Screenshots > --- > > servers options config > http://reviewboard.kde.org/r/1248/s/168/ > > > Thanks, > > patcito > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [PATCH] Adds posting private picture to imagebin.ca from the pastebin plasmoid
oops, forgot to hit the publish button, should be up now http://reviewboard.kde.org/r/1248/ On Sun, Aug 9, 2009 at 3:00 PM, Patrick Aljord wrote: > http://reviewboard.kde.org/r/1248/ here is the diff with the > imagebinPrivacy always as int. > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: adds private imagebin to the pastebin plasmoid This is my first patch, it just adds "posting private picture to imagebin.ca from the pastebin plasmoid" as the title says, it needs to b
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1248/ --- Review request for Plasma. Summary --- This is my first patch, it just adds "posting private picture to imagebin.ca from the pastebin plasmoid" as the title says, it needs to be applied from kdeplasma-addons, hope it works for you. Diffs - /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt 1008583 /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/imagebinca.h 1008583 /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/imagebinca.cpp 1008583 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 1008583 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 1008583 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinServersOptionsConfig.ui PRE-CREATION Diff: http://reviewboard.kde.org/r/1248/diff Testing --- Screenshots --- servers options config http://reviewboard.kde.org/r/1248/s/168/ Thanks, patcito ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [PATCH] Adds posting private picture to imagebin.ca from the pastebin plasmoid
http://reviewboard.kde.org/r/1248/ here is the diff with the imagebinPrivacy always as int. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [PATCH] Adds posting private picture to imagebin.ca from the pastebin plasmoid
On August 9, 2009 12:42:30 Patrick Aljord wrote: > On Sat, Aug 8, 2009 at 1:56 PM, Chani wrote: > > kompare won't load the diff for some reason... > > I used the techbase tutorial here > http://techbase.kde.org/Contribute/Send_Patches#Creating_a_Simple_File_Patc >h and used that command: > > svn diff --diff-cmd diff --extensions "-u -p" huh. I just use svn diff. :) it's possible the problem was with trying to load a file from kmail, and not with the diff itself. -- This message brought to you by eevil bananas and the number 3. www.chani3.com signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [PATCH] Adds posting private picture to imagebin.ca from the pastebin plasmoid
On Sat, Aug 8, 2009 at 1:56 PM, Chani wrote: > > kompare won't load the diff for some reason... I used the techbase tutorial here http://techbase.kde.org/Contribute/Send_Patches#Creating_a_Simple_File_Patch and used that command: svn diff --diff-cmd diff --extensions "-u -p" ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [PATCH] Adds posting private picture to imagebin.ca from the pastebin plasmoid
I was thinking with time we could add more options for alll the different servers, then a new page would make sense, for now it's true that it looks empty. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [PATCH] Adds posting private picture to imagebin.ca from the pastebin plasmoid
On August 8, 2009 18:41:32 Patrick Aljord wrote: > Thanks to all for your comments. I haven't coded anything in C++ for > at least 3 years so I guess it shows :) > > I'll send the patch with your suggestions tomorrow, in the meantime > here is the screenshot http://imagebin.ca/view/fyaoR7T.html hmmm. I don't think we need a separate page for that option. there's not much on the first page, after all. actually I'm not too keen on the existing "servers" page either. a very odd way to allow people to use other servers... I wonder why it was done that way... -- This message brought to you by eevil bananas and the number 3. www.chani3.com signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [PATCH] Adds posting private picture to imagebin.ca from the pastebin plasmoid
Thanks to all for your comments. I haven't coded anything in C++ for at least 3 years so I guess it shows :) I'll send the patch with your suggestions tomorrow, in the meantime here is the screenshot http://imagebin.ca/view/fyaoR7T.html ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [PATCH] Adds posting private picture to imagebin.ca from the pastebin plasmoid
On Saturday 08 August 2009, 16:35 Chani wrote: > oh. > but we also have this: > int imagebinPrivacy = uiServersOptions.imagebinPrivacy->currentIndex(); > > so, either make it always an int, or make it an enum. don't use a string. > especially a string that just contains a number anyways... +1 for always int -- Artur Duque de Souza openBossa Research Labs INdT - Instituto Nokia de Tecnologia -- Blog: http://blog.morpheuz.cc PGP: 0xDBEEAAC3 @ wwwkeys.pgp.net -- signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [PATCH] Adds posting private picture to imagebin.ca from the pastebin plasmoid
> > one thing I don't get is how you managed to use a string ("0") as the
> > default value for an int ;)
>
> +QString m_privacy;
>
> m_privacy seems to be a QString :)
oh.
but we also have this:
int imagebinPrivacy = uiServersOptions.imagebinPrivacy->currentIndex();
so, either make it always an int, or make it an enum. don't use a string.
especially a string that just contains a number anyways...
--
This message brought to you by eevil bananas and the number 3.
www.chani3.com
signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [PATCH] Adds posting private picture to imagebin.ca from the pastebin plasmoid
On Saturday 08 August 2009, 13:40 Patrick Aljord wrote:
> This is my first patch, it just adds "posting private picture to
> imagebin.ca from the pastebin plasmoid" as the title says, it needs to
> be applied from kdeplasma-addons, hope it works for you.
Thanks for the patch! As Chani asked, can you provide a screenshot of the
config
dialog ?
Some comments on code:
Index: applets/pastebin/backends/imagebinca.h
===
--- applets/pastebin/backends/imagebinca.h (revision 1008583)
+++ applets/pastebin/backends/imagebinca.h (working copy)
@@ -42,6 +42,8 @@ public:
void finish();
bool addPair(const QString& name, const QString& value);
bool addFile(const QString& name,const QString& path);
+QString adult;
It seems that you do not need to store this string in the object and can
declare it when you setup this string, something like this:
QString adult;
+if(m_privacy == "0"){
+ adult = "f";
+} else {
+ adult = "t";
+}
> one thing I don't get is how you managed to use a string ("0") as the default
> value for an int ;)
+QString m_privacy;
m_privacy seems to be a QString :)
Cheers!
--
Artur Duque de Souza
openBossa Research Labs
INdT - Instituto Nokia de Tecnologia
--
Blog: http://blog.morpheuz.cc
PGP: 0xDBEEAAC3 @ wwwkeys.pgp.net
--
signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [PATCH] Adds posting private picture to imagebin.ca from the pastebin plasmoid
On August 8, 2009 09:40:28 Patrick Aljord wrote:
> Hey all,
>
> This is my first patch, it just adds "posting private picture to
> imagebin.ca from the pastebin plasmoid" as the title says, it needs to
> be applied from kdeplasma-addons, hope it works for you.
>
> Cheers,
>
> Pat
thanks for the patch :)
the code looks generally ok, although kompare won't load the diff for some
reason...
one thing I don't get is how you managed to use a string ("0") as the default
value for an int ;)
can you give us a screenshot of the new config?
btw, next time put your patch on reviewboard.kde.org, less chance of us losing
it there :)
--
This message brought to you by eevil bananas and the number 3.
www.chani3.com
signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[PATCH] Adds posting private picture to imagebin.ca from the pastebin plasmoid
Hey all,
This is my first patch, it just adds "posting private picture to
imagebin.ca from the pastebin plasmoid" as the title says, it needs to
be applied from kdeplasma-addons, hope it works for you.
Cheers,
Pat
Index: applets/pastebin/pastebin.cpp
===
--- applets/pastebin/pastebin.cpp (revision 1008583)
+++ applets/pastebin/pastebin.cpp (working copy)
@@ -463,6 +463,15 @@ void Pastebin::createConfigurationInterf
QString imageshackURL = cg.readEntry("imageshack", "http://imageshack.us";);
uiServers.imageshack->setText(imageshackURL);
+
+uiConfig.textServer->setCurrentIndex(m_textBackend);
+
+QWidget *serversoptions = new QWidget();
+uiServersOptions.setupUi(serversoptions);
+int imagebinPrivacy = cg.readEntry("imagebinPrivacy", "0").toInt();
+uiServersOptions.imagebinPrivacy->setCurrentIndex(imagebinPrivacy);
+
+parent->addPage(serversoptions, i18n("Servers Options"), Applet::icon());
}
void Pastebin::configAccepted()
@@ -477,6 +486,8 @@ void Pastebin::configAccepted()
QString imagebincaURL = uiServers.imagebinca->text();
QString imageshackURL = uiServers.imageshack->text();
+int imagebinPrivacy = uiServersOptions.imagebinPrivacy->currentIndex();
+
cg.writeEntry("TextBackend", textBackend);
cg.writeEntry("ImageBackend", imageBackend);
cg.writeEntry("HistorySize", historySize);
@@ -486,6 +497,8 @@ void Pastebin::configAccepted()
cg.writeEntry("imagebinca", imagebincaURL);
cg.writeEntry("imageshack", imageshackURL);
+cg.writeEntry("imagebinPrivacy", imagebinPrivacy);
+
setTextServer(textBackend);
setImageServer(imageBackend);
setHistorySize(historySize);
Index: applets/pastebin/backends/imagebinca.cpp
===
--- applets/pastebin/backends/imagebinca.cpp(revision 1008583)
+++ applets/pastebin/backends/imagebinca.cpp(working copy)
@@ -35,8 +35,8 @@
ImagebinCAServer::ImagebinCAServer(const KConfigGroup& config)
: PastebinServer()
{
+m_privacy = config.readEntry("imagebinPrivacy", "0");
m_server = config.readEntry("imagebinca", "http://imagebin.ca";);
-
m_boundary = "--";
m_boundary += KRandom::randomString(42 + 13).toAscii();
}
@@ -168,10 +168,17 @@ void ImagebinCAServer::post(const QStrin
addPair("tags", "plasma");
url.addQueryItem("tags", "plasma");
-addPair("adult", "f");
-url.addQueryItem("adult", "f");
+if(m_privacy == "0"){
+ adult = "f";
+} else {
+ adult = "t";
+}
+
+addPair("adult", adult);
+url.addQueryItem("adult", adult);
addFile("f", content);
+
finish();
_data.clear();
Index: applets/pastebin/backends/imagebinca.h
===
--- applets/pastebin/backends/imagebinca.h (revision 1008583)
+++ applets/pastebin/backends/imagebinca.h (working copy)
@@ -42,6 +42,8 @@ public:
void finish();
bool addPair(const QString& name, const QString& value);
bool addFile(const QString& name,const QString& path);
+QString adult;
+QString m_privacy;
protected:
QByteArray m_buffer;
Index: applets/pastebin/pastebin.h
===
--- applets/pastebin/pastebin.h (revision 1008583)
+++ applets/pastebin/pastebin.h (working copy)
@@ -23,6 +23,7 @@
#include "backends/backends.h"
#include "ui_pastebinConfig.h"
#include "ui_pastebinServersConfig.h"
+#include "ui_pastebinServersOptionsConfig.h"
#include
#include
@@ -153,6 +154,7 @@ private:
Ui::pastebinConfig uiConfig;
Ui::pastebinServersConfig uiServers;
+Ui::pastebinServersOptionsConfig uiServersOptions;
};
K_EXPORT_PLASMA_APPLET(pastebin, Pastebin)
Index: applets/pastebin/CMakeLists.txt
===
--- applets/pastebin/CMakeLists.txt (revision 1008583)
+++ applets/pastebin/CMakeLists.txt (working copy)
@@ -1,5 +1,8 @@
project(plasma-pastebin)
+cmake_minimum_required(VERSION 2.6)
+find_package(KDE4 REQUIRED)
+
set(pastebin_SRCS
backends/server.cpp
backends/pastebinca.cpp
@@ -10,6 +13,7 @@ set(pastebin_SRCS
kde4_add_ui_files(pastebin_SRCS pastebinConfig.ui)
kde4_add_ui_files(pastebin_SRCS pastebinServersConfig.ui)
+kde4_add_ui_files(pastebin_SRCS pastebinServersOptionsConfig.ui)
kde4_add_plugin(plasma_applet_pastebin ${pastebin_SRCS})
target_link_libraries(plasma_applet_pastebin ${KDE4_PLASMA_
Re: Review Request: Adding history to pastebin plasmoid.
On Tuesday 31 March 2009 12:42:12 Aaron Seigo wrote: > Ship it! > case, the code looks alright... thanks for the patch, please commit. If you do not have commit access, just tell me and I can commit for you =) Cheers, -- Artur Duque de Souza OpenBossa Research Labs INdT - Instituto Nokia de Tecnologia -- Blog: http://labs.morpheuz.eng.br/blog/ GPG: 0xDBEEAAC3 @ wwwkeys.pgp.net -- signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Adding history to pastebin plasmoid.
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/483/#review755 --- Ship it! i'm really not sold on the bottom separator; that should be up to the Applet/Containment to make it fit properly into the overall menu. in any case, the code looks alright... thanks for the patch, please commit. - Aaron On 2009-03-31 04:38:08, Danilo Cesar Lemes de Paula wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/483/ > --- > > (Updated 2009-03-31 04:38:08) > > > Review request for Plasma. > > > Summary > --- > > Adding history to pastebin plasmoid. > > Plasmoid should show the last 3 links shown by the plasmoid (when you click > with the right button), and it should be copied to clipboard when user click > on it. > > > Diffs > - > > trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 945384 > trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 945384 > > Diff: http://reviewboard.kde.org/r/483/diff > > > Testing > --- > > > > > Thanks, > > Danilo Cesar > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Adding history to pastebin plasmoid.
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/483/#review753 --- trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp <http://reviewboard.kde.org/r/483/#comment450> Yes. topSeparator was used to separate "Paste" action from "Pastebin Settings". As I'm adding new items under that action, it would be nice to have another separator on the bottom at that list. - Danilo Cesar On 2009-03-31 04:38:08, Danilo Cesar Lemes de Paula wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/483/ > --- > > (Updated 2009-03-31 04:38:08) > > > Review request for Plasma. > > > Summary > --- > > Adding history to pastebin plasmoid. > > Plasmoid should show the last 3 links shown by the plasmoid (when you click > with the right button), and it should be copied to clipboard when user click > on it. > > > Diffs > - > > trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 945384 > trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 945384 > > Diff: http://reviewboard.kde.org/r/483/diff > > > Testing > --- > > > > > Thanks, > > Danilo Cesar > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Adding history to pastebin plasmoid.
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/483/ --- (Updated 2009-03-31 04:38:08.731243) Review request for Plasma. Changes --- Fixing minor issues (KDE coding style) Summary --- Adding history to pastebin plasmoid. Plasmoid should show the last 3 links shown by the plasmoid (when you click with the right button), and it should be copied to clipboard when user click on it. Diffs (updated) - trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 945384 trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 945384 Diff: http://reviewboard.kde.org/r/483/diff Testing --- Thanks, Danilo Cesar ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Adding history to pastebin plasmoid.
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/483/#review744 --- a few minor things, but the patch looks good in general :) trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h <http://reviewboard.kde.org/r/483/#comment444> nitpick: no space after the * :) trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp <http://reviewboard.kde.org/r/483/#comment447> !m_paste trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp <http://reviewboard.kde.org/r/483/#comment445> please use ! instead of 'not' trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp <http://reviewboard.kde.org/r/483/#comment448> !m_bottomSeparator trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp <http://reviewboard.kde.org/r/483/#comment446> is the bottom separator really necessary? one should be provided by the caller of this method if it is... - Aaron On 2009-03-30 12:35:21, Danilo Cesar Lemes de Paula wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/483/ > --- > > (Updated 2009-03-30 12:35:21) > > > Review request for Plasma. > > > Summary > --- > > Adding history to pastebin plasmoid. > > Plasmoid should show the last 3 links shown by the plasmoid (when you click > with the right button), and it should be copied to clipboard when user click > on it. > > > Diffs > - > > trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 945384 > trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 945384 > > Diff: http://reviewboard.kde.org/r/483/diff > > > Testing > --- > > > > > Thanks, > > Danilo Cesar > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Adding history to pastebin plasmoid.
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/483/ --- (Updated 2009-03-30 12:35:21.706314) Review request for Plasma. Changes --- including QMap is unnecessary. Summary --- Adding history to pastebin plasmoid. Plasmoid should show the last 3 links shown by the plasmoid (when you click with the right button), and it should be copied to clipboard when user click on it. Diffs (updated) - trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 945384 trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 945384 Diff: http://reviewboard.kde.org/r/483/diff Testing --- Thanks, Danilo Cesar ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Adding history to pastebin plasmoid.
> On 2009-03-30 12:06:16, Danilo Cesar Lemes de Paula wrote: > > Maybe the logic between lines 564 and 580 could be replaced by a > > QSignalmapper. I will work on that. Done! See diff r_2! - Danilo Cesar --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/483/#review739 --- On 2009-03-30 12:27:02, Danilo Cesar Lemes de Paula wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/483/ > --- > > (Updated 2009-03-30 12:27:02) > > > Review request for Plasma. > > > Summary > --- > > Adding history to pastebin plasmoid. > > Plasmoid should show the last 3 links shown by the plasmoid (when you click > with the right button), and it should be copied to clipboard when user click > on it. > > > Diffs > - > > trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 945384 > trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 945384 > > Diff: http://reviewboard.kde.org/r/483/diff > > > Testing > --- > > > > > Thanks, > > Danilo Cesar > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Adding history to pastebin plasmoid.
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/483/ --- (Updated 2009-03-30 12:27:02.315631) Review request for Plasma. Changes --- I changed the signals logic to use a QSignalMapper instead of another list with QActions. With SignalMapper we can call copyToClipboard directly, and the historyClicked slot is unnecessary. Summary --- Adding history to pastebin plasmoid. Plasmoid should show the last 3 links shown by the plasmoid (when you click with the right button), and it should be copied to clipboard when user click on it. Diffs (updated) - trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 945384 trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 945384 Diff: http://reviewboard.kde.org/r/483/diff Testing --- Thanks, Danilo Cesar ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Adding history to pastebin plasmoid.
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/483/#review739 --- Maybe the logic between lines 564 and 580 could be replaced by a QSignalmapper. I will work on that. - Danilo Cesar On 2009-03-30 11:08:15, Danilo Cesar Lemes de Paula wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/483/ > --- > > (Updated 2009-03-30 11:08:15) > > > Review request for Plasma. > > > Summary > --- > > Adding history to pastebin plasmoid. > > Plasmoid should show the last 3 links shown by the plasmoid (when you click > with the right button), and it should be copied to clipboard when user click > on it. > > > Diffs > - > > trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 945384 > trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 945384 > > Diff: http://reviewboard.kde.org/r/483/diff > > > Testing > --- > > > > > Thanks, > > Danilo Cesar > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Adding history to pastebin plasmoid.
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/483/ --- Review request for Plasma. Summary --- Adding history to pastebin plasmoid. Plasmoid should show the last 3 links shown by the plasmoid (when you click with the right button), and it should be copied to clipboard when user click on it. Diffs - trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 945384 trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 945384 Diff: http://reviewboard.kde.org/r/483/diff Testing --- Thanks, Danilo Cesar ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
