Chris
I could only guess that this is related to the new way how the JS files
of the plugins are compressed, using JSMinPlus. The check for custom
JS files under the config directories was there also before, now they
are just referenced in the phtml file at a different place.
That huge difference looks strange to me though.
Try the difference by replacing in incphp/js/js_session.php line 21
PMCommon::compressJavaScriptFile(...
with
PMCommon::compressJavaScriptFilePM(...
the latter is using the old hand-made compression as it was before, the
first uses the JSMinPlus library for that. If with the old function it
works fast again I will change it back to this.
Armin
On 08/16/2013 01:40 PM, Chris forum wrote:
Hi Armin,
I have just installed pmapper from trunk r1318 to test your
modifications on my project.
I didn't try to add any plugin custom JS file yet.
I don't know if it is the process to look for custom JS files or the new
JS compression tool, but with that pmapper release my project takes more
time to be loaded. Actually more than twice the time so I think it is
worth pointing that to you.
According to Firebug network tab:
release 1314: 1.7 sec (Thomas' last changes)
GET js_session.php?: 86ms
GET js_config.php?: 31ms
release 1318: 3.9 sec
GET js_session.php?: 2.46s
GET js_config.php?: 2.47s
Is it the price to pay for having a check at custom JS files?
If so, wasn't it possible to simply add references to such files in the
main phtml file?
Regards,
Chris
On Sat, Aug 10, 2013 at 12:23 PM, Armin Burger armin.bur...@gmail.com
mailto:armin.bur...@gmail.com wrote:
The JS custom files loading should now be solved with separate loading
of those files from the config directories. See changeset 1316
http://svn.pmapper.net/trac/changeset/1316
To use it you need to replace the files under incphp with the new
versions and add a line
echo $jsCustomReference;
in your map_xyz.phtml file as shown in the changeset link.
I also used now a more professional JS compression method via the
JSMinPlus tool. If someone experiences now problems with plugins and
their compressed JS code please let me know.
armin
On 07/26/2013 11:50 AM, Chris forum wrote:
Hi all,
Now that Thomas has updated several plugins, I realise I
shouldn't have
customized them in their own directories.
I am now trying to put my changes back into custom.css and
custom.js, in
order to not loose them at the next general update.
I am first trying to do that with the Coordinates plugin where I
have done
some modifications into coordinates.js.
So now there is a modded
*$.extend(PM.Plugin,
{
Coordinates:
{*
into my custom.js file, but it is not used/read by pmapper.
In order to have it taken into account, I have to delete that part in
coordinates.js
Am I doing this correctly?
Is there a way to have custom.js 'taking the lead' over the
plugins files?
What if a PHP file of a plugin needs to be modified?
Cheers,
Chris
--
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from
AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831iu=/4140/ostg.clktrk
___
pmapper-users mailing list
pmapper-users@lists.sourceforge.net
mailto:pmapper-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/pmapper-users
--
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with 2% overhead.
Download for free and get started troubleshooting in minutes.
http://pubads.g.doubleclick.net/gampad/clk?id=48897031iu=/4140/ostg.clktrk
___
pmapper-users mailing list
pmapper-users@lists.sourceforge.net
mailto:pmapper-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/pmapper-users
--
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with 2% overhead.
Download for free and get started troubleshooting in minutes.
