[pmd-commits] [pmd/pmd] 1ea2d5: Update documentation
Branch: refs/heads/gh-pages Home: https://github.com/pmd/pmd Commit: 1ea2d5efd2cfa1b2f9e7d32580ad48aa7f11e481 https://github.com/pmd/pmd/commit/1ea2d5efd2cfa1b2f9e7d32580ad48aa7f11e481 Author: PMD CI (pmd-bot) Date: 2021-10-22 (Fri, 22 Oct 2021) Changed paths: M feed.xml M pmd_rules_apex_codestyle.html Log Message: --- Update documentation https://github.com/pmd/pmd/actions/runs/1374062719 https://github.com/pmd/pmd/compare/142b8577500f...f543babca6e7 ___ Pmd-commits mailing list Pmd-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/pmd-commits
[pmd-commits] [pmd/pmd] 6737d7: Update documentation
Branch: refs/heads/gh-pages Home: https://github.com/pmd/pmd Commit: 6737d718ad2baa6ec1566dea3248efe7564e2395 https://github.com/pmd/pmd/commit/6737d718ad2baa6ec1566dea3248efe7564e2395 Author: PMD CI (pmd-bot) Date: 2021-10-22 (Fri, 22 Oct 2021) Changed paths: M feed.xml M pmd_rules_apex_errorprone.html Log Message: --- Update documentation https://github.com/pmd/pmd/actions/runs/1374055715 https://github.com/pmd/pmd/compare/0bc53fca8dbe...142b8577500f ___ Pmd-commits mailing list Pmd-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/pmd-commits
[pmd-commits] [pmd/pmd] 13dd78: Update documentation
Branch: refs/heads/gh-pages Home: https://github.com/pmd/pmd Commit: 13dd780cc9f6c9ef7b4f4ff8bf8316f0441b11b2 https://github.com/pmd/pmd/commit/13dd780cc9f6c9ef7b4f4ff8bf8316f0441b11b2 Author: PMD CI (pmd-bot) Date: 2021-10-22 (Fri, 22 Oct 2021) Changed paths: M feed.xml M pmd_rules_apex_security.html Log Message: --- Update documentation https://github.com/pmd/pmd/actions/runs/1374050670 https://github.com/pmd/pmd/compare/b9f53ef56af9...0bc53fca8dbe ___ Pmd-commits mailing list Pmd-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/pmd-commits
[pmd-commits] [pmd/pmd] c20db3: Issue 3570 - Added a new configuration property, '...
Branch: refs/heads/master Home: https://github.com/pmd/pmd Commit: c20db3388455aa921fc3b93e27ff23e9fdf95fb1 https://github.com/pmd/pmd/commit/c20db3388455aa921fc3b93e27ff23e9fdf95fb1 Author: Scott Wells Date: 2021-10-20 (Wed, 20 Oct 2021) Changed paths: M pmd-apex/src/main/resources/category/apex/codestyle.xml M pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/codestyle/xml/OneDeclarationPerLine.xml Log Message: --- Issue 3570 - Added a new configuration property, 'reportInForLoopInitializer', that if set to false (default is true if unspecified) doesn't report an issue for multiple declarations in a for loop initializer. Commit: f543babca6e70b92c0e26b81ac1518528ed10ceb https://github.com/pmd/pmd/commit/f543babca6e70b92c0e26b81ac1518528ed10ceb Author: Robert Sösemann <8180281+rsoesem...@users.noreply.github.com> Date: 2021-10-23 (Sat, 23 Oct 2021) Changed paths: M pmd-apex/src/main/resources/category/apex/codestyle.xml M pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/codestyle/xml/OneDeclarationPerLine.xml Log Message: --- Merge pull request #3575 from SCWells72/pmd-3570 [apex] Fix for #3570 - Added new configuration property reportInForLoopInitializer to OneDeclarationPerLine Compare: https://github.com/pmd/pmd/compare/142b8577500f...f543babca6e7 ___ Pmd-commits mailing list Pmd-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/pmd-commits
[pmd-commits] [pmd/pmd] ff6c17: Issue 3568 - Added a new configuration property, '...
Branch: refs/heads/master Home: https://github.com/pmd/pmd Commit: ff6c178108129a7574fdb07bb5868e17b9857d20 https://github.com/pmd/pmd/commit/ff6c178108129a7574fdb07bb5868e17b9857d20 Author: Scott Wells Date: 2021-10-20 (Wed, 20 Oct 2021) Changed paths: M pmd-apex/src/main/resources/category/apex/errorprone.xml M pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/errorprone/xml/EmptyStatementBlock.xml Log Message: --- Issue 3568 - Added a new configuration property, 'reportEmptyPrivateNoArgConstructor', that if set to false (default is true if unspecified) doesn't report an issue for empty private no-arg constructors that are commonly used in singleton and utility class implementations according to respective best practices. Commit: ddd310eb63c07f317c9504ecc5c03eeeabbef5c0 https://github.com/pmd/pmd/commit/ddd310eb63c07f317c9504ecc5c03eeeabbef5c0 Author: Scott Wells Date: 2021-10-20 (Wed, 20 Oct 2021) Changed paths: M pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/ast/ASTModifierNode.java M pmd-apex/src/main/resources/category/apex/errorprone.xml M pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/ast/SafeNavigationOperator.txt M pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/errorprone/xml/EmptyStatementBlock.xml Log Message: --- Issue 3568 - Added a new configuration property, 'reportEmptyVirtualMethod', that if set to false (default is true if unspecified) doesn't report an issue for empty virtual methods that are commonly used in abstract base classes as default no-op implementations when partial override/specialization is typical in derived classes. Commit: 142b8577500f631f67872f11ea9d2f9685353a1b https://github.com/pmd/pmd/commit/142b8577500f631f67872f11ea9d2f9685353a1b Author: Robert Sösemann <8180281+rsoesem...@users.noreply.github.com> Date: 2021-10-23 (Sat, 23 Oct 2021) Changed paths: M pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/ast/ASTModifierNode.java M pmd-apex/src/main/resources/category/apex/errorprone.xml M pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/ast/SafeNavigationOperator.txt M pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/errorprone/xml/EmptyStatementBlock.xml Log Message: --- Merge pull request #3573 from SCWells72/pmd-3568 [apex] Fix for #3568 - Added new configuration properties reportEmptyPrivateNoArgConstructor and reportEmptyVirtualMethod to EmptyStatementBlock Compare: https://github.com/pmd/pmd/compare/0bc53fca8dbe...142b8577500f ___ Pmd-commits mailing list Pmd-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/pmd-commits
[pmd-commits] [pmd/pmd] 98b647: Updated the rule documentation for the new config ...
Branch: refs/heads/master Home: https://github.com/pmd/pmd Commit: 98b6479ecb249c78c75a0368a771143b0a096cb6 https://github.com/pmd/pmd/commit/98b6479ecb249c78c75a0368a771143b0a096cb6 Author: Scott Wells Date: 2021-10-22 (Fri, 22 Oct 2021) Changed paths: M pmd-apex/src/main/resources/category/apex/security.xml Log Message: --- Updated the rule documentation for the new config params. Commit: 0bc53fca8dbe15b10d4b8984b1ce89bbefec9eb5 https://github.com/pmd/pmd/commit/0bc53fca8dbe15b10d4b8984b1ce89bbefec9eb5 Author: Robert Sösemann <8180281+rsoesem...@users.noreply.github.com> Date: 2021-10-23 (Sat, 23 Oct 2021) Changed paths: M pmd-apex/src/main/resources/category/apex/security.xml Log Message: --- Merge pull request #3578 from SCWells72/pmd-3576 [apex] Documentation changes for #3576 Compare: https://github.com/pmd/pmd/compare/b9f53ef56af9...0bc53fca8dbe ___ Pmd-commits mailing list Pmd-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/pmd-commits
[pmd-commits] [pmd/pmd] 9d6e20: Update documentation
Branch: refs/heads/gh-pages Home: https://github.com/pmd/pmd Commit: 9d6e20a60caace061912c4df92179e659fb606ed https://github.com/pmd/pmd/commit/9d6e20a60caace061912c4df92179e659fb606ed Author: PMD CI (pmd-bot) Date: 2021-10-22 (Fri, 22 Oct 2021) Changed paths: M feed.xml M pmd_rules_apex_security.html Log Message: --- Update documentation https://github.com/pmd/pmd/actions/runs/1373221098 https://github.com/pmd/pmd/compare/e67f2a04001a...b9f53ef56af9 ___ Pmd-commits mailing list Pmd-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/pmd-commits
[pmd-commits] [pmd/pmd] b84324: Issue 3576 - First commit for this work with suppo...
Branch: refs/heads/master Home: https://github.com/pmd/pmd Commit: b843242e47e26d1f33887cf5250705fd8e1b9e4c https://github.com/pmd/pmd/commit/b843242e47e26d1f33887cf5250705fd8e1b9e4c Author: Scott Wells Date: 2021-10-21 (Thu, 21 Oct 2021) Changed paths: M pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/security/ApexCRUDViolationRule.java M pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/security/xml/ApexCRUDViolation.xml Log Message: --- Issue 3576 - First commit for this work with support for most DML operations but not yet undelete (which doesn't seem to be supported at all yet) or merge, nor does it support read/query operations yet. I'll add those in subsequent commits, but I want to lay the foundation now that it seems to be in good shape. Commit: 4e1c17e2971494c05cea9b2f8c4d54debb2aab82 https://github.com/pmd/pmd/commit/4e1c17e2971494c05cea9b2f8c4d54debb2aab82 Author: Scott Wells Date: 2021-10-21 (Thu, 21 Oct 2021) Changed paths: M pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/security/ApexCRUDViolationRule.java M pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/security/xml/ApexCRUDViolation.xml Log Message: --- Added support for undelete (except for ESAPI which doesn't support it anyway) and merge. Updated unit tests for this enhancement to include a combination of DML statements and Database methods. Commit: 57626f44d2e878c9895d85778e366d7debf21dd8 https://github.com/pmd/pmd/commit/57626f44d2e878c9895d85778e366d7debf21dd8 Author: Scott Wells Date: 2021-10-21 (Thu, 21 Oct 2021) Changed paths: M pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/security/ApexCRUDViolationRule.java M pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/security/xml/ApexCRUDViolation.xml Log Message: --- Added tests for read/queries. Changed to use set-based multimaps as duplicate entries aren't useful. Commit: 2e0ea7161759ef1e7dff0e3e17566a1a157186d5 https://github.com/pmd/pmd/commit/2e0ea7161759ef1e7dff0e3e17566a1a157186d5 Author: Scott Wells Date: 2021-10-21 (Thu, 21 Oct 2021) Changed paths: M pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/security/ApexCRUDViolationRule.java Log Message: --- Minor clean-up from branch-to-branch merge. Commit: b07686ae437b611f38e28a69ec9813055260d6b2 https://github.com/pmd/pmd/commit/b07686ae437b611f38e28a69ec9813055260d6b2 Author: Scott Wells Date: 2021-10-21 (Thu, 21 Oct 2021) Changed paths: M pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/security/xml/ApexCRUDViolation.xml Log Message: --- Added a test to verify the *TypeParamIndex configuration properties. Commit: baad5701dc097e1cd8c792b51276da10f7f04baa https://github.com/pmd/pmd/commit/baad5701dc097e1cd8c792b51276da10f7f04baa Author: Scott Wells Date: 2021-10-21 (Thu, 21 Oct 2021) Changed paths: M pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/security/ApexCRUDViolationRule.java M pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/security/xml/ApexCRUDViolation.xml Log Message: --- Minor formatting corrections. Commit: 873f3527b292aca1f524d9241bdcd1ca45cac4d3 https://github.com/pmd/pmd/commit/873f3527b292aca1f524d9241bdcd1ca45cac4d3 Author: Scott Wells Date: 2021-10-21 (Thu, 21 Oct 2021) Changed paths: M pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/security/ApexCRUDViolationRule.java M pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/security/xml/ApexCRUDViolation.xml Log Message: --- Added information about an observed bug with authorization checks against sub-relations in static SOQL queries. Added a test case that reproduces the bug. Once the bug is fixed, the unit test expectation can be changed to provide both verification and a check against regressions. Commit: 64595b801baff2f37fb133d5bfd4b2d9bb829041 https://github.com/pmd/pmd/commit/64595b801baff2f37fb133d5bfd4b2d9bb829041 Author: Scott Wells Date: 2021-10-21 (Thu, 21 Oct 2021) Changed paths: M pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/security/ApexCRUDViolationRule.java Log Message: --- Added a compiled pattern cache for the configured method name patterns. Fixed some checkstyle-reported formatting issues. Commit: c919c4d05823df28fbaae0b5c1ce859ef0c62c2e https://github.com/pmd/pmd/commit/c919c4d05823df28fbaae0b5c1ce859ef0c62c2e Author: Scott Wells Date: 2021-10-22 (Fri, 22 Oct 2021) Changed paths: M pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/security/ApexCRUDViolationRule.java M pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/security/xml/ApexCRUDViolation.xml Log Message: ---
[pmd-commits] [pmd/pmd] 087c0a: Update documentation
Branch: refs/heads/gh-pages Home: https://github.com/pmd/pmd Commit: 087c0a3b9fbc300e699de2be6e9f3a491e25da6d https://github.com/pmd/pmd/commit/087c0a3b9fbc300e699de2be6e9f3a491e25da6d Author: PMD CI (pmd-bot) Date: 2021-10-22 (Fri, 22 Oct 2021) Changed paths: M feed.xml M pmd_rules_apex_documentation.html Log Message: --- Update documentation https://github.com/pmd/pmd/actions/runs/1373131798 https://github.com/pmd/pmd/compare/e1d4a29e94b8...e67f2a04001a ___ Pmd-commits mailing list Pmd-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/pmd-commits
[pmd-commits] [pmd/pmd] b36228: Update documentation
Branch: refs/heads/gh-pages Home: https://github.com/pmd/pmd Commit: b36228ea97c614b30afa436b84240c66734b235c https://github.com/pmd/pmd/commit/b36228ea97c614b30afa436b84240c66734b235c Author: PMD CI (pmd-bot) Date: 2021-10-22 (Fri, 22 Oct 2021) Changed paths: M feed.xml M pmd_rules_apex_bestpractices.html Log Message: --- Update documentation https://github.com/pmd/pmd/actions/runs/1373122125 https://github.com/pmd/pmd/compare/02af52702669...e1d4a29e94b8 ___ Pmd-commits mailing list Pmd-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/pmd-commits
[pmd-commits] [pmd/pmd] efbe14: Issue 3566 - Added a new configuration property, '...
Branch: refs/heads/master Home: https://github.com/pmd/pmd Commit: efbe149f21d52c49bd498d5bdeed9fefff71b3a8 https://github.com/pmd/pmd/commit/efbe149f21d52c49bd498d5bdeed9fefff71b3a8 Author: Scott Wells Date: 2021-10-20 (Wed, 20 Oct 2021) Changed paths: M pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/documentation/ApexDocRule.java M pmd-apex/src/main/resources/category/apex/documentation.xml M pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/documentation/xml/ApexDoc.xml Log Message: --- Issue 3566 - Added a new configuration property, 'reportMissingDescription', that if set to false (default is true if unspecified) doesn't report an issue if the '@description' tag is missing. This is consistent with the dialect supported by ApexDoc derivatives such as SfApexDoc. Commit: e67f2a04001a8b53b4c51a6b454a48176d1d77f6 https://github.com/pmd/pmd/commit/e67f2a04001a8b53b4c51a6b454a48176d1d77f6 Author: Robert Sösemann <8180281+rsoesem...@users.noreply.github.com> Date: 2021-10-22 (Fri, 22 Oct 2021) Changed paths: M pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/documentation/ApexDocRule.java M pmd-apex/src/main/resources/category/apex/documentation.xml M pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/documentation/xml/ApexDoc.xml Log Message: --- Merge pull request #3572 from SCWells72/pmd-3566 Compare: https://github.com/pmd/pmd/compare/e1d4a29e94b8...e67f2a04001a ___ Pmd-commits mailing list Pmd-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/pmd-commits
[pmd-commits] [pmd/pmd] 230fc4: Issue 1089 - Added a new configuration property, '...
Branch: refs/heads/master Home: https://github.com/pmd/pmd Commit: 230fc4c805367a13afd6ca2c928b2489a175eb1b https://github.com/pmd/pmd/commit/230fc4c805367a13afd6ca2c928b2489a175eb1b Author: Scott Wells Date: 2021-10-20 (Wed, 20 Oct 2021) Changed paths: M pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/bestpractices/ApexUnitTestClassShouldHaveAssertsRule.java M pmd-apex/src/main/resources/category/apex/bestpractices.xml M pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/bestpractices/xml/ApexUnitTestClassShouldHaveAsserts.xml Log Message: --- Issue 1089 - Added a new configuration property, 'additionalAssertMethodPattern', that when specified is also evaluated against each invoked method name to determine whether it represents a test assertion. This will provide support for those who use testing facades such as sirono-common's Assert, or who encapsulate common assertions in local utility methods. Commit: dc0e1ee17f1e18123e8fd42ea66ca1fba2e0cd91 https://github.com/pmd/pmd/commit/dc0e1ee17f1e18123e8fd42ea66ca1fba2e0cd91 Author: Scott Wells Date: 2021-10-22 (Fri, 22 Oct 2021) Changed paths: M pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/bestpractices/ApexUnitTestClassShouldHaveAssertsRule.java M pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/bestpractices/xml/ApexUnitTestClassShouldHaveAsserts.xml Log Message: --- Changes based on review feedback, specifically: 1) Only try to compile the configured pattern once if provided for both efficiency and noise suppression reasons. The suggested dysfunctionReason() approach was not used because that doesn't seem to be called when executing for unit tests. Happy to revisit this if I'm just missing something. 2) Catch more specific exceptions, in this case IllegalArgumentException which is thrown by Pattern#compile both as that type and as its sub-type PatternSyntaxException. 3) Document why we're using a string property and not a regex property so that we can control the pattern compilation params. 4) Add expected failure line numbers to the new test case. Commit: e1d4a29e94b8e6a50dd31ca8ca307aa6a09ec654 https://github.com/pmd/pmd/commit/e1d4a29e94b8e6a50dd31ca8ca307aa6a09ec654 Author: Robert Sösemann <8180281+rsoesem...@users.noreply.github.com> Date: 2021-10-22 (Fri, 22 Oct 2021) Changed paths: M pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/bestpractices/ApexUnitTestClassShouldHaveAssertsRule.java M pmd-apex/src/main/resources/category/apex/bestpractices.xml M pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/bestpractices/xml/ApexUnitTestClassShouldHaveAsserts.xml Log Message: --- Merge pull request #3571 from SCWells72/pmd-1089 Compare: https://github.com/pmd/pmd/compare/02af52702669...e1d4a29e94b8 ___ Pmd-commits mailing list Pmd-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/pmd-commits
[pmd-commits] [pmd/pmd] 3b791b: fix resource leak due to Files.walk
Branch: refs/heads/master Home: https://github.com/pmd/pmd Commit: 3b791b49c7c729f23048cd71e3b02a5a81726074 https://github.com/pmd/pmd/commit/3b791b49c7c729f23048cd71e3b02a5a81726074 Author: lujie Date: 2021-10-19 (Tue, 19 Oct 2021) Changed paths: M pmd-doc/src/main/java/net/sourceforge/pmd/docs/DeadLinksChecker.java Log Message: --- fix resource leak due to Files.walk Commit: 1cae88061dcdd765ef9f7ad49fa2cf3e68de3b78 https://github.com/pmd/pmd/commit/1cae88061dcdd765ef9f7ad49fa2cf3e68de3b78 Author: Andreas Dangel Date: 2021-10-22 (Fri, 22 Oct 2021) Changed paths: M pmd-doc/src/main/java/net/sourceforge/pmd/docs/DeadLinksChecker.java Log Message: --- Fix missing import j.u.s.Stream Commit: ad0233e9abff861a35280f0456dd5184c0907160 https://github.com/pmd/pmd/commit/ad0233e9abff861a35280f0456dd5184c0907160 Author: Andreas Dangel Date: 2021-10-22 (Fri, 22 Oct 2021) Changed paths: M docs/pages/release_notes.md Log Message: --- [doc] Update release notes (#3565) Commit: 95e61c593338b5f2ac512ac0d33acb16a0c1fc8f https://github.com/pmd/pmd/commit/95e61c593338b5f2ac512ac0d33acb16a0c1fc8f Author: Andreas Dangel Date: 2021-10-22 (Fri, 22 Oct 2021) Changed paths: M .all-contributorsrc M docs/pages/pmd/projectdocs/credits.md Log Message: --- Add @lujiefsi as a contributor Commit: 02af527026699b60aa304089ba657895054a471c https://github.com/pmd/pmd/commit/02af527026699b60aa304089ba657895054a471c Author: Andreas Dangel Date: 2021-10-22 (Fri, 22 Oct 2021) Changed paths: M .all-contributorsrc M docs/pages/pmd/projectdocs/credits.md M docs/pages/release_notes.md M pmd-doc/src/main/java/net/sourceforge/pmd/docs/DeadLinksChecker.java Log Message: --- Merge pull request #3565 from lujiefsi:master [doc] Fix resource leak due to Files.walk #3565 Compare: https://github.com/pmd/pmd/compare/adaf0313114b...02af52702669 ___ Pmd-commits mailing list Pmd-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/pmd-commits
