Re: editors/calligra: link imath and remove kcalendarcore and kcontacts (Was: Re: "LIB_DEPENDS not needed for")

2021-12-15 Thread Rafael Sadowski
On Wed Dec 15, 2021 at 06:51:09PM -0800, Nam Nguyen wrote:
> Rafael Sadowski writes:
> 
> > On Sun Dec 12, 2021 at 03:41:48PM +0100, Rafael Sadowski wrote:
> >> I'll fix calligra.
> >> 
> 
> I propose an inline diff that does the following three things:
> 
> 1.) Removes kcalendarcore and kcontacts from BUILD_DEPENDS and
> RUN_DEPENDS.
> 
> These are listed as optional and only linked in if KF5Akondai is also
> found. I propose removing until KF5Akondai is added.
> 
> CMakeFiles.txt lists purposes:
> KF5CalendarCore:
> PURPOSE "Optionally used by semantic item Event"
> KF5Contacts:
> PURPOSE "Optionally used by semantic item Contact"
> KF5AkonadiCore:
> PURPOSE "Optionally used by semantic items Event and Contact"
> 
> plugins/semanticitems/event/CMakeLists.txt
> 19:if (KF5CalendarCore_FOUND AND KF5Akonadi_FOUND)
> 
> plugins/semanticitems/contact/CMakeLists.txt
> 19:if (KF5Contacts_FOUND AND KF5Akonadi_FOUND)

Thank you for digging deeper, so I think we need something like
-DCMAKE_DISABLE_FIND_PACKAGE_KF5Akonadi=ON

With that OK rsadowski@

> 
> 2.) Add math/imath to LIB_DEPENDS.
> 
> graphics/openexr split off the math/imath library. According to this
> commit, calligra only relies on imath and does not need to link to
> openexr.
> 
> see:
> https://invent.kde.org/office/calligra/-/commit/c52eb33f20a66acb648b725e2eee3ed977eae896
> 
> 3.)  Set OpenEXR_FOUND in CMakeLists.txt patch.
> 
> OpenEXR_FOUND is used for conditional linking in lcms2 and
> libs/pigment. It should be set by either extra-cmake-modules or
> ${WRKSRC}/cmake/modules/FindOpenEXR.cmake, but it does not utilize these
> files because it finds Imath directly:
> 
> macro_optional_find_package(Imath 3.0 CONFIG QUIET)
> 
> OPENEXR_FOUND (all caps) is set in FindOpenEXR.cmake but the other bits
> use OpenEXR_FOUND.
> 
> $ ag OpenEXR_FOUND 
> plugins/colorengines/lcms2/tests/CMakeLists.txt
> 15:if(OpenEXR_FOUND)
> 
> plugins/colorengines/lcms2/CMakeLists.txt
> 34:if (HAVE_LCMS24 AND OpenEXR_FOUND)
> 44:if(OpenEXR_FOUND)
> 83:if (HAVE_LCMS24 AND OpenEXR_FOUND)
> 
> libs/pigment/CMakeLists.txt
> 15:if(OpenEXR_FOUND)

Agree. OK!

> 
> Testing
> ===
> I could not really test runtime as I am not sure how to make use of the
> pigment and lcms2 color management system. #2 and #3 allow linking with
> Imath: -lImath-3_1

Just like me.

> 
> `make test' has a similar amounts of tests pass.
> before:
> 26% tests passed, 106 tests failed out of 143
> after:
> 26% tests passed, 105 tests failed out of 142
> 
> Test #103: libs-pigment-TestKoColorSpaceMaths is the only test that uses
> half.h and imath, and that still passes.
> 
> Index: Makefile
> ===
> RCS file: /cvs/ports/editors/calligra/Makefile,v
> retrieving revision 1.48
> diff -u -p -u -p -r1.48 Makefile
> --- Makefile  13 Dec 2021 18:21:35 -  1.48
> +++ Makefile  16 Dec 2021 00:55:10 -
> @@ -5,7 +5,7 @@ HOMEPAGE =https://www.calligra.org
>  VERSION =3.2.1
>  DISTNAME =   calligra-${VERSION}
>  CATEGORIES = editors
> -REVISION =   4
> +REVISION =   5
>  
>  SHARED_LIBS =   RtfReader 51.0 # 0.0
>  SHARED_LIBS +=  basicflakes   50.0 # 0.0
> @@ -50,7 +50,8 @@ MAINTAINER =Rafael Sadowski   PERMIT_PACKAGE = Yes
>  DPB_PROPERTIES = parallel
>  
> -WANTLIB += ${COMPILER_LIBCXX} ICE KChart KF5Activities KF5Archive
> +WANTLIB += ${COMPILER_LIBCXX} ICE Imath-3_1
> +WANTLIB += KChart KF5Activities KF5Archive
>  WANTLIB += KF5Auth KF5AuthCore KF5Bookmarks KF5Codecs KF5Completion
>  WANTLIB += KF5ConfigCore KF5ConfigGui KF5ConfigWidgets KF5CoreAddons
>  WANTLIB += KF5Crash KF5DBusAddons KF5GuiAddons KF5I18n KF5IconThemes
> @@ -73,8 +74,6 @@ COMPILER =  base-clang ports-gcc
>  
>  BUILD_DEPENDS =  devel/boost \
>   devel/gettext,-tools \
> - devel/kf5/kcalendarcore \
> - devel/kf5/kcontacts \
>   devel/kf5/kdoctools \
>   devel/kf5/kinit \
>   devel/kf5/kross \
> @@ -84,8 +83,6 @@ BUILD_DEPENDS = devel/boost \
>  
>  RUN_DEPENDS =devel/desktop-file-utils \
>   devel/gettext,-runtime \
> - devel/kf5/kcalendarcore \
> - devel/kf5/kcontacts \
>   devel/kf5/kinit \
>   devel/kf5/ktexteditor \
>   misc/shared-mime-info \
> @@ -121,6 +118,7 @@ LIB_DEPENDS = converters/libiconv \
>   devel/kf5/sonnet \
>   graphics/kdiagram \
>   graphics/lcms2 \
> + math/imath \
>   multimedia/phonon \
>   print/poppler,-qt5 \
>   security/qca-qt5 \
> Index: patches/patch-CMakeLists_txt
> ===
> RCS file: /cvs/ports/editors/calligra/patches/patch-CMakeLists_txt,v
> retrieving revision 1.3
> diff -u -p -u -p -r1.3 patch-CMakeLists_txt
> --- patches/patch-CMakeLists_txt  31 Aug 2021 07:31:43 -  

editors/calligra: link imath and remove kcalendarcore and kcontacts (Was: Re: "LIB_DEPENDS not needed for")

2021-12-15 Thread Nam Nguyen
Rafael Sadowski writes:

> On Sun Dec 12, 2021 at 03:41:48PM +0100, Rafael Sadowski wrote:
>> I'll fix calligra.
>> 

I propose an inline diff that does the following three things:

1.) Removes kcalendarcore and kcontacts from BUILD_DEPENDS and
RUN_DEPENDS.

These are listed as optional and only linked in if KF5Akondai is also
found. I propose removing until KF5Akondai is added.

CMakeFiles.txt lists purposes:
KF5CalendarCore:
PURPOSE "Optionally used by semantic item Event"
KF5Contacts:
PURPOSE "Optionally used by semantic item Contact"
KF5AkonadiCore:
PURPOSE "Optionally used by semantic items Event and Contact"

plugins/semanticitems/event/CMakeLists.txt
19:if (KF5CalendarCore_FOUND AND KF5Akonadi_FOUND)

plugins/semanticitems/contact/CMakeLists.txt
19:if (KF5Contacts_FOUND AND KF5Akonadi_FOUND)

2.) Add math/imath to LIB_DEPENDS.

graphics/openexr split off the math/imath library. According to this
commit, calligra only relies on imath and does not need to link to
openexr.

see:
https://invent.kde.org/office/calligra/-/commit/c52eb33f20a66acb648b725e2eee3ed977eae896

3.)  Set OpenEXR_FOUND in CMakeLists.txt patch.

OpenEXR_FOUND is used for conditional linking in lcms2 and
libs/pigment. It should be set by either extra-cmake-modules or
${WRKSRC}/cmake/modules/FindOpenEXR.cmake, but it does not utilize these
files because it finds Imath directly:

macro_optional_find_package(Imath 3.0 CONFIG QUIET)

OPENEXR_FOUND (all caps) is set in FindOpenEXR.cmake but the other bits
use OpenEXR_FOUND.

$ ag OpenEXR_FOUND 
plugins/colorengines/lcms2/tests/CMakeLists.txt
15:if(OpenEXR_FOUND)

plugins/colorengines/lcms2/CMakeLists.txt
34:if (HAVE_LCMS24 AND OpenEXR_FOUND)
44:if(OpenEXR_FOUND)
83:if (HAVE_LCMS24 AND OpenEXR_FOUND)

libs/pigment/CMakeLists.txt
15:if(OpenEXR_FOUND)

Testing
===
I could not really test runtime as I am not sure how to make use of the
pigment and lcms2 color management system. #2 and #3 allow linking with
Imath: -lImath-3_1

`make test' has a similar amounts of tests pass.
before:
26% tests passed, 106 tests failed out of 143
after:
26% tests passed, 105 tests failed out of 142

Test #103: libs-pigment-TestKoColorSpaceMaths is the only test that uses
half.h and imath, and that still passes.

Index: Makefile
===
RCS file: /cvs/ports/editors/calligra/Makefile,v
retrieving revision 1.48
diff -u -p -u -p -r1.48 Makefile
--- Makefile13 Dec 2021 18:21:35 -  1.48
+++ Makefile16 Dec 2021 00:55:10 -
@@ -5,7 +5,7 @@ HOMEPAGE =  https://www.calligra.org
 VERSION =  3.2.1
 DISTNAME = calligra-${VERSION}
 CATEGORIES =   editors
-REVISION = 4
+REVISION = 5
 
 SHARED_LIBS =   RtfReader 51.0 # 0.0
 SHARED_LIBS +=  basicflakes   50.0 # 0.0
@@ -50,7 +50,8 @@ MAINTAINER =  Rafael Sadowski 

Re: "LIB_DEPENDS not needed for"

2021-12-13 Thread Marc Espie
On Sun, Dec 12, 2021 at 11:52:40AM +, Stuart Henderson wrote:
> Related to the "policy for dlopen'd libraries etc" mail I just posted but
> worth a separate thread I think ..
> 
> When you see "LIB_DEPENDS  not needed for " when "make package"
> runs, it means that the LIB_DEPENDS entry is *ignored* as a run dependency
> and is equivalent to BUILD_DEPENDS.
> 
> : LIB_DEPENDS  not needed for   There doesn't seem to 
> be
> : any WANTLIB to match the given LIB_DEPENDS.  Thus, the LIB_DEPENDS won't
> : turn into a @depends line in the created package.
> 
> This is nearly always an error - bsd.port.mk(5) lists some "might be
> intentional" but those cases are rare and could be handled with conditionals
> instead (perhaps it would be better if we do turn it into an actual error).
> 
> I think all current cases in ports *are* an error:
> 
> audio/moc LIB_DEPENDS devel/gettext,-runtime not needed for 
> audio/moc ?
> audio/cantata LIB_DEPENDS audio/libebur128 not needed for 
> audio/cantata ?
> x11/kde-applications/kcronLIB_DEPENDS devel/kf5/kiconthemes not needed 
> for x11/kde-applications/kcron ?
> x11/pidgin-libnotify  LIB_DEPENDS net/pidgin,-libpurple not needed for 
> x11/pidgin-libnotify ?
> graphics/opencsg  LIB_DEPENDS x11/qt5/qtbase,-main not needed for 
> graphics/opencsg ?
> graphics/piglit   LIB_DEPENDS graphics/vulkan-loader not needed 
> for graphics/piglit ?
> net/pidginLIB_DEPENDS lang/python/3.9 not needed for 
> net/pidgin,-finch ?
> editors/calligra  LIB_DEPENDS devel/kf5/kcalendarcore not needed for 
> editors/calligra ?
> editors/calligra  LIB_DEPENDS devel/kf5/kcontacts not needed for 
> editors/calligra ?
> editors/calligra  LIB_DEPENDS textproc/libwpd not needed for 
> editors/calligra ?
> games/f1spiritLIB_DEPENDS devel/libidn not needed for 
> games/f1spirit ?
> math/nonogram LIB_DEPENDS math/nonolib not needed for math/nonogram ?
> sysutils/libfsapfsLIB_DEPENDS sysutils/libfwnt not needed for 
> sysutils/libfsapfs ?
> 
> 
> 
Considering how few there are left, I concur.

Once they're fixed, we can turn these into errors.



Re: "LIB_DEPENDS not needed for"

2021-12-12 Thread Rafael Sadowski
On Sun Dec 12, 2021 at 03:41:48PM +0100, Rafael Sadowski wrote:
> On Sun Dec 12, 2021 at 11:52:40AM +, Stuart Henderson wrote:
> > Related to the "policy for dlopen'd libraries etc" mail I just posted but
> > worth a separate thread I think ..
> > 
> > When you see "LIB_DEPENDS  not needed for " when "make package"
> > runs, it means that the LIB_DEPENDS entry is *ignored* as a run dependency
> > and is equivalent to BUILD_DEPENDS.
> > 
> > : LIB_DEPENDS  not needed for   There doesn't seem 
> > to be
> > : any WANTLIB to match the given LIB_DEPENDS.  Thus, the LIB_DEPENDS 
> > won't
> > : turn into a @depends line in the created package.
> > 
> > This is nearly always an error - bsd.port.mk(5) lists some "might be
> > intentional" but those cases are rare and could be handled with conditionals
> > instead (perhaps it would be better if we do turn it into an actual error).
> > 
> > I think all current cases in ports *are* an error:
> > 
> > audio/moc   LIB_DEPENDS devel/gettext,-runtime not needed for 
> > audio/moc ?
> > audio/cantata   LIB_DEPENDS audio/libebur128 not needed for 
> > audio/cantata ?
> > x11/kde-applications/kcron  LIB_DEPENDS devel/kf5/kiconthemes not needed 
> > for x11/kde-applications/kcron ?
> 
> Exactly, I fixed that a few days ago.
> 
> > x11/pidgin-libnotifyLIB_DEPENDS net/pidgin,-libpurple not needed 
> > for x11/pidgin-libnotify ?
> > graphics/opencsgLIB_DEPENDS x11/qt5/qtbase,-main not needed for 
> > graphics/opencsg ?
> 
> Maybe MODQT_DEPS = No helps here.
> 
> > graphics/piglit LIB_DEPENDS graphics/vulkan-loader not needed 
> > for graphics/piglit ?
> > net/pidgin  LIB_DEPENDS lang/python/3.9 not needed for 
> > net/pidgin,-finch ?
> > editors/calligraLIB_DEPENDS devel/kf5/kcalendarcore not needed for 
> > editors/calligra ?
> > editors/calligraLIB_DEPENDS devel/kf5/kcontacts not needed for 
> > editors/calligra ?
> > editors/calligraLIB_DEPENDS textproc/libwpd not needed for 
> > editors/calligra ?
> 
> I'll fix calligra.
> 


Index: Makefile
===
RCS file: /cvs/ports/editors/calligra/Makefile,v
retrieving revision 1.47
diff -u -p -u -p -r1.47 Makefile
--- Makefile31 Aug 2021 07:31:43 -  1.47
+++ Makefile12 Dec 2021 17:48:50 -
@@ -5,7 +5,7 @@ HOMEPAGE =  https://www.calligra.org
 VERSION =  3.2.1
 DISTNAME = calligra-${VERSION}
 CATEGORIES =   editors
-REVISION = 3
+REVISION = 4
 
 SHARED_LIBS =   RtfReader 51.0 # 0.0
 SHARED_LIBS +=  basicflakes   50.0 # 0.0
@@ -50,8 +50,7 @@ MAINTAINER =  Rafael Sadowski 

Re: "LIB_DEPENDS not needed for"

2021-12-12 Thread Stefan Hagen
Rafael Sadowski wrote:
> On Sun Dec 12, 2021 at 11:52:40AM +, Stuart Henderson wrote:
> > Related to the "policy for dlopen'd libraries etc" mail I just posted but
> > worth a separate thread I think ..
> > 
> > When you see "LIB_DEPENDS  not needed for " when "make package"
> > runs, it means that the LIB_DEPENDS entry is *ignored* as a run dependency
> > and is equivalent to BUILD_DEPENDS.
> > 
> > : LIB_DEPENDS  not needed for   There doesn't seem 
> > to be
> > : any WANTLIB to match the given LIB_DEPENDS.  Thus, the LIB_DEPENDS 
> > won't
> > : turn into a @depends line in the created package.
> > 
> > This is nearly always an error - bsd.port.mk(5) lists some "might be
> > intentional" but those cases are rare and could be handled with conditionals
> > instead (perhaps it would be better if we do turn it into an actual error).
> > 
> > I think all current cases in ports *are* an error:
> > 
> > audio/moc   LIB_DEPENDS devel/gettext,-runtime not needed for 
> > audio/moc ?
> 
> I see no gettext usage in the moc source tree. While I'm here, fix
> WANTLIB by regen.
> 
> OK?

Tested with not packages preinstalled.

OK sdk@

> Index: Makefile
> ===
> RCS file: /cvs/ports/audio/moc/Makefile,v
> retrieving revision 1.24
> diff -u -p -r1.24 Makefile
> --- Makefile  26 Jan 2020 11:14:29 -  1.24
> +++ Makefile  12 Dec 2021 15:52:07 -
> @@ -7,18 +7,18 @@ HOMEPAGE =  http://moc.daper.net/
>  MASTER_SITES =   http://ftp.daper.net/pub/soft/moc/stable/ \
>   https://distfiles.sigtrap.nl/
>  EXTRACT_SUFX =   .tar.bz2
> -REVISION =   7
> +REVISION =   8
>  
>  # GPLv3+
>  PERMIT_PACKAGE = Yes
>  
>  # uses pledge()
> -WANTLIB += ${COMPILER_LIBCXX}
> -WANTLIB += FLAC avcodec avformat avutil bz2 c crypto curl curses
> -WANTLIB += db faad gsm iconv id3tag ltdl m mad magic modplug mp3lame
> -WANTLIB += mpcdec nghttp2 ogg opus samplerate sndfile sndio speex
> -WANTLIB += ssl swresample tag tag_c vorbis vorbisenc vorbisfile
> -WANTLIB += vpx wavpack x264 x265 xvidcore z
> +WANTLIB += ${COMPILER_LIBCXX} FLAC aom avcodec avformat avutil
> +WANTLIB += bz2 c crypto curl curses dav1d db faad gsm iconv id3tag
> +WANTLIB += ltdl lzma m mad magic modplug mp3lame mpcdec nghttp2
> +WANTLIB += ogg opus samplerate sndfile sndio speex ssl swresample
> +WANTLIB += tag tag_c theoradec theoraenc vorbis vorbisenc vorbisfile
> +WANTLIB += vpx wavpack x264 x265 xml2 xvidcore z
>  
>  COMPILER =   base-clang ports-gcc base-gcc
>  
> @@ -35,7 +35,6 @@ LIB_DEPENDS =   audio/faad \
>   audio/speex \
>   audio/taglib \
>   databases/db/v4 \
> - devel/gettext,-runtime \
>   devel/libmagic \
>   devel/libtool,-ltdl \
>   graphics/ffmpeg \
> 

-- 
STEFAN HAGEN // GPG 0x52BE43BA
CONTACT INFO :: finger(1) @codevoid.de



Re: "LIB_DEPENDS not needed for"

2021-12-12 Thread Rafael Sadowski
On Sun Dec 12, 2021 at 11:52:40AM +, Stuart Henderson wrote:
> Related to the "policy for dlopen'd libraries etc" mail I just posted but
> worth a separate thread I think ..
> 
> When you see "LIB_DEPENDS  not needed for " when "make package"
> runs, it means that the LIB_DEPENDS entry is *ignored* as a run dependency
> and is equivalent to BUILD_DEPENDS.
> 
> : LIB_DEPENDS  not needed for   There doesn't seem to 
> be
> : any WANTLIB to match the given LIB_DEPENDS.  Thus, the LIB_DEPENDS won't
> : turn into a @depends line in the created package.
> 
> This is nearly always an error - bsd.port.mk(5) lists some "might be
> intentional" but those cases are rare and could be handled with conditionals
> instead (perhaps it would be better if we do turn it into an actual error).
> 
> I think all current cases in ports *are* an error:
> 
> audio/moc LIB_DEPENDS devel/gettext,-runtime not needed for 
> audio/moc ?

I see no gettext usage in the moc source tree. While I'm here, fix
WANTLIB by regen.

OK?

Index: Makefile
===
RCS file: /cvs/ports/audio/moc/Makefile,v
retrieving revision 1.24
diff -u -p -r1.24 Makefile
--- Makefile26 Jan 2020 11:14:29 -  1.24
+++ Makefile12 Dec 2021 15:52:07 -
@@ -7,18 +7,18 @@ HOMEPAGE =http://moc.daper.net/
 MASTER_SITES = http://ftp.daper.net/pub/soft/moc/stable/ \
https://distfiles.sigtrap.nl/
 EXTRACT_SUFX = .tar.bz2
-REVISION = 7
+REVISION = 8
 
 # GPLv3+
 PERMIT_PACKAGE = Yes
 
 # uses pledge()
-WANTLIB += ${COMPILER_LIBCXX}
-WANTLIB += FLAC avcodec avformat avutil bz2 c crypto curl curses
-WANTLIB += db faad gsm iconv id3tag ltdl m mad magic modplug mp3lame
-WANTLIB += mpcdec nghttp2 ogg opus samplerate sndfile sndio speex
-WANTLIB += ssl swresample tag tag_c vorbis vorbisenc vorbisfile
-WANTLIB += vpx wavpack x264 x265 xvidcore z
+WANTLIB += ${COMPILER_LIBCXX} FLAC aom avcodec avformat avutil
+WANTLIB += bz2 c crypto curl curses dav1d db faad gsm iconv id3tag
+WANTLIB += ltdl lzma m mad magic modplug mp3lame mpcdec nghttp2
+WANTLIB += ogg opus samplerate sndfile sndio speex ssl swresample
+WANTLIB += tag tag_c theoradec theoraenc vorbis vorbisenc vorbisfile
+WANTLIB += vpx wavpack x264 x265 xml2 xvidcore z
 
 COMPILER = base-clang ports-gcc base-gcc
 
@@ -35,7 +35,6 @@ LIB_DEPENDS = audio/faad \
audio/speex \
audio/taglib \
databases/db/v4 \
-   devel/gettext,-runtime \
devel/libmagic \
devel/libtool,-ltdl \
graphics/ffmpeg \



Re: "LIB_DEPENDS not needed for"

2021-12-12 Thread Rafael Sadowski
On Sun Dec 12, 2021 at 11:52:40AM +, Stuart Henderson wrote:
> Related to the "policy for dlopen'd libraries etc" mail I just posted but
> worth a separate thread I think ..
> 
> When you see "LIB_DEPENDS  not needed for " when "make package"
> runs, it means that the LIB_DEPENDS entry is *ignored* as a run dependency
> and is equivalent to BUILD_DEPENDS.
> 
> : LIB_DEPENDS  not needed for   There doesn't seem to 
> be
> : any WANTLIB to match the given LIB_DEPENDS.  Thus, the LIB_DEPENDS won't
> : turn into a @depends line in the created package.
> 
> This is nearly always an error - bsd.port.mk(5) lists some "might be
> intentional" but those cases are rare and could be handled with conditionals
> instead (perhaps it would be better if we do turn it into an actual error).
> 
> I think all current cases in ports *are* an error:
> 
> audio/moc LIB_DEPENDS devel/gettext,-runtime not needed for 
> audio/moc ?
> audio/cantata LIB_DEPENDS audio/libebur128 not needed for 
> audio/cantata ?
> x11/kde-applications/kcronLIB_DEPENDS devel/kf5/kiconthemes not needed 
> for x11/kde-applications/kcron ?

Exactly, I fixed that a few days ago.

> x11/pidgin-libnotify  LIB_DEPENDS net/pidgin,-libpurple not needed for 
> x11/pidgin-libnotify ?
> graphics/opencsg  LIB_DEPENDS x11/qt5/qtbase,-main not needed for 
> graphics/opencsg ?

Maybe MODQT_DEPS = No helps here.

> graphics/piglit   LIB_DEPENDS graphics/vulkan-loader not needed 
> for graphics/piglit ?
> net/pidginLIB_DEPENDS lang/python/3.9 not needed for 
> net/pidgin,-finch ?
> editors/calligra  LIB_DEPENDS devel/kf5/kcalendarcore not needed for 
> editors/calligra ?
> editors/calligra  LIB_DEPENDS devel/kf5/kcontacts not needed for 
> editors/calligra ?
> editors/calligra  LIB_DEPENDS textproc/libwpd not needed for 
> editors/calligra ?

I'll fix calligra.

> games/f1spiritLIB_DEPENDS devel/libidn not needed for 
> games/f1spirit ?
> math/nonogram LIB_DEPENDS math/nonolib not needed for math/nonogram ?
> sysutils/libfsapfsLIB_DEPENDS sysutils/libfwnt not needed for 
> sysutils/libfsapfs ?
> 
> 



"LIB_DEPENDS not needed for"

2021-12-12 Thread Stuart Henderson
Related to the "policy for dlopen'd libraries etc" mail I just posted but
worth a separate thread I think ..

When you see "LIB_DEPENDS  not needed for " when "make package"
runs, it means that the LIB_DEPENDS entry is *ignored* as a run dependency
and is equivalent to BUILD_DEPENDS.

: LIB_DEPENDS  not needed for   There doesn't seem to be
: any WANTLIB to match the given LIB_DEPENDS.  Thus, the LIB_DEPENDS won't
: turn into a @depends line in the created package.

This is nearly always an error - bsd.port.mk(5) lists some "might be
intentional" but those cases are rare and could be handled with conditionals
instead (perhaps it would be better if we do turn it into an actual error).

I think all current cases in ports *are* an error:

audio/moc   LIB_DEPENDS devel/gettext,-runtime not needed for 
audio/moc ?
audio/cantata   LIB_DEPENDS audio/libebur128 not needed for 
audio/cantata ?
x11/kde-applications/kcron  LIB_DEPENDS devel/kf5/kiconthemes not needed 
for x11/kde-applications/kcron ?
x11/pidgin-libnotifyLIB_DEPENDS net/pidgin,-libpurple not needed for 
x11/pidgin-libnotify ?
graphics/opencsgLIB_DEPENDS x11/qt5/qtbase,-main not needed for 
graphics/opencsg ?
graphics/piglit LIB_DEPENDS graphics/vulkan-loader not needed for 
graphics/piglit ?
net/pidgin  LIB_DEPENDS lang/python/3.9 not needed for 
net/pidgin,-finch ?
editors/calligraLIB_DEPENDS devel/kf5/kcalendarcore not needed for 
editors/calligra ?
editors/calligraLIB_DEPENDS devel/kf5/kcontacts not needed for 
editors/calligra ?
editors/calligraLIB_DEPENDS textproc/libwpd not needed for 
editors/calligra ?
games/f1spirit  LIB_DEPENDS devel/libidn not needed for games/f1spirit ?
math/nonogram   LIB_DEPENDS math/nonolib not needed for math/nonogram ?
sysutils/libfsapfs  LIB_DEPENDS sysutils/libfwnt not needed for 
sysutils/libfsapfs ?