[UPDATE] devel/p5-Sub-Identify to 0.12
Adds better support for subroutine signatures, plus some segfault fixes. I'm a bit confused about why `make port-lib-depends-check` now says that I no longer need the WANTLIB line, did I miss a change about that someplace? Other than that, tests all pass, and reverse depends don't have any changes. devel/p5-namespace-autoclean fails tests both with and without these changes. OK? With or without the WANTLIB line? Index: Makefile === RCS file: /cvs/ports/devel/p5-Sub-Identify/Makefile,v retrieving revision 1.14 diff -u -p -r1.14 Makefile --- Makefile20 Mar 2016 19:56:35 - 1.14 +++ Makefile24 Nov 2016 20:00:16 - @@ -1,7 +1,7 @@ # $OpenBSD: Makefile,v 1.14 2016/03/20 19:56:35 naddy Exp $ COMMENT = retrieve names of code references -DISTNAME = Sub-Identify-0.10 +DISTNAME = Sub-Identify-0.12 CATEGORIES = devel MAINTAINER = Andrew Fresh @@ -9,10 +9,11 @@ MAINTAINER = Andrew Fresh Index: distinfo === RCS file: /cvs/ports/devel/p5-Sub-Identify/distinfo,v retrieving revision 1.4 diff -u -p -r1.4 distinfo --- distinfo4 Jul 2015 22:12:56 - 1.4 +++ distinfo24 Nov 2016 20:00:16 - @@ -1,2 +1,2 @@ -SHA256 (Sub-Identify-0.10.tar.gz) = VVhrnLPA5jtsbe3lqMAK9I3mZDWS6hAP4eYUbh6T7iA= -SIZE (Sub-Identify-0.10.tar.gz) = 52135 +SHA256 (Sub-Identify-0.12.tar.gz) = g7t4WmYRO0qWbbCkGG/R3QeYes2stFArHhVY+Bfd6CU= +SIZE (Sub-Identify-0.12.tar.gz) = 52414
Re: [UPDATE] devel/p5-Sub-Identify to 0.12
On Thu, Nov 24, 2016 at 01:07:03PM -0700, Andrew Fresh wrote: > I'm a bit confused about why `make port-lib-depends-check` now says that > I no longer need the WANTLIB line, did I miss a change about that > someplace? Don't know. Normally I just do what the port-lib-depends-check tells me. But in this case WANTLIB c perl looks reasonable. > devel/p5-namespace-autoclean fails tests both with and without these > changes. I am testing the Perl 5.24.1-RC4 update. With that it passes. > OK? With or without the WANTLIB line? OK bluhm@ > > Index: Makefile > === > RCS file: /cvs/ports/devel/p5-Sub-Identify/Makefile,v > retrieving revision 1.14 > diff -u -p -r1.14 Makefile > --- Makefile 20 Mar 2016 19:56:35 - 1.14 > +++ Makefile 24 Nov 2016 20:00:16 - > @@ -1,7 +1,7 @@ > # $OpenBSD: Makefile,v 1.14 2016/03/20 19:56:35 naddy Exp $ > > COMMENT =retrieve names of code references > -DISTNAME = Sub-Identify-0.10 > +DISTNAME = Sub-Identify-0.12 > CATEGORIES = devel > > MAINTAINER = Andrew Fresh > @@ -9,10 +9,11 @@ MAINTAINER =Andrew Fresh # perl > PERMIT_PACKAGE_CDROM = Yes > > -WANTLIB += c perl > +WANTLIB += c perl > > -MODULES =cpan > +MODULES =cpan > > -TEST_DEPENDS = devel/p5-Test-Pod > +# Additional dependency to avoid skipping tests > +TEST_DEPENDS += devel/p5-Test-Pod > > .include > Index: distinfo > === > RCS file: /cvs/ports/devel/p5-Sub-Identify/distinfo,v > retrieving revision 1.4 > diff -u -p -r1.4 distinfo > --- distinfo 4 Jul 2015 22:12:56 - 1.4 > +++ distinfo 24 Nov 2016 20:00:16 - > @@ -1,2 +1,2 @@ > -SHA256 (Sub-Identify-0.10.tar.gz) = > VVhrnLPA5jtsbe3lqMAK9I3mZDWS6hAP4eYUbh6T7iA= > -SIZE (Sub-Identify-0.10.tar.gz) = 52135 > +SHA256 (Sub-Identify-0.12.tar.gz) = > g7t4WmYRO0qWbbCkGG/R3QeYes2stFArHhVY+Bfd6CU= > +SIZE (Sub-Identify-0.12.tar.gz) = 52414
Re: [UPDATE] devel/p5-Sub-Identify to 0.12
On Fri, Nov 25, 2016 at 11:13:41PM +0100, Alexander Bluhm wrote: > On Thu, Nov 24, 2016 at 01:07:03PM -0700, Andrew Fresh wrote: > > devel/p5-namespace-autoclean fails tests both with and without these > > changes. > > I am testing the Perl 5.24.1-RC4 update. With that it passes. Aha, for some reason it's missing the p5-Test-Requires hard requirement. With this patch, more tests run and they all pass, even after pkg_deleteing everything before `make test`. Index: Makefile === RCS file: /cvs/ports/devel/p5-namespace-autoclean/Makefile,v retrieving revision 1.10 diff -u -p -r1.10 Makefile --- Makefile20 Mar 2016 19:56:42 - 1.10 +++ Makefile25 Nov 2016 23:50:42 - @@ -20,4 +20,9 @@ RUN_DEPENDS = devel/p5-B-Hooks-EndOfScop TEST_DEPENDS = devel/p5-Moose \ devel/p5-Sub-Name +TEST_DEPENDS +=devel/p5-Test-Requires \ + devel/p5-Moo \ + devel/p5-MooseX-Role-WithOverloading \ + devel/p5-Mouse + .include
Re: [UPDATE] devel/p5-Sub-Identify to 0.12
On Fri, Nov 25, 2016 at 06:49:35PM -0700, Andrew Fresh wrote: > On Fri, Nov 25, 2016 at 11:13:41PM +0100, Alexander Bluhm wrote: > > On Thu, Nov 24, 2016 at 01:07:03PM -0700, Andrew Fresh wrote: > > > devel/p5-namespace-autoclean fails tests both with and without these > > > changes. > > > > I am testing the Perl 5.24.1-RC4 update. With that it passes. > > Aha, for some reason it's missing the p5-Test-Requires hard requirement. > With this patch, more tests run and they all pass, even after > pkg_deleteing everything before `make test`. Usually I do a 'grep use' in the t directory. Not all dependencies are recorded properly in various perl modules. I think you should add devel/p5-Sub-Install although it is currently installed by a transitive dependency. > > Index: Makefile > === > RCS file: /cvs/ports/devel/p5-namespace-autoclean/Makefile,v > retrieving revision 1.10 > diff -u -p -r1.10 Makefile > --- Makefile 20 Mar 2016 19:56:42 - 1.10 > +++ Makefile 25 Nov 2016 23:50:42 - > @@ -20,4 +20,9 @@ RUN_DEPENDS = devel/p5-B-Hooks-EndOfScop > TEST_DEPENDS = devel/p5-Moose \ > devel/p5-Sub-Name The indentation is wrong here. Space vs. Tab > > +TEST_DEPENDS += devel/p5-Test-Requires \ > + devel/p5-Moo \ > + devel/p5-MooseX-Role-WithOverloading \ > + devel/p5-Mouse Why another TEST_DEPENDS += block? Can you put it in one? > + > .include anyway OK bluhm@
