Re: NEW: net/vf1
Edd Barrett wrote: > On Fri, Dec 14, 2018 at 06:13:02PM +0100, Paco Esteban wrote: > > Applied, here's the tar attached for convenience. > > Anyone willing to OK Paco's port? ok solene@ :) you can import
Re: NEW: net/vf1
On Fri, Dec 14, 2018 at 06:13:02PM +0100, Paco Esteban wrote: > Applied, here's the tar attached for convenience. Anyone willing to OK Paco's port? -- Best Regards Edd Barrett http://www.theunixzoo.co.uk
Re: NEW: net/vf1
On Fri, 14 Dec 2018, Edd Barrett wrote:
> I think we can make the README more concise, like this:
>
> --- README.orig Fri Dec 14 16:48:13 2018
> +++ README Fri Dec 14 16:49:45 2018
> @@ -4,6 +4,5 @@
> | Running ${PKGSTEM} on OpenBSD
> +---
>
> -If you get encoding errors, be sure you have set the LC_CTYPE
> -environment variable in your system to an UTF-8 variant, like
> -en_US.UTF-8, zh_CN-UTF-8, etc.
> +To avoid character encoding issues, ensure that you have your LC_CTYPE
> +environment set to one of the UTF-8 variants. E.g. en_US.UTF-8.
Applied, here's the tar attached for convenience.
Cheers,
--
Paco Esteban
https://onna.be/gpgkey.asc
vf1.tgz
Description: Binary data
Re: NEW: net/vf1
On Fri, Dec 14, 2018 at 05:31:47PM +0100, Paco Esteban wrote:
> Find attached the port with the README instead of a patch.
Good.
I think we can make the README more concise, like this:
--- README.orig Fri Dec 14 16:48:13 2018
+++ README Fri Dec 14 16:49:45 2018
@@ -4,6 +4,5 @@
| Running ${PKGSTEM} on OpenBSD
+---
-If you get encoding errors, be sure you have set the LC_CTYPE
-environment variable in your system to an UTF-8 variant, like
-en_US.UTF-8, zh_CN-UTF-8, etc.
+To avoid character encoding issues, ensure that you have your LC_CTYPE
+environment set to one of the UTF-8 variants. E.g. en_US.UTF-8.
Then I think this is ready.
--
Best Regards
Edd Barrett
http://www.theunixzoo.co.uk
Re: NEW: net/vf1
On Fri, 14 Dec 2018, Edd Barrett wrote: > Do we know if this is an OpenBSD-specific issue? As far as I know, yes. At least I could not reproduce it on a linux box I have here unsetting LC_* > If it is, or if we are not sure, I suggest adding that message instead > to a package README that gets installed in > /usr/local/share/doc/pkg-readmes/. > > Search the tree for examples of pkg/README. > > That was actually what I was suggesting all along, but I wasn't totally > clear. Sorry! No worries, I'm learning all of this process, so I appreciate you take the time to review this port. Find attached the port with the README instead of a patch. Cheers, -- Paco Esteban https://onna.be/gpgkey.asc vf1.tgz Description: Binary data
Re: NEW: net/vf1
On Thu, Dec 13, 2018 at 06:52:14PM +0100, Paco Esteban wrote: > I guess a note on the README is enough. Here's the port with a patch for > that. If you think something else should be done, I can maybe contact > with the author. We've talked a couple of times on IRC and is a nice > guy. Do we know if this is an OpenBSD-specific issue? If it is, or if we are not sure, I suggest adding that message instead to a package README that gets installed in /usr/local/share/doc/pkg-readmes/. Search the tree for examples of pkg/README. That was actually what I was suggesting all along, but I wasn't totally clear. Sorry! -- Best Regards Edd Barrett http://www.theunixzoo.co.uk
Re: NEW: net/vf1
On Thu, 13 Dec 2018, Edd Barrett wrote: > On Thu, Dec 13, 2018 at 02:27:17PM +0100, Paco Esteban wrote: > > So, given this, should I make it dependent on textproc/py-chardet ? or > > should be enough with the "set this on your rc file" thing ? > > chardet makes no difference, however, setting LC_CTYPE=en_US.UTF-8 makes > the crash go away. > > Not sure if it's worth mentioning in a README or not. I guess most users > already have LC_CTYPE set in their X session. The only reason I didn't > have it set is because I do all my porting under a different user > account. > > Thoughts? I guess a note on the README is enough. Here's the port with a patch for that. If you think something else should be done, I can maybe contact with the author. We've talked a couple of times on IRC and is a nice guy. Cheers, -- Paco Esteban https://onna.be/gpgkey.asc vf1.tgz Description: Binary data
Re: NEW: net/vf1
On Thu, Dec 13, 2018 at 02:27:17PM +0100, Paco Esteban wrote: > So, given this, should I make it dependent on textproc/py-chardet ? or > should be enough with the "set this on your rc file" thing ? chardet makes no difference, however, setting LC_CTYPE=en_US.UTF-8 makes the crash go away. Not sure if it's worth mentioning in a README or not. I guess most users already have LC_CTYPE set in their X session. The only reason I didn't have it set is because I do all my porting under a different user account. Thoughts? -- Best Regards Edd Barrett http://www.theunixzoo.co.uk
Re: NEW: net/vf1
Hi Edd,
On Thu, 13 Dec 2018, Edd Barrett wrote:
> Port-wise, I have one comment. I'd remove NO_TEST=Yes. Although there are no
> tests, it still succeeds to invoke the test target. If tests are added in a
> later release, we will run them without having to flip NO_TEST.
Ok, I'll remove it.
> I found a crash:
> ...
> VF-1>
> [1] Floodgap Systems gopher root/
> [2] Enter new search keywords
> [3] Folders/directories are least accurate! (and other notes)
> [4] Refining your query
> [5] France/
> [6] France/
> [7] FFDN: A Federation of DIY-ISPs in France and Belgium/
> Traceback (most recent call last):
> File "/usr/local/bin/vf1", line 11, in
> load_entry_point('VF-1==0.0.10', 'console_scripts', 'vf1')()
> File "/usr/local/lib/python3.6/site-packages/vf1.py", line 1004, in main
> gc.cmdloop()
> File "/usr/local/lib/python3.6/cmd.py", line 138, in cmdloop
> stop = self.onecmd(line)
> File "/usr/local/lib/python3.6/cmd.py", line 204, in onecmd
> return self.emptyline()
> File "/usr/local/lib/python3.6/site-packages/vf1.py", line 796, in emptyline
> self.show_lookup(offset=i, end=i+10)
> File "/usr/local/lib/python3.6/site-packages/vf1.py", line 500, in
> show_lookup
> print(self._format_gopheritem(n+offset+1, gi, name, url))
> UnicodeEncodeError: 'ascii' codec can't encode character '\u2013' in position
> 9: ordinal not in range(128)
> --->8---
It crashes trying to show a unicode char on what would be result "8":
[8] 2018 – bitreichcon in Rodez, France/
I have no problems on my machine with that, so I've been reading the
README.md and it has something about encodings:
"""
## Text encoding
VF-1 attempts to decode the content received for any text-based item types
(e.g. 0, 1, 7, h) as UTF-8. Most content in gopherspace is ASCII-encoded, and
since UTF-8 is backward compatible with ASCII, this will generally "just work".
If the received content *cannot* be decoded as UTF-8, one of two possible
things will happen.
If the [chardet](https://pypi.python.org/pypi/chardet) Python module is
installed on your system, VF-1 will use it to attempt to automatically detect
the encoding used and decode the text appropriately. Note that pip etc. will
not install chardet for you when you install VF-1, as VF-1 does not formally
depend on chardet. It uses it opportunistically, so that it can still be
easily installed and used on systems where chardet is not / cannot be installed.
If chardet is not installed, or if chardet cannot identify an encoding with
confidence exceeding 0.5, VF-1 will attempt to fall back to a single,
user-specified alternative encoding. This encoding can be set with, e.g.:
```
VF-1> set encoding koi8-r
```
The default fall back encoding is iso-8559-1, which is used by the popular
gopher site floodgap.com. If you routinely visit gopher sites encoded with some
other encoding, consider using an RC file (see below) to automatically set your
alternative encoding at start up.
"""
So, given this, should I make it dependent on textproc/py-chardet ? or
should be enough with the "set this on your rc file" thing ?
Cheers,
--
Paco Esteban
https://onna.be/gpgkey.asc
Re: NEW: net/vf1
Hey Paco,
On Thu, Dec 13, 2018 at 12:01:12PM +0100, Paco Esteban wrote:
> Thanks Solène for your suggestion.
> Here's the updated port.
Port-wise, I have one comment. I'd remove NO_TEST=Yes. Although there are no
tests, it still succeeds to invoke the test target. If tests are added in a
later release, we will run them without having to flip NO_TEST.
I found a crash:
---8<---
Welcome to VF-1!
[103/1991]
Enjoy your flight through Gopherspace...
VF-1> go sdf.org
Welcome to the SDF Public Access UNIX System .. est. 1987
Official Site of the Internet Gopher Club Underground Syndicate
We offer FREE and inexpensive memberships for people interested
in the UNIX system and internetworking. Personal GOPHERSPACE
is available to all users as well as hundreds of UNIX utilities,
games and networking utilities. We are a federally recognized
non-profit 501(c)7 organization and we are supported entirely
by donations and membership dues. ssh://sdf.org
[1] SDF PHLOGOSPHERE (275 phlogs)/
[2] SDF GOPHERSPACE (1276 ACTIVE users)/
[3] SDF GOPHERSPACE (1363 AGED users)/
[4] SDF GOPHERSPACE (372 ANCIENT users)/
[5] SDF Frequently Asked Questions (FAQ)/
[6] SDF Accredited University Courses/
[7] Software and Documentation for various computers/
[8] GopherSpace SEARCH Engine
[9] Floodgap's GOPHERSPACE/
Gophered by Gophernicus/101 on NetBSD/amd64 8.0_STABLE
VF-1> 8
Query term: france
[1] Floodgap Systems gopher root/
Veronica-2 2.058.2 (C)2000-2016 Cameron Kaiser
Engine version 0.4.051
** Search in progress, please wait **
*** Search terms: france ***
First 30 selectors displayed (page 1).
Results sorted by apparent relevance.
Approximately 300 total matches.
[2] Enter new search keywords
[3] Folders/directories are least accurate! (and other notes)
[4] Refining your query
[5] France/
gopher://therandymon.com:70/1/Travel/France
[6] France/
gopher://dictatorshandbook.net:70/1/Travel/France
[7] FFDN: A Federation of DIY-ISPs in France and Belgium/
gopher://gopher.raumzeitlabor.org:70/1/event/4956
[8] 2018 _ bitreichcon in Rodez, France/
gopher://bitreich.org:70/1/con/2018
[9] Francis.Bacon/
gopher://gopher.std.com:70/11/The Online Book Initiative/Francis.Bacon
[10] France/
gopher://gopher.std.com:70/11/The Online Book Initiative/Anthems/France
[11] [09-Jun-2011] france/
gopher://sdf.org:70/1/users/france/
[12] [23-Jan-2006] francis/
...
[34] France
gopher://gopherpedia.com:70/0/France
[35] Enter new search keywords
[36] Back to the beginning/
[37] Next 30 matches/
VF-1>
[1] Floodgap Systems gopher root/
[2] Enter new search keywords
[3] Folders/directories are least accurate! (and other notes)
[4] Refining your query
[5] France/
[6] France/
[7] FFDN: A Federation of DIY-ISPs in France and Belgium/
Traceback (most recent call last):
File "/usr/local/bin/vf1", line 11, in
load_entry_point('VF-1==0.0.10', 'console_scripts', 'vf1')()
File "/usr/local/lib/python3.6/site-packages/vf1.py", line 1004, in main
gc.cmdloop()
File "/usr/local/lib/python3.6/cmd.py", line 138, in cmdloop
stop = self.onecmd(line)
File "/usr/local/lib/python3.6/cmd.py", line 204, in onecmd
return self.emptyline()
File "/usr/local/lib/python3.6/site-packages/vf1.py", line 796, in emptyline
self.show_lookup(offset=i, end=i+10)
File "/usr/local/lib/python3.6/site-packages/vf1.py", line 500, in show_lookup
print(self._format_gopheritem(n+offset+1, gi, name, url))
UnicodeEncodeError: 'ascii' codec can't encode character '\u2013' in position
9: ordinal not in range(128)
--->8---
(Before the crash, I pressed enter on a blank line to page the long list
of results)
Good old Python3 and unicode...
--
Best Regards
Edd Barrett
http://www.theunixzoo.co.uk
Re: NEW: net/vf1
On Thu, 13 Dec 2018, Solene Rapenne wrote: > Paco Esteban wrote: > > Ping. > > > > (zip attached again) > > hi > > the port looks fine to me but it doesn't provide any documentation. In the > sources there is a README.md file which could be used. You can use the port > sysutils/boar as an example for adding the README.md file to the package. > Thanks Solène for your suggestion. Here's the updated port. -- Paco Esteban https://onna.be/gpgkey.asc vf1.tgz Description: Binary data
Re: NEW: net/vf1
Paco Esteban wrote: > Ping. > > (zip attached again) hi the port looks fine to me but it doesn't provide any documentation. In the sources there is a README.md file which could be used. You can use the port sysutils/boar as an example for adding the README.md file to the package.
Re: NEW: net/vf1
Ping. (zip attached again) -- Paco Esteban https://onna.be/gpgkey.asc vf1.tgz Description: Binary data
Re: NEW: net/vf1
On Tue, 13 Nov 2018, Stuart Henderson wrote: > I guess not too much interest in the 90's protocol from Minneapolis ;) Yeah, I can't blame anybody for that. It's almost archeology :-P > Anyway you sent the package, not the port. And that's the facepalm moment I was expecting ... Hopefully I'll attach the correct thing now. Sorry. -- Paco Esteban https://onna.be/gpgkey.asc vf1.tgz Description: Binary data
Re: NEW: net/vf1
On 2018/11/13 20:07, Paco Esteban wrote: > On Wed, 07 Nov 2018, Paco Esteban wrote: > > > ping ... > > I guess there's no interest in this port. > > Anyway, could somebody please take a look at it just to tell me if > there's something wrong and/or what can I improve for future reference ? > > Thank you. > > -- > Paco Esteban > https://onna.be/gpgkey.asc > I guess not too much interest in the 90's protocol from Minneapolis ;) Anyway you sent the package, not the port.
Re: NEW: net/vf1
On Wed, 07 Nov 2018, Paco Esteban wrote: > ping ... I guess there's no interest in this port. Anyway, could somebody please take a look at it just to tell me if there's something wrong and/or what can I improve for future reference ? Thank you. -- Paco Esteban https://onna.be/gpgkey.asc
Re: NEW: net/vf1
ping ... On Tue, 30 Oct 2018, Paco Esteban wrote: > Hi all, > > Find attached vf1-0.0.10. > This is a small gopher client written in python I usually use (not > written by me though). > > - > $ pkg_info vf1 > Information for inst:vf1-0.0.10 > > Comment: > command line gopher client > > Description: > VF-1 is a command line gopher client. It is built around an interactive > command > prompt, and has a very "REPL" feeling. You only need a small number of > commands > to get around, and most of them can be abbreviated to one or two chars > > Maintainer: Paco Esteban > > WWW: https://github.com/solderpunk/VF-1 > - > > OK ? > > p.s.: This is my first attempt to create a port, so there will be errors > probably. -- Paco Esteban https://onna.be/gpgkey.asc
NEW: net/vf1
Hi all, Find attached vf1-0.0.10. This is a small gopher client written in python I usually use (not written by me though). - $ pkg_info vf1 Information for inst:vf1-0.0.10 Comment: command line gopher client Description: VF-1 is a command line gopher client. It is built around an interactive command prompt, and has a very "REPL" feeling. You only need a small number of commands to get around, and most of them can be abbreviated to one or two chars Maintainer: Paco Esteban WWW: https://github.com/solderpunk/VF-1 - OK ? p.s.: This is my first attempt to create a port, so there will be errors probably. -- Paco Esteban https://onna.be/gpgkey.asc vf1-0.0.10.tgz Description: Binary data
