Re: NEW. sysutils/croc

2024-02-26 Thread Sebastien Marie
Paco Esteban  writes:

> After reading other comments, I added the README to ${PREFIX}/share/doc/croc/
> This is markdown, so not so pleasant to read from the terminal.  But
> it's something.

fine with it.

>> > The software has a "relay" mode in which it acts as a daemon.  I did not
>> > include startup scripts or reserve a system user, should we do that ?
>> 
>> I don't have strong opinion about it. I am fine without it, but if you
>> expect users to want to setup a local relay, it might be preferable (as
>> it will be properly configured at first).
>
> I added the startup script and user in the end.  I think it's better to
> have it even if the user base is small.

the @newuser is a bit odd: you have a home defined to
${LOCALSTATEDIR}/croc , but the directory isn't created by the port.

if the relay mode doesn't need an owned directory as home, just use /var/empty

for the rc script, prefer:
  daemon="${TRUEPREFIX}/bin/croc relay"
  daemon_flags=""

so the relay command will not be overrided by user setting.

please note that the default configuration (if the user enable the
script) makes the relay to listen to *:90{09,10,11,12,13}. It might be
preferable to listen to localhost by default (even if not really an
useful relay).

  daemon_flags="--host localhost"

Thanks.
-- 
Sebastien Marie



Re: NEW. sysutils/croc

2024-02-26 Thread Paco Esteban
On Mon, 26 Feb 2024, Sebastien Marie wrote:

> Paco Esteban  writes:
> 
> > Hi ports@,
> >
> > cat DESCR
> >
> > croc is a tool that allows any two computers to simply and securely 
> > transfer
> > files and folders.
> > croc's features include:
> >
> > * allow any two computers to transfer data (using a relay)
> > * end-to-end encryption (using PAKE)
> > * easy cross-platform transfers (Windows, Linux, Mac)
> > * multiple file transfers
> > * resume transfers that are interrupted
> > * local server or port-forwarding not needed
> > * ipv6-first with ipv4 fallback
> > * can use proxy, like tor
> >
> > You'll notice than PLIST only contains the binary.  The only
> > documentation they include in the sources is the project README file,
> > which I'm not sure if we should include in the package.
> 
> Eventually, it could be possible add just few lines as example in DESC:
> 
> $ croc send foobar
> Sending 'foobar' (6.6 MB)
> Code is: 1767-cubic-ringo-source
> On the other computer run
> 
> croc 1767-cubic-ringo-source

After reading other comments, I added the README to ${PREFIX}/share/doc/croc/
This is markdown, so not so pleasant to read from the terminal.  But
it's something.

> > The software has a "relay" mode in which it acts as a daemon.  I did not
> > include startup scripts or reserve a system user, should we do that ?
> 
> I don't have strong opinion about it. I am fine without it, but if you
> expect users to want to setup a local relay, it might be preferable (as
> it will be properly configured at first).

I added the startup script and user in the end.  I think it's better to
have it even if the user base is small.

> > Comments and suggestions welcome.
> >
> > Ok to import ?
> 
> There is still a commented "FIX_CLEANUP_PERMISSIONS" in the Makefile.

Removed.

> Outside of that, I am fine with it. ok semarie@

Still ok ?

Here's the diff for the new user and attached the modified port:

diff /usr/ports
commit - 26872df732fc01fa20b4946684e0cbe5fe3971ff
path + /usr/ports
blob - b42938f202aa5f3563a1fbbd9b4e89d5e7a3d49a
file + infrastructure/db/user.list
--- infrastructure/db/user.list
+++ infrastructure/db/user.list
@@ -405,3 +405,4 @@ id  usergroup   port
 894 _gonic _gonic  audio/gonic
 895 _soju  _soju   net/soju
 896 _certspotter   _certspottersecurity/certspotter
+897 _croc  _croc   sysutils/croc

-- 
Paco Esteban.
0x5818130B8A6DBC03


croc.tgz
Description: application/tar-gz


Re: NEW. sysutils/croc

2024-02-26 Thread Jag Talon
On Sun Feb 25, 2024 at 2:19 PM EST, Paco Esteban wrote:

> You'll notice than PLIST only contains the binary.  The only
> documentation they include in the sources is the project README file,
> which I'm not sure if we should include in the package.
> The software has a "relay" mode in which it acts as a daemon.  I did not
> include startup scripts or reserve a system user, should we do that ?

I used to use croc a lot--I'm excited about this port! I think personally I'd
like to have access to the usage section of the README file from the repo easily
accessible (but perhaps without the relay part) so that I don't have to go to
Github to remember the commands.



Re: NEW. sysutils/croc

2024-02-26 Thread Sebastien Marie
Paco Esteban  writes:

> Hi ports@,
>
> cat DESCR
>
> croc is a tool that allows any two computers to simply and securely 
> transfer
> files and folders.
> croc's features include:
>
> * allow any two computers to transfer data (using a relay)
> * end-to-end encryption (using PAKE)
> * easy cross-platform transfers (Windows, Linux, Mac)
> * multiple file transfers
> * resume transfers that are interrupted
> * local server or port-forwarding not needed
> * ipv6-first with ipv4 fallback
> * can use proxy, like tor
>
> You'll notice than PLIST only contains the binary.  The only
> documentation they include in the sources is the project README file,
> which I'm not sure if we should include in the package.

Eventually, it could be possible add just few lines as example in DESC:

$ croc send foobar
Sending 'foobar' (6.6 MB)
Code is: 1767-cubic-ringo-source
On the other computer run

croc 1767-cubic-ringo-source

> The software has a "relay" mode in which it acts as a daemon.  I did not
> include startup scripts or reserve a system user, should we do that ?

I don't have strong opinion about it. I am fine without it, but if you
expect users to want to setup a local relay, it might be preferable (as
it will be properly configured at first).

> Comments and suggestions welcome.
>
> Ok to import ?

There is still a commented "FIX_CLEANUP_PERMISSIONS" in the Makefile.
Outside of that, I am fine with it. ok semarie@

Thanks.
-- 
Sebastien Marie



NEW. sysutils/croc

2024-02-25 Thread Paco Esteban
Hi ports@,

cat DESCR

croc is a tool that allows any two computers to simply and securely transfer
files and folders.
croc's features include:

* allow any two computers to transfer data (using a relay)
* end-to-end encryption (using PAKE)
* easy cross-platform transfers (Windows, Linux, Mac)
* multiple file transfers
* resume transfers that are interrupted
* local server or port-forwarding not needed
* ipv6-first with ipv4 fallback
* can use proxy, like tor

You'll notice than PLIST only contains the binary.  The only
documentation they include in the sources is the project README file,
which I'm not sure if we should include in the package.
The software has a "relay" mode in which it acts as a daemon.  I did not
include startup scripts or reserve a system user, should we do that ?

Comments and suggestions welcome.

Ok to import ?

-- 
Paco Esteban.
0x5818130B8A6DBC03


croc.tgz
Description: application/tar-gz