Re: New port : editors/kakoune
Le Sunday 14 Jun 2020 à 11:23 (+0200), Solene Rapenne a écrit : > looks good, I'm ok to import it with a minor change. > > Comparing to Makefile.template, the variables MASTER_SITES and > EXTRACT_SUFX should be moved below WANTLIB. Fixed in the attached tarball. Thank you. fredg kakoune-v3.tgz Description: Binary data
Re: New port : editors/kakoune
On Sun, 14 Jun 2020 03:51:02 +0200 Klemens Nanni : > On Sat, Jun 13, 2020 at 10:15:01PM +0200, Frédéric GALUSIK wrote: > [...] > Thanks to cmake, this is relatively straight forward; only a few > things I could spot for now: > > PKGNAME defaults to DISTNAME, so the former is redundant. > > WANTLIB is incomplete, you'll want to see "make > port-lib-depends-check". > > COMPILER is set correctly, however a comment is appropiate to tell > *why* such a selection is needed; here it's probably the use of > -std=c++17, so you could just add "# -std=c++17" above the COMPILER > line, that's it. > > For readability, "=" is usually followed by tabs in ports Makefiles to > align the second column. > > I've done all of this in the attached tarball, thanks a lot for > working on kakoune :-) looks good, I'm ok to import it with a minor change. Comparing to Makefile.template, the variables MASTER_SITES and EXTRACT_SUFX should be moved below WANTLIB.
Re: New port : editors/kakoune
Le Sunday 14 Jun 2020 à 03:51 (+0200), Klemens Nanni a écrit : > On Sat, Jun 13, 2020 at 10:15:01PM +0200, Frédéric GALUSIK wrote: > > Then, it was built and tested on amd64, it needs some love on others > > platforms. > Thanks to cmake, this is relatively straight forward; only a few things > I could spot for now: > > PKGNAME defaults to DISTNAME, so the former is redundant. > > WANTLIB is incomplete, you'll want to see "make port-lib-depends-check". > > COMPILER is set correctly, however a comment is appropiate to tell *why* > such a selection is needed; here it's probably the use of -std=c++17, > so you could just add "# -std=c++17" above the COMPILER line, that's it. > > For readability, "=" is usually followed by tabs in ports Makefiles to > align the second column. > > I've done all of this in the attached tarball, thanks a lot for working > on kakoune :-) It is noted. Thank you very much. fredg
Re: New port : editors/kakoune
On Sat, Jun 13, 2020 at 10:15:01PM +0200, Frédéric GALUSIK wrote: > Then, it was built and tested on amd64, it needs some love on others > platforms. Thanks to cmake, this is relatively straight forward; only a few things I could spot for now: PKGNAME defaults to DISTNAME, so the former is redundant. WANTLIB is incomplete, you'll want to see "make port-lib-depends-check". COMPILER is set correctly, however a comment is appropiate to tell *why* such a selection is needed; here it's probably the use of -std=c++17, so you could just add "# -std=c++17" above the COMPILER line, that's it. For readability, "=" is usually followed by tabs in ports Makefiles to align the second column. I've done all of this in the attached tarball, thanks a lot for working on kakoune :-) kakoune-v2.tgz Description: Binary data
New port : editors/kakoune
Hello, Here is my first port and, first, I want thank a lot solene@ for her kindly help. Then, it was built and tested on amd64, it needs some love on others platforms. So, Kakoune is a code editor that implements Vi’s "keystrokes as a text editing language" model. As it’s also a modal editor, it is somewhat similar to the Vim editor (after which Kakoune was originally inspired). Kakoune can operate in two modes, normal and insertion. In insertion mode, keys are directly inserted into the current buffer. In normal mode, keys are used to manipulate the current selection and to enter insertion mode. Kakoune has a strong focus on interactivity, most commands provide immediate and incremental results, while still being competitive (as in keystroke count) with Vim. Kakoune works on selections, which are oriented, inclusive range of characters, selections have an anchor and a cursor character. Most commands move both of them, except when extending selection where the anchor character stays fixed and the cursor one moves around. https://kakoune.org/ https://github.com/mawww/kakoune/wiki/OpenBSD Best regards. fredg kakoune.tgz Description: Binary data