Re: [UPDATE] lang/nim 1.2.0 -> 1.4.2

2021-02-11 Thread Luca De Pandis 
Hi,
I fixed the MAINTAINER syntax.

If the patch is ok could someone commit it, please?


Best regards,
Luca De Pandis


Index: Makefile
===
RCS file: /cvs/ports/lang/nim/Makefile,v
retrieving revision 1.11
diff -u -p -u -p -r1.11 Makefile
--- Makefile2 May 2020 09:33:06 -   1.11
+++ Makefile11 Feb 2021 13:42:45 -
@@ -6,7 +6,7 @@ BROKEN-i386 = hardcodes gcc; see config/
 

 COMMENT =  statically typed, imperative programming language
 

-VERSION =  1.2.0
+VERSION =  1.4.2
 DISTNAME = nim-${VERSION}
 EXTRACT_SUFX = .tar.xz
 REVISION = 0
@@ -14,6 +14,9 @@ REVISION =0
 CATEGORIES =   lang
 

 HOMEPAGE = http://nim-lang.org/
+
+MAINTAINER =   Luca De Pandis 
+
 MASTER_SITES = http://nim-lang.org/download/ \
https://download.tuxfamily.org/jod/lang/nim/
 

@@ -22,6 +25,13 @@ PERMIT_PACKAGE = Yes
 

 WANTLIB =  c m
 

+# cc is not a supported compiler, so CC has to be set as clang instead
+CC =   clang
+
+MODULES =  lang/python
+
+MODPY_VERSION =${MODPY_DEFAULT_VERSION_3}
+
 post-patch:
mkdir -p ${WRKSRC}/nimcache-port
mkdir -p ${WRKSRC}/nimcache-port-test
@@ -33,15 +43,15 @@ do-build:
cd ${WRKSRC} && ${SETENV} CC="${CC}" LINKER="${CC}" \
CFLAGS="${CFLAGS}" sh build.sh
# slow machines can get a head of themselves and fail to link
-   cd ${WRKSRC} && bin/nim c -d:release --parallelBuild:1 \
+   cd ${WRKSRC} && bin/nim c -d:release --parallelBuild:${MAKE_JOBS} \
--nimcache:"${WRKSRC}/nimcache-port" --listFullPaths \
-   --listCmd --putenv:"PATH=${PATH}" koch
-   cd ${WRKSRC} && ./koch boot -d:release --parallelBuild:1 \
+   --listCmd --putenv:"PATH=${PATH}" --cc:${CC} koch
+   cd ${WRKSRC} && ./koch boot -d:release --parallelBuild:${MAKE_JOBS} \
--nimcache:"${WRKSRC}/nimcache-port" --listFullPaths \
-   --listCmd --putenv:"PATH=${PATH}"
-   cd ${WRKSRC} && ./koch nimble -d:release --parallelBuild:1 \
+   --listCmd --putenv:"PATH=${PATH}" --cc:${CC}
+   cd ${WRKSRC} && ./koch nimble -d:release --parallelBuild:${MAKE_JOBS} \
--nimcache:"${WRKSRC}/nimcache-port" --listFullPaths \
-   --listCmd --putenv:"PATH=${PATH}"
+   --listCmd --putenv:"PATH=${PATH}" --cc:${CC}
 

 do-install:
${INSTALL_PROGRAM_DIR} ${PREFIX}/bin
@@ -54,11 +64,13 @@ do-install:
${INSTALL_DATA} ${WRKSRC}/doc/*.txt ${PREFIX}/share/doc/nim
${INSTALL_DATA_DIR} ${PREFIX}/share/examples/nim
${INSTALL_DATA} ${WRKSRC}/config/*.cfg ${PREFIX}/share/examples/nim
+   ${MODPY_BIN} ${MODPY_LIBDIR}/compileall.py \
+   ${PREFIX}/lib/nim/pure/unidecode/gen.py
 

 do-test:
cd ${WRKSRC} && ${SETENV} ./koch test all -d:release \
-   --parallelBuild:1 --listFullPaths --listCmd \
+   --parallelBuild:${MAKE_JOBS} --listFullPaths --listCmd \
--nimcache:"${WRKSRC}/nimcache-port-test" \
-   --putenv:"PATH=${PATH}"
+   --putenv:"PATH=${PATH}" --cc:${CC}
 

 .include 
Index: distinfo
===
RCS file: /cvs/ports/lang/nim/distinfo,v
retrieving revision 1.5
diff -u -p -u -p -r1.5 distinfo
--- distinfo2 May 2020 09:33:06 -   1.5
+++ distinfo11 Feb 2021 13:42:45 -
@@ -1,2 +1,2 @@
-SHA256 (nim-1.2.0.tar.xz) = TpRYOjc5ZYIYBeZl4KBfUvthCRZnbtsJFIlBQVY3xXU=
-SIZE (nim-1.2.0.tar.xz) = 5869428
+SHA256 (nim-1.4.2.tar.xz) = 
03a47583777dd81380a3407aa6a788c9aa8a67df4821025770c9ac4186291161
+SIZE (nim-1.4.2.tar.xz) = 4770616
Index: patches/patch-install_sh
===
RCS file: /cvs/ports/lang/nim/patches/patch-install_sh,v
retrieving revision 1.1
diff -u -p -u -p -r1.1 patch-install_sh
--- patches/patch-install_sh2 May 2020 09:33:06 -   1.1
+++ patches/patch-install_sh11 Feb 2021 13:42:45 -
@@ -1,4 +1,7 @@
 install.sh.orig 2020-04-03 17:25:49 UTC
+$OpenBSD$
+
+Index: install.sh
+--- install.sh.orig
 +++ install.sh
 @@ -15,48 +15,14 @@ if [ $# -eq 1 ] ; then
  "--help"|"-h"|"help"|"h")
@@ -19,7 +22,7 @@
 -  libdir=/usr/lib/nim
 -  docdir=/usr/share/nim/doc
 -  datadir=/usr/share/nim/data
--  nimbleDir="/opt/nimble/pkgs/compiler-1.2.0"
+-  nimbleDir="/opt/nimble/pkgs/compiler-1.4.2"
 -  ;;
 -"/usr/local/bin")
 -  bindir=/usr/local/bin
@@ -27,7 +30,7 @@
 -  libdir=/usr/local/lib/nim
 -  docdir=/usr/local/share/nim/doc
 -  datadir=/usr/local/share/nim/data
--  nimbleDir="/opt/nimble/pkgs/compiler-1.2.0"
+-  nimbleDir="/opt/nimble/pkgs/compiler-1.4.2"
 -  ;;
 -"/opt")
 -

Re: [UPDATE] lang/nim 1.2.0 -> 1.4.2

2021-02-07 Thread Luca De Pandis 
Hi,
since I don't think there are people interested in such port beside me,
I will gladly take the maintainership of lang/nim.

I modified the patch in order to reflect the change.

Could someone commit if patch is ok?


Best regards,
Luca De Pandis


Index: Makefile
===
RCS file: /cvs/ports/lang/nim/Makefile,v
retrieving revision 1.11
diff -u -p -u -p -r1.11 Makefile
--- Makefile2 May 2020 09:33:06 -   1.11
+++ Makefile6 Feb 2021 00:10:49 -
@@ -6,7 +6,7 @@ BROKEN-i386 = hardcodes gcc; see config/
 

 COMMENT =  statically typed, imperative programming language
 

-VERSION =  1.2.0
+VERSION =  1.4.2
 DISTNAME = nim-${VERSION}
 EXTRACT_SUFX = .tar.xz
 REVISION = 0
@@ -14,6 +14,9 @@ REVISION =0
 CATEGORIES =   lang
 

 HOMEPAGE = http://nim-lang.org/
+
+MAINTAINER =   luca.depan...@protonmail.com
+
 MASTER_SITES = http://nim-lang.org/download/ \
https://download.tuxfamily.org/jod/lang/nim/
 

@@ -22,6 +25,13 @@ PERMIT_PACKAGE = Yes
 

 WANTLIB =  c m
 

+# cc is not a supported compiler, so CC has to be set as clang instead
+CC =   clang
+
+MODULES =  lang/python
+
+MODPY_VERSION =${MODPY_DEFAULT_VERSION_3}
+
 post-patch:
mkdir -p ${WRKSRC}/nimcache-port
mkdir -p ${WRKSRC}/nimcache-port-test
@@ -33,15 +43,15 @@ do-build:
cd ${WRKSRC} && ${SETENV} CC="${CC}" LINKER="${CC}" \
CFLAGS="${CFLAGS}" sh build.sh
# slow machines can get a head of themselves and fail to link
-   cd ${WRKSRC} && bin/nim c -d:release --parallelBuild:1 \
+   cd ${WRKSRC} && bin/nim c -d:release --parallelBuild:${MAKE_JOBS} \
--nimcache:"${WRKSRC}/nimcache-port" --listFullPaths \
-   --listCmd --putenv:"PATH=${PATH}" koch
-   cd ${WRKSRC} && ./koch boot -d:release --parallelBuild:1 \
+   --listCmd --putenv:"PATH=${PATH}" --cc:${CC} koch
+   cd ${WRKSRC} && ./koch boot -d:release --parallelBuild:${MAKE_JOBS} \
--nimcache:"${WRKSRC}/nimcache-port" --listFullPaths \
-   --listCmd --putenv:"PATH=${PATH}"
-   cd ${WRKSRC} && ./koch nimble -d:release --parallelBuild:1 \
+   --listCmd --putenv:"PATH=${PATH}" --cc:${CC}
+   cd ${WRKSRC} && ./koch nimble -d:release --parallelBuild:${MAKE_JOBS} \
--nimcache:"${WRKSRC}/nimcache-port" --listFullPaths \
-   --listCmd --putenv:"PATH=${PATH}"
+   --listCmd --putenv:"PATH=${PATH}" --cc:${CC}
 

 do-install:
${INSTALL_PROGRAM_DIR} ${PREFIX}/bin
@@ -54,11 +64,13 @@ do-install:
${INSTALL_DATA} ${WRKSRC}/doc/*.txt ${PREFIX}/share/doc/nim
${INSTALL_DATA_DIR} ${PREFIX}/share/examples/nim
${INSTALL_DATA} ${WRKSRC}/config/*.cfg ${PREFIX}/share/examples/nim
+   ${MODPY_BIN} ${MODPY_LIBDIR}/compileall.py \
+   ${PREFIX}/lib/nim/pure/unidecode/gen.py
 

 do-test:
cd ${WRKSRC} && ${SETENV} ./koch test all -d:release \
-   --parallelBuild:1 --listFullPaths --listCmd \
+   --parallelBuild:${MAKE_JOBS} --listFullPaths --listCmd \
--nimcache:"${WRKSRC}/nimcache-port-test" \
-   --putenv:"PATH=${PATH}"
+   --putenv:"PATH=${PATH}" --cc:${CC}
 

 .include 
Index: distinfo
===
RCS file: /cvs/ports/lang/nim/distinfo,v
retrieving revision 1.5
diff -u -p -u -p -r1.5 distinfo
--- distinfo2 May 2020 09:33:06 -   1.5
+++ distinfo6 Feb 2021 00:10:49 -
@@ -1,2 +1,2 @@
-SHA256 (nim-1.2.0.tar.xz) = TpRYOjc5ZYIYBeZl4KBfUvthCRZnbtsJFIlBQVY3xXU=
-SIZE (nim-1.2.0.tar.xz) = 5869428
+SHA256 (nim-1.4.2.tar.xz) = 
03a47583777dd81380a3407aa6a788c9aa8a67df4821025770c9ac4186291161
+SIZE (nim-1.4.2.tar.xz) = 4770616
Index: patches/patch-install_sh
===
RCS file: /cvs/ports/lang/nim/patches/patch-install_sh,v
retrieving revision 1.1
diff -u -p -u -p -r1.1 patch-install_sh
--- patches/patch-install_sh2 May 2020 09:33:06 -   1.1
+++ patches/patch-install_sh6 Feb 2021 00:10:49 -
@@ -1,4 +1,7 @@
 install.sh.orig 2020-04-03 17:25:49 UTC
+$OpenBSD$
+
+Index: install.sh
+--- install.sh.orig
 +++ install.sh
 @@ -15,48 +15,14 @@ if [ $# -eq 1 ] ; then
  "--help"|"-h"|"help"|"h")
@@ -19,7 +22,7 @@
 -  libdir=/usr/lib/nim
 -  docdir=/usr/share/nim/doc
 -  datadir=/usr/share/nim/data
--  nimbleDir="/opt/nimble/pkgs/compiler-1.2.0"
+-  nimbleDir="/opt/nimble/pkgs/compiler-1.4.2"
 -  ;;
 -"/usr/local/bin")
 -  bindir=/usr/local/bin
@@ -27,7 +30,7 @@
 -  libdir=/usr/local/lib/nim
 -  docdir=/usr/local/share/nim/doc
 -  datadir=/usr/local/share/nim/data
--

Re: [UPDATE] lang/nim 1.2.0 -> 1.4.2

2021-02-03 Thread Luca De Pandis 
up



On Sat, Jan 16, 2021 at 02:31:42PM +0100, Luca De Pandis wrote:
> Hi,
> thank you everyone for the feedback.
> 
> On Fri, Jan 15, 2021 at 05:01:19PM +, Stuart Henderson wrote:
> > 3 days is way too soon to be prodding really, especially for what is
> > a relatively specialist port that most ports devs won't use. Anyway a
> > few quick comments I am short on time - as mentioned by others please
> > send a diff not a tar for updates. Use cvs add / cvs rm if there are
> > any new/removed files and cvs diff -uNp.
> > 
> > patch-config_nim_cfg:
> > -cc = gcc
> > +cc = clang
> > 
> > The compiler should be passed from the port in CC not hardcoded.
> nim.cfg is read by the nim compiler to know what C compiler it has to run
> when it is going to compile nim code.
> It cannot be left neither unset nor set to cc %= "$CC", otherwise the
> compilation will fail.
> That said, I added the --cc:$CC parameter in Makefile order to let the port
> build with the compiler of choice, as long as it is supported by nim. This
> parameter will override the value in nim.cfg during the building of the port.
> 
> 
> > 
> > PLIST: missing @sample for the new cfg file
> Now it should be ok.
> 
> $ grep sample pkg/PLIST   
>   
>  
> @sample ${SYSCONFDIR}/nim/
> @sample ${SYSCONFDIR}/nim/nim.cfg
> @sample ${SYSCONFDIR}/nim/nimdoc.cfg
> @sample ${SYSCONFDIR}/nim/nimdoc.tex.cfg
> 
>  
> > Makefile: drop REVISION, maybe the --parallelBuild:1 should really
> > be ${MAKE_JOBS} instead of 1
> >
> Fixed.
> 
> 
> Best regards,
> Luca De Pandis
> 
> 
> 
> 
> Index: Makefile
> ===
> RCS file: /cvs/ports/lang/nim/Makefile,v
> retrieving revision 1.11
> diff -u -p -u -p -r1.11 Makefile
> --- Makefile  2 May 2020 09:33:06 -   1.11
> +++ Makefile  16 Jan 2021 13:10:55 -
> @@ -6,7 +6,7 @@ BROKEN-i386 = hardcodes gcc; see config/
>  
>  COMMENT =statically typed, imperative programming language
>  
> -VERSION =1.2.0
> +VERSION =1.4.2
>  DISTNAME =   nim-${VERSION}
>  EXTRACT_SUFX =   .tar.xz
>  REVISION =   0
> @@ -22,6 +22,13 @@ PERMIT_PACKAGE =   Yes
>  
>  WANTLIB =c m
>  
> +# cc is not a supported compiler, so CC has to be set as clang instead
> +CC = clang
> +
> +MODULES =lang/python
> +
> +MODPY_VERSION =  ${MODPY_DEFAULT_VERSION_3}
> +
>  post-patch:
>   mkdir -p ${WRKSRC}/nimcache-port
>   mkdir -p ${WRKSRC}/nimcache-port-test
> @@ -33,15 +40,15 @@ do-build:
>   cd ${WRKSRC} && ${SETENV} CC="${CC}" LINKER="${CC}" \
>   CFLAGS="${CFLAGS}" sh build.sh
>   # slow machines can get a head of themselves and fail to link
> - cd ${WRKSRC} && bin/nim c -d:release --parallelBuild:1 \
> + cd ${WRKSRC} && bin/nim c -d:release --parallelBuild:${MAKE_JOBS} \
>   --nimcache:"${WRKSRC}/nimcache-port" --listFullPaths \
> - --listCmd --putenv:"PATH=${PATH}" koch
> - cd ${WRKSRC} && ./koch boot -d:release --parallelBuild:1 \
> + --listCmd --putenv:"PATH=${PATH}" --cc:${CC} koch
> + cd ${WRKSRC} && ./koch boot -d:release --parallelBuild:${MAKE_JOBS} \
>   --nimcache:"${WRKSRC}/nimcache-port" --listFullPaths \
> - --listCmd --putenv:"PATH=${PATH}"
> - cd ${WRKSRC} && ./koch nimble -d:release --parallelBuild:1 \
> + --listCmd --putenv:"PATH=${PATH}" --cc:${CC}
> + cd ${WRKSRC} && ./koch nimble -d:release --parallelBuild:${MAKE_JOBS} \
>   --nimcache:"${WRKSRC}/nimcache-port" --listFullPaths \
> - --listCmd --putenv:"PATH=${PATH}"
> + --listCmd --putenv:"PATH=${PATH}" --cc:${CC}
>  
>  do-install:
>   ${INSTALL_PROGRAM_DIR} ${PREFIX}/bin
> @@ -54,11 +61,13 @@ do-install:
>   ${INSTALL_DATA} ${WRKSRC}/doc/*.txt ${PREFIX}/share/doc/nim
>   ${INSTALL_DATA_DIR} ${PREFIX}/share/examples/nim
>   ${INSTALL_DATA} ${WRKSRC}/config/*.cfg ${PREFIX}/share/examples/nim
> + ${MODPY_BIN} ${MODPY_LIBDIR}/compileall.py \
> + ${PREFIX}/lib/nim/pure/unidecode/gen.py
>  
>  do-test:
>   cd ${WRKSRC} && ${SETENV} ./koch test all -d:release \
> - --parallelBuild:1 --listFullPaths --listCmd \
> + --parallelBuild:${MAKE_JOBS} --listFullPaths --listCmd \
>   --nimcache:"${WRKSRC}/nimcache-port-test" \
> - --putenv:"PATH=${PATH}"
> + --putenv:"PATH=${PATH}" --cc:${CC}
>  
>  .include 
> Index: distinfo
> ===
> RCS file: /cvs/ports/lang/nim/distinfo,v
> retrieving revision 1.5
> diff -u -p -u -p -r1.5 distinfo
> --- distinfo  2 May 2020 09:33:06 -   1.5
> +++ distinfo  16 Jan 2021 13:10:55 -
> @@ -1,2 +1,2 @@
> -SHA256

Re: [UPDATE] lang/nim 1.2.0 -> 1.4.2

2021-01-16 Thread Luca De Pandis 
Hi,
thank you everyone for the feedback.

On Fri, Jan 15, 2021 at 05:01:19PM +, Stuart Henderson wrote:
> 3 days is way too soon to be prodding really, especially for what is
> a relatively specialist port that most ports devs won't use. Anyway a
> few quick comments I am short on time - as mentioned by others please
> send a diff not a tar for updates. Use cvs add / cvs rm if there are
> any new/removed files and cvs diff -uNp.
> 
> patch-config_nim_cfg:
> -cc = gcc
> +cc = clang
> 
> The compiler should be passed from the port in CC not hardcoded.
nim.cfg is read by the nim compiler to know what C compiler it has to run
when it is going to compile nim code.
It cannot be left neither unset nor set to cc %= "$CC", otherwise the
compilation will fail.
That said, I added the --cc:$CC parameter in Makefile order to let the port
build with the compiler of choice, as long as it is supported by nim. This
parameter will override the value in nim.cfg during the building of the port.


> 
> PLIST: missing @sample for the new cfg file
Now it should be ok.

$ grep sample pkg/PLIST 

 
@sample ${SYSCONFDIR}/nim/
@sample ${SYSCONFDIR}/nim/nim.cfg
@sample ${SYSCONFDIR}/nim/nimdoc.cfg
@sample ${SYSCONFDIR}/nim/nimdoc.tex.cfg

 
> Makefile: drop REVISION, maybe the --parallelBuild:1 should really
> be ${MAKE_JOBS} instead of 1
>
Fixed.


Best regards,
Luca De Pandis




Index: Makefile
===
RCS file: /cvs/ports/lang/nim/Makefile,v
retrieving revision 1.11
diff -u -p -u -p -r1.11 Makefile
--- Makefile2 May 2020 09:33:06 -   1.11
+++ Makefile16 Jan 2021 13:10:55 -
@@ -6,7 +6,7 @@ BROKEN-i386 = hardcodes gcc; see config/
 
 COMMENT =  statically typed, imperative programming language
 
-VERSION =  1.2.0
+VERSION =  1.4.2
 DISTNAME = nim-${VERSION}
 EXTRACT_SUFX = .tar.xz
 REVISION = 0
@@ -22,6 +22,13 @@ PERMIT_PACKAGE = Yes
 
 WANTLIB =  c m
 
+# cc is not a supported compiler, so CC has to be set as clang instead
+CC =   clang
+
+MODULES =  lang/python
+
+MODPY_VERSION =${MODPY_DEFAULT_VERSION_3}
+
 post-patch:
mkdir -p ${WRKSRC}/nimcache-port
mkdir -p ${WRKSRC}/nimcache-port-test
@@ -33,15 +40,15 @@ do-build:
cd ${WRKSRC} && ${SETENV} CC="${CC}" LINKER="${CC}" \
CFLAGS="${CFLAGS}" sh build.sh
# slow machines can get a head of themselves and fail to link
-   cd ${WRKSRC} && bin/nim c -d:release --parallelBuild:1 \
+   cd ${WRKSRC} && bin/nim c -d:release --parallelBuild:${MAKE_JOBS} \
--nimcache:"${WRKSRC}/nimcache-port" --listFullPaths \
-   --listCmd --putenv:"PATH=${PATH}" koch
-   cd ${WRKSRC} && ./koch boot -d:release --parallelBuild:1 \
+   --listCmd --putenv:"PATH=${PATH}" --cc:${CC} koch
+   cd ${WRKSRC} && ./koch boot -d:release --parallelBuild:${MAKE_JOBS} \
--nimcache:"${WRKSRC}/nimcache-port" --listFullPaths \
-   --listCmd --putenv:"PATH=${PATH}"
-   cd ${WRKSRC} && ./koch nimble -d:release --parallelBuild:1 \
+   --listCmd --putenv:"PATH=${PATH}" --cc:${CC}
+   cd ${WRKSRC} && ./koch nimble -d:release --parallelBuild:${MAKE_JOBS} \
--nimcache:"${WRKSRC}/nimcache-port" --listFullPaths \
-   --listCmd --putenv:"PATH=${PATH}"
+   --listCmd --putenv:"PATH=${PATH}" --cc:${CC}
 
 do-install:
${INSTALL_PROGRAM_DIR} ${PREFIX}/bin
@@ -54,11 +61,13 @@ do-install:
${INSTALL_DATA} ${WRKSRC}/doc/*.txt ${PREFIX}/share/doc/nim
${INSTALL_DATA_DIR} ${PREFIX}/share/examples/nim
${INSTALL_DATA} ${WRKSRC}/config/*.cfg ${PREFIX}/share/examples/nim
+   ${MODPY_BIN} ${MODPY_LIBDIR}/compileall.py \
+   ${PREFIX}/lib/nim/pure/unidecode/gen.py
 
 do-test:
cd ${WRKSRC} && ${SETENV} ./koch test all -d:release \
-   --parallelBuild:1 --listFullPaths --listCmd \
+   --parallelBuild:${MAKE_JOBS} --listFullPaths --listCmd \
--nimcache:"${WRKSRC}/nimcache-port-test" \
-   --putenv:"PATH=${PATH}"
+   --putenv:"PATH=${PATH}" --cc:${CC}
 
 .include 
Index: distinfo
===
RCS file: /cvs/ports/lang/nim/distinfo,v
retrieving revision 1.5
diff -u -p -u -p -r1.5 distinfo
--- distinfo2 May 2020 09:33:06 -   1.5
+++ distinfo16 Jan 2021 13:10:55 -
@@ -1,2 +1,2 @@
-SHA256 (nim-1.2.0.tar.xz) = TpRYOjc5ZYIYBeZl4KBfUvthCRZnbtsJFIlBQVY3xXU=
-SIZE (nim-1.2.0.tar.xz) = 5869428
+SHA256 (nim-1.4.2.tar.xz) = 
03a47583777dd81380a3407aa6a788c9aa8a67df4821025770c9ac4186291161
+SIZE (nim-1.4.2.tar.xz) = 4770616
Index:

Re: [UPDATE] lang/nim 1.2.0 -> 1.4.2

2021-01-16 Thread Thomas Frohwein 
On Fri, Jan 15, 2021 at 05:07:10PM +0100, Rafael Sadowski wrote:

[...]

> cvs diff -uNp, please. More information:
> https://www.openbsd.org/faq/ports/testing.html

Yes, but note that this is the automatic default and doesn't need to be
specified *unless* you changed /etc/skel/.cvsrc or your $HOME/.cvsrc.

$ grep diff /etc/skel/.cvsrc
diff -uNp

These become the default flags for cvs per cvs(1).

Still probably good to have the occasional reminder about the existence
of these rc files and what goes into your 'cvs diff' command.

> 
> > 
> > regards,
> >   Dimitri
> > 
>

Re: [UPDATE] lang/nim 1.2.0 -> 1.4.2

2021-01-15 Thread Dimitri Karamazov 
On Fri, Jan 15, 2021 at 01:02:16PM +, Luca De Pandis wrote:
> Hi,
> could anyone review this, so that the port could be upgraded, please?
> 
> 
> Best regards,
> Luca De Pandis
> 
> 
> On Tue, Jan 12, 2021 at 10:40:00PM +0100, me wrote:
> > Hi,
> > I updated the lang/nim port to the latest version.
> > 
> > The following checks passed:
> > - portcheck
> > - port-lib-depends-check
> > - update-plist
> > 
> > Best regards,
> > Luca De Pandis

Updates are supposed to be sent as an inline diff.
To get the diff:
cd /usr/ports/lang/nim && cvs diff

regards,
  Dimitri

Re: [UPDATE] lang/nim 1.2.0 -> 1.4.2

2021-01-15 Thread Stuart Henderson 
On 2021/01/15 14:02, Luca De Pandis wrote:
> Hi,
> could anyone review this, so that the port could be upgraded, please?
> 
> 
> Best regards,
> Luca De Pandis
> 
> 
> On Tue, Jan 12, 2021 at 10:40:00PM +0100, me wrote:
> > Hi,
> > I updated the lang/nim port to the latest version.
> > 
> > The following checks passed:
> > - portcheck
> > - port-lib-depends-check
> > - update-plist
> > 
> > Best regards,
> > Luca De Pandis
> 
> 

3 days is way too soon to be prodding really, especially for what is
a relatively specialist port that most ports devs won't use. Anyway a
few quick comments I am short on time - as mentioned by others please
send a diff not a tar for updates. Use cvs add / cvs rm if there are
any new/removed files and cvs diff -uNp.

patch-config_nim_cfg:
-cc = gcc
+cc = clang

The compiler should be passed from the port in CC not hardcoded.

PLIST: missing @sample for the new cfg file

Makefile: drop REVISION, maybe the --parallelBuild:1 should really
be ${MAKE_JOBS} instead of 1

Re: [UPDATE] lang/nim 1.2.0 -> 1.4.2

2021-01-15 Thread Rafael Sadowski 
On Fri Jan 15, 2021 at 03:58:57PM +, Dimitri Karamazov wrote:
> On Fri, Jan 15, 2021 at 01:02:16PM +, Luca De Pandis wrote:
> > Hi,
> > could anyone review this, so that the port could be upgraded, please?
> > 
> > 
> > Best regards,
> > Luca De Pandis
> > 
> > 
> > On Tue, Jan 12, 2021 at 10:40:00PM +0100, me wrote:
> > > Hi,
> > > I updated the lang/nim port to the latest version.
> > > 
> > > The following checks passed:
> > > - portcheck
> > > - port-lib-depends-check
> > > - update-plist
> > > 
> > > Best regards,
> > > Luca De Pandis
> 
> Updates are supposed to be sent as an inline diff.
> To get the diff:
> cd /usr/ports/lang/nim && cvs diff

cvs diff -uNp, please. More information:
https://www.openbsd.org/faq/ports/testing.html

> 
> regards,
>   Dimitri
>

Re: [UPDATE] lang/nim 1.2.0 -> 1.4.2

2021-01-15 Thread Luca De Pandis 
Hi,
could anyone review this, so that the port could be upgraded, please?


Best regards,
Luca De Pandis


On Tue, Jan 12, 2021 at 10:40:00PM +0100, me wrote:
> Hi,
> I updated the lang/nim port to the latest version.
> 
> The following checks passed:
> - portcheck
> - port-lib-depends-check
> - update-plist
> 
> Best regards,
> Luca De Pandis