Re: UPDATE: misc/redshift 1.11 => 1.12
On 05/24/18 09:43, Dumitru Mișu Moldovan wrote: Brian Callahan wrote: This is my "portroach rampage" contribution of the day, which is a new term I just learned. It is a mostly straightforward update of misc/redshift. I say mostly, because I noticed that while redshift was compiling with cc, it was linking with gcc -- it looks for your Objective-C compiler and uses that as the linker (and apparently defaults to gcc). But the override is trivial. It's nice to have the GTK+ systray widget bundled with this, but I kind of regret not having the option to install redshift without all the GTK+ 3.x and Python 3.x deps, like in FreeBSD, where the redshift package was pretty light. I know I'm not the only one to be bothered by this: https://www.tedunangst.com/flak/post/sct-set-color-temperature. :-] Maybe a flavor would be an option? There is sctd also, but I would still prefer a lighter flavor of redshift. Would a patch be welcome? I hope it's not an advanced topic, as I have pretty much zero experience with OpenBSD porting and packaging thus far… Sure. Send patches. You can even take over as MAINTAINER too. ~Brian
Re: UPDATE: misc/redshift 1.11 => 1.12
Brian Callahan wrote: > > This is my "portroach rampage" contribution of the day, which is a > new term I just learned. It is a mostly straightforward update of > misc/redshift. I say mostly, because I noticed that while redshift > was compiling with cc, it was linking with gcc -- it looks for your > Objective-C compiler and uses that as the linker (and apparently > defaults to gcc). But the override is trivial. It's nice to have the GTK+ systray widget bundled with this, but I kind of regret not having the option to install redshift without all the GTK+ 3.x and Python 3.x deps, like in FreeBSD, where the redshift package was pretty light. I know I'm not the only one to be bothered by this: https://www.tedunangst.com/flak/post/sct-set-color-temperature. :-] Maybe a flavor would be an option? There is sctd also, but I would still prefer a lighter flavor of redshift. Would a patch be welcome? I hope it's not an advanced topic, as I have pretty much zero experience with OpenBSD porting and packaging thus far… pgp5xqJi1IyG8.pgp Description: Semnătură digitală OpenPGP
Re: UPDATE: misc/redshift 1.11 => 1.12
On 2018/05/23 23:53, Brian Callahan wrote: > Hi ports -- > > This is my "portroach rampage" contribution of the day, which is a new term > I just learned. It is a mostly straightforward update of misc/redshift. I > say mostly, because I noticed that while redshift was compiling with cc, it > was linking with gcc -- it looks for your Objective-C compiler and uses that > as the linker (and apparently defaults to gcc). But the override is trivial. > > OK? Not sure about forcing OBJC=$CC... Seems better to restore the Makefile.in section to how it was in 1.11 for now and check with upstream? This was introduced when adding MacOS CoreLocation support. Index: src/Makefile.in --- src/Makefile.in.orig +++ src/Makefile.in @@ -661,7 +661,7 @@ windows/versioninfo.$(OBJEXT): windows/$(am__dirstamp) redshift$(EXEEXT): $(redshift_OBJECTS) $(redshift_DEPENDENCIES) $(EXTRA_redshift_DEPENDENCIES) @rm -f redshift$(EXEEXT) - $(AM_V_OBJCLD)$(OBJCLINK) $(redshift_OBJECTS) $(redshift_LDADD) $(LIBS) + $(AM_V_CCLD)$(LINK) $(redshift_OBJECTS) $(redshift_LDADD) $(LIBS) mostlyclean-compile: -rm -f *.$(OBJEXT) Also: configure picks up geoclue2 if present at build time.
Re: UPDATE: misc/redshift 1.11 => 1.12
On Wed, May 23, 2018 at 11:53:23PM -0400, Brian Callahan wrote: > This is my "portroach rampage" contribution of the day, which is a new term > I just learned. It is a mostly straightforward update of misc/redshift. I > say mostly, because I noticed that while redshift was compiling with cc, it > was linking with gcc -- it looks for your Objective-C compiler and uses that > as the linker (and apparently defaults to gcc). But the override is trivial. Looks good to me, works as expected on my X250. I noticed this at the end of `fake', though: gtk-update-icon-cache -f -t /usr/local/share/icons/hicolor || :; gtk-update-icon-cache: Failed to open file /usr/local/share/icons/hicolor/.icon-theme.cache : Permission denied Glancing at the configure script and invoked compiler commands during `build', OBJCFLAGS seems unset. Did you take a closer look at these just to make sure they don't interfere with CFLAGS, DEBUG and the like?
Re: UPDATE: misc/redshift
Looks correct to me. OK gsoares@
Re: UPDATE: misc/redshift
On 2016/05/20 16:56, Ryan Freeman wrote: > On Thu, May 19, 2016 at 06:07:41PM -0700, Ryan Freeman wrote: > > Heres an update to redshift 1.11. > > Let's try this again properly :-) > > Update to redshift 1.11, switch to using GH_TAGNAME (thanks sthen!), > and update plist (d'oh, thanks gsoares!). > > The redshift.desktop file addtition also fixes the geoclue issue > properly, no modification to /etc/geoclue/geoclue.conf necessary. > Thanks ajacoutot for making me re-read the issue tracker properly :-) Thanks, committed.
Re: UPDATE: misc/redshift
On Thu, May 19, 2016 at 06:07:41PM -0700, Ryan Freeman wrote:
> Heres an update to redshift 1.11.
Let's try this again properly :-)
Update to redshift 1.11, switch to using GH_TAGNAME (thanks sthen!),
and update plist (d'oh, thanks gsoares!).
The redshift.desktop file addtition also fixes the geoclue issue
properly, no modification to /etc/geoclue/geoclue.conf necessary.
Thanks ajacoutot for making me re-read the issue tracker properly :-)
Cheers,
--ryan
? redshift.diff
Index: Makefile
===
RCS file: /cvs/ports/misc/redshift/Makefile,v
retrieving revision 1.25
diff -u -p -r1.25 Makefile
--- Makefile24 Aug 2015 10:01:10 - 1.25
+++ Makefile20 May 2016 23:55:33 -
@@ -2,13 +2,9 @@
COMMENT= automatic color temperature adjustment
-V= 1.10
-DISTNAME= redshift-${V}
-REVISION= 2
-
GH_PROJECT=redshift
GH_ACCOUNT=jonls
-DISTFILES= v${V}${EXTRACT_SUFX}
+GH_TAGNAME=v1.11
CATEGORIES=misc graphics
Index: distinfo
===
RCS file: /cvs/ports/misc/redshift/distinfo,v
retrieving revision 1.6
diff -u -p -r1.6 distinfo
--- distinfo10 Jan 2015 09:39:21 - 1.6
+++ distinfo20 May 2016 23:55:33 -
@@ -1,2 +1,2 @@
-SHA256 (v1.10.tar.gz) = 96HKHsz2YplXN+FPiUwrFRk5I/u+N40VHjRqgBNkTxY=
-SIZE (v1.10.tar.gz) = 519595
+SHA256 (redshift-1.11.tar.gz) = qJzuDcgi+iv9oHA9js7ezMCNo6698YgFk/KNqBw9yHk=
+SIZE (redshift-1.11.tar.gz) = 543804
Index: pkg/PLIST
===
RCS file: /cvs/ports/misc/redshift/pkg/PLIST,v
retrieving revision 1.8
diff -u -p -r1.8 PLIST
--- pkg/PLIST 10 Jan 2015 09:39:21 - 1.8
+++ pkg/PLIST 20 May 2016 23:55:33 -
@@ -19,6 +19,7 @@ lib/python${MODPY_VERSION}/site-packages
share/appdata/
share/appdata/redshift-gtk.appdata.xml
share/applications/redshift-gtk.desktop
+share/applications/redshift.desktop
share/icons/hicolor/scalable/apps/redshift-status-off.svg
share/icons/hicolor/scalable/apps/redshift-status-on.svg
share/icons/hicolor/scalable/apps/redshift.svg
@@ -50,6 +51,7 @@ share/locale/pt/LC_MESSAGES/redshift.mo
share/locale/pt_BR/LC_MESSAGES/redshift.mo
share/locale/ru/LC_MESSAGES/redshift.mo
share/locale/sv/LC_MESSAGES/redshift.mo
+share/locale/tr/LC_MESSAGES/redshift.mo
share/locale/zh_CN/LC_MESSAGES/redshift.mo
@exec %D/bin/gtk-update-icon-cache -q -t %D/share/icons/hicolor
@unexec-delete %D/bin/gtk-update-icon-cache -q -t %D/share/icons/hicolor
Re: UPDATE: misc/redshift
Looks like it is missing some files in PLIST. (make update-plist) +share/applications/redshift.desktop +share/locale/tr/LC_MESSAGES/redshift.mo by the way, "redshift.desktop" was pointed out by upstream at https://github.com/jonls/redshift/issues/158 and it seems related to geoclue thing. I haven't tested though.
Re: UPDATE: misc/redshift
On 2016/05/20 07:07, Antoine Jacoutot wrote: > > retrieving revision 1.6 > > diff -u -p -r1.6 distinfo > > --- distinfo10 Jan 2015 09:39:21 - 1.6 > > +++ distinfo20 May 2016 01:02:05 - > > @@ -1,2 +1,2 @@ > > -SHA256 (v1.10.tar.gz) = 96HKHsz2YplXN+FPiUwrFRk5I/u+N40VHjRqgBNkTxY= > > -SIZE (v1.10.tar.gz) = 519595 > > +SHA256 (v1.11.tar.gz) = qJzuDcgi+iv9oHA9js7ezMCNo6698YgFk/KNqBw9yHk= > > +SIZE (v1.11.tar.gz) = 543804 ugh :) The DISTFILES line should change to GH_TAGNAME and regen distinfo.
Re: UPDATE: misc/redshift
On Thu, May 19, 2016 at 06:07:41PM -0700, Ryan Freeman wrote:
> Heres an update to redshift 1.11. tried it trying to figure out the geoclue2
> error before finally coming across the issue thread describing redshift needs
> the exception in /etc/geoclue/geoclue.conf ;) (1.11 doesn't magically make
> that requirement go away!)
>
> Works good on amd64.
>
> Would it be worth adding a pkg/README with a note about this?
No. See : https://github.com/jonls/redshift/issues/158
I am ok with the diff though.
> Index: Makefile
> ===
> RCS file: /cvs/ports/misc/redshift/Makefile,v
> retrieving revision 1.25
> diff -u -p -r1.25 Makefile
> --- Makefile 24 Aug 2015 10:01:10 - 1.25
> +++ Makefile 20 May 2016 01:02:05 -
> @@ -2,9 +2,8 @@
>
> COMMENT= automatic color temperature adjustment
>
> -V= 1.10
> +V= 1.11
> DISTNAME=redshift-${V}
> -REVISION=2
>
> GH_PROJECT= redshift
> GH_ACCOUNT= jonls
> Index: distinfo
> ===
> RCS file: /cvs/ports/misc/redshift/distinfo,v
> retrieving revision 1.6
> diff -u -p -r1.6 distinfo
> --- distinfo 10 Jan 2015 09:39:21 - 1.6
> +++ distinfo 20 May 2016 01:02:05 -
> @@ -1,2 +1,2 @@
> -SHA256 (v1.10.tar.gz) = 96HKHsz2YplXN+FPiUwrFRk5I/u+N40VHjRqgBNkTxY=
> -SIZE (v1.10.tar.gz) = 519595
> +SHA256 (v1.11.tar.gz) = qJzuDcgi+iv9oHA9js7ezMCNo6698YgFk/KNqBw9yHk=
> +SIZE (v1.11.tar.gz) = 543804
>
--
Antoine
Re: UPDATE: misc/redshift
Ryan Freeman [r...@slipgate.org] wrote: > > Context may help. By 'this', I mean the geoclue.conf hint: > > [redshift] > allowed=true > system=false > users= > absolutely
Re: UPDATE: misc/redshift
On Thu, May 19, 2016 at 06:07:41PM -0700, Ryan Freeman wrote:
> Heres an update to redshift 1.11. tried it trying to figure out the geoclue2
> error before finally coming across the issue thread describing redshift needs
> the exception in /etc/geoclue/geoclue.conf ;) (1.11 doesn't magically make
> that requirement go away!)
>
> Works good on amd64.
>
> Would it be worth adding a pkg/README with a note about this?
Context may help. By 'this', I mean the geoclue.conf hint:
[redshift]
allowed=true
system=false
users=
>
> Cheers,
> -ryan
>
>
> ? redshift.diff
> Index: Makefile
> ===
> RCS file: /cvs/ports/misc/redshift/Makefile,v
> retrieving revision 1.25
> diff -u -p -r1.25 Makefile
> --- Makefile 24 Aug 2015 10:01:10 - 1.25
> +++ Makefile 20 May 2016 01:02:05 -
> @@ -2,9 +2,8 @@
>
> COMMENT= automatic color temperature adjustment
>
> -V= 1.10
> +V= 1.11
> DISTNAME=redshift-${V}
> -REVISION=2
>
> GH_PROJECT= redshift
> GH_ACCOUNT= jonls
> Index: distinfo
> ===
> RCS file: /cvs/ports/misc/redshift/distinfo,v
> retrieving revision 1.6
> diff -u -p -r1.6 distinfo
> --- distinfo 10 Jan 2015 09:39:21 - 1.6
> +++ distinfo 20 May 2016 01:02:05 -
> @@ -1,2 +1,2 @@
> -SHA256 (v1.10.tar.gz) = 96HKHsz2YplXN+FPiUwrFRk5I/u+N40VHjRqgBNkTxY=
> -SIZE (v1.10.tar.gz) = 519595
> +SHA256 (v1.11.tar.gz) = qJzuDcgi+iv9oHA9js7ezMCNo6698YgFk/KNqBw9yHk=
> +SIZE (v1.11.tar.gz) = 543804
>
Re: [UPDATE] misc/redshift
On 03/11/14 22:05, Antoine Jacoutot wrote: On Tue, Mar 11, 2014 at 10:03:35PM +, Fred wrote: Hi ports@ Here is update to redshift to version 1.8, I've tested it on i386 and amd64, and will test it on macppc once my ibook is up to date. The gtk appalication has been renamed to redshift-gtk. I'll take care of this, thanks. Tested successfully on macppc as well.
Re: [UPDATE] misc/redshift
On Tue, Mar 11, 2014 at 10:03:35PM +, Fred wrote:
> Hi ports@
>
> Here is update to redshift to version 1.8, I've tested it on i386 and amd64,
> and will test it on macppc once my ibook is up to date.
>
> The gtk appalication has been renamed to redshift-gtk.
I'll take care of this, thanks.
>
> Cheers
>
> Fred
>
>
> ? redshift.diff
> ? pkg/MESSAGE
> Index: Makefile
> ===
> RCS file: /cvs/ports/misc/redshift/Makefile,v
> retrieving revision 1.17
> diff -u -p -u -r1.17 Makefile
> --- Makefile 27 Sep 2013 17:49:06 - 1.17
> +++ Makefile 11 Mar 2014 20:51:53 -
> @@ -2,9 +2,9 @@
>
> COMMENT= automatic color temperature adjustment
>
> -V= 1.7
> +V= 1.8
> DISTNAME=redshift-${V}
> -REVISION=5
> +REVISION=0
> EXTRACT_SUFX=.tar.bz2
>
> CATEGORIES= misc
> @@ -38,6 +38,6 @@ CONFIGURE_ARGS= --enable-randr \
> --enable-gnome-clock \
> --enable-gui
>
> -MODPY_ADJ_FILES= src/gtk-redshift/gtk-redshift
> +MODPY_ADJ_FILES= src/redshift-gtk/redshift-gtk
>
> .include
> Index: distinfo
> ===
> RCS file: /cvs/ports/misc/redshift/distinfo,v
> retrieving revision 1.3
> diff -u -p -u -r1.3 distinfo
> --- distinfo 17 Jul 2011 08:05:36 - 1.3
> +++ distinfo 11 Mar 2014 20:51:53 -
> @@ -1,5 +1,2 @@
> -MD5 (redshift-1.7.tar.bz2) = xWUSr6KStalLcV7UoYQdTA==
> -RMD160 (redshift-1.7.tar.bz2) = wrobxD6L1USKIsCrJf8reBMhkps=
> -SHA1 (redshift-1.7.tar.bz2) = zKO4Ov7xaHtTMzdkmvEoURaRhZA=
> -SHA256 (redshift-1.7.tar.bz2) =
> m/o8PUqc5uoGpeYjWrToIVpFbAjW50UcA4lFajfQEMg=
> -SIZE (redshift-1.7.tar.bz2) = 269820
> +SHA256 (redshift-1.8.tar.bz2) =
> keB5h7zR9TKvOY2YfcOlGm5KW1/B2y43cChQvJ0T1hg=
> +SIZE (redshift-1.8.tar.bz2) = 276449
> Index: pkg/PLIST
> ===
> RCS file: /cvs/ports/misc/redshift/pkg/PLIST,v
> retrieving revision 1.5
> diff -u -p -u -r1.5 PLIST
> --- pkg/PLIST 15 Jun 2012 08:32:17 - 1.5
> +++ pkg/PLIST 11 Mar 2014 20:51:53 -
> @@ -1,21 +1,21 @@
> @comment $OpenBSD: PLIST,v 1.5 2012/06/15 08:32:17 ajacoutot Exp $
> -bin/gtk-redshift
> @bin bin/redshift
> -lib/python${MODPY_VERSION}/site-packages/gtk_redshift/
> -lib/python${MODPY_VERSION}/site-packages/gtk_redshift/__init__.py
> -lib/python${MODPY_VERSION}/site-packages/gtk_redshift/__init__.pyc
> -lib/python${MODPY_VERSION}/site-packages/gtk_redshift/__init__.pyo
> -lib/python${MODPY_VERSION}/site-packages/gtk_redshift/defs.py
> -lib/python${MODPY_VERSION}/site-packages/gtk_redshift/defs.pyc
> -lib/python${MODPY_VERSION}/site-packages/gtk_redshift/defs.pyo
> -lib/python${MODPY_VERSION}/site-packages/gtk_redshift/statusicon.py
> -lib/python${MODPY_VERSION}/site-packages/gtk_redshift/statusicon.pyc
> -lib/python${MODPY_VERSION}/site-packages/gtk_redshift/statusicon.pyo
> -lib/python${MODPY_VERSION}/site-packages/gtk_redshift/utils.py
> -lib/python${MODPY_VERSION}/site-packages/gtk_redshift/utils.pyc
> -lib/python${MODPY_VERSION}/site-packages/gtk_redshift/utils.pyo
> +bin/redshift-gtk
> +lib/python${MODPY_VERSION}/site-packages/redshift_gtk/
> +lib/python${MODPY_VERSION}/site-packages/redshift_gtk/__init__.py
> +lib/python${MODPY_VERSION}/site-packages/redshift_gtk/__init__.pyc
> +lib/python${MODPY_VERSION}/site-packages/redshift_gtk/__init__.pyo
> +lib/python${MODPY_VERSION}/site-packages/redshift_gtk/defs.py
> +lib/python${MODPY_VERSION}/site-packages/redshift_gtk/defs.pyc
> +lib/python${MODPY_VERSION}/site-packages/redshift_gtk/defs.pyo
> +lib/python${MODPY_VERSION}/site-packages/redshift_gtk/statusicon.py
> +lib/python${MODPY_VERSION}/site-packages/redshift_gtk/statusicon.pyc
> +lib/python${MODPY_VERSION}/site-packages/redshift_gtk/statusicon.pyo
> +lib/python${MODPY_VERSION}/site-packages/redshift_gtk/utils.py
> +lib/python${MODPY_VERSION}/site-packages/redshift_gtk/utils.pyc
> +lib/python${MODPY_VERSION}/site-packages/redshift_gtk/utils.pyo
> @man man/man1/redshift.1
> -share/applications/gtk-redshift.desktop
> +share/applications/redshift-gtk.desktop
> share/icons/hicolor/scalable/apps/redshift-status-off.svg
> share/icons/hicolor/scalable/apps/redshift-status-on.svg
> share/icons/hicolor/scalable/apps/redshift.svg
> Index: MESSAGE
> ===
> RCS file: MESSAGE
> diff -N MESSAGE
> --- /dev/null 1 Jan 1970 00:00:00 -
> +++ MESSAGE 11 Mar 2014 22:01:15 -
> @@ -0,0 +1 @@
> +The gui version of the application has been rename to redshift-gtk.
>
--
Antoine
