Re: [new] x11/x2goclient 4.0.5.0

2015-08-20 Thread Rafael Sadowski
On Sun Aug 16, 2015 at 12:36:48PM +0200, Rafael Sadowski wrote:
 On Fri Aug 14, 2015 at 10:10:13AM +0100, Stuart Henderson wrote:
  I think it would be better if DESCR explained a bit about what X2Go
  is, otherwise somebody reading it is just going to have to go to their
  website to work out what it's for..
 
 new version:
 
 https://github.com/jasperla/openbsd-wip/commit/ec236327d247e1dc420da371ac0c890ca3bf6bc6
 
 - install LICENSE
 - install examples
 - new DESCR
 
 x11/x2goclient/Makefile
 x11/x2goclient/distinfo
 x11/x2goclient/patches
 x11/x2goclient/patches/patch-x2goclient_pro
 x11/x2goclient/patches/patch-src_sshprocess_cpp
 x11/x2goclient/pkg
 x11/x2goclient/pkg/DESCR
 x11/x2goclient/pkg/PLIST
 
 
 OK? Cheers, Rafael


ping :-(



Re: [new] x11/x2goclient 4.0.5.0

2015-08-20 Thread Vadim Zhukov
2015-08-20 15:20 GMT+03:00 Rafael Sadowski raf...@sizeofvoid.org:
 On Sun Aug 16, 2015 at 12:36:48PM +0200, Rafael Sadowski wrote:
 On Fri Aug 14, 2015 at 10:10:13AM +0100, Stuart Henderson wrote:
  I think it would be better if DESCR explained a bit about what X2Go
  is, otherwise somebody reading it is just going to have to go to their
  website to work out what it's for..

 new version:

 https://github.com/jasperla/openbsd-wip/commit/ec236327d247e1dc420da371ac0c890ca3bf6bc6

 - install LICENSE
 - install examples
 - new DESCR

 x11/x2goclient/Makefile
 x11/x2goclient/distinfo
 x11/x2goclient/patches
 x11/x2goclient/patches/patch-x2goclient_pro
 x11/x2goclient/patches/patch-src_sshprocess_cpp
 x11/x2goclient/pkg
 x11/x2goclient/pkg/DESCR
 x11/x2goclient/pkg/PLIST


 OK? Cheers, Rafael


 ping :-(

Missing dependencies? From port-lib-depends-check:

x2goclient-4.0.5.0(x11/x2goclient):
Missing: cups.6 from cups-libs-2.0.4a (/usr/local/bin/x2goclient)
Missing: ldap.13 from openldap-client-2.4.41 (/usr/local/bin/x2goclient)
Missing: ssh.1 from libssh-0.6.4 (/usr/local/bin/x2goclient)
WANTLIB += cups ldap ssh

--
  WBR,
  Vadim Zhukov



Re: [new] x11/x2goclient 4.0.5.0

2015-08-16 Thread Rafael Sadowski
On Fri Aug 14, 2015 at 10:10:13AM +0100, Stuart Henderson wrote:
 I think it would be better if DESCR explained a bit about what X2Go
 is, otherwise somebody reading it is just going to have to go to their
 website to work out what it's for..

new version:

https://github.com/jasperla/openbsd-wip/commit/ec236327d247e1dc420da371ac0c890ca3bf6bc6

- install LICENSE
- install examples
- new DESCR

x11/x2goclient/Makefile
x11/x2goclient/distinfo
x11/x2goclient/patches
x11/x2goclient/patches/patch-x2goclient_pro
x11/x2goclient/patches/patch-src_sshprocess_cpp
x11/x2goclient/pkg
x11/x2goclient/pkg/DESCR
x11/x2goclient/pkg/PLIST


OK? Cheers, Rafael


x2goclient.tar.gz
Description: application/tar-gz


Re: [new] x11/x2goclient 4.0.5.0

2015-08-14 Thread Stuart Henderson
I think it would be better if DESCR explained a bit about what X2Go
is, otherwise somebody reading it is just going to have to go to their
website to work out what it's for..



Re: [new] x11/x2goclient 4.0.5.0

2015-08-14 Thread Rafael Sadowski
On Fri Aug 14, 2015 at 10:10:13AM +0100, Stuart Henderson wrote:
 I think it would be better if DESCR explained a bit about what X2Go
 is, otherwise somebody reading it is just going to have to go to their
 website to work out what it's for..

maybe from homepage:

The x2goclient application provides you the possibility to access the
remote running desktop, exchange files with it and redirect sound from
the session on the server to your local client.



Re: [new] x11/x2goclient 4.0.5.0

2015-08-13 Thread Vadim Zhukov
2015-08-13 22:10 GMT+03:00 Rafael Sadowski raf...@sizeofvoid.org:
 Hi ports@,

 after frequently requests from the OpenBSD community here is a stable
 version/port. Tested @amd64.

 $ cat pkg/DESCR
 x2goclient is a GUI application for launching server-side X2Go sessions.

 Ok(s)?

1. PKGNAME is not needed since it's the same with DISTNAME.

2. In the x2goclient.pro patch, you'd better use $(X11BASE)/include
instead of hardcoding /usr/X11R6/include.

3. No need to separate pre-configure and do-configure targets. The
pre-configure should be used when you want some default configure code
to work, but do-configure overrides it.

4. It probably worths installing some more documentation, since the
manual page looks like more an options summary than a manual. But I
could not insist here on anything since I'm not a user of this
software.

--
  WBR,
  Vadim Zhukov



Re: [new] x11/x2goclient 4.0.5.0

2015-08-13 Thread Rafael Sadowski
On Thu Aug 13, 2015 at 10:37:34PM +0300, Vadim Zhukov wrote:
 2015-08-13 22:10 GMT+03:00 Rafael Sadowski raf...@sizeofvoid.org:
  Hi ports@,
 
  after frequently requests from the OpenBSD community here is a stable
  version/port. Tested @amd64.
 
  $ cat pkg/DESCR
  x2goclient is a GUI application for launching server-side X2Go sessions.
 
  Ok(s)?
 
 1. PKGNAME is not needed since it's the same with DISTNAME.
 
 2. In the x2goclient.pro patch, you'd better use $(X11BASE)/include
 instead of hardcoding /usr/X11R6/include.
 
 3. No need to separate pre-configure and do-configure targets. The
 pre-configure should be used when you want some default configure code
 to work, but do-configure overrides it.
 
 4. It probably worths installing some more documentation, since the
 manual page looks like more an options summary than a manual. But I
 could not insist here on anything since I'm not a user of this
 software.
 
 --
   WBR,
   Vadim Zhukov

... tarball


x2goclient.tar.gz
Description: application/tar-gz


Re: [new] x11/x2goclient 4.0.5.0

2015-08-13 Thread Rafael Sadowski
On Thu Aug 13, 2015 at 10:37:34PM +0300, Vadim Zhukov wrote:
 2015-08-13 22:10 GMT+03:00 Rafael Sadowski raf...@sizeofvoid.org:
  Hi ports@,
 
  after frequently requests from the OpenBSD community here is a stable
  version/port. Tested @amd64.
 
  $ cat pkg/DESCR
  x2goclient is a GUI application for launching server-side X2Go sessions.
 
  Ok(s)?
 

Thanks for your review!

 1. PKGNAME is not needed since it's the same with DISTNAME.

fixed;

 
 2. In the x2goclient.pro patch, you'd better use $(X11BASE)/include
 instead of hardcoding /usr/X11R6/include.
 

fixed;

 3. No need to separate pre-configure and do-configure targets. The
 pre-configure should be used when you want some default configure code
 to work, but do-configure overrides it.

of course, fixed;

 
 4. It probably worths installing some more documentation, since the
 manual page looks like more an options summary than a manual. But I
 could not insist here on anything since I'm not a user of this
 software.
 

trust me, there is no more documentation necessary.