Re: Build gtetrinet without esound

2014-11-04 Thread Jonathan Armani 
 I noticed your diff adds libaudfile but there are no WANTLIB additions
 which should be the case. I don't see anything in the gtetrinet code
 that uses libaudfile. Was this intended? The rest of the diff looks
 fine.

You're right. New diff attached that regen wantlib completly (lot of
extra) and remove libaudiofile.

Regen dist while there


Index: Makefile
===
RCS file: /cvs/ports/games/gtetrinet/Makefile,v
retrieving revision 1.28
diff -u -p -r1.28 Makefile
--- Makefile11 Oct 2013 23:49:37 -  1.28
+++ Makefile4 Nov 2014 08:20:57 -
@@ -6,7 +6,7 @@ COMMENT-main=   tetrinet client
 COMMENT-themes=collection of gtetrinet themes
 DISTNAME=  gtetrinet-0.7.11
 PKGNAME-main=  ${DISTNAME}
-REVISION-main= 17
+REVISION-main= 18
 PKGNAME-themes=gtetrinet-themes-20070623
 REVISION-themes=2
 CATEGORIES=x11 games
@@ -39,8 +39,7 @@ MODULES=  textproc/intltool \
 
 LIB_DEPENDS-main=  ${MODGCONF2_LIB_DEPENDS} \
x11/gnome/libgnome \
-   x11/gnome/libgnomeui \
-   audio/esound=0.2.38
+   x11/gnome/libgnomeui
 LIB_DEPENDS-themes=
 WANTLIB-themes=
 RUN_DEPENDS-main=  ${RUN_DEPENDS} \
@@ -48,16 +47,13 @@ RUN_DEPENDS-main=   ${RUN_DEPENDS} \
 RUN_DEPENDS-themes=games/gtetrinet
 PKG_ARCH-themes=   *
 
-WANTLIB-main += gnome-2 gnomeui-2 esd ${MODGCONF2_WANTLIB}
-WANTLIB-main += ICE ORBit-2 SM X11 Xau Xcomposite Xcursor Xdamage Xdmcp
-WANTLIB-main += Xext Xfixes Xi Xinerama Xrandr Xrender art_lgpl_2 atk-1.0
-WANTLIB-main += audiofile bonobo-2 bonobo-activation bonoboui-2 c cairo
-WANTLIB-main += expat fontconfig freetype gailutil gdk-x11-2.0
-WANTLIB-main += gdk_pixbuf-2.0 gio-2.0 glib-2.0 gmodule-2.0 gnome-keyring
-WANTLIB-main += gnomecanvas-2 gnomevfs-2 gobject-2.0 gthread-2.0 gtk-x11-2.0
-WANTLIB-main += m pango-1.0 pangocairo-1.0 pangoft2-1.0
-WANTLIB-main += pixman-1 png popt pthread pthread-stubs sndio xcb xml2 z
-WANTLIB-main += GL Xxf86vm canberra drm xcb-render xcb-shm 
${MODGETTEXT_WANTLIB}
+WANTLIB-main += ICE ORBit-2 SM X11 Xcomposite Xcursor Xdamage Xext
+WANTLIB-main += Xfixes Xi Xinerama Xrandr Xrender art_lgpl_2 atk-1.0
+WANTLIB-main += bonobo-2 bonobo-activation bonoboui-2 c cairo fontconfig
+WANTLIB-main += freetype gconf-2 gdk-x11-2.0 gdk_pixbuf-2.0 gio-2.0
+WANTLIB-main += glib-2.0 gmodule-2.0 gnome-2 gnomecanvas-2 gnomeui-2
+WANTLIB-main += gnomevfs-2 gobject-2.0 gthread-2.0 gtk-x11-2.0 intl m
+WANTLIB-main += pango-1.0 pangocairo-1.0 pangoft2-1.0 popt pthread z
 
 WANTLIB-themes =
 
Index: distinfo
===
RCS file: /cvs/ports/games/gtetrinet/distinfo,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 distinfo
--- distinfo28 Jun 2007 15:38:16 -  1.1.1.1
+++ distinfo4 Nov 2014 08:20:57 -
@@ -1,27 +1,3 @@
-MD5 (gtet-theme-TuxNBlue.tar.gz) = qcjMpDKHvQOAT2e3vTnH2Q==
-MD5 (gtet-theme-iconic.tar.gz) = 33BP31vbZC0nn5JQtgSK7g==
-MD5 (gtet-theme-matrix.tar.gz) = zYNK321inQfKE0pT9JhCXA==
-MD5 (gtet-theme-mmr.tar.gz) = HaadPE9EEYRwmqhF8Uk+Og==
-MD5 (gtet-theme-tetrinetlv2.tar.gz) = RPc3D+J+IywxMrIUnLsrow==
-MD5 (gtet-theme-tux.tar.gz) = F/giKJ2aLNvYV1jHtFgyvw==
-MD5 (gtet-theme-wield.tar.gz) = YhDZEER9dO9ZDecxVUn8OA==
-MD5 (gtetrinet-0.7.11.tar.gz) = pFUAB/Bb3E1N4K1o2JE6kA==
-RMD160 (gtet-theme-TuxNBlue.tar.gz) = D7pHC+6AMXQ7nIlGMjb2Mkzsy4Q=
-RMD160 (gtet-theme-iconic.tar.gz) = T+jCJpewZw0cFMvxpG36RMxIlgM=
-RMD160 (gtet-theme-matrix.tar.gz) = yPoYlMR5GmjbFc2JNRObbZNDDOk=
-RMD160 (gtet-theme-mmr.tar.gz) = TlKucQ3d+4MLTNiqG/XBvkV2qhM=
-RMD160 (gtet-theme-tetrinetlv2.tar.gz) = 4vPmmVaGrQkHVt2ZDtCcHMRCnyQ=
-RMD160 (gtet-theme-tux.tar.gz) = BINvNGo9UTau7HZ1UjqLHT8+j50=
-RMD160 (gtet-theme-wield.tar.gz) = YEYIar/a1DFVeUHODyKASRQXx2I=
-RMD160 (gtetrinet-0.7.11.tar.gz) = HVRnWLYK11OAARBFwex0bdzCc6U=
-SHA1 (gtet-theme-TuxNBlue.tar.gz) = 2wHGqf88kAWoQz6Z6PPwHxtmDmQ=
-SHA1 (gtet-theme-iconic.tar.gz) = WDGd2Eb6HXvNtruKa/63ouXvUwY=
-SHA1 (gtet-theme-matrix.tar.gz) = 43EZBXOWyfFhrCnXx8d5jGeiMxM=
-SHA1 (gtet-theme-mmr.tar.gz) = n09HahoOq2BYWZ4o2MHIYbRhxCY=
-SHA1 (gtet-theme-tetrinetlv2.tar.gz) = s0QHCHMxEF1JGKr3+JofCveLvWY=
-SHA1 (gtet-theme-tux.tar.gz) = I2lm2GDg16cfAvQu6XQnsiTMm44=
-SHA1 (gtet-theme-wield.tar.gz) = +VYKYhp27/B4gI/dfX6VaQyxQGw=
-SHA1 (gtetrinet-0.7.11.tar.gz) = RNLcCxobzXL9AYpHjwdBOQszrf8=
 SHA256 (gtet-theme-TuxNBlue.tar.gz) = 
UOZgb0qVihQYrz1VIz78CcqzQIF//hjtmswnBb4OUtM=
 SHA256 (gtet-theme-iconic.tar.gz) = 
dgLyr7guaPL7w+J0M/lfhufHaLVeHZWpVZze1uvtb9A=
 SHA256 (gtet-theme-matrix.tar.gz) = 
MFh1xuOdUDg4XRjgRoalpzImPAJVaFkCvJiO9dEAaKM=

Re: Build gtetrinet without esound

2014-11-04 Thread Stuart Henderson 
On 2014/11/04 00:42, Jonathan Armani wrote:
 -WANTLIB-main += gnome-2 gnomeui-2 esd ${MODGCONF2_WANTLIB}
...
 -WANTLIB-main += GL Xxf86vm canberra drm xcb-render xcb-shm 
 ${MODGETTEXT_WANTLIB}

${MODGCONF2_WANTLIB} and ${MODGETTEXT_WANTLIB} should be kept as-is.
Start with WANTLIB-main += ${MODGCONF2_WANTLIB} ${MODGETTEXT_WANTLIB}
then do port-lib-depends-check and add the rest.

Re: Build gtetrinet without esound

2014-11-04 Thread Jonathan Armani 
On Tue, Nov 04, 2014 at 12:04:11PM +, Stuart Henderson wrote:
 On 2014/11/04 00:42, Jonathan Armani wrote:
  -WANTLIB-main += gnome-2 gnomeui-2 esd ${MODGCONF2_WANTLIB}
 ...
  -WANTLIB-main += GL Xxf86vm canberra drm xcb-render xcb-shm 
  ${MODGETTEXT_WANTLIB}
 
 ${MODGCONF2_WANTLIB} and ${MODGETTEXT_WANTLIB} should be kept as-is.
 Start with WANTLIB-main += ${MODGCONF2_WANTLIB} ${MODGETTEXT_WANTLIB}
 then do port-lib-depends-check and add the rest.
 

That what I did first but got :

gtetrinet-0.7.11p18(games/gtetrinet,-main):
Extra:  iconv.6

New diff, new bump, ok ?

Index: Makefile
===
RCS file: /cvs/ports/games/gtetrinet/Makefile,v
retrieving revision 1.29
diff -u -p -r1.29 Makefile
--- Makefile4 Nov 2014 08:47:36 -   1.29
+++ Makefile4 Nov 2014 12:40:35 -
@@ -6,7 +6,7 @@ COMMENT-main=   tetrinet client
 COMMENT-themes=collection of gtetrinet themes
 DISTNAME=  gtetrinet-0.7.11
 PKGNAME-main=  ${DISTNAME}
-REVISION-main= 18
+REVISION-main= 19
 PKGNAME-themes=gtetrinet-themes-20070623
 REVISION-themes=2
 CATEGORIES=x11 games
@@ -47,13 +47,14 @@ RUN_DEPENDS-main=   ${RUN_DEPENDS} \
 RUN_DEPENDS-themes=games/gtetrinet
 PKG_ARCH-themes=   *
 
+WANTLIB-main += ${MODGCONF2_WANTLIB} ${MODGETTEXT_WANTLIB}
 WANTLIB-main += ICE ORBit-2 SM X11 Xcomposite Xcursor Xdamage Xext
 WANTLIB-main += Xfixes Xi Xinerama Xrandr Xrender art_lgpl_2 atk-1.0
 WANTLIB-main += bonobo-2 bonobo-activation bonoboui-2 c cairo
fontconfig
-WANTLIB-main += freetype gconf-2 gdk-x11-2.0 gdk_pixbuf-2.0 gio-2.0
-WANTLIB-main += glib-2.0 gmodule-2.0 gnome-2 gnomecanvas-2 gnomeui-2
-WANTLIB-main += gnomevfs-2 gobject-2.0 gthread-2.0 gtk-x11-2.0 intl m
-WANTLIB-main += pango-1.0 pangocairo-1.0 pangoft2-1.0 popt pthread z
+WANTLIB-main += freetype gdk-x11-2.0 gdk_pixbuf-2.0 gio-2.0 glib-2.0
+WANTLIB-main += gmodule-2.0 gnome-2 gnomecanvas-2 gnomeui-2 gnomevfs-2
+WANTLIB-main += gobject-2.0 gthread-2.0 gtk-x11-2.0 m pango-1.0
pangocairo-1.0
+WANTLIB-main += pangoft2-1.0 popt pthread z
 
 WANTLIB-themes =

Re: Build gtetrinet without esound

2014-11-03 Thread Alexandre Ratchov 
On Mon, Nov 03, 2014 at 08:18:02PM +0100, Jonathan Armani wrote:
 Hi,
 
 Back on old diffs, remove esound from gtetrinet. This diff does not 
 prevent esound to be picked by configure but I plan to remove it
 completly.
 
 Is that acceptable ? Better idea ?
 

Last gtetrinet release is from 2006. I don't see the point of
keeping enabled the (optional) esound output, given that upstream
didn't take the time to switch it to whatever modern gnome uses.

ok ratchov

Re: Build gtetrinet without esound

2014-11-03 Thread Brad Smith 

On 03/11/14 2:18 PM, Jonathan Armani wrote:

Hi,

Back on old diffs, remove esound from gtetrinet. This diff does not
prevent esound to be picked by configure but I plan to remove it
completly.

Is that acceptable ? Better idea ?


I noticed your diff adds libaudfile but there are no WANTLIB additions
which should be the case. I don't see anything in the gtetrinet code
that uses libaudfile. Was this intended? The rest of the diff looks
fine.


Index: Makefile
===
RCS file: /cvs/ports/games/gtetrinet/Makefile,v
retrieving revision 1.28
diff -u -p -r1.28 Makefile
--- Makefile11 Oct 2013 23:49:37 -  1.28
+++ Makefile3 Nov 2014 19:13:48 -
@@ -6,7 +6,7 @@ COMMENT-main=   tetrinet client
  COMMENT-themes=   collection of gtetrinet themes
  DISTNAME= gtetrinet-0.7.11
  PKGNAME-main= ${DISTNAME}
-REVISION-main= 17
+REVISION-main= 18
  PKGNAME-themes=   gtetrinet-themes-20070623
  REVISION-themes=2
  CATEGORIES=   x11 games
@@ -40,7 +40,7 @@ MODULES=  textproc/intltool \
  LIB_DEPENDS-main= ${MODGCONF2_LIB_DEPENDS} \
x11/gnome/libgnome \
x11/gnome/libgnomeui \
-   audio/esound=0.2.38
+   devel/libaudiofile
  LIB_DEPENDS-themes=
  WANTLIB-themes=
  RUN_DEPENDS-main= ${RUN_DEPENDS} \
@@ -48,7 +48,7 @@ RUN_DEPENDS-main= ${RUN_DEPENDS} \
  RUN_DEPENDS-themes=   games/gtetrinet
  PKG_ARCH-themes=  *

-WANTLIB-main += gnome-2 gnomeui-2 esd ${MODGCONF2_WANTLIB}
+WANTLIB-main += gnome-2 gnomeui-2 ${MODGCONF2_WANTLIB}
  WANTLIB-main += ICE ORBit-2 SM X11 Xau Xcomposite Xcursor Xdamage Xdmcp
  WANTLIB-main += Xext Xfixes Xi Xinerama Xrandr Xrender art_lgpl_2 atk-1.0
  WANTLIB-main += audiofile bonobo-2 bonobo-activation bonoboui-2 c cairo





--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

Re: Build gtetrinet without esound

2014-11-03 Thread Brad Smith 

On 04/11/14 2:49 AM, Brad Smith wrote:

On 03/11/14 2:18 PM, Jonathan Armani wrote:

Hi,

Back on old diffs, remove esound from gtetrinet. This diff does not
prevent esound to be picked by configure but I plan to remove it
completly.

Is that acceptable ? Better idea ?


I noticed your diff adds libaudfile but there are no WANTLIB additions
which should be the case. I don't see anything in the gtetrinet code
that uses libaudfile. Was this intended? The rest of the diff looks
fine.


libaudiofile not libaudfile.

--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.