Re: NEW: archivers/p7zip

2007-01-09 Thread steven mestdagh
Josh Grosse [2007-01-09, 10:42:29]:
> 7-zip is a file archiver with the highest compression ratio.  
> 
> Homepage : www.7-zip.org
> 
> 7zuses plugins to handle archives.  
> 7za   is a stand-alone executable.
> 7za   handles less archive formats than 7z.exe.  i
> 7zr   is a light stand-alone executable that supports only 
>   7z/LZMA/BCJ/BCJ2.
> 
> Tested only on i386, in process of testing on amd64 (qemu takes a long time).
> 
> Comments and suggestions for improvement are welcome.

does this provide any advantages over lzma-utils (archivers/lzma port)?

Disclaimer: http://www.kuleuven.be/cwis/email_disclaimer.htm



Re: NEW: archivers/p7zip

2007-01-09 Thread Stuart Henderson
On 2007/01/09 17:01, steven mestdagh wrote:
> does this provide any advantages over lzma-utils (archivers/lzma port)?

lzma doesn't support 7z files.



Re: NEW: archivers/p7zip

2007-01-09 Thread Josh Grosse
On Tue, Jan 09, 2007 at 05:01:51PM +0100, steven mestdagh wrote:
 
> does this provide any advantages over lzma-utils (archivers/lzma port)?

AFAIK, lzma-utils uses LZMA compression only.  The p7zip sourceforge
project's toolkit includes many other compression and archive formats, 
including (per the doc) ZIP,  CAB,  ARJ,  GZIP, BZIP2, TAR, CPIO, RPM and 
DEB formats.



Re: NEW: archivers/p7zip

2007-01-09 Thread Stuart Henderson
On 2007/01/09 10:42, Josh Grosse wrote:
> 7-zip is a file archiver with the highest compression ratio.  
> Tested only on i386, in process of testing on amd64 (qemu takes a long time).

g++ on armish isn't exactly a speed demon, either (2hrs). The program
seems to run OK there, but I noticed some packaging problems - you list
a bunch of ${BASE_PKGPATH} in the PLIST/PFRAG.shared which don't work
out:-

===>  Building package for p7zip-4.43
Create /usr/ports/packages/arm/all/p7zip-4.43.tgz
Switching to /usr/ports/archivers/p7zip/pkg/PFRAG.shared
Error in package: 
"/usr/ports/archivers/p7zip/w-p7zip-4.43/fake-armish//usr/local/lib/archivers/p7zip/Codecs/7zAES.so"
 does not exist
Error in package: 
"/usr/ports/archivers/p7zip/w-p7zip-4.43/fake-armish//usr/local/lib/archivers/p7zip/Codecs/AES.so"
 does not exist
Error in package: 
"/usr/ports/archivers/p7zip/w-p7zip-4.43/fake-armish//usr/local/lib/archivers/p7zip/Codecs/BZip2.so"
 does not exist
(etc.etc).

Did you perhaps build it in /usr/ports/p7zip on your system?
'make update-plist' fixes this up, you also need to run 'make
lib-depends-check' and fix WANTLIB.

Can anyone tell me if these internal-use .so plugins need any
different handling or is that just for shared libraries intended
for use in other software?



Re: NEW: archivers/p7zip

2007-01-09 Thread Josh Grosse
On Tue, Jan 09, 2007 at 09:29:34PM +, Stuart Henderson wrote:
> On 2007/01/09 10:42, Josh Grosse wrote:
> > 7-zip is a file archiver with the highest compression ratio.  
> > Tested only on i386, in process of testing on amd64 (qemu takes a long 
> > time).
> 
> g++ on armish isn't exactly a speed demon, either (2hrs). The program
> seems to run OK there, but I noticed some packaging problems - you list
> a bunch of ${BASE_PKGPATH} in the PLIST/PFRAG.shared which don't work
> out:-
[snip] 
> Did you perhaps build it in /usr/ports/p7zip on your system?

Thanks for reporting that.  My "make plist" was built under 
/usr/ports/mystuff/p7zip, and I assume that's the packaging problem.

> ...you also need to run 'make
> lib-depends-check' and fix WANTLIB.

Good point.  These apps use libraries from /usr/lib, and they should be
in WANTLIB.  I've also found two typos in pkg/DESCR, and I had a compile
fail in the amd64 build, as g++ needs -fPIC there.  So I have a revision
to make and resubmit.
 
> Can anyone tell me if these internal-use .so plugins need any
> different handling or is that just for shared libraries intended
> for use in other software?

I did not add them to SHARED-LIBS because 1) they don't show up when I 
use ldconfig, so they don't seem like real libraries, and 2) I was unable
to determine if they have any version numbers to stick in SHARED-LIBS
anyway.  There are plenty of ports with other-than-library files in 
/usr/local/lib, so I thought leaving them there without SHARED-LIBS was
the right thing to do.



Re: NEW: archivers/p7zip

2007-01-13 Thread Josh Grosse
On Fri, Jan 12, 2007 at 12:32:14AM +0100, steven mestdagh wrote:

> some testing on more archs would be good...

AFAIK, this port has been tested on i386, amd64, and zaurus.  Has anyone
tested it on any other archs?



Re: NEW: archivers/p7zip

2007-01-15 Thread steven mestdagh
Josh Grosse [2007-01-13, 20:03:24]:
> On Fri, Jan 12, 2007 at 12:32:14AM +0100, steven mestdagh wrote:
> 
> > some testing on more archs would be good...
> 
> AFAIK, this port has been tested on i386, amd64, and zaurus.  Has anyone
> tested it on any other archs?

The tests are giving an error on sparc64:

System error:
E_FAIL
ERROR during : ../bin/7za a -m0=bzip2 7za433_7zip_bzip2.7z
7za433_7zip_bzip2


Disclaimer: http://www.kuleuven.be/cwis/email_disclaimer.htm



Re: NEW: archivers/p7zip (corrected)

2007-01-10 Thread Josh Grosse
Attached is an updated tarball for archivers/p7zip.

Corrections/Additions: 

   1.  -fPIC added to correct errors in amd64 build.
   2.  WANTLIB tested and added to Makefile.
   3.  PLIST and PFRAG.shared rebuilt under archivers/p7zip
   4.  Typos corrected in DESCR.

Tested on i386 and amd64.  


p7zip.tar.gz
Description: application/tar-gz


Re: NEW: archivers/p7zip (corrected)

2007-01-10 Thread Stuart Henderson
On 2007/01/10 05:50, Josh Grosse wrote:
> Attached is an updated tarball for archivers/p7zip.

work for me on armish.



Re: NEW: archivers/p7zip (corrected)

2007-01-10 Thread steven mestdagh
Josh Grosse [2007-01-10, 05:50:42]:
> Attached is an updated tarball for archivers/p7zip.
> 
> Corrections/Additions: 
> 
>1.  -fPIC added to correct errors in amd64 build.
>2.  WANTLIB tested and added to Makefile.
>3.  PLIST and PFRAG.shared rebuilt under archivers/p7zip
>4.  Typos corrected in DESCR.
> 
> Tested on i386 and amd64.  

I cleaned up your port a bit. I think it's SHARED_ONLY because of 7z.
I wonder if we should drop rar support so it becomes more free to
distribute?


Disclaimer: http://www.kuleuven.be/cwis/email_disclaimer.htm



p7zip.tgz
Description: application/tar-gz


Re: NEW: archivers/p7zip (corrected)

2007-01-10 Thread Josh Grosse
On Wed, Jan 10, 2007 at 07:43:56PM +0100, steven mestdagh wrote:
> I cleaned up your port a bit. 

Thank you, I appreciate the help, you've made the Makefile much more readable,
and much easier for someone (like me) to maintain!  

> I think it's SHARED_ONLY because of 7z.

I'm not sure.  Nothing in /usr/local/lib/p7zip is actually a library, as
far as ldconfig can tell, and because of that, I do not have any SHARED_LIBS 
defined.  

The platforms the port has been tested with (i386, amd64, armish) 
all have shared library support, so until someone tries it with a vax or
luna 88K -- are there other archs without it? -- I won't know for sure.

> I wonder if we should drop rar support so it becomes more free to
> distribute?

Yes, that is an option.  It would enable binary package distribution by CD. 

I have not yet looked into what it would take to excise the unRar code 
cleanly ... it might be as simple as leaving the applicable codec and format 
files out of PFRAG.shared.  I can't recall if 7za has unRar code in it or not.

Either way, if the binary package can be built with no unRar code, then 
it can be added to the CD distribution, and a -rar FLAVOR could be provided
to allow building via the ports tree.

I'll look into it!

Thanks again.

  -J-



Re: NEW: archivers/p7zip (FLAVORed)

2007-01-10 Thread Josh Grosse
On Wed, Jan 10, 2007 at 02:26:56PM -0500, Josh Grosse wrote:
> On Wed, Jan 10, 2007 at 07:43:56PM +0100, steven mestdagh wrote:
> > I wonder if we should drop rar support so it becomes more free to
> > distribute?
> 
> I'll look into it!

And here it is.  Change's were few:

Makefile:

FLAVORS= and FLAVOR?= were added. 
PERMIT_PACKAGE_CDROM= changed

pkg/PLIST:

lib/p7zip/Codecs/Rar29.so and lib/p7zip/Formats/Rar.so commented out,
and %%rar%% added.

new pkg/PFRAG.rar:

lib/p7zip/Codecs/Rar29.so and lib/p7zip/Formats/Rar.so were added.


p7zip.tgz
Description: application/tar-gz


Re: NEW: archivers/p7zip (FLAVORed)

2007-01-10 Thread steven mestdagh
Josh Grosse [2007-01-10, 15:58:11]:
> On Wed, Jan 10, 2007 at 02:26:56PM -0500, Josh Grosse wrote:
> > On Wed, Jan 10, 2007 at 07:43:56PM +0100, steven mestdagh wrote:
> > > I wonder if we should drop rar support so it becomes more free to
> > > distribute?
> > 
> > I'll look into it!
> 
> And here it is.  Change's were few:
> 
> Makefile:
> 
> FLAVORS= and FLAVOR?= were added. 
> PERMIT_PACKAGE_CDROM= changed
> 
> pkg/PLIST:
> 
> lib/p7zip/Codecs/Rar29.so and lib/p7zip/Formats/Rar.so commented out,
> and %%rar%% added.

just remove these lines.

> new pkg/PFRAG.rar:
> 
> lib/p7zip/Codecs/Rar29.so and lib/p7zip/Formats/Rar.so were added.

I think it would make more sense to drop the flavor, and put these .so
files in a -rar subpackage. Then you can also set
PERMIT_PACKAGE_CDROM-rar="no fee"
and we don't need to build this thing twice.

any other thoughts on this?

steven

Disclaimer: http://www.kuleuven.be/cwis/email_disclaimer.htm



Re: NEW: archivers/p7zip (FLAVOR or SUBPACKAGE)

2007-01-11 Thread Josh Grosse
On Thu, Jan 11, 2007 at 02:10:56PM -0500, Josh Grosse wrote:
> I will try to deliver *both* a SUBPACKAGE and FLAVOR 
> infrastructure, and a choice of diffs for ports/archivers/Makefile by
> tomorrow.

Both types are attached; I have tested the SUBPACKAGE version here and it
correctly places p7zip-rar-4.43.tgz in /ftp, and places the "-main"
p7zip-4.43.tgz in /cdrom and /ftp.

I have two different diffs here also, for ports/archivers/Makefile
depending on which type is eventually selected for the tree.


p7zip.flavored.tgz
Description: application/tar-gz


p7zip.subpackaged.tgz
Description: application/tar-gz
--- Makefile.orig   Sun Nov 12 11:34:33 2006
+++ MakefileThu Jan 11 15:33:05 2007
@@ -26,6 +26,8 @@
  SUBDIR += p5-Compress-Zlib
  SUBDIR += p5-IO-Zlib
  SUBDIR += p5-PerlIO-gzip
+ SUBDIR += p7zip
+ SUBDIR += p7zip,rar
  SUBDIR += par1cmdline
  SUBDIR += par2cmdline
  SUBDIR += rar
--- Makefile.orig   Sun Nov 12 11:34:33 2006
+++ MakefileThu Jan 11 15:28:12 2007
@@ -26,6 +26,7 @@
  SUBDIR += p5-Compress-Zlib
  SUBDIR += p5-IO-Zlib
  SUBDIR += p5-PerlIO-gzip
+ SUBDIR += p7zip
  SUBDIR += par1cmdline
  SUBDIR += par2cmdline
  SUBDIR += rar


Re: NEW: archivers/p7zip (FLAVOR or SUBPACKAGE)

2007-01-11 Thread steven mestdagh
Josh Grosse [2007-01-11, 15:39:49]:
> On Thu, Jan 11, 2007 at 02:10:56PM -0500, Josh Grosse wrote:
> > I will try to deliver *both* a SUBPACKAGE and FLAVOR 
> > infrastructure, and a choice of diffs for ports/archivers/Makefile by
> > tomorrow.
> 
> Both types are attached; I have tested the SUBPACKAGE version here and it
> correctly places p7zip-rar-4.43.tgz in /ftp, and places the "-main"
> p7zip-4.43.tgz in /cdrom and /ftp.

subpackaging means splitting things up between several packages.
i've attached the port with a fixed PLIST-rar.
some testing on more archs would be good...


Disclaimer: http://www.kuleuven.be/cwis/email_disclaimer.htm



p7zip.tgz
Description: application/tar-gz