Re: [update] graphics/nsxiv v30 -> v31
On 2023/01/29 20:39:34 +0100, "Thim Cederlund" wrote: > Hi ports, > > This patch updates graphics/nsxiv to v31. > > Changelog: https://codeberg.org/nsxiv/nsxiv/src/branch/master/etc/CHANGELOG.md Committed, thanks! I've dropped the installing of the desktop in post-install as it's already done by the port now.
Re: UPDATE: graphics/nsxiv-v30
Thim Cederlund wrote: > Hi, > > On 24/06-22 09:13, Omar Polo wrote: > > looks fine and works fine as usual, thanks! :) > > > > However, I noticed a few things that we may want to consider for the > > update. First of all, the development has moved to codeberg after > > github wiped (but then restored) the account of the maintainer[0]. > > Moving from GH_* to a custom MASTERSITE for Codeberg probably isn't an > > option, but they also have added an homepage[1] that we may want to link. > > Secondarly, I've noticed that upstream do provide icons for the > > software, so why don't install them as well? > > > > [0]: > > https://nrk.neocities.org/articles/miserable-state-of-github-moderation.html > > [1]: https://nsxiv.codeberg.page/ > > > > Updated diff with these addressed and the patch regenerated (make > > update-patches). It's ok for you? :) > > Sure, adding the MASTRERSITE codeberg is ok by me. > > I agree with your changes and not adding the icons was a clear miss > from my end. I don't use icons so I didn't even notice there were > any. they're also difficult to discover, i noticed an `install-icons' almost by chance when I was taking a quick look at the homepage... Committed, thanks! > Thank you Omar :) > > > > > Cheers, > > > > Omar Polo
Re: UPDATE: graphics/nsxiv-v30
On 24/06-22 11:09, Thim Cederlund wrote: > Sure, adding the MASTRERSITE codeberg is ok by me. Sorry, I meant HOMEPAGE and not MASTERSITE obviously. Best Regards, Thim Cederlund
Re: UPDATE: graphics/nsxiv-v30
Hi,
On 24/06-22 09:13, Omar Polo wrote:
> looks fine and works fine as usual, thanks! :)
>
> However, I noticed a few things that we may want to consider for the
> update. First of all, the development has moved to codeberg after
> github wiped (but then restored) the account of the maintainer[0].
> Moving from GH_* to a custom MASTERSITE for Codeberg probably isn't an
> option, but they also have added an homepage[1] that we may want to link.
> Secondarly, I've noticed that upstream do provide icons for the
> software, so why don't install them as well?
>
> [0]:
> https://nrk.neocities.org/articles/miserable-state-of-github-moderation.html
> [1]: https://nsxiv.codeberg.page/
>
> Updated diff with these addressed and the patch regenerated (make
> update-patches). It's ok for you? :)
Sure, adding the MASTRERSITE codeberg is ok by me.
I agree with your changes and not adding the icons was a clear miss
from my end. I don't use icons so I didn't even notice there were
any.
Thank you Omar :)
>
> Cheers,
>
> Omar Polo
>
> Index: Makefile
> ===
> RCS file: /home/cvs/ports/graphics/nsxiv/Makefile,v
> retrieving revision 1.3
> diff -u -p -r1.3 Makefile
> --- Makefile 11 Mar 2022 19:22:54 - 1.3
> +++ Makefile 24 Jun 2022 07:07:36 -
> @@ -2,10 +2,12 @@ COMMENT = neo simple X Image Viewer
>
> GH_PROJECT = nsxiv
> GH_ACCOUNT = nsxiv
> -GH_TAGNAME = v29
> +GH_TAGNAME = v30
>
> CATEGORIES = graphics x11
>
> +HOMEPAGE = https://nsxiv.codeberg.page/
> +
> MAINTAINER = Thim Cederlund
>
> # GPLv2+
> @@ -41,6 +43,7 @@ MAKE_FLAGS =CC="${CC}" \
> CFLAGS="${CFLAGS}" \
> LDFLAGS="${LDFLAGS}"
>
> +FAKE_TARGET =install-all
> NO_TEST =Yes
>
> post-patch:
> Index: distinfo
> ===
> RCS file: /home/cvs/ports/graphics/nsxiv/distinfo,v
> retrieving revision 1.2
> diff -u -p -r1.2 distinfo
> --- distinfo 3 Mar 2022 17:38:24 - 1.2
> +++ distinfo 24 Jun 2022 06:50:20 -
> @@ -1,2 +1,2 @@
> -SHA256 (nsxiv-29.tar.gz) =
> 564a17d921172336f7cd463bf313e39f84e4bcf4fdc789326f4112f848aad039
> -SIZE (nsxiv-29.tar.gz) = 64012
> +SHA256 (nsxiv-30.tar.gz) = TmAIxlynGlHVndfqfPDrSFctniB6dA9z8o58h35DTSs=
> +SIZE (nsxiv-30.tar.gz) = 65642
> Index: patches/patch-nsxiv_1
> ===
> RCS file: /home/cvs/ports/graphics/nsxiv/patches/patch-nsxiv_1,v
> retrieving revision 1.2
> diff -u -p -r1.2 patch-nsxiv_1
> --- patches/patch-nsxiv_1 3 Mar 2022 17:38:24 - 1.2
> +++ patches/patch-nsxiv_1 24 Jun 2022 06:51:28 -
> @@ -3,7 +3,7 @@ Corrects the path of keysymdef.h.
> Index: nsxiv.1
> --- nsxiv.1.orig
> +++ nsxiv.1
> -@@ -470,7 +470,7 @@ By default nsxiv(1) will send one image per-line to st
> +@@ -499,7 +499,7 @@ By default nsxiv(1) will send one image per-line to st
>
> The key combo argument has the following form: "[C-][M-][S-]KEY",
> where C/M/S indicate Ctrl/Meta(Alt)/Shift modifier states and KEY is the X
> Index: pkg/PLIST
> ===
> RCS file: /home/cvs/ports/graphics/nsxiv/pkg/PLIST,v
> retrieving revision 1.2
> diff -u -p -r1.2 PLIST
> --- pkg/PLIST 3 Mar 2022 17:38:24 - 1.2
> +++ pkg/PLIST 24 Jun 2022 07:07:03 -
> @@ -8,5 +8,12 @@ share/doc/nsxiv/
> share/doc/nsxiv/examples/
> share/doc/nsxiv/examples/image-info
> share/doc/nsxiv/examples/key-handler
> +share/doc/nsxiv/examples/thumb-info
> share/doc/nsxiv/examples/win-title
> +share/icons/hicolor/128x128/apps/nsxiv.png
> +share/icons/hicolor/16x16/apps/nsxiv.png
> +share/icons/hicolor/32x32/apps/nsxiv.png
> +share/icons/hicolor/48x48/apps/nsxiv.png
> +share/icons/hicolor/64x64/apps/nsxiv.png
> @tag update-desktop-database
> +@tag gtk-update-icon-cache %D/share/icons/hicolor
>
>
Re: UPDATE: graphics/nsxiv-v30
Thim Cederlund wrote:
> Hi,
>
> Update for nsxiv to v30.
>
> TLDR; a new script has been introduced that is called when the
> selected image changes in thumbnail mode.
>
> Proper changelog doesn't exist so I would advise you to check:
> https://github.com/nsxiv/nsxiv/commits/master
>
> OK? Anyone willing to commit?
looks fine and works fine as usual, thanks! :)
However, I noticed a few things that we may want to consider for the
update. First of all, the development has moved to codeberg after
github wiped (but then restored) the account of the maintainer[0].
Moving from GH_* to a custom MASTERSITE for Codeberg probably isn't an
option, but they also have added an homepage[1] that we may want to link.
Secondarly, I've noticed that upstream do provide icons for the
software, so why don't install them as well?
[0]:
https://nrk.neocities.org/articles/miserable-state-of-github-moderation.html
[1]: https://nsxiv.codeberg.page/
Updated diff with these addressed and the patch regenerated (make
update-patches). It's ok for you? :)
Cheers,
Omar Polo
Index: Makefile
===
RCS file: /home/cvs/ports/graphics/nsxiv/Makefile,v
retrieving revision 1.3
diff -u -p -r1.3 Makefile
--- Makefile11 Mar 2022 19:22:54 - 1.3
+++ Makefile24 Jun 2022 07:07:36 -
@@ -2,10 +2,12 @@ COMMENT = neo simple X Image Viewer
GH_PROJECT = nsxiv
GH_ACCOUNT = nsxiv
-GH_TAGNAME = v29
+GH_TAGNAME = v30
CATEGORIES = graphics x11
+HOMEPAGE = https://nsxiv.codeberg.page/
+
MAINTAINER = Thim Cederlund
# GPLv2+
@@ -41,6 +43,7 @@ MAKE_FLAGS = CC="${CC}" \
CFLAGS="${CFLAGS}" \
LDFLAGS="${LDFLAGS}"
+FAKE_TARGET = install-all
NO_TEST = Yes
post-patch:
Index: distinfo
===
RCS file: /home/cvs/ports/graphics/nsxiv/distinfo,v
retrieving revision 1.2
diff -u -p -r1.2 distinfo
--- distinfo3 Mar 2022 17:38:24 - 1.2
+++ distinfo24 Jun 2022 06:50:20 -
@@ -1,2 +1,2 @@
-SHA256 (nsxiv-29.tar.gz) =
564a17d921172336f7cd463bf313e39f84e4bcf4fdc789326f4112f848aad039
-SIZE (nsxiv-29.tar.gz) = 64012
+SHA256 (nsxiv-30.tar.gz) = TmAIxlynGlHVndfqfPDrSFctniB6dA9z8o58h35DTSs=
+SIZE (nsxiv-30.tar.gz) = 65642
Index: patches/patch-nsxiv_1
===
RCS file: /home/cvs/ports/graphics/nsxiv/patches/patch-nsxiv_1,v
retrieving revision 1.2
diff -u -p -r1.2 patch-nsxiv_1
--- patches/patch-nsxiv_1 3 Mar 2022 17:38:24 - 1.2
+++ patches/patch-nsxiv_1 24 Jun 2022 06:51:28 -
@@ -3,7 +3,7 @@ Corrects the path of keysymdef.h.
Index: nsxiv.1
--- nsxiv.1.orig
+++ nsxiv.1
-@@ -470,7 +470,7 @@ By default nsxiv(1) will send one image per-line to st
+@@ -499,7 +499,7 @@ By default nsxiv(1) will send one image per-line to st
The key combo argument has the following form: "[C-][M-][S-]KEY",
where C/M/S indicate Ctrl/Meta(Alt)/Shift modifier states and KEY is the X
Index: pkg/PLIST
===
RCS file: /home/cvs/ports/graphics/nsxiv/pkg/PLIST,v
retrieving revision 1.2
diff -u -p -r1.2 PLIST
--- pkg/PLIST 3 Mar 2022 17:38:24 - 1.2
+++ pkg/PLIST 24 Jun 2022 07:07:03 -
@@ -8,5 +8,12 @@ share/doc/nsxiv/
share/doc/nsxiv/examples/
share/doc/nsxiv/examples/image-info
share/doc/nsxiv/examples/key-handler
+share/doc/nsxiv/examples/thumb-info
share/doc/nsxiv/examples/win-title
+share/icons/hicolor/128x128/apps/nsxiv.png
+share/icons/hicolor/16x16/apps/nsxiv.png
+share/icons/hicolor/32x32/apps/nsxiv.png
+share/icons/hicolor/48x48/apps/nsxiv.png
+share/icons/hicolor/64x64/apps/nsxiv.png
@tag update-desktop-database
+@tag gtk-update-icon-cache %D/share/icons/hicolor
