Re: new: se-3.0

2013-03-24 Thread Matthias Kilian
On Sun, Mar 24, 2013 at 02:28:51PM -0400, James Turner wrote:
> Attached is a new port for "se" a screen oriented version of the classic
> text editor ed.
> 
> Tested on amd64 and loongson. oks?

No. It unconditionally reads and executes commands (including !
shell commands) from .serc (in the current working directory),
regardless who owns that file or who can write it. Sorry, but this
.serc feature should be either removed or change to work in a way
similar to .nexrc and .exrc in vi(1).

Ciao,
Kili



Re: new: se-3.0

2013-03-24 Thread James Turner
On Sun, Mar 24, 2013 at 10:12:17PM +0100, Matthias Kilian wrote:
> On Sun, Mar 24, 2013 at 02:28:51PM -0400, James Turner wrote:
> > Attached is a new port for "se" a screen oriented version of the classic
> > text editor ed.
> > 
> > Tested on amd64 and loongson. oks?
> 
> No. It unconditionally reads and executes commands (including !
> shell commands) from .serc (in the current working directory),
> regardless who owns that file or who can write it. Sorry, but this
> .serc feature should be either removed or change to work in a way
> similar to .nexrc and .exrc in vi(1).
> 
> Ciao,
>   Kili
> 

I'll try to get this fixed and integrated upstream. I'll resubmit once
the issuses resolved.

--
James Turner



Re: new: se-3.0

2013-03-24 Thread James Turner
On Sun, Mar 24, 2013 at 05:31:44PM -0400, James Turner wrote:
> On Sun, Mar 24, 2013 at 10:12:17PM +0100, Matthias Kilian wrote:
> > On Sun, Mar 24, 2013 at 02:28:51PM -0400, James Turner wrote:
> > > Attached is a new port for "se" a screen oriented version of the classic
> > > text editor ed.
> > > 
> > > Tested on amd64 and loongson. oks?
> > 
> > No. It unconditionally reads and executes commands (including !
> > shell commands) from .serc (in the current working directory),
> > regardless who owns that file or who can write it. Sorry, but this
> > .serc feature should be either removed or change to work in a way
> > similar to .nexrc and .exrc in vi(1).
> > 
> > Ciao,
> > Kili
> > 
> 
> I'll try to get this fixed and integrated upstream. I'll resubmit once
> the issuses resolved.
> 
> --
> James Turner
> 

The upstream developer just committed a fix [0] and released version
3.0.1. Attached is an updated port.

[0]
https://github.com/tcort/se/commit/49ceea2d72f0517a411467f375f7815c5e910749

-- 
James Turner


se-3.0.1.tar
Description: Unix tar archive


Re: new: se-3.0

2013-03-25 Thread Christian Weisgerber
James Turner  wrote:

> Description:
> se is a screen oriented version of the classic UNIX text editor ed. se
> has a long history dating back to the early 1980s. Beginning in 2013,
> Thomas Cort undertook the task of modernizing the early code and build
> system to get the software working on recent POSIX operating systems.
> 
> The code base was straight forward and only used facilities available 25
> years prior, and as a result, with a few modifications, it runs on many
> modern operating systems. Thomas' primary motivation is to preserve this
> bit of computing history. His goals are to squash any remaining bugs and
> make se as portable as possible. No major new features will be added.

I know we all just copy and paste this stuff, but try to see it
from the user's perspective.  What do I want to know?  What is this
package, what can it be used for.  I do not care about the history,
other operating systems, or the author's love for kittens.  All but
the first line of that description is useless fluff and can be
removed.

-- 
Christian "naddy" Weisgerber  na...@mips.inka.de



Re: new: se-3.0

2013-03-25 Thread Stuart Henderson
On 2013/03/25 16:19, Christian Weisgerber wrote:
> James Turner  wrote:
> 
> > Description:
> > se is a screen oriented version of the classic UNIX text editor ed. se
> > has a long history dating back to the early 1980s. Beginning in 2013,
> > Thomas Cort undertook the task of modernizing the early code and build
> > system to get the software working on recent POSIX operating systems.
> > 
> > The code base was straight forward and only used facilities available 25
> > years prior, and as a result, with a few modifications, it runs on many
> > modern operating systems. Thomas' primary motivation is to preserve this
> > bit of computing history. His goals are to squash any remaining bugs and
> > make se as portable as possible. No major new features will be added.
> 
> I know we all just copy and paste this stuff, but try to see it
> from the user's perspective.  What do I want to know?  What is this
> package, what can it be used for.  I do not care about the history,
> other operating systems, or the author's love for kittens.  All but
> the first line of that description is useless fluff and can be
> removed.

A short description of what "a screen oriented version of(...)ed"
actually does might be handy. Isn't that what vi is? How does this differ?

My usual method for DESCR is to copy/paste, then read through, remove
junk, rewrite sections where they don't make sense or aren't written in
fluent language, and re-flow so they look nice (usually starting with
fmt and par, picking the nicest, then tweaking where it looks raggedy)..



Re: new: se-3.0

2013-03-25 Thread James Turner
On Mon, Mar 25, 2013 at 04:19:50PM +, Christian Weisgerber wrote:
> James Turner  wrote:
> 
> > Description:
> > se is a screen oriented version of the classic UNIX text editor ed. se
> > has a long history dating back to the early 1980s. Beginning in 2013,
> > Thomas Cort undertook the task of modernizing the early code and build
> > system to get the software working on recent POSIX operating systems.
> > 
> > The code base was straight forward and only used facilities available 25
> > years prior, and as a result, with a few modifications, it runs on many
> > modern operating systems. Thomas' primary motivation is to preserve this
> > bit of computing history. His goals are to squash any remaining bugs and
> > make se as portable as possible. No major new features will be added.
> 
> I know we all just copy and paste this stuff, but try to see it
> from the user's perspective.  What do I want to know?  What is this
> package, what can it be used for.  I do not care about the history,
> other operating systems, or the author's love for kittens.  All but
> the first line of that description is useless fluff and can be
> removed.
> 
> -- 
> Christian "naddy" Weisgerber  na...@mips.inka.de
> 

How is the below for an updated DESCR. I didn't really address how it's
different then vi, since in the long wrong it probably isn't all that
different. It just presents a different interface and has different
commands.

DESCR
se is a screen oriented version of the classic UNIX text editor ed. It
has a full visual interface allowing you to see the text you're editing.
It's command syntax will be very familiar to users who already know ed.

Some of se's additional features are, a built-in help system,
configurable options that can be loaded from a startup file, the ability
to be ran interactively or via the included scriptse utility, and
optional usage logging.

-- 
James Turner



Re: new: se-3.0

2013-03-25 Thread Christian Weisgerber
James Turner  wrote:

> How is the below for an updated DESCR.

Sure, that's fine.  Don't overthink it.

-- 
Christian "naddy" Weisgerber  na...@mips.inka.de



Re: new: se-3.0

2013-05-04 Thread James Turner
On Sun, Mar 24, 2013 at 07:19:45PM -0400, James Turner wrote:
> On Sun, Mar 24, 2013 at 05:31:44PM -0400, James Turner wrote:
> > On Sun, Mar 24, 2013 at 10:12:17PM +0100, Matthias Kilian wrote:
> > > On Sun, Mar 24, 2013 at 02:28:51PM -0400, James Turner wrote:
> > > > Attached is a new port for "se" a screen oriented version of the classic
> > > > text editor ed.
> > > > 
> > > > Tested on amd64 and loongson. oks?
> > > 
> > > No. It unconditionally reads and executes commands (including !
> > > shell commands) from .serc (in the current working directory),
> > > regardless who owns that file or who can write it. Sorry, but this
> > > .serc feature should be either removed or change to work in a way
> > > similar to .nexrc and .exrc in vi(1).
> > > 
> > > Ciao,
> > >   Kili
> > > 
> > 
> > I'll try to get this fixed and integrated upstream. I'll resubmit once
> > the issuses resolved.
> > 
> > --
> > James Turner
> > 
> 
> The upstream developer just committed a fix [0] and released version
> 3.0.1. Attached is an updated port.
> 
> [0]
> https://github.com/tcort/se/commit/49ceea2d72f0517a411467f375f7815c5e910749
> 
> -- 
> James Turner

Alright, attached is an update to the se port I originally submitted
back in March. kili@ pointed out a possible race condition int the order
in which .serc was being checked and then read. I submitted a patch
upstream [0] based on original work by kili@ yesterday after his vi
changes were committed to cvs.

The patch was accepted and merged. I've back ported the change to 3.0.1.
Hopefully this should be ready to go in now. Thanks.

[0]
https://github.com/tcort/se/commit/6e47e4bb7cb197c9cbfd83a3dd34601f024c0a03

-- 
James Turner


se-3.0.1.tar
Description: Unix tar archive