UPDATE: windowmaker-0.95.2
Hi, this diff updates WindowMaker 0.92.0 to 0.95.2. Most of the diffs have been kindly integrated into 0.95.2 we previously applied to 0.92.0. I have contacted the devs to integrate the new diffs -- as far as possible. Tested on my i386 machine, broad testing greatly appreciated! Especially regarding the fact that this is my first update to port. ;) Tobias Index: Makefile === RCS file: /home/tobias/anoncvs/ports/x11/windowmaker/Makefile,v retrieving revision 1.83 diff -u -p -r1.83 Makefile --- Makefile29 Mar 2012 13:39:01 - 1.83 +++ Makefile29 Apr 2012 11:59:46 - @@ -3,13 +3,15 @@ COMMENT-main= window manager that emulates NEXTSTEP(tm) COMMENT-lang= language subpackage for Window Maker -V= 0.92.0 +V= 0.95.2 DISTNAME= WindowMaker-${V} PKGNAME-main= ${DISTNAME:L} -REVISION-main= 11 +REVISION-main= 0 FULLPKGNAME-lang= windowmaker-lang-${V} -REVISION-lang= 2 -SHARED_LIBS= wraster 5.0 +REVISION-lang= 0 +SHARED_LIBS= WINGs 2.1 \ + WUtil 2.0 \ + wraster 5.0 CATEGORIES=x11 x11/windowmaker HOMEPAGE= http://www.windowmaker.info/ @@ -23,7 +25,7 @@ PERMIT_DISTFILES_CDROM= Yes PERMIT_DISTFILES_FTP= Yes MASTER_SITES= ${MASTER_SITE_WINDOWMAKER:=source/release/} -EXTRACT_SUFX= .tar.bz2 +EXTRACT_SUFX= .tar.gz NO_REGRESS=Yes SEPARATE_BUILD=Yes @@ -37,7 +39,7 @@ CONFIGURE_ARGS+= ${CONFIGURE_SHARED} \ --with-nlsdir="${LOCALBASE}/share/locale" CONFIGURE_ENV= CPPFLAGS="-I${LOCALBASE}/include -I${LOCALBASE}/include/libpng" LIBS="-L${LOCALBASE}/lib" \ - LINGUAS='be bg bs ca cs da de el es et fi fr gl hr hu it ja ko ms nl no pl pt ro ru sk sv tr zh_CN zh_TW' + LINGUAS='be bg bs ca cs da de el es et fi fr gl hr hu hy it ja ko ms nl no pl pt ro ru sk sv tr zh_CN zh_TW' MULTI_PACKAGES= -main -lang Index: distinfo === RCS file: /home/tobias/anoncvs/ports/x11/windowmaker/distinfo,v retrieving revision 1.6 diff -u -p -r1.6 distinfo --- distinfo5 Apr 2007 17:36:25 - 1.6 +++ distinfo29 Apr 2012 12:00:59 - @@ -1,5 +1,5 @@ -MD5 (WindowMaker-0.92.0.tar.bz2) = qqxUIbaG7S0+arZSKcmAlw== -RMD160 (WindowMaker-0.92.0.tar.bz2) = wWHu5kCS+vtIaBgf4qC225btbeA= -SHA1 (WindowMaker-0.92.0.tar.bz2) = T3/qb0C5up+HDS4vDORidHUO2yw= -SHA256 (WindowMaker-0.92.0.tar.bz2) = tDHOn0fF1M1Sq1uCmM/1b9VwDW5gUrFJ4ZtsVn5SbbE= -SIZE (WindowMaker-0.92.0.tar.bz2) = 2202748 +MD5 (WindowMaker-0.95.2.tar.gz) = ae62bad9c4dee504066e0f172b565ff0 +RIPEMD160(WindowMaker-0.95.2.tar.gz) = bd0e1737ca356a0178afdbaac156abb50115fb1d +SHA1 (WindowMaker-0.95.2.tar.gz) = 9fa55d525a04377089caf6ffc0c4d8d0aebe9d61 +SHA256 (WindowMaker-0.95.2.tar.gz) = 6b271e9427f5207484ec21c25e114e4eb1eafa957b446a1ff516f0c41ac19c59 +SIZE (WindowMaker-0.95.2.tar.gz) = 2753910 Index: patches/patch-WINGs_Makefile_in === RCS file: /home/tobias/anoncvs/ports/x11/windowmaker/patches/patch-WINGs_Makefile_in,v retrieving revision 1.7 diff -u -p -r1.7 patch-WINGs_Makefile_in --- patches/patch-WINGs_Makefile_in 1 Nov 2005 17:28:34 - 1.7 +++ patches/patch-WINGs_Makefile_in 28 Apr 2012 20:50:14 - @@ -1,21 +1,28 @@ -$OpenBSD: patch-WINGs_Makefile_in,v 1.7 2005/11/01 17:28:34 wilfried Exp $ WINGs/Makefile.in.orig Sun Jun 19 05:23:00 2005 -+++ WINGs/Makefile.in Mon Oct 31 18:34:05 2005 -@@ -114,7 +114,7 @@ wprefs_datadir = @wprefs_datadir@ +--- WINGs/Makefile.in.orig Sat Apr 28 21:24:08 2012 WINGs/Makefile.in Sat Apr 28 21:27:43 2012 +@@ -402,7 +402,7 @@ + wconfig.h \ + wutil.c + +-AM_CPPFLAGS = -DLOCALEDIR=\"$(NLSDIR)\" -DRESOURCE_PATH=\"$(datadir)/WINGs\" -DDEBUG ++AM_CPPFLAGS = -DLOCALEDIR=\"$(NLSDIR)\" -DRESOURCE_PATH=\"$(datadir)/WINGs\" + AM_CFLAGS = + INCLUDES = -I$(top_srcdir)/WINGs/WINGs -I$(top_srcdir)/wrlib -I$(top_srcdir)/src \ + @XFTFLAGS@ @HEADER_SEARCH_PATH@ +@@ -964,14 +964,14 @@ + -e 's#$${GFXLIBS}#$(GFXLIBS)#;' \ + -e 's#$${XFTLIBS}#$(XFTLIBS)#;' \ + -e 's#$${INTLIBS}#$(INTLIBS)#;' \ +- -e 's#$${XLIBS}#$(XLIBS)#;' < $(dir $<@)get-wings-flags.in > $@ ++ -e 's#$${XLIBS}#$(XLIBS)#;' < $(abs_srcdir)/get-wings-flags.in > $@ + @chmod 755 $@ + + get-wutil-flags: get-wutil-flags.in Makefile + @echo "Generating $@" + @$(SED) -e 's#$${includedir}#$(includedir)#;' \ + -e 's#$${libdir}#$(libdir)#;' \ +- -e 's#$${INTLIBS}#$(INTLIBS)#;' < $(dir $<@)get-wutil-flags.in > $@ ++ -e 's#$${INTLIBS}#$(INTLIBS)#;' <
Re: UPDATE: WindowMaker-0.95.2
On Sun, 26 Feb 2012 16:35:31 +0100, David Coppa wrote: Hi, This diff updates WindowMaker to its latest version: 0.95.2. Yes, development has started again after so many years... Please test and comment. I'm not CCing maintainer since he's no more a openbsd dev. Ciao David Index: patches/patch-WindowMaker_plmenu === RCS file: /cvs/ports/x11/windowmaker/patches/patch-WindowMaker_plmenu,v retrieving revision 1.3 diff -u -p -r1.3 patch-WindowMaker_plmenu --- patches/patch-WindowMaker_plmenu1 Nov 2005 17:28:34 - 1.3 +++ patches/patch-WindowMaker_plmenu24 Feb 2012 16:27:20 - @@ -1,12 +1,12 @@ $OpenBSD: patch-WindowMaker_plmenu,v 1.3 2005/11/01 17:28:34 wilfried Exp $ WindowMaker/plmenu.origSat Oct 23 05:49:23 2004 -+++ WindowMaker/plmenu Mon Oct 31 18:41:14 2005 +--- WindowMaker/plmenu.origWed Dec 21 11:32:55 2011 WindowMaker/plmenu Wed Dec 21 11:33:18 2011 @@ -93,7 +93,7 @@ -), -("Save Theme", SHEXEC, "getstyle -t $HOME/GNUstep/Library/WindowMaker/Themes/\"%a(Theme name)\""), -("Save IconSet", SHEXEC, "geticonset $HOME/GNUstep/Library/WindowMaker/IconSets/\"%a(IconSet name)\""), -- ("Preferences Utility", EXEC, "/usr/local/GNUstep/Applications/WPrefs.app/WPrefs") -+ ("Preferences Utility", EXEC, "#wprefsdir#/WPrefs") -), -("Session", - ("Save Session", SAVE_SESSION), +), +("Save Theme", SHEXEC, "getstyle -t $HOME/GNUstep/Library/WindowMaker/Themes/\"%a(Theme name)\""), +("Save IconSet", SHEXEC, "geticonset $HOME/GNUstep/Library/WindowMaker/IconSets/\"%a(IconSet name)\""), +- ("Preferences Utility", EXEC, "/usr/local/GNUstep/Applications/WPrefs.app/WPrefs") ++ ("Preferences Utility", EXEC, "#wprefsdir#/WPrefs") +), +("Session", + ("Save Session", SAVE_SESSION), Hi. This part of the patch fails for me. "Hunk #1 failed at 1". Cheers. -- Juan Francisco Cantero Hurtado http://juanfra.info
Re: UPDATE: WindowMaker-0.95.2
On Fri, Mar 2, 2012 at 3:44 PM, Stuart Henderson wrote: > There are trailing ^M in the patch in CVS which aren't making it > through email. Ah, ok. There's the one attached not-inline btw...
Re: UPDATE: WindowMaker-0.95.2
On Fri, Mar 2, 2012 at 4:03 PM, Stuart Henderson wrote: > On 2012/03/02 15:49, David Coppa wrote: >> On Fri, Mar 2, 2012 at 3:44 PM, Stuart Henderson >> wrote: >> > There are trailing ^M in the patch in CVS which aren't making it >> > through email. >> >> Ah, ok. >> >> There's the one attached not-inline btw... > > This doesn't help, email still eats them, easier to put it online - > pbot handles these OK, you can use the attached script (needs p5-libwww) > > cvs di | pbot http://pbot.rmdir.de/fa0e34c8bfab313978f7f9088ce30e8c Thanks for the tip, David
Re: UPDATE: WindowMaker-0.95.2
On Fri, 02 Mar 2012 16:19:38 +0100, David Coppa wrote: On Fri, Mar 2, 2012 at 4:03 PM, Stuart Henderson wrote: On 2012/03/02 15:49, David Coppa wrote: On Fri, Mar 2, 2012 at 3:44 PM, Stuart Henderson wrote: > There are trailing ^M in the patch in CVS which aren't making it > through email. I've tried some of your patches during the last weeks and this problem was common. I always fixed the problem with "tr -d '\r' < yourpatch > newpatch", but I think in this occasion my trick isn't sufficient :) Ah, ok. There's the one attached not-inline btw... This doesn't help, email still eats them, easier to put it online - pbot handles these OK, you can use the attached script (needs p5-libwww) cvs di | pbot http://pbot.rmdir.de/fa0e34c8bfab313978f7f9088ce30e8c Thanks. The patch apply without errors. I don't remember the last time I used wmaker, but I think all works OK. -- Juan Francisco Cantero Hurtado http://juanfra.info
Re: UPDATE: WindowMaker-0.95.2
On 2012-03-02 16:19:38, David Coppa wrote: > > http://pbot.rmdir.de/fa0e34c8bfab313978f7f9088ce30e8c > > Thanks for the tip, > David > I tested it for about 5 minutes before having to roll back to 0.92.0. The problems I saw were as follows. Trying to set ports/games/wesnoth to full-screen mode via its in-game option started a weird loop where the screen would continuously resize from 1600x1200 (my default) to 1024x768 (how I've set Wesnoth's full-screen mode) and then back to 1600x1200 (and then to 1024x768 etc.). It took about a second or two between switches. The first time it happened I was quick (or lucky) enough to untick the full-screen checkbox and the screen went back to 1600x1200. The second time I ended up switching to a console terminal and pkilling wesnoth. The screen was left in 1024x768 mode and had to be set back to normal via xrandr. I've had no problems switching from windowed to full-screen mode before. It's always seamlessly changed to full-screen mode and the lower resolution and then back again with no problems. Another issue is that I have ctrl+u mapped to spawn an xterm. In 0.95.2 a single press of ctrl+u would open two xterms instead of a single one. One final issue I saw was that despite the fact that I have all animations turned off in WindowMaker's preferences app, double-clicking window titles "rolled" the window up and down smoothly instead of instantly {dis,re}appearing. I'm very happy to see WindowMaker getting active development and that you've taken the time to update the port, but with the full-screen bug and the double-spawning of xterms I was not able to use the new version and had to roll back to 0.92. If there's any more information I can provide to help, I would very much like to see an updated version of WindowMaker in the ports tree. All packages are up-to-date with regards to the snapshot I'm running. dmesg follows. (I know it's a bit old and does not have the rthread changes. I've been waiting for a new snapshot to be released. I can retest as soon as a new snap is released if you think it will make a difference.) -- Bryan OpenBSD 5.1 (GENERIC) #157: Fri Feb 10 11:07:41 MST 2012 dera...@i386.openbsd.org:/usr/src/sys/arch/i386/compile/GENERIC cpu0: AMD Athlon(tm) Processor ("AuthenticAMD" 686-class, 256KB L2 cache) 1.01 GHz cpu0: FPU,V86,DE,PSE,TSC,MSR,PAE,MCE,CX8,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,MMX,FXSR,MMXX,3DNOW2,3DNOW real mem = 804753408 (767MB) avail mem = 781492224 (745MB) mainbus0 at root bios0 at mainbus0: AT/286+ BIOS, date 04/23/02, BIOS32 rev. 0 @ 0xf0f80, SMBIOS rev. 2.3 @ 0xf2940 (49 entries) bios0: vendor Award Software, Inc. version "ASUS A7V ACPI BIOS Revision 1011" date 04/23/2002 bios0: ASUSTeK Computer INC. apm0 at bios0: Power Management spec V1.2 acpi at bios0 function 0x0 not configured pcibios0 at bios0: rev 2.1 @ 0xf/0x1802 pcibios0: PCI IRQ Routing Table rev 1.0 @ 0xf1750/176 (9 entries) pcibios0: PCI Interrupt Router at 000:04:0 ("VIA VT82C686 ISA" rev 0x00) pcibios0: PCI bus #1 is the last bus bios0: ROM list: 0xc/0xf400 0xd/0x4000! cpu0 at mainbus0: (uniprocessor) pci0 at mainbus0 bus 0: configuration mode 1 (bios) pchb0 at pci0 dev 0 function 0 "VIA VT8363 Host" rev 0x02 viaagp0 at pchb0: v2 agp0 at viaagp0: aperture at 0xe000, size 0x1000 ppb0 at pci0 dev 1 function 0 "VIA VT8363 AGP" rev 0x00 pci1 at ppb0 bus 1 vga1 at pci1 dev 0 function 0 "ATI Radeon X1300/X1550" rev 0x00 wsdisplay0 at vga1 mux 1: console (80x25, vt100 emulation) wsdisplay0: screen 1-5 added (80x25, vt100 emulation) radeondrm0 at vga1: irq 11 drm0 at radeondrm0 "ATI Radeon X1300/X1550 Sec" rev 0x00 at pci1 dev 0 function 1 not configured pcib0 at pci0 dev 4 function 0 "VIA VT82C686 ISA" rev 0x22 pciide0 at pci0 dev 4 function 1 "VIA VT82C571 IDE" rev 0x10: ATA66, channel 0 configured to compatibility, channel 1 configured to compatibility wd0 at pciide0 channel 0 drive 0: wd0: 1-sector PIO, LBA, 3823MB, 7831152 sectors wd0(pciide0:0:0): using PIO mode 4, Ultra-DMA mode 4 atapiscsi0 at pciide0 channel 1 drive 0 scsibus0 at atapiscsi0: 2 targets cd0 at scsibus0 targ 0 lun 0: ATAPI 5/cdrom removable cd0(pciide0:1:0): using PIO mode 4, Ultra-DMA mode 2 uhci0 at pci0 dev 4 function 2 "VIA VT83C572 USB" rev 0x10: irq 5 uhci1 at pci0 dev 4 function 3 "VIA VT83C572 USB" rev 0x10: irq 5 viapm0 at pci0 dev 4 function 4 "VIA VT82C686 SMBus" rev 0x30: SMI iic0 at viapm0 lm1 at iic0 addr 0x2d: AS99127F viapm0: 24-bit timer at 3579545Hz viapm0: HWM disabled cmpci0 at pci0 dev 9 function 0 "C-Media Electronics CMI8738/C3DX Audio" rev 0x10: irq 5 audio0 at cmpci0 opl at cmpci0 not configured mpu at cmpci0 not configured re0 at pci0 dev 11 function 0 "Realtek 8169" rev 0x10: RTL8110S (0x0400), irq 10, address 00:e0:4c:77:5a:88 rgephy0 at re0 phy 7: RTL8169S/8110S PHY, rev. 0 sili0 at pci0 dev 12 function 0 "CMD Technology SiI3124 SATA" rev 0x02: irq 11 scsibus1 at sili0: 4 targets sd0 at scsibus1 targ 2 lun 0: SCSI3 0/
Re: UPDATE: WindowMaker-0.95.2
On Sat, 03 Mar 2012 04:56:29 +0100, Bryan Linton wrote: On 2012-03-02 16:19:38, David Coppa wrote: http://pbot.rmdir.de/fa0e34c8bfab313978f7f9088ce30e8c Thanks for the tip, David I tested it for about 5 minutes before having to roll back to 0.92.0. The problems I saw were as follows. Trying to set ports/games/wesnoth to full-screen mode via its in-game option started a weird loop where the screen would continuously resize from 1600x1200 (my default) to 1024x768 (how I've set Wesnoth's full-screen mode) and then back to 1600x1200 (and then to 1024x768 etc.). It took about a second or two between switches. The first time it happened I was quick (or lucky) enough to untick the full-screen checkbox and the screen went back to 1600x1200. The second time I ended up switching to a console terminal and pkilling wesnoth. The screen was left in 1024x768 mode and had to be set back to normal via xrandr. I've had no problems switching from windowed to full-screen mode before. It's always seamlessly changed to full-screen mode and the lower resolution and then back again with no problems. Comment the line with "--enable-xrandr" in the makefile and try again. This is a new option and can be the culprit. Another issue is that I have ctrl+u mapped to spawn an xterm. In 0.95.2 a single press of ctrl+u would open two xterms instead of a single one. One final issue I saw was that despite the fact that I have all animations turned off in WindowMaker's preferences app, double-clicking window titles "rolled" the window up and down smoothly instead of instantly {dis,re}appearing. I'm very happy to see WindowMaker getting active development and that you've taken the time to update the port, but with the full-screen bug and the double-spawning of xterms I was not able to use the new version and had to roll back to 0.92. If there's any more information I can provide to help, I would very much like to see an updated version of WindowMaker in the ports tree. All packages are up-to-date with regards to the snapshot I'm running. dmesg follows. (I know it's a bit old and does not have the rthread changes. I've been waiting for a new snapshot to be released. I can retest as soon as a new snap is released if you think it will make a difference.) -- Juan Francisco Cantero Hurtado http://juanfra.info
Re: UPDATE: WindowMaker-0.95.2
On 2012-03-04 01:36:46, Juan Francisco Cantero Hurtado wrote: >On Sat, 03 Mar 2012 04:56:29 +0100, Bryan Linton wrote: >>On 2012-03-02 16:19:38, David Coppa wrote: >>> >>>http://pbot.rmdir.de/fa0e34c8bfab313978f7f9088ce30e8c >>> >>>Thanks for the tip, >>>David >>> >> >>I tested it for about 5 minutes before having to roll back to >>0.92.0. The problems I saw were as follows. >> >>Trying to set ports/games/wesnoth to full-screen mode via its >>in-game option started a weird loop where the screen would >>continuously resize from 1600x1200 (my default) to 1024x768 (how >>I've set Wesnoth's full-screen mode) and then back to 1600x1200 (and >>then to 1024x768 etc.). >> >> [...] >> >>I've had no problems switching from windowed to full-screen mode >>before. It's always seamlessly changed to full-screen mode and the >>lower resolution and then back again with no problems. >> > > Comment the line with "--enable-xrandr" in the makefile and try > again. This is a new option and can be the culprit. > This seems to have fixed the problem. Also, I noticed that the problem I had with the double spawning of xterms when I press ctrl+u is fixed as well. I wonder if this behavior was a bug triggered by the resize loop because I can't reproduce it now. I also can't remember if it was double-spawning before I tried to launch Wesnoth or only after. Windows still "roll" up and down with an animation even though I have animations disabled in my preferences but this is only a minor annoyance and something that I assume will be fixed in a future update of WindowMaker. So far it seems like everything else is working smoothly. I'll run with this new version since the show-stopping bugs are gone now and report back if anything major happens. Otherwise, if xrandr support were disabled (which on WindowMaker's website is admitted to needing more work to be bug free) it would be nice to see this committed. I've been running WindowMaker for 10 years now and it really is great that development is being picked up again. -- Bryan
Re: UPDATE: WindowMaker-0.95.2
On 2012-03-04 16:27:50, Bryan Linton wrote: > > Also, I noticed that the problem I had with the double spawning > of xterms when I press ctrl+u is fixed as well. > I spoke too soon. WindowMaker ran fine for about a day, then all of a sudden ctrl+u started spawning two xterms. I can't think of anything I did which may have caused this. It seemed like it happened out of the blue. Restarting WindowMaker via its own restart option (i.e. not quitting Xorg nor quitting WindowMaker) fixed the double spawning. Since I don't lose my open windows by doing so, I'll continue to run with the new version in hopes of maybe recognizing something that triggers this behavior. Scanning through their git repo, nothing obviously popped out that may be the cause of this. Hopefully if it happens a few more times I'll be able to find a way to reproduce it. -- Bryan
Re: UPDATE: WindowMaker-0.95.2
On Sun, 04 Mar 2012, Bryan Linton wrote: > > Comment the line with "--enable-xrandr" in the makefile and try > > again. This is a new option and can be the culprit. > > > > This seems to have fixed the problem. Ok, I've removed optional XRandr support. Thanks a lot for testing, new diff is at: http://pbot.rmdir.de/bfdb46b47f24db7e9736acc9fd1f80ab > Also, I noticed that the problem I had with the double spawning > of xterms when I press ctrl+u is fixed as well. > > I wonder if this behavior was a bug triggered by the resize loop > because I can't reproduce it now. I also can't remember if it was > double-spawning before I tried to launch Wesnoth or only after. > > Windows still "roll" up and down with an animation even though I > have animations disabled in my preferences but this is only a > minor annoyance and something that I assume will be fixed in a > future update of WindowMaker. For the other problems, please report them to upstream if you can/want to... Ciao, David
Re: UPDATE: WindowMaker-0.95.2
On Sun, 04 Mar 2012, Bryan Linton wrote: > On 2012-03-04 16:27:50, Bryan Linton wrote: > > > > Also, I noticed that the problem I had with the double spawning > > of xterms when I press ctrl+u is fixed as well. > > > > I spoke too soon. WindowMaker ran fine for about a day, then all > of a sudden ctrl+u started spawning two xterms. I can't think of > anything I did which may have caused this. It seemed like it > happened out of the blue. > > Restarting WindowMaker via its own restart option (i.e. not > quitting Xorg nor quitting WindowMaker) fixed the double spawning. I'm just guessing, but... Can you try to reproduce this problem with a fresh configuration directory? i.e.: $ mv ~/GNUstep ~/GNUstep.orig && wmaker.inst cheers, David
Re: UPDATE: WindowMaker-0.95.2
On 2012-03-05 10:31:03, David Coppa wrote: > On Sun, 04 Mar 2012, Bryan Linton wrote: >> On 2012-03-04 16:27:50, Bryan Linton wrote: >>> >>> Also, I noticed that the problem I had with the double spawning >>> of xterms when I press ctrl+u is fixed as well. >>> >> >> I spoke too soon. WindowMaker ran fine for about a day, then all >> of a sudden ctrl+u started spawning two xterms. I can't think of >> anything I did which may have caused this. It seemed like it >> happened out of the blue. >> >> Restarting WindowMaker via its own restart option (i.e. not >> quitting Xorg nor quitting WindowMaker) fixed the double spawning. > > I'm just guessing, but... Can you try to reproduce this problem with > a fresh configuration directory? > > i.e.: > > $ mv ~/GNUstep ~/GNUstep.orig && wmaker.inst > Some good news and some bad news to report. I've been able to reliably reproduce the double-spawning of xterms I've been seeing. The bad news is that it still happens even with a fresh configuration directory. To reproduce: 0) Create a keyboard shortcut if one does not already exist (I'm using +u set to spawn an xterm) 1) Open WindowMaker's preferences. 2) Click on "Applications Menu Definition" (it's the icon immediately to the left of the keyboard icon) 3) Click save, and then close. 4) Keyboard shortcuts will spawn two applications. I use keyboard shortcuts to spawn xterms, browsers, and filemanagers. All of them spawn twice after performing the above. To fix it, or -> Exit -> Restart. If I repeat steps 1-3, three windows will spawn. Repeat again and four windows will spawn etc. (I stopped after getting five to spawn at once). Two other bugs that happened that I have not been able to reproduce since running 0.95.2 are as follows. I had WindowMaker start to use 100% CPU and become unresponsive. I had to switch to a console and pkill wmaker. IIRC, ++ did not function to quit X while this was happening, hence the use of pkill on the console. I also had a weird bug where videos in mplayer that normally played fine, only played at about 5 FPS. Restarting WindowMaker had no effect, but quitting WindowMaker and running startx again did fix it. I will continue to run with 0.95.2 to see if I can reproduce the above two bugs or find any new ones. -- Bryan
Re: UPDATE: WindowMaker-0.95.2
On Mon, Mar 12, 2012 at 1:14 AM, Bryan Linton wrote: > Some good news and some bad news to report. I've been able to > reliably reproduce the double-spawning of xterms I've been seeing. > The bad news is that it still happens even with a fresh > configuration directory. > > To reproduce: > 0) Create a keyboard shortcut if one does not already exist (I'm > using +u set to spawn an xterm) > 1) Open WindowMaker's preferences. > 2) Click on "Applications Menu Definition" (it's the icon > immediately to the left of the keyboard icon) > 3) Click save, and then close. > 4) Keyboard shortcuts will spawn two applications. > > I use keyboard shortcuts to spawn xterms, browsers, and filemanagers. > All of them spawn twice after performing the above. To fix it, > or -> Exit -> Restart. > > If I repeat steps 1-3, three windows will spawn. Repeat again and > four windows will spawn etc. (I stopped after getting five to > spawn at once). > > > Two other bugs that happened that I have not been able to > reproduce since running 0.95.2 are as follows. > > I had WindowMaker start to use 100% CPU and become unresponsive. > I had to switch to a console and pkill wmaker. IIRC, > ++ did not function to quit X while this was > happening, hence the use of pkill on the console. > > I also had a weird bug where videos in mplayer that normally > played fine, only played at about 5 FPS. Restarting WindowMaker > had no effect, but quitting WindowMaker and running startx again > did fix it. > > > I will continue to run with 0.95.2 to see if I can reproduce the > above two bugs or find any new ones. So... What should I do with this update? ciao, david
Re: UPDATE: WindowMaker-0.95.2
On 2012-03-16 12:08:30, David Coppa wrote: > On Mon, Mar 12, 2012 at 1:14 AM, Bryan Linton wrote: > >> Some good news and some bad news to report. I've been able to >> reliably reproduce the double-spawning of xterms I've been seeing. >> The bad news is that it still happens even with a fresh >> configuration directory. >> > > So... What should I do with this update? > Hmm, my opinion is to hold off and wait for a newer version that will hopefully be more stable than this one. I'm probably going to switch back to 0.92 because of all the new bugs in 0.95.2. The only bug in 0.92 I encountered was the "periodic focus bug". If it were patched away, there would not be any bugs in the older release that affected me. Patch attached. (I think I did this right, someone should probably double-check.) -- Bryan Index: Makefile === RCS file: /cvs/ports/x11/windowmaker/Makefile,v retrieving revision 1.81 diff -u -p -r1.81 Makefile --- Makefile16 Sep 2011 12:29:17 - 1.81 +++ Makefile17 Mar 2012 01:31:47 - @@ -6,7 +6,7 @@ COMMENT-lang= language subpackage for W V= 0.92.0 DISTNAME= WindowMaker-${V} PKGNAME-main= ${DISTNAME:L} -REVISION-main= 10 +REVISION-main= 11 FULLPKGNAME-lang= windowmaker-lang-${V} REVISION-lang= 2 SHARED_LIBS= wraster 5.0 Index: patches/patch-src_actions_c === RCS file: patches/patch-src_actions_c diff -N patches/patch-src_actions_c --- /dev/null 1 Jan 1970 00:00:00 - +++ patches/patch-src_actions_c 17 Mar 2012 01:31:47 - @@ -0,0 +1,39 @@ +$OpenBSD$ +# +# This is a backport from WindowMaker cvs which fixes the +# "periodic focus bug" described at: +# http://repo.or.cz/w/wmaker-crm.git/commitdiff/c91bb1ba1360006c568db37438779e525868cf17 +# + +--- src/actions.c.orig Fri Mar 16 17:10:27 2012 src/actions.c Fri Mar 16 17:11:57 2012 +@@ -78,6 +78,15 @@ static struct { + #define SHADE_STEPS shadePars[(int)wPreferences.shade_speed].steps + #define SHADE_DELAY shadePars[(int)wPreferences.shade_speed].delay + ++static int ++compareTimes(Time t1, Time t2) ++{ ++ Time diff; ++ if (t1 == t2) ++ return 0; ++ diff = t1 - t2; ++ return (diff < 6) ? 1 : -1; ++} + + /* + *-- +@@ -99,11 +108,11 @@ wSetFocusTo(WScreen *scr, WWindow *wwin) + + WWindow *old_focused; + WWindow *focused=scr->focused_window; +-int timestamp=LastTimestamp; ++Time timestamp=LastTimestamp; + WApplication *oapp=NULL, *napp=NULL; + int wasfocused; + +-if (scr->flags.ignore_focus_events || LastFocusChange > timestamp) ++if (scr->flags.ignore_focus_events || compareTimes(LastFocusChange, timestamp) > 0) + return; + + if (!old_scr)
Re: UPDATE: WindowMaker-0.95.2
On 03/16/12 21:40, Bryan Linton wrote: > On 2012-03-16 12:08:30, David Coppa wrote: >> So... What should I do with this update? >> > > Hmm, my opinion is to hold off and wait for a newer version that > will hopefully be more stable than this one. I'm probably going > to switch back to 0.92 because of all the new bugs in 0.95.2. > > The only bug in 0.92 I encountered was the "periodic focus bug". > If it were patched away, there would not be any bugs in the older > release that affected me. Ah, that's when you hit that point where it's impossible to set the focus on anything and you're just kinda stuck and have to relaunch WM? Great. As a longtime WM user I agree with Bryan, 0.95.2 didn't bring anything with it except new bugs. I'm still running it on one machine and it doesn't crash or anything, but still has the problems mentioned. Oh well, better luck next time. Stu
Re: UPDATE: WindowMaker-0.95.2
On Sat, Mar 17, 2012 at 2:40 AM, Bryan Linton wrote: > The only bug in 0.92 I encountered was the "periodic focus bug". > If it were patched away, there would not be any bugs in the older > release that affected me. > > Patch attached. (I think I did this right, someone should > probably double-check.) I've just committed this. Thanks, David
Re: UPDATE: windowmaker-0.95.2
On 2012/04/29 11:07, Tobias Stoeckmann wrote: > this diff updates WindowMaker 0.92.0 to 0.95.2. Most of the diffs have > been kindly integrated into 0.95.2 we previously applied to 0.92.0. > I have contacted the devs to integrate the new diffs -- as far as possible. > > Tested on my i386 machine, broad testing greatly appreciated! Especially > regarding the fact that this is my first update to port. ;) A similar diff came up before, but there were some problems, see http://marc.info/?t=13302723911&r=1&w=3
Re: UPDATE: windowmaker-0.95.2
On Sun, Apr 29, 2012 at 11:07:33AM +0200, Tobias Stoeckmann wrote: > Hi, > > this diff updates WindowMaker 0.92.0 to 0.95.2. Most of the diffs have > been kindly integrated into 0.95.2 we previously applied to 0.92.0. > I have contacted the devs to integrate the new diffs -- as far as possible. > > Tested on my i386 machine, broad testing greatly appreciated! Especially > regarding the fact that this is my first update to port. ;) > FWIW, you should check the thread that started at http://marc.info/?l=openbsd-ports&m=133027221413367&w=2 and especially the conclusion http://marc.info/?l=openbsd-ports&m=133194866716250&w=2 -- Matthieu Herrb