Re: UPDATE: databases/py-redis-3.0.1
ping?
Edward Lopez-Acosta
On 12/6/18 5:39 PM, Edward Lopez-Acosta wrote:
Resubmitting the diff so its easier for commit.
I replaced the py-py test depend with py-mock like it should be. py-py
is pulled is as a dependency of mock.
Edward Lopez-Acosta
On 12/6/18 4:26 AM, Stuart Henderson wrote:
On 2018/12/05 18:47, Edward Lopez-Acosta wrote:
Backwards incompatible changes in this, but checking sqlports I found
nothing that depends on this. I installed this package and ran a
series of
tests on it using some of my old scripts and didn't hit issues.
$ sqlite3 /usr/local/share/sqlports "select * from depends where
dependspath
like 'databases/py-redis' or dependspath like
'databases/py-redis,python3'"
| wc -l
btw you can do "where dependspath like 'databases/py-redis%'" to cover
both flavours.
Tests also require devel/py-mock:
===> Regression tests for py-redis-3.0.1
running test
Searching for mock
Reading https://pypi.org/simple/mock/
Download error on https://pypi.org/simple/mock/: [Errno 65] No route
to host -- Some packages may not be found!
Couldn't find index page for 'mock' (maybe misspelled?)
Scanning index of all packages (this may take a while)
Reading https://pypi.org/simple/
Download error on https://pypi.org/simple/: [Errno 65] No route to
host -- Some packages may not be found!
No local packages or working download links found for mock
error: Could not find suitable distribution for Requirement.parse('mock')
Otherwise looks good to me.
Re: UPDATE: databases/py-redis-3.0.1
Resubmitting the diff so its easier for commit.
I replaced the py-py test depend with py-mock like it should be. py-py
is pulled is as a dependency of mock.
Edward Lopez-Acosta
On 12/6/18 4:26 AM, Stuart Henderson wrote:
On 2018/12/05 18:47, Edward Lopez-Acosta wrote:
Backwards incompatible changes in this, but checking sqlports I found
nothing that depends on this. I installed this package and ran a series of
tests on it using some of my old scripts and didn't hit issues.
$ sqlite3 /usr/local/share/sqlports "select * from depends where dependspath
like 'databases/py-redis' or dependspath like 'databases/py-redis,python3'"
| wc -l
btw you can do "where dependspath like 'databases/py-redis%'" to cover
both flavours.
Tests also require devel/py-mock:
===> Regression tests for py-redis-3.0.1
running test
Searching for mock
Reading https://pypi.org/simple/mock/
Download error on https://pypi.org/simple/mock/: [Errno 65] No route to host --
Some packages may not be found!
Couldn't find index page for 'mock' (maybe misspelled?)
Scanning index of all packages (this may take a while)
Reading https://pypi.org/simple/
Download error on https://pypi.org/simple/: [Errno 65] No route to host -- Some
packages may not be found!
No local packages or working download links found for mock
error: Could not find suitable distribution for Requirement.parse('mock')
Otherwise looks good to me.
diff --git Makefile Makefile
index 0d6e4a7e5b6..d335eed8153 100644
--- Makefile
+++ Makefile
@@ -2,12 +2,11 @@
COMMENT = Python interface to Redis
-MODPY_EGG_VERSION = 2.10.6
+MODPY_EGG_VERSION = 3.0.1
GH_ACCOUNT = andymccurdy
GH_PROJECT = redis-py
GH_TAGNAME = ${MODPY_EGG_VERSION}
-REVISION = 0
DISTNAME = ${GH_PROJECT}-${MODPY_EGG_VERSION}
PKGNAME = py-redis-${MODPY_EGG_VERSION}
@@ -31,7 +30,7 @@ MODPY_SETUPTOOLS = Yes
TEST_IS_INTERACTIVE = Yes
TEST_DEPENDS = databases/redis \
- devel/py-py${MODPY_FLAVOR} \
+ devel/py-mock${MODPY_FLAVOR} \
devel/py-test${MODPY_FLAVOR}>=2.5.0
.include
diff --git distinfo distinfo
index f1c40bcf07d..e1591ccb4e3 100644
--- distinfo
+++ distinfo
@@ -1,2 +1,2 @@
-SHA256 (redis-py-2.10.6.tar.gz) = 4o4kU51lkKi4hJjy0w9/4+K+EXHXqR/h+mxbaYJRkBU=
-SIZE (redis-py-2.10.6.tar.gz) = 94869
+SHA256 (redis-py-3.0.1.tar.gz) = 0hAZRs9YKu5y1zvu1egVzNpMitT8Kh1ZORMV+ucFnqM=
+SIZE (redis-py-3.0.1.tar.gz) = 106780
diff --git pkg/PLIST pkg/PLIST
index c73d0d89da2..2252caccca2 100644
--- pkg/PLIST
+++ pkg/PLIST
@@ -4,6 +4,7 @@ lib/python${MODPY_VERSION}/site-packages/redis-${MODPY_EGG_VERSION}-py${MODPY_VE
lib/python${MODPY_VERSION}/site-packages/redis-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/PKG-INFO
lib/python${MODPY_VERSION}/site-packages/redis-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/SOURCES.txt
lib/python${MODPY_VERSION}/site-packages/redis-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/dependency_links.txt
+lib/python${MODPY_VERSION}/site-packages/redis-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/requires.txt
lib/python${MODPY_VERSION}/site-packages/redis-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/top_level.txt
lib/python${MODPY_VERSION}/site-packages/redis/__init__.py
${MODPY_COMMENT}lib/python${MODPY_VERSION}/site-packages/redis/${MODPY_PYCACHE}/
Re: UPDATE: databases/py-redis-3.0.1
Hi Stuart,
It does look like the py-py requirement changed to mock as you noted. I didn't
notice the warning initially, my mistake.
Would you like me to submit a new diff this evening with that change? I see the
same number of tests pass and be skipped.
Thanks for the sqlite tip as well. I am going to update the application I wrote
with that in mind, and add clarity to my output.
On December 6, 2018 10:26:07 AM UTC, Stuart Henderson
wrote:
>On 2018/12/05 18:47, Edward Lopez-Acosta wrote:
>> Backwards incompatible changes in this, but checking sqlports I found
>> nothing that depends on this. I installed this package and ran a
>series of
>> tests on it using some of my old scripts and didn't hit issues.
>>
>> $ sqlite3 /usr/local/share/sqlports "select * from depends where
>dependspath
>> like 'databases/py-redis' or dependspath like
>'databases/py-redis,python3'"
>> | wc -l
>
>btw you can do "where dependspath like 'databases/py-redis%'" to cover
>both flavours.
>
>Tests also require devel/py-mock:
>
>===> Regression tests for py-redis-3.0.1
>running test
>Searching for mock
>Reading https://pypi.org/simple/mock/
>Download error on https://pypi.org/simple/mock/: [Errno 65] No route to
>host -- Some packages may not be found!
>Couldn't find index page for 'mock' (maybe misspelled?)
>Scanning index of all packages (this may take a while)
>Reading https://pypi.org/simple/
>Download error on https://pypi.org/simple/: [Errno 65] No route to host
>-- Some packages may not be found!
>No local packages or working download links found for mock
>error: Could not find suitable distribution for
>Requirement.parse('mock')
>
>Otherwise looks good to me.
Re: UPDATE: databases/py-redis-3.0.1
On 2018/12/05 18:47, Edward Lopez-Acosta wrote:
> Backwards incompatible changes in this, but checking sqlports I found
> nothing that depends on this. I installed this package and ran a series of
> tests on it using some of my old scripts and didn't hit issues.
>
> $ sqlite3 /usr/local/share/sqlports "select * from depends where dependspath
> like 'databases/py-redis' or dependspath like 'databases/py-redis,python3'"
> | wc -l
btw you can do "where dependspath like 'databases/py-redis%'" to cover
both flavours.
Tests also require devel/py-mock:
===> Regression tests for py-redis-3.0.1
running test
Searching for mock
Reading https://pypi.org/simple/mock/
Download error on https://pypi.org/simple/mock/: [Errno 65] No route to host --
Some packages may not be found!
Couldn't find index page for 'mock' (maybe misspelled?)
Scanning index of all packages (this may take a while)
Reading https://pypi.org/simple/
Download error on https://pypi.org/simple/: [Errno 65] No route to host -- Some
packages may not be found!
No local packages or working download links found for mock
error: Could not find suitable distribution for Requirement.parse('mock')
Otherwise looks good to me.
UPDATE: databases/py-redis-3.0.1
Backwards incompatible changes in this, but checking sqlports I found
nothing that depends on this. I installed this package and ran a series
of tests on it using some of my old scripts and didn't hit issues.
$ sqlite3 /usr/local/share/sqlports "select * from depends where
dependspath like 'databases/py-redis' or dependspath like
'databases/py-redis,python3'" | wc -l
0
Version bump, no new patches needed, MAINTAINER CC, builds and installs
fine on amd64.
diff generated with `git diff --relative .` in the port directory for
easy application with patch.
Test results for py3 below but are the same for py2. This is using Redis
4 which is currently in the tree.
= test session starts
==
platform openbsd6 -- Python 3.6.7, pytest-3.5.0, py-1.5.3, pluggy-0.6.0
rootdir: /usr/ports/pobj/py-redis-3.0.1-python3/redis-py-3.0.1, inifile:
collected 384 items
tests/test_commands.py ...sss...
[ 12%]
[ 31%]
....
[ 50%]
..s.sss...
[ 66%]
tests/test_connection_pool.py ..
[ 77%]
.
[ 77%]
tests/test_encoding.py ..
[ 79%]
tests/test_lock.py .
[ 83%]
tests/test_pipeline.py .
[ 88%]
tests/test_pubsub.py ...
[ 95%]
tests/test_scripting.py ...
[ 96%]
tests/test_sentinel.py
[100%]
357 passed, 27 skipped in 9.77 seconds
Thoughts?
--
Edward Lopez-Acosta
diff --git Makefile Makefile
index 0d6e4a7e5b6..315b9964ca6 100644
--- Makefile
+++ Makefile
@@ -2,12 +2,11 @@
COMMENT = Python interface to Redis
-MODPY_EGG_VERSION = 2.10.6
+MODPY_EGG_VERSION = 3.0.1
GH_ACCOUNT = andymccurdy
GH_PROJECT = redis-py
GH_TAGNAME = ${MODPY_EGG_VERSION}
-REVISION = 0
DISTNAME = ${GH_PROJECT}-${MODPY_EGG_VERSION}
PKGNAME = py-redis-${MODPY_EGG_VERSION}
diff --git distinfo distinfo
index f1c40bcf07d..e1591ccb4e3 100644
--- distinfo
+++ distinfo
@@ -1,2 +1,2 @@
-SHA256 (redis-py-2.10.6.tar.gz) = 4o4kU51lkKi4hJjy0w9/4+K+EXHXqR/h+mxbaYJRkBU=
-SIZE (redis-py-2.10.6.tar.gz) = 94869
+SHA256 (redis-py-3.0.1.tar.gz) = 0hAZRs9YKu5y1zvu1egVzNpMitT8Kh1ZORMV+ucFnqM=
+SIZE (redis-py-3.0.1.tar.gz) = 106780
diff --git pkg/PLIST pkg/PLIST
index c73d0d89da2..2252caccca2 100644
--- pkg/PLIST
+++ pkg/PLIST
@@ -4,6 +4,7 @@ lib/python${MODPY_VERSION}/site-packages/redis-${MODPY_EGG_VERSION}-py${MODPY_VE
lib/python${MODPY_VERSION}/site-packages/redis-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/PKG-INFO
lib/python${MODPY_VERSION}/site-packages/redis-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/SOURCES.txt
lib/python${MODPY_VERSION}/site-packages/redis-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/dependency_links.txt
+lib/python${MODPY_VERSION}/site-packages/redis-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/requires.txt
lib/python${MODPY_VERSION}/site-packages/redis-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/top_level.txt
lib/python${MODPY_VERSION}/site-packages/redis/__init__.py
${MODPY_COMMENT}lib/python${MODPY_VERSION}/site-packages/redis/${MODPY_PYCACHE}/
