Re: xkb-qwerty-fr (port installing files in /usr/X11R6/?)

2013-06-27 Thread Tristan Le Guern
On Mon, Jun 24, 2013 at 7:09 PM, Jérémie Courrèges-Anglas
j...@wxcvbn.org wrote:
 Tristan Le Guern aversi...@gmail.com writes:
 On Sat, Jun 22, 2013 at 4:22 PM, Jérémie Courrèges-Anglas
 j...@wxcvbn.org wrote:
 I think the cleanest way would be to just install the file in
 ${PREFIX}/share/X11/xkb/, and then tell users to use setxkbmap -I ...
 Just tried this but it seems I can't make it work. :)
 I tried it too and the result is weird.
 With us_fr installed under /usr/X11R6/share/X11/xkb/symbols/ everything is 
 ok:

 I forgot to ask you why you used us_fr instead of what upstream uses.
Laziness: it's shorter to type. It's probably not a good answer though.
Renaming it us_qwerty-fr, the upstream name, doesn't change anything.

 Yup.  I took a look at setxkbmap.c but stopped when I (maybe falsely)
 assumed that the problem wasn't there.
I looked it too and I don't know what's wrong.
Anyway I added this line to the PLIST and it now works:

@sample /usr/X11R6/share/X11/xkb/symbols/us_qwerty-fr

 - it's better not to try to be smart about MASTER_SITES
 What do you mean?

 MASTER_SITES =  http://marin.jb.free.fr/qwerty-fr/sources/
 is enough, it's more readable and easier for people to take a look at
 new versions when ''make peek-ftp'' doesn't work because MASTER_SITES
 only lists http:// uris.

 http://marc.info/?l=openbsd-portsm=136623136912606w=2
I have changed it. This recommendation should probably be listed in
the porter's handbook.

Is this port better now?
--
Tristan Le Guern
Epitech 2013


xkb-qwerty-fr.tar.gz
Description: GNU Zip compressed data


Re: xkb-qwerty-fr (port installing files in /usr/X11R6/?)

2013-06-24 Thread Tristan Le Guern
On Sat, Jun 22, 2013 at 4:22 PM, Jérémie Courrèges-Anglas
j...@wxcvbn.org wrote:
 Tristan Le Guern aversi...@gmail.com writes:

 Hi,

 Hi Tristan,

 Attached is an unfinished port of xkb-qwerty-fr, a qwerty layout with
 French extensions but no dead-keys. It's on openbsd-wip for those who
 cares.

 The port install a file under /usr/X11R6/share/X11/xkb/symbols/, but
 systrace complains and forbids it. How can I do that? Is there a
 standard place under /usr/local for additional keymap files?

 I think the cleanest way would be to just install the file in
 ${PREFIX}/share/X11/xkb/, and then tell users to use setxkbmap -I ...
 Just tried this but it seems I can't make it work. :)
I tried it too and the result is weird.
With us_fr installed under /usr/X11R6/share/X11/xkb/symbols/ everything is ok:

[leguern@le5410]setxkbmap -v 6 us_fr
Warning! Multiple definitions of keyboard layout
 Using command line, ignoring X server
Trying to build keymap using the following components:
keycodes:   xfree86+aliases(qwerty)
types:  complete
compat: complete
symbols:pc+us_fr+inet(pc105)+terminate(ctrl_alt_bksp)
geometry:   pc(pc105)
[leguern@le5410:xkb][14:31]echo $?
0

If it is under /usr/local/X11R6/share/X11/xkb/symbols/ or
/usr/local/share/X11/xkb/symbols/ the output is the same but there
is an error:

[leguern@le5410]setxkbmap -v 6 -I /usr/local/share/X11/xkb/symbols
us_fr
Warning! Multiple definitions of keyboard layout
 Using command line, ignoring X server
Trying to build keymap using the following components:
keycodes:   xfree86+aliases(qwerty)
types:  complete
compat: complete
symbols:pc+us_fr+inet(pc105)+terminate(ctrl_alt_bksp)
geometry:   pc(pc105)
Error loading new keyboard description
[leguern@le5410]echo $?
251

 Possible other ways to do it:
 2. include the mapping into xenocara.  Perhaps you could ask the author
to change the licence?
 3. install in ${PREFIX}/share/examples/xkb-qwerty-fr and then @sample it
in /usr/X11R6. Dunno if that's ok for other porters and X11 people.
 4. patch setxkbmap so that it also looks at /usr/local/share/X11/xkb/.
But a custom PREFIX at port build time to would break this, and
that'd be one more patch Matthieu has to deal with.
I haven't tried these yet, but I will.

 Also I put it in the misc section, but it should probably use x11,
 what do you think?

 I think x11 would be nicer too.
Done.

 Some hints for your port:
 - I'd tweak COMMENT, something like qwerty keyboard layout for french
   users
Done.

 - your PKGNAME doesn't include a version number, it should. You could
   set V = 0.5 and then use it in PKGNAME and INTERNAL
Done. It fixes one of my problem!

 - PERMIT_PACKAGE_FTP and PERMIT_DISTFILES_FTP are not needed anymore.
Done.

   Also I think it would be better to install the copyright notice.
   (I've seen some ports removing them in the past and felt a bit
   puzzled...)
Done, I now also install the keymap.txt file.

 - it's better not to try to be smart about MASTER_SITES
What do you mean?

 - most if not all porters prefer variable assignements to be properly
   aligned with tabs
Done.

Thanks for your reply :)
--
Tristan Le Guern
Epitech 2013



Re: xkb-qwerty-fr (port installing files in /usr/X11R6/?)

2013-06-24 Thread Jérémie Courrèges-Anglas
Tristan Le Guern aversi...@gmail.com writes:

 On Sat, Jun 22, 2013 at 4:22 PM, Jérémie Courrèges-Anglas
 j...@wxcvbn.org wrote:
 Tristan Le Guern aversi...@gmail.com writes:

 Hi,

 Hi Tristan,

 Attached is an unfinished port of xkb-qwerty-fr, a qwerty layout with
 French extensions but no dead-keys. It's on openbsd-wip for those who
 cares.

 The port install a file under /usr/X11R6/share/X11/xkb/symbols/, but
 systrace complains and forbids it. How can I do that? Is there a
 standard place under /usr/local for additional keymap files?

 I think the cleanest way would be to just install the file in
 ${PREFIX}/share/X11/xkb/, and then tell users to use setxkbmap -I ...
 Just tried this but it seems I can't make it work. :)
 I tried it too and the result is weird.
 With us_fr installed under /usr/X11R6/share/X11/xkb/symbols/ everything is 
 ok:

I forgot to ask you why you used us_fr instead of what upstream uses.

 [leguern@le5410]setxkbmap -v 6 us_fr
 Warning! Multiple definitions of keyboard layout
  Using command line, ignoring X server
 Trying to build keymap using the following components:
 keycodes:   xfree86+aliases(qwerty)
 types:  complete
 compat: complete
 symbols:pc+us_fr+inet(pc105)+terminate(ctrl_alt_bksp)
 geometry:   pc(pc105)
 [leguern@le5410:xkb][14:31]echo $?
 0

 If it is under /usr/local/X11R6/share/X11/xkb/symbols/ or
 /usr/local/share/X11/xkb/symbols/ the output is the same but there
 is an error:

 [leguern@le5410]setxkbmap -v 6 -I /usr/local/share/X11/xkb/symbols
 us_fr
 Warning! Multiple definitions of keyboard layout
  Using command line, ignoring X server
 Trying to build keymap using the following components:
 keycodes:   xfree86+aliases(qwerty)
 types:  complete
 compat: complete
 symbols:pc+us_fr+inet(pc105)+terminate(ctrl_alt_bksp)
 geometry:   pc(pc105)
 Error loading new keyboard description
 [leguern@le5410]echo $?
 251

Yup.  I took a look at setxkbmap.c but stopped when I (maybe falsely)
assumed that the problem wasn't there.

 Possible other ways to do it:
 2. include the mapping into xenocara.  Perhaps you could ask the author
to change the licence?
 3. install in ${PREFIX}/share/examples/xkb-qwerty-fr and then @sample it
in /usr/X11R6. Dunno if that's ok for other porters and X11 people.
 4. patch setxkbmap so that it also looks at /usr/local/share/X11/xkb/.
But a custom PREFIX at port build time to would break this, and
that'd be one more patch Matthieu has to deal with.
 I haven't tried these yet, but I will.

 Also I put it in the misc section, but it should probably use x11,
 what do you think?

 I think x11 would be nicer too.
 Done.

 Some hints for your port:
 - I'd tweak COMMENT, something like qwerty keyboard layout for french
   users
 Done.

 - your PKGNAME doesn't include a version number, it should. You could
   set V = 0.5 and then use it in PKGNAME and INTERNAL
 Done. It fixes one of my problem!

 - PERMIT_PACKAGE_FTP and PERMIT_DISTFILES_FTP are not needed anymore.
 Done.

   Also I think it would be better to install the copyright notice.
   (I've seen some ports removing them in the past and felt a bit
   puzzled...)
 Done, I now also install the keymap.txt file.

 - it's better not to try to be smart about MASTER_SITES
 What do you mean?

MASTER_SITES =  http://marin.jb.free.fr/qwerty-fr/sources/
is enough, it's more readable and easier for people to take a look at
new versions when ''make peek-ftp'' doesn't work because MASTER_SITES
only lists http:// uris.

http://marc.info/?l=openbsd-portsm=136623136912606w=2

 - most if not all porters prefer variable assignements to be properly
   aligned with tabs
 Done.

 Thanks for your reply :)
 --
 Tristan Le Guern
 Epitech 2013


-- 
Jérémie Courrèges-Anglas
PGP Key fingerprint: 61DB D9A0 00A4 67CF 2A90  8961 6191 8FBF 06A1 1494



Re: xkb-qwerty-fr (port installing files in /usr/X11R6/?)

2013-06-22 Thread Jérémie Courrèges-Anglas
Tristan Le Guern aversi...@gmail.com writes:

 Hi,

Hi Tristan,

 Attached is an unfinished port of xkb-qwerty-fr, a qwerty layout with
 French extensions but no dead-keys. It's on openbsd-wip for those who
 cares.

 The port install a file under /usr/X11R6/share/X11/xkb/symbols/, but
 systrace complains and forbids it. How can I do that? Is there a
 standard place under /usr/local for additional keymap files?

I think the cleanest way would be to just install the file in
${PREFIX}/share/X11/xkb/, and then tell users to use setxkbmap -I ...
Just tried this but it seems I can't make it work. :)

Possible other ways to do it:
2. include the mapping into xenocara.  Perhaps you could ask the author
   to change the licence?
3. install in ${PREFIX}/share/examples/xkb-qwerty-fr and then @sample it
   in /usr/X11R6. Dunno if that's ok for other porters and X11 people.
4. patch setxkbmap so that it also looks at /usr/local/share/X11/xkb/.
   But a custom PREFIX at port build time to would break this, and
   that'd be one more patch Matthieu has to deal with.

 Also I put it in the misc section, but it should probably use x11,
 what do you think?

I think x11 would be nicer too.

Some hints for your port:
- I'd tweak COMMENT, something like qwerty keyboard layout for french
  users
- your PKGNAME doesn't include a version number, it should. You could
  set V = 0.5 and then use it in PKGNAME and INTERNAL
- PERMIT_PACKAGE_FTP and PERMIT_DISTFILES_FTP are not needed anymore.
  Also I think it would be better to install the copyright notice.
  (I've seen some ports removing them in the past and felt a bit
  puzzled...)
- it's better not to try to be smart about MASTER_SITES
- most if not all porters prefer variable assignements to be properly
  aligned with tabs

-- 
Jérémie Courrèges-Anglas
PGP Key fingerprint: 61DB D9A0 00A4 67CF 2A90  8961 6191 8FBF 06A1 1494