Re: [prometheus-developers] Call for Consensus: node_exporter 1.0.0 release

2020-04-23 Thread Frederic Branczyk 
I think it’s your call to release 1.0, so if you feel it’s right then go
ahead :)

I do think we should make sure we do our best not to have inconsistencies
or possible breaking changes, so Julien’s PR about the config consistency
should probably be included.

On Fri 24. Apr 2020 at 01:20, Julien Pivotto  wrote:

> On 24 Apr 01:14, Bjoern Rabenstein wrote:
> > On 23.04.20 13:40, Richard Hartmann wrote:
> > >
> > > Should the maintainers (Ben & Fish) be allowed to release without
> > > waiting for the audit to finish?
> >
> > If that's their wish, yes, sure.
> >
> > Under the described circumstances, I don't see a reason to block them.
>
>
> I would however draw the attention to the fact that the current config is
> far from what Prometheus offers (regarding config key names).
>
> I have filled in https://github.com/prometheus/node_exporter/pull/1685
> to make it look similar to what we have in the prometheus server.
>
> >
> > --
> > Björn Rabenstein
> > [PGP-ID] 0x851C3DA17D748D03
> > [email] bjo...@rabenste.in
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "Prometheus Developers" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to prometheus-developers+unsubscr...@googlegroups.com.
> > To view this discussion on the web visit
> https://groups.google.com/d/msgid/prometheus-developers/20200423231459.GJ2315%40jahnn
> .
>
> --
>  (o-Julien Pivotto
>  //\Open-Source Consultant
>  V_/_   Inuits - https://www.inuits.eu
>
> --
> You received this message because you are subscribed to the Google Groups
> "Prometheus Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to prometheus-developers+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/prometheus-developers/20200423232018.GA1315860%40oxygen
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to prometheus-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/prometheus-developers/CAOs1Umw2OcfqCfmVbLtZCtEPn-m9aJ5Mifae8%2ByMmQM7s29%2BmA%40mail.gmail.com.

Re: [prometheus-developers] Call for Consensus: node_exporter 1.0.0 release

2020-04-23 Thread Julien Pivotto 
On 24 Apr 01:14, Bjoern Rabenstein wrote:
> On 23.04.20 13:40, Richard Hartmann wrote:
> > 
> > Should the maintainers (Ben & Fish) be allowed to release without
> > waiting for the audit to finish?
> 
> If that's their wish, yes, sure.
> 
> Under the described circumstances, I don't see a reason to block them.


I would however draw the attention to the fact that the current config is
far from what Prometheus offers (regarding config key names).

I have filled in https://github.com/prometheus/node_exporter/pull/1685
to make it look similar to what we have in the prometheus server.

> 
> -- 
> Björn Rabenstein
> [PGP-ID] 0x851C3DA17D748D03
> [email] bjo...@rabenste.in
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Prometheus Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to prometheus-developers+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/prometheus-developers/20200423231459.GJ2315%40jahnn.

-- 
 (o-Julien Pivotto
 //\Open-Source Consultant
 V_/_   Inuits - https://www.inuits.eu

-- 
You received this message because you are subscribed to the Google Groups 
"Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to prometheus-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/prometheus-developers/20200423232018.GA1315860%40oxygen.


signature.asc
Description: PGP signature

Re: [prometheus-developers] Call for Consensus: node_exporter 1.0.0 release

2020-04-23 Thread Bjoern Rabenstein 
On 23.04.20 13:40, Richard Hartmann wrote:
> 
> Should the maintainers (Ben & Fish) be allowed to release without
> waiting for the audit to finish?

If that's their wish, yes, sure.

Under the described circumstances, I don't see a reason to block them.

-- 
Björn Rabenstein
[PGP-ID] 0x851C3DA17D748D03
[email] bjo...@rabenste.in

-- 
You received this message because you are subscribed to the Google Groups 
"Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to prometheus-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/prometheus-developers/20200423231459.GJ2315%40jahnn.

Re: [prometheus-developers] Call for Consensus: node_exporter 1.0.0 release

2020-04-23 Thread 'GANESH VERNEKAR' via Prometheus Developers 
Yes to release now

On Thu, Apr 23, 2020, 5:11 PM Richard Hartmann 
wrote:

> Dear all,
>
> This is a call for consensus within Prometheus-team on releasing
> node_exporter 1.0.0 as-is.
>
> node_exporter 1.0.0-rc.0 has been cut on 2020-02-20[1]. It features
> experimental TLS support[2]. We are planning to use this TLS support
> as a template for all other exporters within and outside of Prometheus
> proper. To make sure we didn’t build a footgun nor that we’re holding
> it wrong, CNCF is sponsoring an external security review by Cure53. We
> have not been giving a clear timeline but work should start in week 22
> (May 25th) at the latest with no time to completion stated.
>
> There are two positions:
> * Wait for the security review to finish before cutting 1.0.0
> * Release ASAP, given that this feature is clearly marked as
> experimental and it will not see wider testing until we cut 1.0.0
>
> I am asking Prometheus-team to establish rough consensus with a hum.
>
> Should the maintainers (Ben & Fish) be allowed to release without
> waiting for the audit to finish?
>
>
> Best,
> Richard
>
> [1] https://github.com/prometheus/node_exporter/releases/tag/v1.0.0-rc.0
> [2] https://github.com/prometheus/node_exporter/pull/1277
>
> --
> You received this message because you are subscribed to the Google Groups
> "Prometheus Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to prometheus-developers+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/prometheus-developers/CAD77%2BgRRHN%2BXfAxXeVitomS9Gz1Nx78ZGw1p%3D6xhtfQmqPJcXg%40mail.gmail.com
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to prometheus-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/prometheus-developers/CAKYffmeT7ceypJbe9ObK4mrC4p7VaSi8GdZ_uASX1MTKcDmZ%3Dg%40mail.gmail.com.

Re: [prometheus-developers] Call for Consensus: node_exporter 1.0.0 release

2020-04-23 Thread Bartłomiej Płotka 
Yes to release now.

On Thu, 23 Apr 2020 at 17:12, Chris Marchbanks 
wrote:

> Yes to releasing now.
>
> On Thu, Apr 23, 2020 at 13:40, Richard Hartmann <
> richih.mailingl...@gmail.com> wrote:
>
> Dear all, This is a call for consensus within Prometheus-team on releasing
> node_exporter 1.0.0 as-is. node_exporter 1.0.0-rc.0 has been cut on
> 2020-02-20[1]. It features experimental TLS support[2]. We are planning to
> use this TLS support as a template for all other exporters within and
> outside of Prometheus proper. To make sure we didn’t build a footgun nor
> that we’re holding it wrong, CNCF is sponsoring an external security review
> by Cure53. We have not been giving a clear timeline but work should start
> in week 22 (May 25th) at the latest with no time to completion stated.
> There are two positions: * Wait for the security review to finish before
> cutting 1.0.0 * Release ASAP, given that this feature is clearly marked as
> experimental and it will not see wider testing until we cut 1.0.0 I am
> asking Prometheus-team to establish rough consensus with a hum. Should the
> maintainers (Ben & Fish) be allowed to release without waiting for the
> audit to finish? Best, Richard [1]
> https://github.com/prometheus/node_exporter/releases/tag/v1.0.0-rc.0 [2]
> https://github.com/prometheus/node_exporter/pull/1277
> --
> You received this message because you are subscribed to the Google Groups
> "Prometheus Developers" group. To unsubscribe from this group and stop
> receiving emails from it, send an email to
> prometheus-developers+unsubscr...@googlegroups.com. To view this
> discussion on the web visit
> https://groups.google.com/d/msgid/prometheus-developers/CAD77%2BgRRHN%2BXfAxXeVitomS9Gz1Nx78ZGw1p%3D6xhtfQmqPJcXg%40mail.gmail.com.
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "Prometheus Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to prometheus-developers+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/prometheus-developers/00199Q.0BW99PEPRXG62%40gmail.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to prometheus-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/prometheus-developers/CAMssQwZt8SQrP77D05huOU7Lo2OpAyY4ZBEJq7JwKiFoR%2B9Qbg%40mail.gmail.com.

Re: [prometheus-developers] Call for Consensus: node_exporter 1.0.0 release

2020-04-23 Thread Chris Marchbanks 

Yes to releasing now.

On Thu, Apr 23, 2020 at 13:40, Richard Hartmann 
 wrote:

Dear all,

This is a call for consensus within Prometheus-team on releasing
node_exporter 1.0.0 as-is.

node_exporter 1.0.0-rc.0 has been cut on 2020-02-20[1]. It features
experimental TLS support[2]. We are planning to use this TLS support
as a template for all other exporters within and outside of Prometheus
proper. To make sure we didn’t build a footgun nor that we’re 
holding

it wrong, CNCF is sponsoring an external security review by Cure53. We
have not been giving a clear timeline but work should start in week 22
(May 25th) at the latest with no time to completion stated.

There are two positions:
* Wait for the security review to finish before cutting 1.0.0
* Release ASAP, given that this feature is clearly marked as
experimental and it will not see wider testing until we cut 1.0.0

I am asking Prometheus-team to establish rough consensus with a hum.

Should the maintainers (Ben & Fish) be allowed to release without
waiting for the audit to finish?


Best,
Richard

[1] 


[2] 

--
You received this message because you are subscribed to the Google 
Groups "Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, 
send an email to prometheus-developers+unsubscr...@googlegroups.com 
.
To view this discussion on the web visit 
.


--
You received this message because you are subscribed to the Google Groups 
"Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to prometheus-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/prometheus-developers/00199Q.0BW99PEPRXG62%40gmail.com.

Re: [prometheus-developers] Call for Consensus: node_exporter 1.0.0 release

2020-04-23 Thread Julien Pivotto 
On 23 Apr 13:40, Richard Hartmann wrote:
> Dear all,
> 
> This is a call for consensus within Prometheus-team on releasing
> node_exporter 1.0.0 as-is.
> 
> node_exporter 1.0.0-rc.0 has been cut on 2020-02-20[1]. It features
> experimental TLS support[2]. We are planning to use this TLS support
> as a template for all other exporters within and outside of Prometheus
> proper. To make sure we didn’t build a footgun nor that we’re holding
> it wrong, CNCF is sponsoring an external security review by Cure53. We
> have not been giving a clear timeline but work should start in week 22
> (May 25th) at the latest with no time to completion stated.
> 
> There are two positions:
> * Wait for the security review to finish before cutting 1.0.0
> * Release ASAP, given that this feature is clearly marked as
> experimental and it will not see wider testing until we cut 1.0.0
> 
> I am asking Prometheus-team to establish rough consensus with a hum.
> 
> Should the maintainers (Ben & Fish) be allowed to release without
> waiting for the audit to finish?

Yes

> 
> 
> Best,
> Richard
> 
> [1] https://github.com/prometheus/node_exporter/releases/tag/v1.0.0-rc.0
> [2] https://github.com/prometheus/node_exporter/pull/1277
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Prometheus Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to prometheus-developers+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/prometheus-developers/CAD77%2BgRRHN%2BXfAxXeVitomS9Gz1Nx78ZGw1p%3D6xhtfQmqPJcXg%40mail.gmail.com.

-- 
 (o-Julien Pivotto
 //\Open-Source Consultant
 V_/_   Inuits - https://www.inuits.eu

-- 
You received this message because you are subscribed to the Google Groups 
"Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to prometheus-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/prometheus-developers/20200423130633.GA419731%40oxygen.


signature.asc
Description: PGP signature

Re: [prometheus-developers] Call for Consensus: node_exporter 1.0.0 release

2020-04-23 Thread Ben Kochie 
Yes, let's release right away.

On Thu, Apr 23, 2020 at 1:41 PM Richard Hartmann <
richih.mailingl...@gmail.com> wrote:

> Dear all,
>
> This is a call for consensus within Prometheus-team on releasing
> node_exporter 1.0.0 as-is.
>
> node_exporter 1.0.0-rc.0 has been cut on 2020-02-20[1]. It features
> experimental TLS support[2]. We are planning to use this TLS support
> as a template for all other exporters within and outside of Prometheus
> proper. To make sure we didn’t build a footgun nor that we’re holding
> it wrong, CNCF is sponsoring an external security review by Cure53. We
> have not been giving a clear timeline but work should start in week 22
> (May 25th) at the latest with no time to completion stated.
>
> There are two positions:
> * Wait for the security review to finish before cutting 1.0.0
> * Release ASAP, given that this feature is clearly marked as
> experimental and it will not see wider testing until we cut 1.0.0
>
> I am asking Prometheus-team to establish rough consensus with a hum.
>
> Should the maintainers (Ben & Fish) be allowed to release without
> waiting for the audit to finish?
>
>
> Best,
> Richard
>
> [1] https://github.com/prometheus/node_exporter/releases/tag/v1.0.0-rc.0
> [2] https://github.com/prometheus/node_exporter/pull/1277
>
> --
> You received this message because you are subscribed to the Google Groups
> "Prometheus Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to prometheus-developers+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/prometheus-developers/CAD77%2BgRRHN%2BXfAxXeVitomS9Gz1Nx78ZGw1p%3D6xhtfQmqPJcXg%40mail.gmail.com
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to prometheus-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/prometheus-developers/CABbyFmoA0uyzRaLRQ0pNgEbmxiTMkL1Og8YVuJZn2DRfcuUm0g%40mail.gmail.com.