Re: [Pulp-dev] Branch protection

[Brian Bouterse]

With all +1s and it being after July 22nd, David and I enabled the
following for pulp/pulp:2-master

* reviews are required for merging
* the 'default' check must pass for merging. 'default' is the name of the
Jenkins job that runs the tests, lints, etc. It's the quality checker.

Any Pulp2 plugins are encouraged to do the same for their 2-master branches
also. If you want help doing this, let me know.

Thanks @daviddavis for organizing this.



On Wed, Jul 11, 2018 at 8:32 AM, Ina Panova  wrote:

> +1
>
>
>
> 
> Regards,
>
> Ina Panova
> Software Engineer| Pulp| Red Hat Inc.
>
> "Do not go where the path may lead,
>  go instead where there is no path and leave a trail."
>
> On Tue, Jul 10, 2018 at 11:31 PM, Jeff Ortel  wrote:
>
>> +1
>>
>>
>> On 07/10/2018 02:30 PM, David Davis wrote:
>>
>> We noticed in Pulp that the 2-master branch has branch protection but
>> only to prevent force pushes and deletion. I was wondering if we should
>> also add these checks:
>>
>> - Require an approving review
>> - Require status checks (e.g. unit tests, docs test, flake8)
>>
>> If so, I think we should also do this for all master and 2-master
>> branches for all Pulp core repos (where applicable). Does anyone have any
>> thoughts or objections?
>>
>> I’ll leave this discussion open until July 22, 2018.
>>
>> David
>>
>>
>> ___
>> Pulp-dev mailing 
>> listPulp-dev@redhat.comhttps://www.redhat.com/mailman/listinfo/pulp-dev
>>
>>
>>
>> ___
>> Pulp-dev mailing list
>> Pulp-dev@redhat.com
>> https://www.redhat.com/mailman/listinfo/pulp-dev
>>
>>
>
> ___
> Pulp-dev mailing list
> Pulp-dev@redhat.com
> https://www.redhat.com/mailman/listinfo/pulp-dev
>
>
___
Pulp-dev mailing list
Pulp-dev@redhat.com
https://www.redhat.com/mailman/listinfo/pulp-dev

Re: [Pulp-dev] Branch protection

[Ina Panova]

+1




Regards,

Ina Panova
Software Engineer| Pulp| Red Hat Inc.

"Do not go where the path may lead,
 go instead where there is no path and leave a trail."

On Tue, Jul 10, 2018 at 11:31 PM, Jeff Ortel  wrote:

> +1
>
>
> On 07/10/2018 02:30 PM, David Davis wrote:
>
> We noticed in Pulp that the 2-master branch has branch protection but only
> to prevent force pushes and deletion. I was wondering if we should also add
> these checks:
>
> - Require an approving review
> - Require status checks (e.g. unit tests, docs test, flake8)
>
> If so, I think we should also do this for all master and 2-master branches
> for all Pulp core repos (where applicable). Does anyone have any thoughts
> or objections?
>
> I’ll leave this discussion open until July 22, 2018.
>
> David
>
>
> ___
> Pulp-dev mailing 
> listPulp-dev@redhat.comhttps://www.redhat.com/mailman/listinfo/pulp-dev
>
>
>
> ___
> Pulp-dev mailing list
> Pulp-dev@redhat.com
> https://www.redhat.com/mailman/listinfo/pulp-dev
>
>
___
Pulp-dev mailing list
Pulp-dev@redhat.com
https://www.redhat.com/mailman/listinfo/pulp-dev

Re: [Pulp-dev] Branch protection

[Jeff Ortel]

+1

On 07/10/2018 02:30 PM, David Davis wrote:
We noticed in Pulp that the 2-master branch has branch protection but 
only to prevent force pushes and deletion. I was wondering if we 
should also add these checks:


- Require an approving review
- Require status checks (e.g. unit tests, docs test, flake8)

If so, I think we should also do this for all master and 2-master 
branches for all Pulp core repos (where applicable). Does anyone have 
any thoughts or objections?


I’ll leave this discussion open until July 22, 2018.

David


___
Pulp-dev mailing list
Pulp-dev@redhat.com
https://www.redhat.com/mailman/listinfo/pulp-dev


___
Pulp-dev mailing list
Pulp-dev@redhat.com
https://www.redhat.com/mailman/listinfo/pulp-dev

Re: [Pulp-dev] Branch protection

[Dana Walker]

+1

Dana Walker

Associate Software Engineer

Red Hat




On Tue, Jul 10, 2018 at 3:58 PM, Daniel Alley  wrote:

> +1
>
> On Tue, Jul 10, 2018 at 3:30 PM, David Davis 
> wrote:
>
>> We noticed in Pulp that the 2-master branch has branch protection but
>> only to prevent force pushes and deletion. I was wondering if we should
>> also add these checks:
>>
>> - Require an approving review
>> - Require status checks (e.g. unit tests, docs test, flake8)
>>
>> If so, I think we should also do this for all master and 2-master
>> branches for all Pulp core repos (where applicable). Does anyone have any
>> thoughts or objections?
>>
>> I’ll leave this discussion open until July 22, 2018.
>>
>> David
>>
>> ___
>> Pulp-dev mailing list
>> Pulp-dev@redhat.com
>> https://www.redhat.com/mailman/listinfo/pulp-dev
>>
>>
>
> ___
> Pulp-dev mailing list
> Pulp-dev@redhat.com
> https://www.redhat.com/mailman/listinfo/pulp-dev
>
>
___
Pulp-dev mailing list
Pulp-dev@redhat.com
https://www.redhat.com/mailman/listinfo/pulp-dev

Re: [Pulp-dev] Branch protection

[Daniel Alley]

+1

On Tue, Jul 10, 2018 at 3:30 PM, David Davis  wrote:

> We noticed in Pulp that the 2-master branch has branch protection but only
> to prevent force pushes and deletion. I was wondering if we should also add
> these checks:
>
> - Require an approving review
> - Require status checks (e.g. unit tests, docs test, flake8)
>
> If so, I think we should also do this for all master and 2-master branches
> for all Pulp core repos (where applicable). Does anyone have any thoughts
> or objections?
>
> I’ll leave this discussion open until July 22, 2018.
>
> David
>
> ___
> Pulp-dev mailing list
> Pulp-dev@redhat.com
> https://www.redhat.com/mailman/listinfo/pulp-dev
>
>
___
Pulp-dev mailing list
Pulp-dev@redhat.com
https://www.redhat.com/mailman/listinfo/pulp-dev

[Pulp-dev] Branch protection

[David Davis]

We noticed in Pulp that the 2-master branch has branch protection but only
to prevent force pushes and deletion. I was wondering if we should also add
these checks:

- Require an approving review
- Require status checks (e.g. unit tests, docs test, flake8)

If so, I think we should also do this for all master and 2-master branches
for all Pulp core repos (where applicable). Does anyone have any thoughts
or objections?

I’ll leave this discussion open until July 22, 2018.

David
___
Pulp-dev mailing list
Pulp-dev@redhat.com
https://www.redhat.com/mailman/listinfo/pulp-dev