Re: [Puppet Users] facter's zpool_version errors using zfsonlinux
On May 7, 2013 4:48 AM, "Marc Fournier" wrote: > > Excerpts from treydock's message of 2013-05-06 20:04:16 +0200: > > Has anyone run into an issue with zfsonlinux >= 0.6.1 failing to work with > > the Facter zpool_version fact? I get the following error "Could not > > retrieve zfs_version: undefined method `captures' for nil:NilClass" which a > > bug report [1] indicates was fixed. I'm curious if it's a real issue. I > > have a code change to contribute that has a seperate means of checking > > zpool_version using "confine :kernel => "Linux"". Should this be a new bug > > or attached to the other recent bug [1] ? > > > > Ran into with puppet-3.1.1 and facter-1.7.0 > > Could you please open a new bug, and join the output of "zpool upgrade -v" > and "zfs upgrade -v" on your system with zfsonlinux ? > Done, http://projects.puppetlabs.com/issues/20617 > > I believe the underlying problem is that the "zpool upgrade -v" in > > zfsonlinux does not output the version number anymore. Using a basic > > "dmesg | grep 'ZFS:'" with the same "captures" line seems to work. I > > uploaded my module [2] with the proposed facter fact addition if someone > > would like to confirm this. I have only confirmed in vagrant tests, > > haven't pushed to my Puppet master yet, but I saw the symptoms on my live > > systems. > > Basing facts on "dmesg | grep" seems quite fragile to me, as the messages > will eventually get rotated away of the output of dmesg. > > Do you know if there are any other ways to get the zpool version, when > using zfsonlinux ? I couldn't find anything in /proc that had the zpool version, but did find that the same parsing used to get the zfs_version fact works for zpool_version. However it may be a misleading fact because zfsonlinux hardcodes zpool version to be 5000. I can do a pull request for the changes to zpool_version.rb, but am unsure if it's best to do a 'confine :kernel => "Linux"' to do the zpool upgrade -v scan, or to modify the existing fact to use the same parsing method as zfs_version.rb. Thanks - Trey -- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-users+unsubscr...@googlegroups.com. To post to this group, send email to puppet-users@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-users?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: [Puppet Users] facter's zpool_version errors using zfsonlinux
Excerpts from treydock's message of 2013-05-06 20:04:16 +0200: > Has anyone run into an issue with zfsonlinux >= 0.6.1 failing to work with > the Facter zpool_version fact? I get the following error "Could not > retrieve zfs_version: undefined method `captures' for nil:NilClass" which a > bug report [1] indicates was fixed. I'm curious if it's a real issue. I > have a code change to contribute that has a seperate means of checking > zpool_version using "confine :kernel => "Linux"". Should this be a new bug > or attached to the other recent bug [1] ? > > Ran into with puppet-3.1.1 and facter-1.7.0 Could you please open a new bug, and join the output of "zpool upgrade -v" and "zfs upgrade -v" on your system with zfsonlinux ? > I believe the underlying problem is that the "zpool upgrade -v" in > zfsonlinux does not output the version number anymore. Using a basic > "dmesg | grep 'ZFS:'" with the same "captures" line seems to work. I > uploaded my module [2] with the proposed facter fact addition if someone > would like to confirm this. I have only confirmed in vagrant tests, > haven't pushed to my Puppet master yet, but I saw the symptoms on my live > systems. Basing facts on "dmesg | grep" seems quite fragile to me, as the messages will eventually get rotated away of the output of dmesg. Do you know if there are any other ways to get the zpool version, when using zfsonlinux ? Thanks ! Marc -- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-users+unsubscr...@googlegroups.com. To post to this group, send email to puppet-users@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-users?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
[Puppet Users] facter's zpool_version errors using zfsonlinux
Has anyone run into an issue with zfsonlinux >= 0.6.1 failing to work with the Facter zpool_version fact? I get the following error "Could not retrieve zfs_version: undefined method `captures' for nil:NilClass" which a bug report [1] indicates was fixed. I'm curious if it's a real issue. I have a code change to contribute that has a seperate means of checking zpool_version using "confine :kernel => "Linux"". Should this be a new bug or attached to the other recent bug [1] ? Ran into with puppet-3.1.1 and facter-1.7.0 I believe the underlying problem is that the "zpool upgrade -v" in zfsonlinux does not output the version number anymore. Using a basic "dmesg | grep 'ZFS:'" with the same "captures" line seems to work. I uploaded my module [2] with the proposed facter fact addition if someone would like to confirm this. I have only confirmed in vagrant tests, haven't pushed to my Puppet master yet, but I saw the symptoms on my live systems. Thanks - Trey [1] - http://projects.puppetlabs.com/issues/17794 [2] - https://github.com/treydock/puppet-zfsonlinux -- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-users+unsubscr...@googlegroups.com. To post to this group, send email to puppet-users@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-users?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
