[issue7679] Warning building 2.7 on OS X 10.6 libintl.h "Present But Cannot Be Compiled"

2010-01-12 Thread Ned Deily

Ned Deily  added the comment:

Works for me.

GNU gettext, which provides libintl, is not included in OS X 10.6.  Chances are 
your build is being contaminated by packages installed via MacPorts or Fink or 
in /usr/local.  If you do want to build with it, check config.log in your build 
directory.  I bet you'll find that it is trying to pick up a 32-bit only 
version from MacPorts or friends.

--
nosy: +ned.deily

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7657] test_ctypes failure on AIX 5.3

2010-01-12 Thread sangamesh

sangamesh  added the comment:

These failures are specific to xlc compiler
In xlc signed bit fields will be mapped to unsigned by default as opposed to 
gcc where the value stored in the bit field is of type declared. 
so the the value returned by "func(byref(b), name)"  positive in some cases as 
it expected to be of type declared.

Their  is an xlc compiler option  "-qbitfields=signed" to make the bit fields 
of type signed.
After this all the ctypes test cases got passed.

--
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7658] OS X pythonw.c compile error with 10.4 or earlier deployment target: no spawn.h

2010-01-12 Thread Ronald Oussoren

Ronald Oussoren  added the comment:

I've attached a patch that should fix the build issues with the 10.4 SDK. 

The patch touches configure.in, run autoconf and autoheader after applying  the 
patch.

I haven't tested the patch yet beyond compilation on 10.6 system without the 
10.4 SDK. 

This patch does not attempt to fix the issues Ned has with LIPO_32BIT_FLAGS, I 
will look into that later today.

--
keywords: +patch
Added file: http://bugs.python.org/file15833/pythonw-on-10.4.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7679] Warning building 2.7 on OS X 10.6 libintl.h "Present But Cannot Be Compiled"

2010-01-12 Thread Ronald Oussoren

Ronald Oussoren  added the comment:

As Ned noted you probably have installed GNU gettext in /usr/local and that 
copy does not contain both intel architectures (i386 and x86_64)

There's nothing we can do about that, I have tried to find a way to exclude 
non-system locations from the default compiler search path but haven't found 
those yet.

--
resolution:  -> works for me

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7680] pythonw crash while attempting to start() a thread object

2010-01-12 Thread Amaury Forgeot d'Arc

Amaury Forgeot d'Arc  added the comment:

pythonw.exe has an invalid stdout.
Does the problem reproduce when you call print function directly, without a 
thread?

--
nosy: +amaury.forgeotdarc

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7681] Incorrect division in [wave.py] causing crash

2010-01-12 Thread Alf P. Steinbach

New submission from Alf P. Steinbach :

CPython 3.1.1 in Windows XP.

Traceback (most recent call last):
  File "C:\Documents and Settings\Alf\sound\error.py", line 6, in 
writer.setframerate( framerate )
NameError: name 'framerate' is not defined
Exception wave.Error: Error('sampling rate not specified',) in > ignored

TO FIX:

"/" needs to be changed to "//" in lines and 243 464 of [wave.py]

--
components: Library (Lib)
files: error.py
messages: 97629
nosy: alfps
severity: normal
status: open
title: Incorrect division in [wave.py] causing crash
type: crash
versions: Python 3.1
Added file: http://bugs.python.org/file15834/error.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7681] Incorrect division in [wave.py] causing crash

2010-01-12 Thread Alf P. Steinbach

Changes by Alf P. Steinbach :


Removed file: http://bugs.python.org/file15834/error.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7681] Incorrect division in [wave.py] causing crash

2010-01-12 Thread Alf P. Steinbach

Alf P. Steinbach  added the comment:

Sorry, here's correct error message:

Traceback (most recent call last):
  File "C:\Documents and Settings\Alf\sound\error.py", line 8, in 
writer.writeframes( b"\0"*2*4 )
  File "C:\Program Files\cpython\python31\lib\wave.py", line 432, in writeframes
self.writeframesraw(data)
  File "C:\Program Files\cpython\python31\lib\wave.py", line 416, in 
writeframesraw
self._ensure_header_written(len(data))
  File "C:\Program Files\cpython\python31\lib\wave.py", line 459, in 
_ensure_header_written
self._write_header(datasize)
  File "C:\Program Files\cpython\python31\lib\wave.py", line 472, in 
_write_header
self._sampwidth * 8, 'data'))
struct.error: required argument is not an integer
Exception struct.error: 'required argument is not an integer' in > ignored

--
Added file: http://bugs.python.org/file15835/error.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7682] Optimisation of if with constant expression

2010-01-12 Thread Sylvain Defresne

New submission from Sylvain Defresne :

Python compiler detect some constant expression used in if / while statement 
and evaluate them at compilation. However, it does not perform some simple 
optimisation (evaluating not unary expression or checking if and or or 
expression are constant because of the first expression).

The attached patch allow Python to detect some more constant expression, and to 
optimise test like the following:

   if __debug__ and x:
   pass

   if not __debug__:
   pass

--
components: Interpreter Core
files: compile.diff
keywords: patch
messages: 97631
nosy: sdefresne
severity: normal
status: open
title: Optimisation of if with constant expression
type: performance
versions: Python 3.2
Added file: http://bugs.python.org/file15836/compile.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7682] Optimisation of if with constant expression

2010-01-12 Thread Sylvain Defresne

Changes by Sylvain Defresne :


Removed file: http://bugs.python.org/file15836/compile.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7682] Optimisation of if with constant expression

2010-01-12 Thread Sylvain Defresne

Sylvain Defresne  added the comment:

Correct version of the patch.

--
Added file: http://bugs.python.org/file15837/compile.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7682] Optimisation of if with constant expression

2010-01-12 Thread Antoine Pitrou

Changes by Antoine Pitrou :


--
priority:  -> normal
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7681] Incorrect division in [wave.py] causing crash

2010-01-12 Thread Brian Curtin

Brian Curtin  added the comment:

In your example, the "n_frames" name does not exist, which is causing the 
problem. In your first comment, "framerate" also did not exist.

I don't know what a proper frame rate value is, but I just put 10 in there and 
it worked fine. Can you confirm?

--
nosy: +brian.curtin
priority:  -> normal
stage:  -> needs patch
type: crash -> 

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7092] Test suite emits many DeprecationWarnings when -3 is enabled

2010-01-12 Thread Florent Xicluna

Changes by Florent Xicluna :


Removed file: http://bugs.python.org/file15814/unnamed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1602] windows console doesn't print utf8 (Py30a2)

2010-01-12 Thread sorin

Changes by sorin :


--
nosy: +sorin

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7680] pythonw crash while attempting to start() a thread object

2010-01-12 Thread dontbugme

dontbugme  added the comment:

I did not understand the question.
If you were meaning running a plain print(), then it does work:
#!/usr/bin/env python
print "foo"

IDLE 2.6.4   No Subprocess 
>>> 
foo
>>> 

Well, as you suggested the problem most probably originates from calling print 
from within a thread.

This code works as it should:
#!/usr/bin/env python
import threading

class MyThread (threading.Thread):
def __init__(self):
threading.Thread.__init__(self)

def run(self):
f = open('I am alive', 'w')
f.write('hello, dude!\n')
f.close()

t = MyThread()
t.start()

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2679] email.feedparser regex duplicate

2010-01-12 Thread Ezio Melotti

Changes by Ezio Melotti :


--
nosy: +ezio.melotti
type:  -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7683] Wrong link in HTML documentation

2010-01-12 Thread Francesco Ricciardi

New submission from Francesco Ricciardi :

The first page of the Python Tutorial in version 3.1 
(http://docs.python.org/3.1/tutorial/index.html) has the "previous topic" link 
pointing to "What’s New in Python 2.0" instead of "What’s New in Python 3.1".

--
assignee: georg.brandl
components: Documentation
messages: 97635
nosy: francescor, georg.brandl
severity: normal
status: open
title: Wrong link in HTML documentation
versions: Python 3.1

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7523] add SOCK_NONBLOCK and SOCK_CLOEXEC to socket module

2010-01-12 Thread Antoine Pitrou

Antoine Pitrou  added the comment:

The patch is basically fine. I'll add a "try .. finally" to the tests.
lekma, do you have a real name that we should add to the ACKS file?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2554] test_ioctl failed Python 2.6a2 Solaris 10 SUN C

2010-01-12 Thread Brian Curtin

Changes by Brian Curtin :


--
priority:  -> normal
stage:  -> needs patch
type:  -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7683] Wrong link in HTML documentation

2010-01-12 Thread Francesco Ricciardi

Francesco Ricciardi  added the comment:

As written in the description, it should point to the "What's New in Python 
3.1" page, shouldn't it?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7683] Wrong link in HTML documentation

2010-01-12 Thread July Tikhonov

July Tikhonov  added the comment:

I don't see anything wrong in this fact..

All "what's new" pages since python 2.0 are keeped in documentation, not only 
the last one.

--
nosy: +july

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7683] Wrong link in HTML documentation

2010-01-12 Thread Ezio Melotti

Ezio Melotti  added the comment:

The section before the tutorial is the "What's new" and there all the "What's 
new" pages are listed starting from 3.1 to 2.0 in descending order.
The "What's new in Python 2.0" is therefore the last page in the "What's new" 
section so the link in the tutorial points there.
It shouldn't point to the 3.1 page, but maybe the "previous/next topic" links 
shouldn't be visible in the first/last page of the section.

--
nosy: +ezio.melotti
priority:  -> low
resolution:  -> invalid
stage:  -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue6690] BUILD_SET followed by COMPARE_OP (in) can be optimized if all items are consts

2010-01-12 Thread Alex

Alex  added the comment:

Ugh, I haven't had the time to work on this, just wanted to note that this now 
applies to 2.7 as well since set literals were backported.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7523] add SOCK_NONBLOCK and SOCK_CLOEXEC to socket module

2010-01-12 Thread Antoine Pitrou

Antoine Pitrou  added the comment:

Looking at it again, there's the question of accept() behaviour. In the 
original code, it will call internal_setblocking() on the new fd if the 
listening socket is non-blocking. In the new code, if SOCK_NONBLOCK is defined 
it will not call any OS function to set the new fd in non-blocking mode.

Here is what the man page has to say:

   On Linux, the new socket returned by accept() does not inherit file 
status  flags  such  as
   O_NONBLOCK and O_ASYNC from the listening socket.  This behavior differs 
from the canonical
   BSD sockets implementation.  Portable programs should not rely on 
inheritance or non-inher‐
   itance  of  file  status  flags  and always explicitly set all required 
flags on the socket
   returned from accept().

Linux has defined accept4() precisely for this purpose:

   If flags is 0, then accept4() is the same as accept().  The following 
values can be bitwise
   ORed in flags to obtain different behavior:

   SOCK_NONBLOCK   Set the O_NONBLOCK file status flag  on  the  new  open  
file  description.
   Using this flag saves extra calls to fcntl(2) to achieve 
the same result.

   SOCK_CLOEXECSet  the  close-on-exec  (FD_CLOEXEC) flag on the new 
file descriptor.  See
   the description of the O_CLOEXEC flag in open(2) for 
reasons why  this  may
   be useful.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue6690] BUILD_SET followed by COMPARE_OP (in) can be optimized if all items are consts

2010-01-12 Thread Antoine Pitrou

Changes by Antoine Pitrou :


--
versions: +Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7669] test_unicode_file fails with non-ascii path

2010-01-12 Thread Ezio Melotti

Ezio Melotti  added the comment:

This is because in "path = join(os.getcwd(), path)" os.getcwd() returns a 
non-ascii byte string and path is unicode, so the cwd is implicitly decoded 
with the ascii codec in join and the error is raised.
Using getcwdu() when the path is unicode seems to fix the problem:

 def abspath(path):
 """Return an absolute path."""
 if not isabs(path):
-path = join(os.getcwd(), path)
+if isinstance(path, unicode):
+path = join(os.getcwdu(), path)
+else:
+path = join(os.getcwd(), path)
 return normpath(path)

--
nosy: +ezio.melotti

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue6651] Py3k's posixpath.relpath not compatible with ntpath.relpath

2010-01-12 Thread Ezio Melotti

Changes by Ezio Melotti :


--
nosy: +ezio.melotti
priority:  -> normal
stage:  -> test needed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2643] mmap_object_dealloc does not call FlushViewOfFile on windows

2010-01-12 Thread Brian Curtin

Brian Curtin  added the comment:

Added the FlushViewOfFile calls, and an msync call to the close method. Not 
sure how to explicitly test this, if it's possible. Current tests pass on 
Windows, I'll need to check *NIX when I have the access later today.

As for justification, from the UnmapViewOfFile docs[1]: "To minimize the risk 
of data loss in the event of a power failure or a system crash, applications 
should explicitly flush modified pages using the FlushViewOfFile function."

[1] http://msdn.microsoft.com/en-us/library/aa366882%28VS.85%29.aspx

--
keywords: +needs review, patch
nosy: +brian.curtin
priority:  -> normal
stage:  -> patch review
versions: +Python 2.7, Python 3.1, Python 3.2
Added file: http://bugs.python.org/file15838/issue2643.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2643] mmap_object_dealloc does not call FlushViewOfFile on windows

2010-01-12 Thread Brian Curtin

Changes by Brian Curtin :


Removed file: http://bugs.python.org/file15838/issue2643.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2643] mmap_object_dealloc does not call FlushViewOfFile on windows

2010-01-12 Thread Brian Curtin

Brian Curtin  added the comment:

tab/space issue, updated the patch

--
Added file: http://bugs.python.org/file15839/issue2643.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue3426] os.path.abspath with unicode argument should call os.getcwdu

2010-01-12 Thread Ezio Melotti

Ezio Melotti  added the comment:

This also caused the failure in #7669.
I think that the functions in os.path are supposed to return unicode when they 
get unicode, so I agree that os.getcwdu should be used instead.
I'm not sure about os.path.supports_unicode_filenames though.

--
assignee:  -> ezio.melotti
stage:  -> test needed
superseder:  -> test_unicode_file fails with non-ascii path

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7669] test_unicode_file fails with non-ascii path

2010-01-12 Thread Ezio Melotti

Ezio Melotti  added the comment:

See #3426.

--
priority:  -> normal
resolution:  -> duplicate
stage:  -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2919] Merge profile/cProfile in 3.0

2010-01-12 Thread Brett Cannon

Brett Cannon  added the comment:

I'll see if I can have a look sometime soon, but my profile experience is 
practically non-existent so I am not the best person for a code review.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7679] Warning building 2.7 on OS X 10.6 libintl.h "Present But Cannot Be Compiled"

2010-01-12 Thread Steve Steiner

Steve Steiner  added the comment:

It's in /usr/local/include alright but I have no idea with which package it 
came in.  I don't use Fink or Macports.

If it's not going to wreck the build, maybe remove the "Report this to 
http://bugs.python.org/"; instructions?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7632] dtoa.c: oversize b in quorem

2010-01-12 Thread Mark Dickinson

Mark Dickinson  added the comment:

Progress report:  I've had a response, and fix, from David Gay for the first 2 
bugs (Stefan's original bug and the incorrect subnormal result);  I'm still 
arguing with him about a 3rd one (not reported here; there's some possibly 
incorrect code in bigcomp that probably never actually gets called).  I 
reported the 4th bug (the incorrect rounding for values near 1) to him today.  
In the mean time, here's bug number 5, found by eyeballing the bigcomp code 
until it surrendered.  :-)

>>> 1000e-16
1e+23
>>> 1e-17
1.0001e+23

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue3426] os.path.abspath with unicode argument should call os.getcwdu

2010-01-12 Thread Florent Xicluna

Changes by Florent Xicluna :


--
nosy: +flox

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue767645] incorrect os.path.supports_unicode_filenames

2010-01-12 Thread Ezio Melotti

Changes by Ezio Melotti :


--
nosy: +ezio.melotti

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue767645] incorrect os.path.supports_unicode_filenames

2010-01-12 Thread Brett Cannon

Changes by Brett Cannon :


--
nosy:  -brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue6690] BUILD_SET followed by COMPARE_OP (in) can be optimized if all items are consts

2010-01-12 Thread Dave Malcolm

Dave Malcolm  added the comment:

Attaching a probably over-simplistic attempt at this patch, against the py3k 
branch.

This patch attempts to extend the replacement of
  LOAD_CONST, , LOAD_CONST, BUILD_LIST, COMPARE_OP(in)
with
  LOAD_CONST(tuple), COMPAREOP(in)

so that it also replaces:
  LOAD_CONST, , LOAD_CONST, BUILD_SET, COMPARE_OP(in)
with 
  LOAD_CONST(tuple), COMPAREOP(in)

i.e. using a tuple, not a frozenset (on the grounds that the "in" conditions 
should at least still work); caveat: I'm relatively new to the innards of this 
code.

With this patch:
>>> dis.dis(lambda o: o in {1,2,3})
  1   0 LOAD_FAST0 (o) 
  3 LOAD_CONST   3 ((1, 2, 3)) 
  6 COMPARE_OP   6 (in) 
  9 RETURN_VALUE 
but:
>>> dis.dis(lambda o: o in {1,2,3,3,2,1})
  1   0 LOAD_FAST0 (o) 
  3 LOAD_CONST   3 ((1, 2, 3, 3, 2, 1)) 
  6 COMPARE_OP   6 (in) 
  9 RETURN_VALUE 

Is it worth me working on a rewrite to use a frozenset.

Hope this is helpful
Dave

--
keywords: +patch
nosy: +dmalcolm
Added file: 
http://bugs.python.org/file15840/simple-optimization-of-BUILD_SET-COMPARE_OP(IN)-to-LOAD_CONST(tuple)_COMPARE_OP(IN)-py3k.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue6690] BUILD_SET followed by COMPARE_OP (in) can be optimized if all items are consts

2010-01-12 Thread Alex

Alex  added the comment:

David, I think it should use frozen set since doing it this way could actually 
increase the time the operation takes (which is certainly not our goal!).  Plus 
marshall.c already handles frozenset, so I don't think it's that much more work.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue767645] incorrect os.path.supports_unicode_filenames

2010-01-12 Thread Ezio Melotti

Ezio Melotti  added the comment:

Maybe os.path.supports_unicode_filenames should be deprecated.
The doc currently says:
"True if arbitrary Unicode strings can be used as file names (within 
limitations imposed by the file system), and if os.listdir() returns Unicode 
strings for a Unicode argument."

On Linux both the things work, even if the value of 
os.path.supports_unicode_filenames is still False:
>>> os.path.supports_unicode_filenames
False
>>> open(u'fòòbàr', 'w')

>>> os.listdir(u'.')
[u'f\xf2\xf2b\xe0r', ...]
>>> open(u'fòòbàr')


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue6690] BUILD_SET followed by COMPARE_OP (in) can be optimized if all items are consts

2010-01-12 Thread Dave Malcolm

Dave Malcolm  added the comment:

Alex: good point - thanks!

Attaching updated version of the patch (again, against py3k, likewise, I'm 
somewhat new to this code, so I may have missed things)

With this:
>>> dis.dis(lambda o: o in {1,2,3})
  1   0 LOAD_FAST0 (o) 
  3 LOAD_CONST   3 (frozenset({1, 2, 3})) 
  6 COMPARE_OP   6 (in) 
  9 RETURN_VALUE 
>>> dis.dis(lambda o: o in {1,2,3,3,2,1})
  1   0 LOAD_FAST0 (o) 
  3 LOAD_CONST   3 (frozenset({1, 2, 3})) 
  6 COMPARE_OP   6 (in) 
  9 RETURN_VALUE 
and the tuple/list cases are again as in the original comment.

I'm in the process of running the full test suite.

--
Added file: 
http://bugs.python.org/file15841/simple-optimization-of-BUILD_SET-COMPARE_OP(IN)-to-LOAD_CONST(frozenset)_COMPARE_OP(IN)-py3k.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue6690] BUILD_SET followed by COMPARE_OP (in) can be optimized if all items are consts

2010-01-12 Thread Alex

Alex  added the comment:

The patch looks more or less right to me (but I'm far from an expert).  It 
needs tests in the peephole tests though.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue767645] incorrect os.path.supports_unicode_filenames

2010-01-12 Thread R. David Murray

R. David Murray  added the comment:

In addition, whether or not true unicode filenames are supported really 
depends, at least on Linux, on the *filesystem*, not on the OS (for some 
definition of support).  In other words, I think 
os.path.supports_unicode_filenames is an API design that is broken and should 
probably be dropped.

--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7684] decimal.py: infinity coefficients in tuples

2010-01-12 Thread Stefan Krah

New submission from Stefan Krah :

It should not be possible to pass coefficients when constructing infinities 
from tuples. Otherwise it looks like infinities can have payloads (which they 
can't).

Example:

>>> import decimal, cdecimal
>>> d = decimal.Decimal((0, (4, 5, 3, 4), 'F'))
>>> d
Decimal('Infinity')

>>> d = cdecimal.Decimal((0, (4, 5, 3, 4), 'F'))
Traceback (most recent call last):
File "", line 1, in 
cdecimal.InvalidOperation: []


Also, the non-coefficient of infinities should preferably be represented as an 
empty tuple:

>>> decimal.Decimal("Infinity").as_tuple()
DecimalTuple(sign=0, digits=(0,), exponent='F')
>>> cdecimal.Decimal("Infinity").as_tuple()
(0, (), 'F')

--
components: Library (Lib)
messages: 97656
nosy: mark.dickinson, skrah
severity: normal
status: open
title: decimal.py: infinity coefficients in tuples
type: behavior
versions: Python 3.2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7684] decimal.py: infinity coefficients in tuples

2010-01-12 Thread Mark Dickinson

Changes by Mark Dickinson :


--
assignee:  -> mark.dickinson

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7647] Add statvfs flags to the posix module

2010-01-12 Thread Adam Jackson

Adam Jackson  added the comment:

None of the other symbolic constants in 'posix' have documentation.  Perhaps 
they should, but the patch is at least doing the same as what's already done.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue767645] incorrect os.path.supports_unicode_filenames

2010-01-12 Thread Florent Xicluna

Florent Xicluna  added the comment:

Additionally it filters out test_pep277 on some platforms.

But seemingly, it is not needed anymore with this patch.

--
nosy: +flox
resolution: later -> 
Added file: http://bugs.python.org/file15842/issue767645_test_pep277.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7610] Cannot use both read and readline method in same ZipExtFile object

2010-01-12 Thread Antoine Pitrou

Antoine Pitrou  added the comment:

Some comments:
* you should probably write `n = sys.maxsize` instead of `n = 1 << 31 - 1`
* ZipExtFile.read() should support `n=None` as a synonym to `n=-1` (read 
everything)
* `bytes` as a variable name isn't very good since it's the built-in name for 
bytestrings in py3k
* in ZipExtFile.read(), it seems you have removed the adjustment for encrypted 
files (see `adjust read size for encrypted files since the first 12 bytes 
[etc.]`)
* is there a situation where the decompressor might return less bytes than 
expected? (after all compression doesn't /always/ compress, in unfavourable 
chunks of data it might actually expand things a bit)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue767645] incorrect os.path.supports_unicode_filenames

2010-01-12 Thread Joe Amenta

Joe Amenta  added the comment:

If it is decided to keep supports_unicode_filenames, here is a patch for 
test_os.py that verifies the value of supports_unicode_filenames against the 
following line from the documentation:
"True if arbitrary Unicode strings can be used as file names (within 
limitations imposed by the file system), and if os.listdir() returns Unicode 
strings for a Unicode argument."

--
keywords: +patch
nosy: +joe.amenta
Added file: 
http://bugs.python.org/file15843/test_supports_unicode_filenames.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1693546] email.Message set_param rfc2231 encoding incorrect

2010-01-12 Thread R. David Murray

R. David Murray  added the comment:

Hmm.  The RFC text says:

   Note that quotes around parameter values are part of the value
   syntax; they are NOT part of the value itself.  Furthermore, it is
   explicitly permitted to have a mixture of quoted and unquoted
   continuation fields.

So this looks more like a bug in the RFC to me.

--
nosy: +r.david.murray
status: open -> pending

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7685] minor typo in re docs

2010-01-12 Thread Michael Stephens

New submission from Michael Stephens :

Just something small that bothers me whenever I'm in the re docs - his name's 
spelled 'Malcolm Reynolds', not 'Malcom Reynolds' ;)

--
assignee: georg.brandl
components: Documentation
files: malcolm_typo.diff
keywords: patch
messages: 97662
nosy: georg.brandl, mikejs
severity: normal
status: open
title: minor typo in re docs
versions: Python 2.7
Added file: http://bugs.python.org/file15844/malcolm_typo.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7654] [patch] Enable additional bytes and memoryview tests.

2010-01-12 Thread Antoine Pitrou

Antoine Pitrou  added the comment:

Committed in r77448 and r77449, thank you.

--
nosy: +pitrou
resolution:  -> fixed
stage: patch review -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2643] mmap_object_dealloc does not call FlushViewOfFile on windows

2010-01-12 Thread Antoine Pitrou

Antoine Pitrou  added the comment:

A test could explicitly close a dirtied mmaped file and then open() it to check 
that everything was written, no?

--
nosy: +pitrou

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1721862] email.FeedParser.BufferedSubFile improperly handles "\r\n"

2010-01-12 Thread R. David Murray

R. David Murray  added the comment:

This seems to be a duplicate of issue 170, which has a simpler patch.

--
nosy: +r.david.murray
resolution:  -> duplicate
stage: test needed -> committed/rejected
status: open -> closed
superseder:  -> email parser incorrectly breaks headers with a CRLF at 8192

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1555570] email parser incorrectly breaks headers with a CRLF at 8192

2010-01-12 Thread R. David Murray

R. David Murray  added the comment:

See also issue 1721862, which has a different test and patch.  This one seems 
simpler.

--
nosy: +r.david.murray
stage:  -> patch review
type:  -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7632] dtoa.c: oversize b in quorem

2010-01-12 Thread Mark Dickinson

Mark Dickinson  added the comment:

Fixed the crash that Stefan originally reported in r77450.  That revision also 
removes the 'possibly incorrect code in bigcomp that probably never actually 
gets called'.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7681] Incorrect division in [wave.py] causing crash

2010-01-12 Thread Alf P. Steinbach

Alf P. Steinbach  added the comment:

No, sorry, the bugs in [wave.py] have nothing to do with a name IN A COMMENT in 
the trivial code to exercise the bugs.

To reproduce the crash, just run the supplied code with Python 3.1.1 in Windows 
XP.

The cause of the crash is, as I pointed out, use of Python 2.x "/" division 
instead of Python 3.x "//" division. The author of [wave.py] had fixed that in 
some places. But he/she forgot two places.


Cheers & hth.,

- Alf

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7544] Fatal error on thread creation in low memory condition

2010-01-12 Thread Antoine Pitrou

Antoine Pitrou  added the comment:

Running the tests in debug mode gives the following error:

test_3_join_in_forked_from_thread (test.test_threading.ThreadJoinOnShutdown) 
... Fatal Python error: Invalid thread state for this thread
[21851 refs]
FAIL
[snip]

==
FAIL: test_3_join_in_forked_from_thread 
(test.test_threading.ThreadJoinOnShutdown)
--
Traceback (most recent call last):
  File "/home/antoine/cpython/debug/Lib/test/test_threading.py", line 476, in 
test_3_join_in_forked_from_thread
self._run_and_join(script)
  File "/home/antoine/cpython/debug/Lib/test/test_threading.py", line 412, in 
_run_and_join
self.assertEqual(data, "end of main\nend of thread\n")
AssertionError: 'end of main\n' != 'end of main\nend of thread\n'

--
Ran 78 tests in 3.739s

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7632] dtoa.c: oversize b in quorem

2010-01-12 Thread Mark Dickinson

Mark Dickinson  added the comment:

Second bug fixed in r77451 (trunk), using a fix from David Gay, modified 
slightly for correctness.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue6690] BUILD_SET followed by COMPARE_OP (in) can be optimized if all items are consts

2010-01-12 Thread Dave Malcolm

Dave Malcolm  added the comment:

Thanks for looking at the patch.

Attached is an updated version (again against py3k) which adds tests to 
Lib/test/test_peepholer.py, for both the new folding away of BUILD_SET, and for 
the pre-existing folding of BUILD_LIST (which didn't seem to have tests).

Hopefully these look good.  One possible worry I had with them is with the 
string comparison against repr(various frozensets) for the disassembly of the 
bytecode: the new tests thus assume that the ordering of the repr of a 
frozenset is constant.  Is this a reasonable assumption, or should the choice 
of test items be changed to ones with more robust ordering in their repr() 
string?

--
Added file: 
http://bugs.python.org/file15845/simple-optimization-of-BUILD_SET-COMPARE_OP(IN)-to-LOAD_CONST(frozenset)_COMPARE_OP(IN)-with-tests-py3k.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7632] dtoa.c: oversize b in quorem

2010-01-12 Thread Mark Dickinson

Mark Dickinson  added the comment:

Merged fixes so far, and a couple of other cleanups, to py3k in r77452, and 
release31-maint in r77453.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7681] Incorrect division in [wave.py]

2010-01-12 Thread Brian Curtin

Brian Curtin  added the comment:

There is no crash, but I see what you are saying now.
Patch to correct the two divisions and a test similar to your example.

--
keywords: +needs review, patch
stage: needs patch -> patch review
title: Incorrect division in [wave.py] causing crash -> Incorrect division in 
[wave.py]
type:  -> behavior
Added file: http://bugs.python.org/file15846/issue7681.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7686] redundant open modes 'rbb', 'wbb', 'abb' no longer work on Windows

2010-01-12 Thread ivank

New submission from ivank :

This probably only applies to Windows. The redundant 'b' modes still work on 
Linux.

These worked on Windows in 2.6.4:

open('test', 'rbb')
open('test', 'wbb')
open('test', 'abb')

and possibly others.

In 2.7a2, they throw ValueErrors like this:

>>> open('test', 'wbb')
Traceback (most recent call last):
  File "", line 1, in 
ValueError: Invalid mode ('wbb')

It would be nice if the old behavior were preserved for backwards 
compatibility. Some programs append a 'b' indiscriminately.

--
messages: 97674
nosy: ivank
severity: normal
status: open
title: redundant open modes 'rbb', 'wbb', 'abb' no longer work on Windows
type: behavior
versions: Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7685] minor typo in re docs

2010-01-12 Thread Ezio Melotti

Ezio Melotti  added the comment:

Fixed in r77455 (trunk), r77456 (release26-maint), r77457 (py3k) and r77458 
(release31-maint), thanks!

--
assignee: georg.brandl -> ezio.melotti
nosy: +ezio.melotti
priority:  -> normal
resolution:  -> fixed
stage:  -> committed/rejected
status: open -> closed
versions: +Python 2.6, Python 3.1, Python 3.2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5178] Add context manager for temporary directory

2010-01-12 Thread Ezio Melotti

Changes by Ezio Melotti :


--
nosy: +ezio.melotti

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7686] redundant open modes 'rbb', 'wbb', 'abb' no longer work on Windows

2010-01-12 Thread Brian Curtin

Changes by Brian Curtin :


--
priority:  -> normal
stage:  -> needs patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue3426] os.path.abspath with unicode argument should call os.getcwdu

2010-01-12 Thread Ezio Melotti

Ezio Melotti  added the comment:

Here is a patch that uses os.getcwdu() instead of os.getcwd() when the arg of 
abspath is unicode (with tests).

It also include an helper context manager in test_support used to create temp 
dirs and set them as cwd (this will be committed separately) and two helper 
methods (assertUnicode and assertStr) that will probably be useful when I (or 
someone else) will add more tests with unicode strings for the other functions.

--
keywords: +needs review, patch
nosy:  -flox
stage: test needed -> patch review
Added file: http://bugs.python.org/file15847/issue3426.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue3426] os.path.abspath with unicode argument should call os.getcwdu

2010-01-12 Thread Ezio Melotti

Changes by Ezio Melotti :


--
nosy: +flox

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue3636] Managing dual 2.x and 3.0 installations on Windows

2010-01-12 Thread Brian Curtin

Brian Curtin  added the comment:

This won't solve the problem of dual installations, but it'll leave things how 
you were expecting... There is an option in the installer on the customize page 
for "Register Extensions". Choosing to not install that item will keep the 
installer from modifying the path and file association.

I think we could probably have a message on the installer to say that the 
"Register Extensions" feature would be overwriting your previous settings if it 
finds settings of a previous version.

--
components: +Installation -Documentation
nosy: +brian.curtin
priority:  -> normal
stage:  -> needs patch
superseder:  -> PYTHON3PATH environment variable to supersede PYTHONPATH for 
multi-Python environments
type:  -> behavior
versions: +Python 3.2 -Python 3.0

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2375] PYTHON3PATH environment variable to supersede PYTHONPATH for multi-Python environments

2010-01-12 Thread Brian Curtin

Changes by Brian Curtin :


--
stage:  -> needs patch
versions: +Python 3.2 -Python 3.0

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7544] Fatal error on thread creation in low memory condition

2010-01-12 Thread STINNER Victor

STINNER Victor  added the comment:

> Running the tests in debug mode gives the following error:
> ... Fatal Python error: Invalid thread state for this thread

I tried all Lib/test/test_thread*py, but not in debug mode :-/

The problem is here: PyThreadState_New() -> _PyGILState_NoteThreadState() -> 
PyThread_set_key_value() -> find_key() and find_key() calls 
PyThread_get_thread_ident(), but the ident is not the right ident :-/

PyThreadState_New() should not call _PyGILState_NoteThreadState(), it should be 
done _in_ the thread.

I wrote a new patch fixing the unit test. PyThreadState_New() is part of the 
public API, so I can't change its prototype. And _PyGILState_NoteThreadState() 
is a private function (use the "static" keyword). Because of that, I introduced 
two new functions:

 - PyThreadState_Prealloc(): like PyThreadState_New() but for thread 
preallocation, can be called outside the new state (from another thread)

 - PyThreadState_Init(): have to be called in the new thread to finish the 
thread state initialization, only required for state created by 
PyThreadState_Prealloc() (not for PyThreadState_New())

I tried all Lib/test/test_thread*.py tests in debug mode and all test now pass 
;-)

--
Added file: http://bugs.python.org/file15848/thread_prealloc_pystate-2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue4870] ssl module is missing SSL_OP_NO_SSLv2

2010-01-12 Thread Jeremy Kloth

Jeremy Kloth  added the comment:

I have developed a patch that adds the ability to disable SSLv2, SSlv3 and 
TLSv1 when using the SSLv23 method. It changes Modules/_ssl.c, Lib/ssl.py and 
Doc/library/ssl.rst.

--
keywords: +patch
nosy: +jeremy.kloth
Added file: http://bugs.python.org/file15849/issue4870.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue3426] os.path.abspath with unicode argument should call os.getcwdu

2010-01-12 Thread Brian Curtin

Brian Curtin  added the comment:

You could use assertIsInstance(s, unicode, '%r is not unicode' % s) in the 
tests instead of your assertTrue.

I think the rest of it looks good. Works for me.

--
nosy: +brian.curtin

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue4870] ssl module is missing SSL_OP_NO_SSLv2

2010-01-12 Thread Brian Curtin

Changes by Brian Curtin :


--
priority:  -> normal
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2694] msilib file names check too strict ?

2010-01-12 Thread Brian Curtin

Changes by Brian Curtin :


--
priority:  -> normal
stage:  -> needs patch
versions: +Python 2.7 -Python 2.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue444582] Finding programs in PATH, addition to os

2010-01-12 Thread Brian Curtin

Changes by Brian Curtin :


--
stage: test needed -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5115] Extend subprocess.kill to be able to kill process groups

2010-01-12 Thread Brian Curtin

Changes by Brian Curtin :


--
priority:  -> normal
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7579] Patch to add docstrings to msvcrt

2010-01-12 Thread Brian Curtin

Changes by Brian Curtin :


--
priority:  -> normal
stage:  -> patch review
type:  -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue4772] undesired switch fall-through in socketmodule.c

2010-01-12 Thread Brian Curtin

Changes by Brian Curtin :


--
priority:  -> normal
type:  -> behavior
versions: +Python 2.7, Python 3.1, Python 3.2 -Python 3.0

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7306] Patch - skip winsound tests if no default sound is configured

2010-01-12 Thread Brian Curtin

Changes by Brian Curtin :


--
keywords: +needs review
priority:  -> normal
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7347] Add {Create|Delete}KeyEx to _winreg, doc and test updates

2010-01-12 Thread Brian Curtin

Changes by Brian Curtin :


--
priority:  -> normal
stage:  -> test needed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue4722] _winreg.QueryValue fault while reading mangled registry values

2010-01-12 Thread Brian Curtin

Changes by Brian Curtin :


--
keywords: +needs review
priority:  -> normal
stage:  -> patch review
versions:  -Python 2.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7301] Add environment variable $PYTHONWARNINGS

2010-01-12 Thread Brian Curtin

Changes by Brian Curtin :


--
keywords: +needs review
priority:  -> normal
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5774] _winreg.OpenKey() is documented with keyword arguments, but doesn't take them

2010-01-12 Thread Brian Curtin

Changes by Brian Curtin :


--
priority:  -> normal
stage:  -> patch review
type:  -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5774] _winreg.OpenKey() is documented with keyword arguments, but doesn't take them

2010-01-12 Thread Brian Curtin

Changes by Brian Curtin :


Removed file: http://bugs.python.org/file15262/issue5774_20091104_v1.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5774] _winreg.OpenKey() is documented with keyword arguments, but doesn't take them

2010-01-12 Thread Brian Curtin

Changes by Brian Curtin :


--
keywords: +needs review
Added file: http://bugs.python.org/file15850/issue5774.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5116] expose _CrtSetReportMode via the msvcrt module

2010-01-12 Thread Brian Curtin

Changes by Brian Curtin :


--
keywords: +26backport -needs review, patch, patch
stage:  -> needs patch
versions:  -Python 3.0, Python 3.1

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7588] unittest.TestCase.shortDescription isn't short anymore

2010-01-12 Thread Brian Curtin

Changes by Brian Curtin :


--
stage:  -> needs patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1222585] C++ compilation support for distutils

2010-01-12 Thread Brian Curtin

Changes by Brian Curtin :


--
keywords: +needs review
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7672] _ssl module causes segfault

2010-01-12 Thread Bill Janssen

Bill Janssen  added the comment:

Martin, I'm thinking that the module object has a __del__ method, and we could 
un-register the callbacks there.  But I don't know if that method would ever 
get called.  How does the act of "unloading a library" interact with the 
initialized Python interpreter?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7672] _ssl module causes segfault

2010-01-12 Thread Sean Soria

Sean Soria  added the comment:

Simply unloading the callbacks wouldn't be wise. Callbacks are necessary for 
proper thread safety with libcrypto (man pages says random crashing could occur 
without them). So setting them to NULL could cause random crashing which is 
even worse than what's there now. Restoring the existing callbacks is one 
option. It's also not thread safe to be chaing the callbacks all the time. Is 
it critical that Python install its own callbacks over whatever the app has 
provided?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7681] Incorrect division in [wave.py]

2010-01-12 Thread Benjamin Peterson

Benjamin Peterson  added the comment:

Thanks for the patch! Applied in r77459.

--
nosy: +benjamin.peterson
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2846] Gzip cannot handle zero-padded output + patch

2010-01-12 Thread Brian Curtin

Brian Curtin  added the comment:

Here tadek's patch updated for trunk, with a test added to it. 

I feel like this should be documented somewhere, but Doc/Library/gzip.rst 
doesn't feel right. Maybe it just needs a mention in the "What's new" or 
something?

--
assignee:  -> brian.curtin
keywords: +needs review
nosy: +brian.curtin
priority:  -> normal
stage:  -> patch review
versions: +Python 2.6, Python 2.7, Python 3.1, Python 3.2 -Python 2.5
Added file: http://bugs.python.org/file15851/issue2846.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7686] redundant open modes 'rbb', 'wbb', 'abb' no longer work on Windows

2010-01-12 Thread Ezio Melotti

Ezio Melotti  added the comment:

With 2.7 I can reproduce the issue on Windows 7 (i.e. I get a ValueError).
However I'm not sure how common is to add a 'b' indiscriminately:
1) most of the times the modes are written as strings, and not generated 
automatically;
2) even if generated, checking if there's a 'b' is as easy as doing "if 'b' not 
in mode: mode = mode + 'b'".

For consistency both Windows and Linux should have the same behavior, and if 
the extra 'b' is not so common I think it's better if both raise an error.

--
components: +Interpreter Core, Windows
nosy: +ezio.melotti
stage: needs patch -> test needed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2846] Gzip cannot handle zero-padded output + patch

2010-01-12 Thread Brian Curtin

Changes by Brian Curtin :


Removed file: http://bugs.python.org/file15851/issue2846.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2846] Gzip cannot handle zero-padded output + patch

2010-01-12 Thread Brian Curtin

Brian Curtin  added the comment:

Updated patch with some documentation

--
Added file: http://bugs.python.org/file15852/issue2846.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7588] unittest.TestCase.shortDescription isn't short anymore

2010-01-12 Thread Ezio Melotti

Changes by Ezio Melotti :


--
nosy: +ezio.melotti

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7658] OS X pythonw.c compile error with 10.4 or earlier deployment target: no spawn.h

2010-01-12 Thread Ned Deily

Ned Deily  added the comment:

Thanks, Ronald.  The patch looks good. I've got a patch in progress for the 
LIPO flags part: looks like the key is 'ppc' for DEPLOYMENT_TARGET <= 10.4 and 
'ppc7400' for DEPLOYMENT_TARGET >= 10.5 for either gcc-4.0 or -4.2.  I'll test 
the two together on the various platforms tomorrow.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



  1   2   >