[issue29541] Python3 error while building on Alt-F

[Honza Skýpala]

New submission from Honza Skýpala:

While trying to build Python 3.6.0 on emmbedded Linux device — D-Link DNS-320L 
running Alt-F firmware (Linux 3.18.28 #1 Fri Jun 17 14:44:39 WEST 2016 armv5tel 
GNU/Linux), it fails with

./python: can't resolve symbol 'crypt'
make: *** [sharedmods] Error 1

I can see the python executable is compiled fine in the source directory, if I 
try to run it, then it does work, including some quick tests (calculations, 
os.getcwd, random.randint -- works fine). 

I can also see that compiling the crypt modules did not report any errors and 
the .o file is present on the disk. I guess it is some kind of linking error?

Attaching the log from the build.

--
components: Build
files: build.log
messages: 287666
nosy: Honza Skýpala
priority: normal
severity: normal
status: open
title: Python3 error while building on Alt-F
type: compile error
versions: Python 3.6
Added file: http://bugs.python.org/file46636/build.log

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29481] 3.6.0 doc describes 3.6.1 feature - typing.Deque

[Thomas Caswell]

Changes by Thomas Caswell :


--
pull_requests: +50

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29514] Add a test case that prevents magic number changes in minor releases

[Łukasz Langa]

Łukasz Langa added the comment:

I commented on the original issue where the magic number was changed. This 
broke the world at work for me. Our distribution mechanism for Python programs 
is zipped bundles of .pyc and .so files, the optimized variant doesn't keep .py 
files around. So suddenly otherwise correct bundles were refusing to start. 
Better yet, since the rollout of Python is staged and takes a while to do 
safely, new packages started appear with the new magic number that were 
refusing to start on 3.5.0. This was not a fun day :)

So, while I understand Brett's and Serhiy's reasoning, I'd be very careful 
about ever bumping magic numbers in minor releases again, and definitely 
communicate loudly if doing so.

Oh, if you're wondering why I even hit this problem before 3.5.3: since 3.5.2 
had a few regressions we couldn't live with, I released 3.5.2+ from the latest 
commit on the 3.5 branch at the time (after checking the buildbots, running 
tests on our own, etc.). I repeated this feat with 3.6.0+ and again hit a thing 
that would likely upset some people in 3.6.1 (see #29519) but this time decided 
to patch it instead of just complaining ;)

--
nosy: +lukasz.langa

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29481] 3.6.0 doc describes 3.6.1 feature - typing.Deque

[Thomas Caswell]

Thomas Caswell added the comment:

I agree this is very confusing (and in fact confused me for about an hour 
between getting import errors, double checking the docs, checking I was in the 
right env, double checking the docs, checking the source of my env, double 
checking the docs, checking the git source and then tracking through these too 
issues).

--
nosy: +tcaswell

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29424] Multiple vulnerabilities in BaseHTTPRequestHandler enable HTTP response splitting attacks

[Benjamin Gilbert]

Changes by Benjamin Gilbert :


--
nosy: +bgilbert

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29540] Add compact=True flag to json.dump/dumps

[Alex Gordon]

New submission from Alex Gordon:

Broadly speaking, there are three main output styles for json.dump/dumps:

1. Default: json.dumps(obj)
2. Compact: json.dumps(obj, separators=(',', ':'))
3. Pretty-printing: json.dumps(obj, sort_keys=True, indent=4)

The 'compact' style is the densest, suitable if the JSON is to be sent over the 
network, archived on disk, or otherwise consumed by a machine. The 
pretty-printed style is for human consumption: configuration files, debugging, 
etc.

Even though the compact style is often desirable, the API for producing it is 
unforgiving. It's easy to accidentally write code like the following, which 
silently produces invalid nonsense:

json.dumps(obj, separators=(':', ','))

I propose the addition of a new flag `compact=True`, that simply sets 
`separators=(',', ':')`. e.g.

>>> obj = {"foo": 1, "bar": 2}
>>> json.dumps(obj, compact=True)
'{"foo":1,"bar":2}'

The defaults for `separators=` are good, so eventually `compact=` would 
relegate `separators=` to obscurity. Setting both `compact=True` and 
`separators=` at the same time should be an error.

--
components: Library (Lib)
messages: 287663
nosy: Alex Gordon
priority: normal
severity: normal
status: open
title: Add compact=True flag to json.dump/dumps
type: enhancement
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29539] [smtplib] collect response data for all recipients

[David Ford (FirefighterBlu3)]

New submission from David Ford (FirefighterBlu3):

Feature request; collect SMTP response results for all recipients so data 
likely including the queue ID or SMTP delay expectation can be collected

I propose the keyword "keep_results=False" be added to smtplib.sendmail() to 
accomplish this. The default value of False maintains the legacy functionality 
of prior versions. No other changes have been done to smtplib.send_message() 
pending discussion of the following.


@@ -785,7 +785,7 @@
 return (resp, reply)
 
 def sendmail(self, from_addr, to_addrs, msg, mail_options=[],
- rcpt_options=[]):
+ rcpt_options=[], keep_results=False):
 """This command performs an entire mail transaction.
 
 The arguments are:
@@ -797,6 +797,8 @@
  mail command.
 - rcpt_options : List of ESMTP options (such as DSN commands) for
  all the rcpt commands.
+- keep_results : If True, return a dictionary of recipients and the
+ SMTP result for each.
 
 msg may be a string containing characters in the ASCII range, or a byte
 string.  A string is encoded to bytes using the ascii codec, and lone
@@ -807,17 +809,20 @@
 and each of the specified options will be passed to it.  If EHLO
 fails, HELO will be tried and ESMTP options suppressed.
 
-This method will return normally if the mail is accepted for at least
-one recipient.  It returns a dictionary, with one entry for each
-recipient that was refused.  Each entry contains a tuple of the SMTP
-error code and the accompanying error message sent by the server.
+If keep_results is False, this method will return normally if the mail
+is accepted for at least one recipient.  It returns a dictionary, with
+one entry for each recipient that was refused.  Each entry contains a
+tuple of the SMTP error code and the accompanying error message sent by
+the server.  If keep_results is True, this method returns a dictionary
+of all recipients and the SMTP result whether refused or accepted
+unless all are refused then the normal exception is raised.
 
 This method may raise the following exceptions:
 
  SMTPHeloError  The server didn't reply properly to
 the helo greeting.
- SMTPRecipientsRefused  The server rejected ALL recipients
-(no mail was sent).
+ SMTPRecipientsRefused  The server rejected ALL recipients (no mail
+was sent).
  SMTPSenderRefused  The server didn't accept the from_addr.
  SMTPDataError  The server replied with an unexpected
 error code (other than a refusal of
@@ -879,6 +884,10 @@
 self._rset()
 raise SMTPRecipientsRefused(senderrs)
 (code, resp) = self.data(msg)
+if keep_results:
+for each in to_addrs:
+if not each in senderrs:
+senderrs[each]=(code, resp)
 if code != 250:
 if code == 421:
 self.close()

--
components: email
messages: 287662
nosy: David Ford (FirefighterBlu3), barry, r.david.murray
priority: normal
severity: normal
status: open
title: [smtplib] collect response data for all recipients
type: enhancement
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29538] bugs.python.org does not redirect to HTTPS

[Paul Schreiber]

New submission from Paul Schreiber:

bugs.python.org does not redirect HTTP requests to HTTPS and does not provide 
Strict Transport Security.

--
messages: 287661
nosy: paulschreiber
priority: normal
severity: normal
status: open
title: bugs.python.org does not redirect to HTTPS
type: security

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19675] Pool dies with excessive workers, but does not cleanup

[Dustin Oprea]

Dustin Oprea added the comment:

https://github.com/python/cpython/pull/57

On Sun, Feb 12, 2017 at 5:29 PM, Camilla Montonen 
wrote:

>
> Camilla Montonen added the comment:
>
> @dsoprea: would you like to open a PR for this issue on Github? if not,
> are you happy for me to do it?
>
> --
>
> ___
> Python tracker 
> 
> ___
>

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29514] Add a test case that prevents magic number changes in minor releases

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

I don't understand how the table can make maintaining easier. You need to 
support multiple values in every branch even if the only one value is used. I'm 
sure unused values will became outdated pretty fast.

"alpha" and "beta" stages are not related here. The test should be skipped at 
these stages (I recommend to use skipTest() or the skipUnless() decorator 
rather than just make test always success). Magic number can be changed 
multiple times at "alpha" and "beta" stages. Release manager needs to update 
the test only when forming the first release candidate. And his should not do 
anything if the magic number was not changed in this feature release.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19675] Pool dies with excessive workers, but does not cleanup

[Camilla Montonen]

Camilla Montonen added the comment:

@dsoprea: would you like to open a PR for this issue on Github? if not, are you 
happy for me to do it?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29524] Move functions to call objects into a new Objects/call.c file

[STINNER Victor]

STINNER Victor added the comment:

commit c22bfaae83ab5436d008ac0d13e7b47cbe776f08
Author: Victor Stinner 
Date:   Sun Feb 12 19:27:05 2017 +0100

bpo-29524: Add Objects/call.c file (#12)

* Move all functions to call objects in a new Objects/call.c file.
* Rename fast_function() to _PyFunction_FastCallKeywords().
* Copy null_error() from Objects/abstract.c
* Inline type_error() in call.c to not have to copy it, it was only
  called once.
* Export _PyEval_EvalCodeWithName() since it is now called
  from call.c.

Thanks Serhiy and Naoki for your reviews!

It's probably not perfect, but IMHO it's better than what we had previously, 
and we can rework this file later.

About file history: "git blame Objects/call.c" shows me that the first and only 
author, *but* "git blame -C Objects/call.c" works as expected (show the full 
history)!

--
resolution:  -> fixed
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29514] Add a test case that prevents magic number changes in minor releases

[Nick Coghlan]

Nick Coghlan added the comment:

Regarding the naming of the test file: I agree this can just be added to 
Lib/test/test_importlib/test_util:MagicNumberTests rather than being added as a 
new test file.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29514] Add a test case that prevents magic number changes in minor releases

[Nick Coghlan]

Nick Coghlan added the comment:

I think the table of expected magic numbers will be easier to maintain than a 
single value, as otherwise you either have to:

- update it every time the magic number changes during the alpha/beta cycle 
(which would be a bad habit to encourage, since it runs counter to the purpose 
of the test)

- change it to None for the alpha/beta cycle (to effectively disable the test) 
before setting it again at the next release candidate

By contrast, the version table will typically be append only - the only time it 
will routinely require modification is for the first release candidate of a 
particular feature release, and the change will be to add a new entry for that 
release.

I see it as being similar to why we have the full history of all the magic 
numbers in _bootstrap_external.py, even though we technically only need the 
latest one.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29527] Travis: doc job is broken

[STINNER Victor]

STINNER Victor added the comment:

I see that Travis CI now compiles the doc to HTML, there is a single warning 
and the doc works. So I close the issue. Thanks!

If you want to upgrade Sphinx, fix more warnings, etc. : please open new more 
specific issues for these tasks.

--
resolution:  -> fixed
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14044] IncompleteRead error with urllib2 or urllib.request -- fine with urllib, wget, or curl

[CJ Kucera]

CJ Kucera added the comment:

Ah, well, actually I suppose I'll rescind that a bit - other pages about this 
bug around the internet had been claiming that the 'requests' module uses 
urllib in the backend and was subject to this bug as well, but after 
experimenting myself, it seems like if that IS the case, they're working around 
it somehow, because using requests makes this succeed 100% of the time.  I 
probably should've tried that first!

So anyway, there's a reasonable workaround, at least.  Sorry for the bugspam!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29514] Add a test case that prevents magic number changes in minor releases

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

What is the purpose of having a *table* of magic numbers? We need just one 
value. Different Python versions run different tests.

And I don't think this test needs adding separate file.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28929] Provide a link from documentation back to its source file

[Mariatta Wijaya]

Mariatta Wijaya added the comment:

Thanks all :)
PRs have been merged on GitHub.
Closing this.

--
resolution:  -> fixed
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29514] Add a test case that prevents magic number changes in minor releases

[Nick Coghlan]

Nick Coghlan added the comment:

Thanks Eric! I've left some detailed comments on the PR, with the main one 
being to include the "expected" table directly in the test case so it doesn't 
require any changes to importlib itself.

For Serhiy - thanks for the explanation of the potential security impact of the 
original bug, as well as the additional patch that resolves that aspect even 
for the invalid bytecode.

As for as the complexity of the test case itself goes, the main cases we're 
interested in here are how it fails:

- when an RM goes to make a candidate release, they may forget to record the 
now expected magic number for that release series and get prompted by the 
failing test case. We'd like them to be able to just copy the magic number from 
_bootstrap_external.py directly into the table of expected magic numbers

- when someone attempts to bump the magic number in a maintenance release, we 
want the warning that that's a higher impact change than it may first appear 
(one we know how to deal with now, but still something we'd prefer to avoid if 
we possibly can)

So I think it makes sense to have a relatively verbose test case, even though 
the core of it is a really simple check of a single value.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29537] Alternative fix for BUILD_MAP_UNPACK_WITH_CALL opcode in 3.5

[Nick Coghlan]

Nick Coghlan added the comment:

Thanks Serhiy, I think that will work well downstream in combination with 
Petr's patch to accept both magic numbers.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22281] ProcessPoolExecutor/ThreadPoolExecutor should provide introspection APIs

[Camilla Montonen]

Changes by Camilla Montonen :


--
nosy: +Winterflower

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23267] multiprocessing pool.py doesn't close inqueue and outqueue pipes on termination

[Camilla Montonen]

Changes by Camilla Montonen :


--
nosy: +Winterflower

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5001] Remove assertion-based checking in multiprocessing

[Camilla Montonen]

Changes by Camilla Montonen :


--
nosy: +Winterflower

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14119] Ability to adjust queue size in Executors

[Camilla Montonen]

Changes by Camilla Montonen :


--
nosy: +Winterflower

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19675] Pool dies with excessive workers, but does not cleanup

[Camilla Montonen]

Camilla Montonen added the comment:

I've reformatted Dustin Oprea's original patch to be compatible with git, 
applied it to master and executed _test_multiprocessing suite. All tests pass 
locally.

--
Added file: http://bugs.python.org/file46635/bug19675git.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29514] Add a test case that prevents magic number changes in minor releases

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

The patch looks overcomplicated to me. The test could be as simple as

self.assertEqual(importlib.util.MAGIC_NUMBER, ...)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29514] Add a test case that prevents magic number changes in minor releases

[Eric Appelt]

Eric Appelt added the comment:

I added PR #54 with a test as Nick describes for checking magic number changes 
and explaining to the developer the procedure to follow if this is required in 
a maintenance release.

--
nosy: +Eric Appelt
pull_requests: +49

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29176] /tmp does not exist on Android and is used by curses.window.putwin()

[STINNER Victor]

STINNER Victor added the comment:

I created the PR https://github.com/python/cpython/pull/53 for  
curses_temporaryfile.patch.

--
pull_requests: +48

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14044] IncompleteRead error with urllib2 or urllib.request -- fine with urllib, wget, or curl

[CJ Kucera]

CJ Kucera added the comment:

I've just encountered this problem on Python 3.6, on a different URL.  The 
difference being that it's not encountered with EVERY page load, though I'd say 
it happens with at least half:

import urllib.request
html = urllib.request.urlopen('http://www.basicinstructions.net/').read()
print('Succeeded!')

I realize that the root problem here may be an HTTP server doing something 
improper, but I've got no way of fixing someone else's webserver.  It'd be 
really nice if there was a reasonable way of handling this in Python itself.  
As mentioned in the original report, other methods of retreiving this URL work 
without fail (curl/wget/etc).  As it is, the only way for me to be sure of 
retreiving the entire page contents is by looping until I don't get an 
IncompleteRead, which is hardly ideal.

--
nosy: +apocalyptech
versions: +Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29176] /tmp does not exist on Android and is used by curses.window.putwin()

[STINNER Victor]

STINNER Victor added the comment:

I created https://github.com/python/cpython/pull/52 for  
curses_fix_window_class_name.patch.

--
pull_requests: +47

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29514] Add a test case that prevents magic number changes in minor releases

[Brett Cannon]

Brett Cannon added the comment:

That comment is poorly worded. All that is really necessary is that the tag 
differ when you want to have a .pyc file exist side-by-side with another .pyc 
file. So far we have only changed it when releasing a new version of Python, 
but for instance Python 3.5.2 could have had a different tag and that would 
have prevented trying to overwrite any pre-existing .pyc files for 3.5.1 and 
instead create new ones.

So the tag doesn't need to change for every new magic number, just when you 
don't want to overwrite .pyc files created by another version of Python.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28598] RHS not consulted in `str % subclass_of_str` case.

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
nosy: +serhiy.storchaka
stage:  -> patch review
versions: +Python 3.7 -Python 3.3, Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29474] Grammatical errors in weakref.WeakValueDictionary docs

[Mariatta Wijaya]

Mariatta Wijaya added the comment:

Thanks, everyone :)
The GitHub PRs have been merged.

Closing this issue.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27122] Hang with contextlib.ExitStack and subprocess.Popen (regression)

[Berker Peksag]

Berker Peksag added the comment:


New changeset c6d2f498142c29ed62241ab6d89cb7b5e38f2fca by GitHub in branch 
'3.5':
bpo-27122: Fix comment to point to correct issue number (#50)
https://github.com/python/cpython/commit/c6d2f498142c29ed62241ab6d89cb7b5e38f2fca


--
nosy: +berker.peksag

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27122] Hang with contextlib.ExitStack and subprocess.Popen (regression)

[Berker Peksag]

Berker Peksag added the comment:


New changeset 89b1824e693419b20b6a9113e5293f1c1a78065f by GitHub in branch 
'3.6':
bpo-27122: Fix comment to point to correct issue number (#48)
https://github.com/python/cpython/commit/89b1824e693419b20b6a9113e5293f1c1a78065f


--
nosy: +berker.peksag

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28598] RHS not consulted in `str % subclass_of_str` case.

[Martijn Pieters]

Martijn Pieters added the comment:

I'm not sure if issues are linked automatically yet. I put the patch up as a 
pull request on GitHub: https://github.com/python/cpython/pull/51

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29537] Alternative fix for BUILD_MAP_UNPACK_WITH_CALL opcode in 3.5

[Serhiy Storchaka]

New submission from Serhiy Storchaka:

Proposed patch is an alternative fix of issue27286 for Python 3.5. Rather than 
fixing the compiler and bumping the magic number it just avoids using incorrect 
value in eval loop. The patch can be useful for disro maintainers that don't 
want to recompile all .pyc files when update Python to 3.5.3. I think it would 
be the best way to fix issue27286. Now it can be combined with either reverting 
issue27286 changes or applying the workaround 
https://github.com/encukou/cpython/commit/magic-number-workaround .

The patch makes the high byte of oparg be used only when it is unambiguous 
(equal to 1). In that case the error message contains a function name. 
Otherwise the error message doesn't contain a function name. This is small 
usability regression, but the BUILD_MAP_UNPACK_WITH_CALL opcode is very rarely 
used and shouldn't raise an exception in normal case.

--
components: Interpreter Core
messages: 287637
nosy: barry, encukou, ncoghlan, serhiy.storchaka
priority: normal
severity: normal
stage: patch review
status: open
title: Alternative fix for BUILD_MAP_UNPACK_WITH_CALL opcode in 3.5
versions: Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29537] Alternative fix for BUILD_MAP_UNPACK_WITH_CALL opcode in 3.5

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
keywords: +patch
Added file: 
http://bugs.python.org/file46634/BUILD_MAP_UNPACK_WITH_CALL-no-function_location.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29463] Add `docstring` field to AST nodes

[INADA Naoki]

Changes by INADA Naoki :


--
pull_requests: +46

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29463] Add `docstring` field to AST nodes

[INADA Naoki]

INADA Naoki added the comment:

Thanks.  I don't familiar with language frontend.
I'll check NEWS entry.

--
title: Add `docstring` attribute to AST nodes -> Add `docstring` field to AST 
nodes

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29428] Doctest documentation unclear about multi-line fixtures

[Jim DeLaHunt]

Jim DeLaHunt added the comment:

Pull Request https://github.com/python/cpython/pull/45 submitted to new Github 
repo. 

I would appreciate a review.

I attempted to balance all the different opinions in the discussion below: stay 
concise, but also improve the clarity.

--
pull_requests: +45

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com