[issue25403] urllib.parse.urljoin is broken in python 3.5
Wei Wu added the comment: It's a change made in 3.5 that resolution of relative URLs confirms to the RFC 3986. See https://bugs.python.org/issue22118 for details. -- nosy: +kilowu ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue25403> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23566] RFE: faulthandler.register() should support file descriptors
Wei Wu added the comment: @haypo, would you review issue23566_fd_tests_v2.patch? It's been a time since the last update of it. However I think the fd tests on windows is just fine to be skipped. So what's the next plan? Shall we continue to work on it or just resolve this issue? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23566 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23566] RFE: faulthandler.register() should support file descriptors
Wei Wu added the comment: The updated patch refactored test code a little bit according to the latest review comments by Victor. -- Added file: http://bugs.python.org/file38546/issue23566_fd_tests_v2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23566 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23566] RFE: faulthandler.register() should support file descriptors
Wei Wu added the comment: I attached a patch that implements the solution described above. -- Added file: http://bugs.python.org/file38480/issue23566_fd_tests.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23566 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23566] RFE: faulthandler.register() should support file descriptors
Wei Wu added the comment: The last approach I proposed requires some change in template code of check_xxx methods. To make it better, we can add a bool parameter to the check_xxx functions, True value indicating a fd test. If a filename is given at the same time, then a fd can get from that file. Otherwise the fd should be sys.stderr.fileno(). e.g. file = None fp = None if filename: fp = open(filename, wb) # Must use a different name to prevent the file from closing... file = fp if fd: if fp is not None: file = fp.fileno() else: file = sys.stderr.fileno() # file can be file-object, fd or None (use_the_file_to_function...) The fd-passing approach can co-exist with this one. However it will make template code more complex. So I suggest just use one approach to write these fd tests. I will work on a patch(based on tip) at this weekend. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23566 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23566] RFE: faulthandler.register() should support file descriptors
Wei Wu added the comment: Updated the patch and addressed the previous review comments: * Fixed the hasattr problem * Added a default value None for filename in check_dump_traceback * Reverted unnecessary code change in check_dump_traceback_later * Added a new paragraph to the enable, dump_traceback_later and register in doc Let me know if there is possible further improvement in this patch. : ) -- Added file: http://bugs.python.org/file38445/issue23566_v3.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23566 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23566] RFE: faulthandler.register() should support file descriptors
Wei Wu added the comment: Or we could reuse the file created by filename in subprocess? if filename: file = open(filename, wb) if use_fd: file = file.fileno() else: file = None In this case, we need to pass two arguments(both filename and a bool use_fd) to check_xxx functions. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23566 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23566] RFE: faulthandler.register() should support file descriptors
Wei Wu added the comment: Attached a patch to this issue. Made some changes to faulthandler_get_fileno to accept integer as fd. If a fd is provided, the file member of fatal_error struct is set NULL. An new test case is added and some common testing code is also changed in order to be reused. -- keywords: +patch nosy: +kilowu Added file: http://bugs.python.org/file38417/issue23566.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23566 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23566] RFE: faulthandler.register() should support file descriptors
Wei Wu added the comment: @haypo: Thank you for your review. I attached an updated patch addressing the review comments. In addition, I also added a change note in Misc/NEWS. -- Added file: http://bugs.python.org/file38436/issue23566_update.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23566 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14534] Add method to mark unittest.TestCases as do not run.
Changes by Wei Wu we...@cacheme.net: Added file: http://bugs.python.org/file36315/01438f18ee18.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14534 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22116] Weak reference support for C function objects
Wei Wu added the comment: @pitrou, thank you for the review. I have signed the contributor agreement form after submitting this patch. Please let me know if there is a further step to help you to verify the signed contributor agreement. I'm really glad to have the chance to contribute back to the community. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22116 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22116] Weak reference support for C function objects
Wei Wu added the comment: I have made a patch related to this issue, please take a look at it. Thanks :) -- nosy: +kilowu ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22116 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22116] Weak reference support for C function objects
Changes by Wei Wu we...@cacheme.net: -- keywords: +patch Added file: http://bugs.python.org/file36208/22116.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22116 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
