[issue13464] HTTPResponse is missing an implementation of readinto

[Felipe Rodrigues]

Change by Felipe Rodrigues :


--
nosy: +fbidu
nosy_count: 5.0 -> 6.0
pull_requests: +21847
pull_request: https://github.com/python/cpython/pull/22737

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13464] HTTPResponse is missing an implementation of readinto

[Roundup Robot]

Roundup Robot devn...@psf.upfronthosting.co.za added the comment:

New changeset 4b21f651 by Antoine Pitrou in branch 'default':
Issue #13713: fix a regression in HTTP chunked reading after 806cfe39f729
http://hg.python.org/cpython/rev/4b21f651

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13464
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13464] HTTPResponse is missing an implementation of readinto

[Roundup Robot]

Roundup Robot devn...@psf.upfronthosting.co.za added the comment:

New changeset 806cfe39f729 by Antoine Pitrou in branch 'default':
Issue #13464: Add a readinto() method to http.client.HTTPResponse.
http://hg.python.org/cpython/rev/806cfe39f729

--
nosy: +python-dev

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13464
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13464] HTTPResponse is missing an implementation of readinto

[Antoine Pitrou]

Antoine Pitrou pit...@free.fr added the comment:

Ok, thank you. I've now committed the patch in the default branch. 
Congratulations!

(since the documentation doesn't claim that HTTPResponse implements RawIOBase, 
I tend to consider this a feature request rather than a bugfix, hence no 3.2 
commit)

--
resolution:  - fixed
stage: patch review - committed/rejected
status: open - closed
type: behavior - feature request
versions:  -Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13464
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13464] HTTPResponse is missing an implementation of readinto

[Antoine Pitrou]

Antoine Pitrou pit...@free.fr added the comment:

Hello Jon, and thanks for the patch. I have a couple of comments:

- readinto() shouldn't return None but 0 when there is nothing to read (this 
corresponds to read() returning b)

- I see _read_chunked() is only ever called with amt=None, so perhaps it can be 
simplified?

Also, a nitpick: the doc entry needs a versionadded tag.

--
stage:  - patch review

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13464
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13464] HTTPResponse is missing an implementation of readinto

[Jon Kuhn]

Jon Kuhn jonk...@gmail.com added the comment:

Thanks for the comments.  Attached is an updated patch.

In the RawIOBase docs it says If the object is in non-blocking mode and no 
bytes are available, None is returned.  So I wasn't sure if that meant any 
time no bytes were available or just when no bytes are available and EOF has 
not been reached.  -- I updated it to return 0 instead of None.

I simplified _read_chunked() and renamed it to _readall_chunked() since that is 
all it does.  

I added the versionadded tag specifying that it was added in 3.3 since the 
patch is for the default branch.

--
Added file: http://bugs.python.org/file23850/issue13464_r1.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13464
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13464] HTTPResponse is missing an implementation of readinto

[Jon Kuhn]

Jon Kuhn jonk...@gmail.com added the comment:

This is my first contribution to a real open source project.

Attached is my patch.  Suggestions for improvements are welcome.

--
keywords: +patch
nosy: +Jon.Kuhn
Added file: http://bugs.python.org/file23847/issue13464.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13464
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13464] HTTPResponse is missing an implementation of readinto

[R. David Murray]

New submission from R. David Murray rdmur...@bitdance.com:

HTTPResponse subclasses RawIOBase, but does not provide an implementation of 
readinto, only read.  This means that it is not conforming to the IO spec, and 
so it cannot be wrapped in a BufferedIOBase when using the C version of io.

--
components: Library (Lib)
keywords: easy
messages: 148199
nosy: orsenthil, pitrou, r.david.murray
priority: normal
severity: normal
status: open
title: HTTPResponse is missing an implementation of readinto
type: behavior
versions: Python 3.2, Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13464
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com