[issue32627] Header dependent _uuid build failure on Fedora 27

[Ned Deily]

Ned Deily  added the comment:


New changeset e90815b3b16ab196c10f3a4dd91402cdc2e07d06 by Ned Deily (Miss 
Islington (bot)) in branch '3.7':
bpo-32627: Fix compile error when conflicting `_uuid` headers included 
(GH-11751)
https://github.com/python/cpython/commit/e90815b3b16ab196c10f3a4dd91402cdc2e07d06


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32627] Header dependent _uuid build failure on Fedora 27

[Ned Deily]

Ned Deily  added the comment:

Thanks, @adam, for the analysis and thanks, zihengCat, for the PR.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32627] Header dependent _uuid build failure on Fedora 27

[miss-islington]

miss-islington  added the comment:


New changeset 76b72f6ea26de4280279a01863f30fccd2dde8f3 by Miss Islington (bot) 
in branch '3.8':
bpo-32627: Fix compile error when conflicting `_uuid` headers included 
(GH-11751)
https://github.com/python/cpython/commit/76b72f6ea26de4280279a01863f30fccd2dde8f3


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32627] Header dependent _uuid build failure on Fedora 27

[miss-islington]

miss-islington  added the comment:


New changeset 742b16edd692f58a06e0d55bedfffb77a112b205 by Miss Islington (bot) 
in branch '3.7':
bpo-32627: Fix compile error when conflicting `_uuid` headers included 
(GH-11751)
https://github.com/python/cpython/commit/742b16edd692f58a06e0d55bedfffb77a112b205


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32627] Header dependent _uuid build failure on Fedora 27

[miss-islington]

Change by miss-islington :


--
pull_requests: +14167
pull_request: https://github.com/python/cpython/pull/14348

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32627] Header dependent _uuid build failure on Fedora 27

[miss-islington]

Change by miss-islington :


--
pull_requests: +14166
pull_request: https://github.com/python/cpython/pull/14347

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32627] Header dependent _uuid build failure on Fedora 27

[Ned Deily]

Ned Deily  added the comment:


New changeset 6ffd9b05dfade9e3a101fe039157856eb855f82e by Ned Deily (ziheng) in 
branch 'master':
bpo-32627: Fix compile error when conflicting `_uuid` headers included 
(GH-11751)
https://github.com/python/cpython/commit/6ffd9b05dfade9e3a101fe039157856eb855f82e


--
nosy: +ned.deily

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32627] Header dependent _uuid build failure on Fedora 27

[Roundup Robot]

Change by Roundup Robot :


--
keywords: +patch, patch
pull_requests: +11682, 11683
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32627] Header dependent _uuid build failure on Fedora 27

[Roundup Robot]

Change by Roundup Robot :


--
keywords: +patch, patch, patch
pull_requests: +11682, 11683, 11684
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32627] Header dependent _uuid build failure on Fedora 27

[Roundup Robot]

Change by Roundup Robot :


--
keywords: +patch, patch, patch, patch
pull_requests: +11682, 11683, 11684, 11685
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32627] Header dependent _uuid build failure on Fedora 27

[Roundup Robot]

Change by Roundup Robot :


--
keywords: +patch
pull_requests: +11682
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32627] Header dependent _uuid build failure on Fedora 27

[Frank Thommen]

Change by Frank Thommen :


--
nosy: +fthommen

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32627] Header dependent _uuid build failure on Fedora 27

[Adam]

Adam  added the comment:

Some systems might have both uuid.h and uuid/uuid.h. For example, NetBSD 
provides /usr/include/uuid.h, and one might also install libuuid from a 
package, and the latter has uuid/uuid.h.

To fix this, do not include both files, when both have been detected.

Here is a patch:

--- Modules/_uuidmodule.c.orig
+++ Modules/_uuidmodule.c
@@ -3,8 +3,7 @@
 #include "Python.h"
 #ifdef HAVE_UUID_UUID_H
 #include 
-#endif
-#ifdef HAVE_UUID_H
+#elif defined(HAVE_UUID_H)
 #include 
 #endif

--
nosy: +a...@netbsd.org

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32627] Header dependent _uuid build failure on Fedora 27

[Nick Coghlan]

Nick Coghlan  added the comment:

(Reducing priority since "sudo dnf remove uuid-devel" is a straightforward 
workaround)

--
priority: normal -> low

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32627] Header dependent _uuid build failure on Fedora 27

[Nick Coghlan]

Nick Coghlan  added the comment:

Reverting my previous commit doesn't fix the problem: if both uuid-devel and 
libuuid-devel are installed, then it reports that the necessary bits to build 
_uuid weren't found, without even attempting to compile it at all.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32627] Header dependent _uuid build failure on Fedora 27

[Nick Coghlan]

New submission from Nick Coghlan :

I'm hitting a build failure relating to the new _uuid module on Fedora 27:

==
building '_uuid' extension
gcc -pthread -fPIC -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 
-Wall -Wstrict-prototypes -std=c99 -Wextra -Wno-unused-result 
-Wno-unused-parameter -Wno-missing-field-initializers 
-Werror=implicit-function-declaration -I./Include -I. -I/usr/local/include 
-I/home/ncoghlan/devel/cpython/Include -I/home/ncoghlan/devel/cpython -c 
/home/ncoghlan/devel/cpython/Modules/_uuidmodule.c -o 
build/temp.linux-x86_64-3.7/home/ncoghlan/devel/cpython/Modules/_uuidmodule.o
In file included from /home/ncoghlan/devel/cpython/Modules/_uuidmodule.c:8:0:
/usr/include/uuid.h:94:24: error: conflicting types for ‘uuid_t’
 typedef struct uuid_st uuid_t;
^~
In file included from /home/ncoghlan/devel/cpython/Modules/_uuidmodule.c:5:0:
/usr/include/uuid/uuid.h:44:23: note: previous declaration of ‘uuid_t’ was here
 typedef unsigned char uuid_t[16];
   ^~
In file included from /home/ncoghlan/devel/cpython/Modules/_uuidmodule.c:8:0:
/usr/include/uuid.h:107:22: error: conflicting types for ‘uuid_compare’
 extern uuid_rc_t uuid_compare  (const uuid_t  *_uuid, const uuid_t 
*_uuid2, int *_result);
  ^~~~
In file included from /home/ncoghlan/devel/cpython/Modules/_uuidmodule.c:5:0:
/usr/include/uuid/uuid.h:73:12: note: previous declaration of ‘uuid_compare’ 
was here
 extern int uuid_compare(const uuid_t uu1, const uuid_t uu2);
^~~~
/home/ncoghlan/devel/cpython/Modules/_uuidmodule.c: In function 
‘py_uuid_generate_time_safe’:
/home/ncoghlan/devel/cpython/Modules/_uuidmodule.c:15:12: error: storage size 
of ‘uuid’ isn’t known
 uuid_t uuid;
^~~~
/home/ncoghlan/devel/cpython/Modules/_uuidmodule.c:15:12: warning: unused 
variable ‘uuid’ [-Wunused-variable]
/home/ncoghlan/devel/cpython/Modules/_uuidmodule.c:29:1: warning: control 
reaches end of non-void function [-Wreturn-type]
 }
 ^
==

>From my initial investigation, I think the issue may be related to my previous 
>attempt to fix this in 
>https://github.com/python/cpython/commit/53efbf3977a44e382397e7994a2524b4f8c9d053#diff-2eeaed663bd0d25b7e608891384b7298
> and the fact that there are *two* "uuid.h" headers available in the Fedora 
>repos:

* /usr/include/uuid.h (provided by uuid-devel)
* /usr/include/uuid/uuid.h (provided by libuuid-devel)

Right now, the build works if you have "libuuid-devel" installed, but do *not* 
have "uuid-devel" installed.

With both installed, neither installed, or only uuid-devel installed, the build 
will fail, but the exact errors reported will vary. (There's also a distinct 
set of compile errors you can get if you forget to rerun configure after 
installing the additional headers)

Reverting my previous commit (and replacing it with a comment saying we're 
specifically looking for "uuid/uuid.h", not "uuid.h") may be enough to handle 
the case where both are installed.

--
messages: 310459
nosy: christian.heimes, ncoghlan, vstinner
priority: normal
severity: normal
stage: needs patch
status: open
title: Header dependent _uuid build failure on Fedora 27
type: compile error
versions: Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com