[issue38643] Assertion failures when calling PyNumber_ToBase() with an invalid base

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38643] Assertion failures when calling PyNumber_ToBase() with an invalid base

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 6f4e7fcfca6923d0422b20fc8702240bd4e56ebd by Serhiy Storchaka in 
branch '3.7':
[3.7] bpo-38643: Raise SystemError instead of crashing when PyNumber_ToBase is 
called with invalid base. (GH-18863). (GH-18955)
https://github.com/python/cpython/commit/6f4e7fcfca6923d0422b20fc8702240bd4e56ebd


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38643] Assertion failures when calling PyNumber_ToBase() with an invalid base

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
pull_requests: +18306
pull_request: https://github.com/python/cpython/pull/18955

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38643] Assertion failures when calling PyNumber_ToBase() with an invalid base

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset ab9c72912178cfdb4d0637be036d78913b769154 by Serhiy Storchaka in 
branch '3.8':
[3.8] bpo-38643: Raise SystemError instead of crashing when PyNumber_ToBase is 
called with invalid base. (GH-18863). (GH-18954)
https://github.com/python/cpython/commit/ab9c72912178cfdb4d0637be036d78913b769154


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38643] Assertion failures when calling PyNumber_ToBase() with an invalid base

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
pull_requests: +18305
pull_request: https://github.com/python/cpython/pull/18954

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38643] Assertion failures when calling PyNumber_ToBase() with an invalid base

[Zackery Spytz]

Zackery Spytz  added the comment:

Okay, Serhiy.  I think your patch is a better choice.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38643] Assertion failures when calling PyNumber_ToBase() with an invalid base

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset e5ccc94bbb153431698b2391df625e8d47a93276 by Serhiy Storchaka in 
branch 'master':
bpo-38643: Raise SystemError instead of crashing when PyNumber_ToBase is called 
with invalid base. (GH-18863)
https://github.com/python/cpython/commit/e5ccc94bbb153431698b2391df625e8d47a93276


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38643] Assertion failures when calling PyNumber_ToBase() with an invalid base

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
components: +C API -Interpreter Core

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38643] Assertion failures when calling PyNumber_ToBase() with an invalid base

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Sorry Zackery, I did not know about this issue so I wrote different PR to fix 
this problem. And only after writing it I have found this issue.

There are several differences between your PR and PR 18863.

* SystemError is raised instead of ValueError because this is incorrect use of 
the C API.
* The error message mentions also base 10.
* The test is written mostly in Python.

For these reasons I prefer my PR.

Please let me know if you need a review for other PRs.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38643] Assertion failures when calling PyNumber_ToBase() with an invalid base

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
versions:  -Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38643] Assertion failures when calling PyNumber_ToBase() with an invalid base

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
nosy: +serhiy.storchaka
nosy_count: 1.0 -> 2.0
pull_requests: +18220
pull_request: https://github.com/python/cpython/pull/18863

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38643] Assertion failures when calling PyNumber_ToBase() with an invalid base

[Zackery Spytz]

Change by Zackery Spytz :


--
keywords: +patch
pull_requests: +16523
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/16996

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38643] Assertion failures when calling PyNumber_ToBase() with an invalid base

[Zackery Spytz]

New submission from Zackery Spytz :

If a base other than 2, 8, or 16 is passed to PyNumber_ToBase(), an assertion 
failure will occur. An exception should be raised instead.

This was mentioned in bpo-38249 (msg353039).

--
components: Interpreter Core
messages: 355715
nosy: ZackerySpytz
priority: normal
severity: normal
status: open
title: Assertion failures when calling PyNumber_ToBase() with an invalid base
type: crash
versions: Python 2.7, Python 3.7, Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com