[issue7990] xml.etree.cElementTree lacks full dir() on Element

[Roundup Robot]

Roundup Robot added the comment:

New changeset fef7f041c1a7 by Serhiy Storchaka in branch 'default':
Issue #7990: dir() on ElementTree.Element now lists properties: "tag",
https://hg.python.org/cpython/rev/fef7f041c1a7

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7990] xml.etree.cElementTree lacks full dir() on Element

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
assignee:  -> serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7990] xml.etree.cElementTree lacks full dir() on Element

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Here is a patch updated to 3.6.

--
nosy: +serhiy.storchaka
versions: +Python 3.6 -Python 3.3, Python 3.4
Added file: http://bugs.python.org/file41133/etree_attributes.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7990] xml.etree.cElementTree lacks full dir() on Element

[Martin Panter]

Martin Panter added the comment:

The patch looks technically good, though I’m not a big fan of the double 
underscores, like element_get__text(). Maybe element_text_getter() instead, 
because it has to match the “getter” signature?

Personally, I would say keep the doc strings basic. If you want to add more 
depth about “tail”, I suggest to keep it to the main RST documentation (which 
was updated fairly recently). But it would be good to quickly distinguish text 
and tail other than by name. Maybe:

{"text", ..., "A string of text directly after the start tag, or None"},
{"tail", ..., "A string of text directly after the end tag, or None"},

--
nosy: +martin.panter

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7990] xml.etree.cElementTree lacks full dir() on Element

[Eli Bendersky]

Eli Bendersky added the comment:

Could you please refresh the patch for Python 3.3 and 3.4 (_elementtree went 
through many changes in 3.3)?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7990
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7990] xml.etree.cElementTree lacks full dir() on Element

[Christian Heimes]

Changes by Christian Heimes li...@cheimes.de:


--
nosy: +christian.heimes

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7990
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7990] xml.etree.cElementTree lacks full dir() on Element

[Florent Xicluna]

Changes by Florent Xicluna florent.xicl...@gmail.com:


--
assignee: effbot - 
nosy: +eli.bendersky
stage: needs patch - patch review

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7990
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7990] xml.etree.cElementTree lacks full dir() on Element

[Santoso Wijaya]

Santoso Wijaya santoso.wij...@gmail.com added the comment:

Is this a right approach? I converted the hard-coded attributes into real, 
C-API attributes.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7990
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7990] xml.etree.cElementTree lacks full dir() on Element

[Arc Riley]

Arc Riley arcri...@gmail.com added the comment:

It looks right to me, but I would include more verbose pydoc strings.  

IE, The tail attribute can be used to hold additional data associated with the 
element tells me nothing.  You could explain here what .tail actually is, a 
few XML examples of what would be put in tail or what tail would become, and 
the API design reason why tail is used in addition to text.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7990
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7990] xml.etree.cElementTree lacks full dir() on Element

[Santoso Wijaya]

Changes by Santoso Wijaya santoso.wij...@gmail.com:


--
versions: +Python 3.4 -Python 2.7, Python 3.1, Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7990
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7990] xml.etree.cElementTree lacks full dir() on Element

[Santoso Wijaya]

Santoso Wijaya santoso.wij...@gmail.com added the comment:

Attached a patch with test for this:

Following the suggestion, I put tag, text, tail, and attrib to be 
accessible via tp_getset for _etree.Element type.

--
keywords: +patch
nosy: +santa4nt
Added file: http://bugs.python.org/file21041/dir_elem_c.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7990
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7990] xml.etree.cElementTree lacks full dir() on Element

[Santoso Wijaya]

Changes by Santoso Wijaya santoso.wij...@gmail.com:


--
versions: +Python 3.1, Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7990
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com