[python-committers] Commit privileges for Eli Bendersky
Two years ago, Eli Bendersky submitted to the tracker one of several duplicate reports about problems with difflib.SequenceMatcher. After I consolidated and closed all issues but one, he wrote me, said he wanted to get more involved in Python development, and offered to help with that and other issues. Since then he has actively participated in 34 issues, submitting 1 or more patches to 20 issues, listed below. Of those, 14 are closed. I believe his work always or nearly always contributed to the commit. Another has been committed to 3.2 and is only open for backports and possible tweaks. Another is waiting for 3.3, another for my response. His activity has covered core, library, and doc issues. He can work on C, Python, and .rst code and text He has shown himself to be a careful reader of both code and text. He has also participated a bit on pydev. I believe he said last September, in private email in response to my query, that he would like full developer privileges 'someday'. Before I reviewed his tracker activity, I was merely going to recommend that we 'start thinking about' a promotion. But then I discovered that he had done much I did not know about, as several developers (me, Alexander B, Georg B. Eric A, Michael F., ...) have done commits involving his patches. So I now think, 'why wait?' I am confident that he will start with whatever cautions he is given, with issues that are either trivial or that have been reviewed by others. http://bugs.python.org/issue9132 http://bugs.python.org/issue9282 http://bugs.python.org/issue9214 http://bugs.python.org/issue1397474 needs comment from me http://bugs.python.org/issue9323 http://bugs.python.org/issue9315 http://bugs.python.org/issue9317 open http://bugs.python.org/issue10439 http://bugs.python.org/issue10470 http://bugs.python.org/issue9222 http://bugs.python.org/issue10468 http://bugs.python.org/issue766910 open http://bugs.python.org/issue10534 http://bugs.python.org/issue10693 http://bugs.python.org/issue9312 http://bugs.python.org/issue9264 open for backport http://bugs.python.org/issue10461 http://bugs.python.org/issue10801 http://bugs.python.org/issue10516 waiting for 3.3 http://bugs.python.org/issue10594 -- Terry Jan Reedy ___ python-committers mailing list python-committers@python.org http://mail.python.org/mailman/listinfo/python-committers
Re: [python-committers] Commit privileges for Eli Bendersky
+1 On Jan 8, 2011, at 3:09 PM, Terry Reedy wrote: > Two years ago, Eli Bendersky submitted to the tracker one of several > duplicate reports about problems with difflib.SequenceMatcher. After I > consolidated and closed all issues but one, he wrote me, said he wanted to > get more involved in Python development, and offered to help with that and > other issues. Since then he has actively participated in 34 issues, > submitting 1 or more patches to 20 issues, listed below. Of those, 14 are > closed. I believe his work always or nearly always contributed to the commit. > Another has been committed to 3.2 and is only open for backports and possible > tweaks. Another is waiting for 3.3, another for my response. His activity has > covered core, library, and doc issues. He can work on C, Python, and .rst > code and text He has shown himself to be a careful reader of both code and > text. He has also participated a bit on pydev. > > I believe he said last September, in private email in response to my query, > that he would like full developer privileges 'someday'. Before I reviewed his > tracker activity, I was merely going to recommend that we 'start thinking > about' a promotion. But then I discovered that he had done much I did not > know about, as several developers (me, Alexander B, Georg B. Eric A, Michael > F., ...) have done commits involving his patches. So I now think, 'why wait?' > I am confident that he will start with whatever cautions he is given, with > issues that are either trivial or that have been reviewed by others. > > http://bugs.python.org/issue9132 > http://bugs.python.org/issue9282 > http://bugs.python.org/issue9214 > http://bugs.python.org/issue1397474 needs comment from me > http://bugs.python.org/issue9323 > http://bugs.python.org/issue9315 > http://bugs.python.org/issue9317 open > http://bugs.python.org/issue10439 > http://bugs.python.org/issue10470 > http://bugs.python.org/issue9222 > http://bugs.python.org/issue10468 > http://bugs.python.org/issue766910 open > http://bugs.python.org/issue10534 > http://bugs.python.org/issue10693 > http://bugs.python.org/issue9312 > http://bugs.python.org/issue9264 open for backport > http://bugs.python.org/issue10461 > http://bugs.python.org/issue10801 > http://bugs.python.org/issue10516 waiting for 3.3 > http://bugs.python.org/issue10594 > -- > Terry Jan Reedy > ___ > python-committers mailing list > python-committers@python.org > http://mail.python.org/mailman/listinfo/python-committers ___ python-committers mailing list python-committers@python.org http://mail.python.org/mailman/listinfo/python-committers
[python-committers] Commit rights for Ned Deily
Hello, Based on his work to diagnose and fix many issues related to OS X and/or IDLE/tk, I would like to propose that we give Ned Deily commit rights. He seems to already have developer rights on the tracker. Regards Antoine. ___ python-committers mailing list python-committers@python.org http://mail.python.org/mailman/listinfo/python-committers
Re: [python-committers] Commit rights for Ned Deily
> Based on his work to diagnose and fix many issues related to OS X and/or > IDLE/tk, I would like to propose that we give Ned Deily commit rights. > He seems to already have developer rights on the tracker. Are you willing to mentor him (where necessary)? If so, please make him send his SSH key and subscribe to the committers list, and give any instructions you deem necessary. Regards, Martin ___ python-committers mailing list python-committers@python.org http://mail.python.org/mailman/listinfo/python-committers
Re: [python-committers] Commit rights for Ned Deily
+1 On Jan 8, 2011, at 3:50 PM, Antoine Pitrou wrote: > > Hello, > > Based on his work to diagnose and fix many issues related to OS X and/or > IDLE/tk, I would like to propose that we give Ned Deily commit rights. > He seems to already have developer rights on the tracker. > > Regards > > Antoine. > > > ___ > python-committers mailing list > python-committers@python.org > http://mail.python.org/mailman/listinfo/python-committers ___ python-committers mailing list python-committers@python.org http://mail.python.org/mailman/listinfo/python-committers
Re: [python-committers] Commit privileges for Eli Bendersky
+1 On Jan 8, 2011, at 6:11 PM, Raymond Hettinger wrote: > +1 > > > On Jan 8, 2011, at 3:09 PM, Terry Reedy wrote: > >> Two years ago, Eli Bendersky submitted to the tracker one of several >> duplicate reports about problems with difflib.SequenceMatcher. After I >> consolidated and closed all issues but one, he wrote me, said he wanted to >> get more involved in Python development, and offered to help with that and >> other issues. Since then he has actively participated in 34 issues, >> submitting 1 or more patches to 20 issues, listed below. Of those, 14 are >> closed. I believe his work always or nearly always contributed to the >> commit. Another has been committed to 3.2 and is only open for backports and >> possible tweaks. Another is waiting for 3.3, another for my response. His >> activity has covered core, library, and doc issues. He can work on C, >> Python, and .rst code and text He has shown himself to be a careful reader >> of both code and text. He has also participated a bit on pydev. >> >> I believe he said last September, in private email in response to my query, >> that he would like full developer privileges 'someday'. Before I reviewed >> his tracker activity, I was merely going to recommend that we 'start >> thinking about' a promotion. But then I discovered that he had done much I >> did not know about, as several developers (me, Alexander B, Georg B. Eric A, >> Michael F., ...) have done commits involving his patches. So I now think, >> 'why wait?' I am confident that he will start with whatever cautions he is >> given, with issues that are either trivial or that have been reviewed by >> others. >> >> http://bugs.python.org/issue9132 >> http://bugs.python.org/issue9282 >> http://bugs.python.org/issue9214 >> http://bugs.python.org/issue1397474 needs comment from me >> http://bugs.python.org/issue9323 >> http://bugs.python.org/issue9315 >> http://bugs.python.org/issue9317 open >> http://bugs.python.org/issue10439 >> http://bugs.python.org/issue10470 >> http://bugs.python.org/issue9222 >> http://bugs.python.org/issue10468 >> http://bugs.python.org/issue766910 open >> http://bugs.python.org/issue10534 >> http://bugs.python.org/issue10693 >> http://bugs.python.org/issue9312 >> http://bugs.python.org/issue9264 open for backport >> http://bugs.python.org/issue10461 >> http://bugs.python.org/issue10801 >> http://bugs.python.org/issue10516 waiting for 3.3 >> http://bugs.python.org/issue10594 >> -- >> Terry Jan Reedy >> ___ >> python-committers mailing list >> python-committers@python.org >> http://mail.python.org/mailman/listinfo/python-committers > > ___ > python-committers mailing list > python-committers@python.org > http://mail.python.org/mailman/listinfo/python-committers ___ python-committers mailing list python-committers@python.org http://mail.python.org/mailman/listinfo/python-committers
[python-committers] Partial commit privileges
Hi, The process to gain the commit priviledges is long, and it is sometimes difficult to decide if someone should have it or not. Would it be possible to have different "levels" of commit priviledes to simplify the process? Eg. first only be able to commit on a specific module, and then maybe more modules, to finally be able to commit everywhere. It doesn't need to be a technical limitation. The idea is to imply more people in the Python development and recognize their work. I remember that a rule to imply someone into the Python development is that we look for people in the long-term. Is the artial commit privilege compatible with this rule? What do you think? Would it be dangerous? As the current process, we should have mentors, maybe more than one mentor for one new developer. I would be happy to be the mentor of someone even if I don't have suggestion currently. Victor ___ python-committers mailing list python-committers@python.org http://mail.python.org/mailman/listinfo/python-committers
Re: [python-committers] Partial commit privileges
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/01/11 03:18, Victor Stinner wrote: > The process to gain the commit priviledges is long, and it is sometimes > difficult to decide if someone should have it or not. Would it be > possible to have different "levels" of commit priviledes to simplify the > process? Eg. first only be able to commit on a specific module, and then > maybe more modules, to finally be able to commit everywhere. It doesn't > need to be a technical limitation. I would say that mercurial deployment will change the workflow, and the difference between core committers and external developers will diffuse. - -- Jesus Cea Avion _/_/ _/_/_/_/_/_/ j...@jcea.es - http://www.jcea.es/ _/_/_/_/ _/_/_/_/ _/_/ jabber / xmpp:j...@jabber.org _/_/_/_/ _/_/_/_/_/ . _/_/ _/_/_/_/ _/_/ _/_/ "Things are not so easy" _/_/ _/_/_/_/ _/_/_/_/ _/_/ "My name is Dump, Core Dump" _/_/_/_/_/_/ _/_/ _/_/ "El amor es poner tu felicidad en la felicidad de otro" - Leibniz -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQCVAwUBTSkcH5lgi5GaxT1NAQI5KgP+MDJSDiMFO+MAnoIwn/sfgxIYG+BCX4Ox FfUwHSARXcPzOGoGely1zJGFWROF9wRdNygmNn7Jkbg2Xk8O3+aFl877oNOLvE8Y fhwUhlmVqp4CeWiLpFAm1PFdIDkXSzmxWIGc8SR3rcbSPrBVlk1bntbrKf5SdZ35 2OFVw743z+E= =Ee7X -END PGP SIGNATURE- ___ python-committers mailing list python-committers@python.org http://mail.python.org/mailman/listinfo/python-committers
Re: [python-committers] Commit rights for Ned Deily
+1. We will have another OS X developer. On Sun, Jan 9, 2011 at 8:52 AM, Raymond Hettinger wrote: > +1 > > On Jan 8, 2011, at 3:50 PM, Antoine Pitrou wrote: > >> >> Hello, >> >> Based on his work to diagnose and fix many issues related to OS X and/or >> IDLE/tk, I would like to propose that we give Ned Deily commit rights. >> He seems to already have developer rights on the tracker. >> >> Regards >> >> Antoine. >> >> >> ___ >> python-committers mailing list >> python-committers@python.org >> http://mail.python.org/mailman/listinfo/python-committers > > ___ > python-committers mailing list > python-committers@python.org > http://mail.python.org/mailman/listinfo/python-committers > -- Senthil ___ python-committers mailing list python-committers@python.org http://mail.python.org/mailman/listinfo/python-committers
Re: [python-committers] Partial commit privileges
On 1/8/2011 9:18 PM, Victor Stinner wrote: > Hi, > > The process to gain the commit priviledges is long, and it is sometimes > difficult to decide if someone should have it or not. Would it be > possible to have different "levels" of commit priviledes to simplify the > process? Eg. first only be able to commit on a specific module, and then > maybe more modules, to finally be able to commit everywhere. It doesn't > need to be a technical limitation. 'Limited' privileges have been granted in the past, especially with GSOC students. The 'limit' is by agreement (and the fact that all commits are public to python-checkins subscribers. Last summer, Guido discovered that the real problem is not overuse of privileges, but underuse. Some people have be given commit access and never used it. As a neophytes, I can imagine that some are too scared of making an embarrassing mistake. > The idea is to [involve] more people in the Python development and recognize > their work. Until we start fighting over a limited supply of issues, we can use a few more ;-)/ > I would be happy to be the mentor of someone even if I don't have > suggestion currently. In general, I believe more mentoring could be useful. Possible suggestion: find someone without commit access who has submitted a patch for an issue of interest to you that you think should get a committed patch. Review it and as necessary help the person improve it until you think it ready to commit. (You could even ask if they want that or really want someone to take it over from them.) Then commit it. Or help a new person *with* access and let (help) them commit it. --- Terry Jan Reedy ___ python-committers mailing list python-committers@python.org http://mail.python.org/mailman/listinfo/python-committers
Re: [python-committers] Partial commit privileges
On Sun, Jan 9, 2011 at 12:18 PM, Victor Stinner wrote: > Hi, > > The process to gain the commit priviledges is long, and it is sometimes > difficult to decide if someone should have it or not. Would it be > possible to have different "levels" of commit priviledes to simplify the > process? Eg. first only be able to commit on a specific module, and then > maybe more modules, to finally be able to commit everywhere. It doesn't > need to be a technical limitation. > > The idea is to imply more people in the Python development and recognize > their work. > > I remember that a rule to imply someone into the Python development is > that we look for people in the long-term. Is the artial commit privilege > compatible with this rule? > > What do you think? Would it be dangerous? Trust-but-audit is a good way to handle that, and really matches what we already do (my initial privileges years ago were specifically to update PEP 343 when Guido didn't have time to revise it, then I branched out from there into other things over time). As Terry noted, knowing that every checkin you make is going to get dumped in a whole pile of inboxes and posted publicly on the internet makes most sane people a little nervous and keen to do the right thing :) The main thing is for an existing committer to notice someone's contributions and then volunteer to mentor them through the initial process and keep an eye on their initial checkins. Cheers, Nick. -- Nick Coghlan | ncogh...@gmail.com | Brisbane, Australia ___ python-committers mailing list python-committers@python.org http://mail.python.org/mailman/listinfo/python-committers