Re: [python-committers] mention-bot is dead, long live the (misnamed) CODEOWNERS file!

[Brett Cannon]

On Wed, 2 Aug 2017 at 16:01 Steve Dower  wrote:

> Should we seed the teams from the experts list?
>

I thought about it and decided not to because (a) the experts list is keyed
on bugs.python.org account names and so I didn't want to have to look up
details, (b) this is much more automated than being manually nosied on an
issue and so people might not want as much GH notification traffic as
compared to issues, (c) I didn't want to botch the file path rules for
someone by improperly assuming what people wanted to be notified on, (d) I
don't wanna spend the time to do it when we all can edit the CODEOWNERS
file easily enough. :)

-Brett


>
>
> I have no strong opinion about core vs non-core dev, but I think part of
> the point of the distinction is reflected here. Why would we notify someone
> about every PR in an area if we don’t want them to be committers?
>
>
>
> Top-posted from my Windows phone
>
>
>
> *From: *Terry Reedy 
> *Sent: *Wednesday, August 2, 2017 11:21
> *To: *python-committers@python.org
> *Subject: *Re: [python-committers] mention-bot is dead,long live the
> (misnamed) CODEOWNERS file!
>
>
>
> On 8/2/2017 10:37 AM, Nick Coghlan wrote:
>
> > On 2 August 2017 at 07:09, Christian Heimes 
> wrote:
>
> >> I suggested teams to make the file a bit easier to maintain. The rule
>
> >> format works differently than the old mentionbot format. In the old
>
> >> format we had a relationship user -> files. The new CODEOWNERS format
>
> >> has files -> users mapping with last rules trumps all semantic. We have
>
> >> to be careful to not override parts of a previous rules. I believe teams
>
> >> reduce the burden.
>
> >
>
> > +1 for setting up teams, and +1 for an importlib-team :)
>
>
>
> Do people on a team have to be core-developers?
>
>
>
> Terry
>
>
>
> ___
>
> python-committers mailing list
>
> python-committers@python.org
>
> https://mail.python.org/mailman/listinfo/python-committers
>
> Code of Conduct: https://www.python.org/psf/codeofconduct/
>
>
> ___
> python-committers mailing list
> python-committers@python.org
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/
>
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] mention-bot is dead, long live the (misnamed) CODEOWNERS file!

[Brett Cannon]

On Wed, 2 Aug 2017 at 11:20 Terry Reedy  wrote:

> On 8/2/2017 10:37 AM, Nick Coghlan wrote:
> > On 2 August 2017 at 07:09, Christian Heimes 
> wrote:
> >> I suggested teams to make the file a bit easier to maintain. The rule
> >> format works differently than the old mentionbot format. In the old
> >> format we had a relationship user -> files. The new CODEOWNERS format
> >> has files -> users mapping with last rules trumps all semantic. We have
> >> to be careful to not override parts of a previous rules. I believe teams
> >> reduce the burden.
> >
> > +1 for setting up teams, and +1 for an importlib-team :)
>
> Do people on a team have to be core-developers?
>

To be part of a team, yes. To just be manually listed, I don't think so.
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] mention-bot is dead, long live the (misnamed) CODEOWNERS file!

[Steve Dower]

On 02Aug2017 2001, Terry Reedy wrote:
On Wed, Aug 2, 2017 at 2:47 PM, Steve Dower > wrote:



I have no strong opinion about core vs non-core dev, but I think
part of the point of the distinction is reflected here. Why would we
notify someone about every PR in an area if we don’t want them to be
committers?


I not sure what 'them' you are speaking of.  I am thinking about active 
contributors who are potential committers.  Part of becoming a committer 
is demonstrating the ability to do committer-qualify reviews.


Agreed, and perhaps this is similar to when we give someone triage 
permissions on b.p.o without making them a committer?


My thoughts here are:
* would we add someone to the codeowners file who *hadn't* demonstrated 
the ability to do committer-quality reviews?
* if someone has demonstrated the ability to do committer-quality 
reviews, why aren't they made a committer?


I think the answer to the first is clearly no, but the answer to the 
second is more complicated, which is why we probably will end up 
treating this as "you've demonstrated useful reviews already so here's a 
way to help you demonstrate more until we decide to also let you click 
merge".


Cheers,
Steve
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Please edit the commit message when merge a PR

[Serhiy Storchaka]

11.07.17 19:39, Brett Cannon пише:
There's isn't a way to block a merge at that stage. But one thing I've 
been thinking about is adding a check to Bedevere post-merge that sees 
if the commit message was left unchanged (not quite sure  if I can come 
up with a reliable heuristic, though). In instances where the committers 
forgot, Bedevere would simply leave a message saying something like, 
"Hey, thanks for taking the time to merge a PR, but please don't forget 
to clean up the commit message before merging." Basically a friendly 
reminder to not forget next time (I'm also thinking of doing something 
similar for the formatting of the PR title after merging).


+1 for adding a post-merge check and a friendly reminder. I still see 
merged commits containing messages from all intermediate changes. I'm 
afraid that it would be rough from my side to remind about this every 
time, but the bot is impartial.


___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/