[issue28686] py.exe ignored PATH when using python3 shebang

2022-02-04 Thread Segev Finer


Change by Segev Finer :


--
nosy: +Segev Finer

___
Python tracker 
<https://bugs.python.org/issue28686>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39010] ProactorEventLoop raises unhandled ConnectionResetError

2020-04-26 Thread Segev Finer


Change by Segev Finer :


--
nosy: +Segev Finer

___
Python tracker 
<https://bugs.python.org/issue39010>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34478] Possibly misleading/wrong documentation about PyModuleDef.m_free

2018-08-23 Thread Segev Finer


New submission from Segev Finer :

This section in the documentation 
https://docs.python.org/3.7/howto/cporting.html#module-initialization-and-state 
shows how to implement an extension module that works for both Python 2 and 3. 
It also shows how to use m_size to manage module state instead of using static 
globals. But it omits implementing m_free. This is also done in 
https://www.python.org/dev/peps/pep-3121/#example

To my understanding, m_clear is *only* called by the Python GC when the object 
is a part of a reference cycle. It won't be called for a normal free when the 
object wasn't a part of a reference cycle. This means that for such a case the 
objects referenced in the state structure will leak!

Looking around the standard library, it seems the extension modules there point 
m_free to calling the function used to implement m_clear.

The documentation of the structure is also quite unclear on the subject 
https://docs.python.org/3/c-api/module.html?highlight=pymoduledef#c.PyModuleDef.

P.S. There is also no freeing/DECREF-ing stuff in the state on error in the 
Python 2 case, but I think even the standard library is like this.

--
assignee: docs@python
components: Documentation
messages: 323955
nosy: Segev Finer, docs@python
priority: normal
severity: normal
status: open
title: Possibly misleading/wrong documentation about PyModuleDef.m_free
type: enhancement
versions: Python 3.7, Python 3.8

___
Python tracker 
<https://bugs.python.org/issue34478>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34283] [Windows] Python 2 mishandles console code page after setlocale

2018-07-30 Thread Segev Finer


Change by Segev Finer :


--
title: Python 2 mishandles console code page after setlocale -> [Windows] 
Python 2 mishandles console code page after setlocale

___
Python tracker 
<https://bugs.python.org/issue34283>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34283] Python 2 mishandles console code page after setlocale

2018-07-30 Thread Segev Finer

New submission from Segev Finer :

Found by trying to use pip: https://github.com/pypa/pip/issues/5665.

This is likely affected by the console code page.

Python version: 2.7.15 64 bit
OS: Windows 10.0.17134.165 x64
The console locale is set to cp872.
The console font is consolas.

Apparently, msvcrt does charset conversion when writing to its file descriptors 
based on the set locale! and it's even special cased to handle the OEM console 
code page (You can see this in crt/src/write.c:_write_nolock if you have MSVC 
2008).

When the "C" locale is set, no conversion is done. Python encodes to the OEM 
code page, and it passes through to the console unscathed. But once you do 
setlocale than the CRT expects you to use the ANSI code page, but Python will 
be encoding to the OEM code page which will result in this error from fwrite.

file.encoding in Python 2 is also not settable directly from Python (C API 
only), it's only used for stdio and set internally on startup: 
Python/pythonrun.c:349-378.

I found this describing this: Why printf can display non-ASCII characters when 
“C” locale is used?.

#!/usr/bin/env python2
from __future__ import print_function
import locale

print(u' |\u2588')  # Works
locale.setlocale(locale.LC_ALL, '')
print(u' |\u2588')  # IOError: [Errno 42] Illegal byte sequence

--
components: Windows
messages: 322683
nosy: Segev Finer, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: Python 2 mishandles console code page after setlocale
type: behavior
versions: Python 2.7

___
Python tracker 
<https://bugs.python.org/issue34283>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34274] Python launcher behavior with "#!/usr/bin/env python" shebang

2018-07-29 Thread Segev Finer


New submission from Segev Finer :

When using the common "#!/usr/bin/env python" shebang, recent versions of the 
Python launcher will search the PATH for "python" as specified in the shebang.

But Python on Windows installs as python.exe for all versions, both 2 and 3. So 
in a PC where Python 3 is first on PATH, this shebang will choose Python 3. 
That's in contrast to any other shebang like "#!python" or "#!/usr/bin/python" 
which will prefer Python 2.

That's rather subtle and confusing...

To the best of my knowledge most Linux distros still install Python 2 as python 
and Python 3 as python3 (I think that's in the Makefile too). But of course 
there might also be distros that install python3 as python.

--
title: Python launcher behavior with /usr/bin/env python shebang -> Python 
launcher behavior with "#!/usr/bin/env python" shebang

___
Python tracker 
<https://bugs.python.org/issue34274>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34274] Python launcher behavior with /usr/bin/env python shebang

2018-07-29 Thread Segev Finer


Change by Segev Finer :


--
components: Windows
nosy: Segev Finer, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: Python launcher behavior with /usr/bin/env python shebang
type: behavior
versions: Python 3.7

___
Python tracker 
<https://bugs.python.org/issue34274>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34267] find_python.bat doesn't find installed Python 3.7

2018-07-28 Thread Segev Finer


New submission from Segev Finer :

The PCbuild/find_python.bat script doesn't find an installed Python 3.7 and 
will proceed to download Python using nuget.

This is caused by it invoking py with "-3.6" which will only find Python 3.6 
(py doesn't seem to support a 3.6 or above flag), despite the fact that the 
build can use 3.7 and the nuget fallback will install 3.7.

--
components: Windows
messages: 322597
nosy: Segev Finer, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: find_python.bat doesn't find installed Python 3.7
type: behavior
versions: Python 3.7, Python 3.8

___
Python tracker 
<https://bugs.python.org/issue34267>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32814] smtplib.send_message mishandles 8BITMIME RFC 6152

2018-07-28 Thread Segev Finer


Segev Finer  added the comment:

@scorphus Note that I made a PR for this: PR 8303

--

___
Python tracker 
<https://bugs.python.org/issue32814>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32814] smtplib.send_message mishandles 8BITMIME RFC 6152

2018-07-26 Thread Segev Finer


Segev Finer  added the comment:

Merged into the PR that is.

--

___
Python tracker 
<https://bugs.python.org/issue32814>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32814] smtplib.send_message mishandles 8BITMIME RFC 6152

2018-07-26 Thread Segev Finer


Segev Finer  added the comment:

> OK, the #32663 test fix I mentioned in the review is merged.

Yeah. I already merged it in.

--

___
Python tracker 
<https://bugs.python.org/issue32814>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32663] SMTPUTF8SimTests are not actually being run

2018-07-25 Thread Segev Finer


Change by Segev Finer :


--
nosy: +Segev Finer

___
Python tracker 
<https://bugs.python.org/issue32663>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34167] Standard library docs: prev/next skip right over 16.11

2018-07-24 Thread Segev Finer


Segev Finer  added the comment:

I think the prev/next links link to the previous/next document while 16.11 is 
in the same document as 16.10 at the bottom.

--
nosy: +Segev Finer

___
Python tracker 
<https://bugs.python.org/issue34167>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33808] ssl.get_server_certificate fails with openssl 1.1.0 but works with 1.0.2g for self-signed certificate

2018-07-19 Thread Segev Finer


Segev Finer  added the comment:

Even if the server is outdated and the SSL library doesn't support it anymore, 
that's a poor exception to raise for such an error...

Sadly I'm not able to access the affected server to reproduce and debug why it 
raises such a poor exception.

--
nosy: +Segev Finer -Alan.Huang

___
Python tracker 
<https://bugs.python.org/issue33808>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32814] smtplib.send_message mishandles 8BITMIME RFC 6152

2018-07-16 Thread Segev Finer


Change by Segev Finer :


--
keywords: +patch
pull_requests: +7837
stage:  -> patch review

___
Python tracker 
<https://bugs.python.org/issue32814>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34091] REPL does not work in msys2, ConEmu terminals on windows

2018-07-13 Thread Segev Finer


Segev Finer  added the comment:

I'd assume this is using ConEmu's ChildGui which means it hacks up a MinTTY 
window to appear inside ConEmu's GUI. MinTTY doesn't use a real terminal but 
rather pipes as the processes stdio. Any native (non-MSYS2) Windows program 
would have a problem with this.

The known workaround is to launch such programs using WinPTY (Available in the 
MSYS2 pacman), which creates a real console for the program in the background 
and communicates it's input/output so that it appear in the original console.

Sadly that is a limitation of Windows, as Windows does not supply a proper PTY 
interface and MSYS2/MinTTY choose not to use something like WinPTY by default.

--
nosy: +Segev Finer

___
Python tracker 
<https://bugs.python.org/issue34091>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29672] `catch_warnings` context manager causes all warnings to be printed every time, even after exiting

2018-07-10 Thread Segev Finer


Change by Segev Finer :


--
keywords: +patch
pull_requests: +7769
stage:  -> patch review

___
Python tracker 
<https://bugs.python.org/issue29672>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29672] `catch_warnings` context manager causes all warnings to be printed every time, even after exiting

2018-07-10 Thread Segev Finer


Segev Finer  added the comment:

Hmm, I originally missed the per module __warningregistry__... Need to read the 
code more closely...

What should the behavior be? We can add a flag that will make all warning 
actions be "always" when catch_warnings is in effect. But that doesn't feel 
right with the way catch_warnings currently behaves or what is expected of it.

Another idea would be to add a callback that is called whenever we set a module 
registry, allowing catch_warnings to backup the original registry of each 
module and restore them all on exit (Also the _onceregistry and 
_filters_version).

--

___
Python tracker 
<https://bugs.python.org/issue29672>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32245] OSError: raw write() returned invalid length on latest Win 10 Consoles

2018-07-09 Thread Segev Finer


Segev Finer  added the comment:

This should be fixed by the Windows 10 April Update (build 1803) according to 
https://github.com/Microsoft/vscode/issues/36630.

--

___
Python tracker 
<https://bugs.python.org/issue32245>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32818] multiprocessing segmentfault under Windows compatibility mode

2018-03-01 Thread Segev Finer

Change by Segev Finer <segev...@gmail.com>:


--
keywords: +patch
pull_requests: +5716
stage:  -> patch review

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue32818>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32818] multiprocessing segmentfault under Windows compatibility mode

2018-03-01 Thread Segev Finer

Segev Finer <segev...@gmail.com> added the comment:

Windows seems to dereference lpStartupInfo->lpAttributeList, despite it being 
NULL since we had no attributes to set. Smells like a Windows bug in the 
compatibility shim, since it doesn't crash in non compatibility mode.

Not setting EXTENDED_STARTUPINFO_PRESENT when lpStartupInfo->lpAttributeList is 
NULL will fix this. Not sure about lpStartupInfo->cb, I think Windows only 
checks it's large enough.

Also attached is a crash dump with symbols and used source revision of a 
reproduction of this.

Stack Trace:
00 00fee690 5ad47c1c 
AcLayers!NS_ElevateCreateProcess::APIHook_CreateProcessW+0x110
01 00fee740 5ad45f79 python38_d!_winapi_CreateProcess_impl+0x15c 
[cpython\modules\_winapi.c @ 1046]
02 00fee798 5ad78e75 python38_d!_winapi_CreateProcess+0x79 
[cpython\modules\clinic\_winapi.c.h @ 326]
03 00fee7f8 5ad77b64 python38_d!_PyMethodDef_RawFastCallKeywords+0x245 
[cpython\objects\call.c @ 651]
04 00fee81c 5aed8f9f python38_d!_PyCFunction_FastCallKeywords+0x84 
[cpython\objects\call.c @ 730]
05 00fee854 5aee038f python38_d!call_function+0x15f [cpython\python\ceval.c @ 
4532]
06 00fee8f4 5ad7b336 python38_d!_PyEval_EvalFrameDefault+0x59bf 
[cpython\python\ceval.c @ 3128]
07 00fee92c 5ad77ce4 python38_d!function_code_fastcall+0xe6 
[cpython\objects\call.c @ 283]
08 00fee994 5ad79be7 python38_d!_PyFunction_FastCallDict+0x134 
[cpython\objects\call.c @ 322]
09 00fee9d8 5ad79aa6 python38_d!_PyObject_FastCallDict+0xc7 
[cpython\objects\call.c @ 98]
0a 00feea14 5ae0b8f7 python38_d!_PyObject_Call_Prepend+0xf6 
[cpython\objects\call.c @ 904]
0b 00feea50 5ae10a97 python38_d!slot_tp_init+0x47 [cpython\objects\typeobject.c 
@ 6597]
0c 00feea74 5ad7a28e python38_d!type_call+0x187 [cpython\objects\typeobject.c @ 
949]
0d 00feeae0 5aed91d1 python38_d!_PyObject_FastCallKeywords+0x37e 
[cpython\objects\call.c @ 199]
0e 00feeb18 5aedc95b python38_d!call_function+0x391 [cpython\python\ceval.c @ 
4576]

--
Added file: https://bugs.python.org/file47465/crash32818.zip

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue32818>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32370] Wrong ANSI encoding used by subprocess for some locales

2018-02-10 Thread Segev Finer

Change by Segev Finer <segev...@gmail.com>:


--
versions: +Python 3.8

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue32370>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32370] Wrong ANSI encoding used by subprocess for some locales

2018-02-10 Thread Segev Finer

Change by Segev Finer <segev...@gmail.com>:


--
keywords: +patch
pull_requests: +5418
stage:  -> patch review

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue32370>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32815] Document text parameter to subprocess.Popen

2018-02-10 Thread Segev Finer

New submission from Segev Finer <segev...@gmail.com>:

The new text parameter in subprocess was documented for subprocess.run but not 
for subprocess.Popen in the Sphinx documentation. It is documented in the 
docstring for both though.

--
assignee: docs@python
components: Documentation
messages: 311949
nosy: Segev Finer, docs@python
priority: normal
severity: normal
status: open
title: Document text parameter to subprocess.Popen
type: enhancement
versions: Python 3.7

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue32815>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32814] smtplib.send_message mishandles 8BITMIME RFC 6152

2018-02-10 Thread Segev Finer

New submission from Segev Finer <segev...@gmail.com>:

According to https://tools.ietf.org/html/rfc6152 you should only send an 8bit 
email body when the server advertises 8BITMIME in the EHLO, and you should 
declare it with BODY=8BITMIME in the MAIL command.

The default cte_type is 8bit for the new default email policy which is what 
will be used by smtplib.send_message when it calls BytesGenerator.flatten, but 
it will not set BODY=8BITMIME even if the message has any 8-bit characters. It 
will only set BODY=8BITMIME if the message uses any utf-8 mail/from addresses. 
This means that a message with ASCII addresses and an 8-bit utf-8 body will be 
sent without BODY=8BITMIME (I think that's actually quite common).

What should be done is checking if the server advertises 8BITMIME, and if it 
doesn't use cte_type=7bit; if it does we should set BODY=8BITMIME if the policy 
is using cte_type=8bit.

I don't know whether any real email server chokes on this. But it's best to 
follow the RFC, I think.

--
components: Library (Lib), email
messages: 311947
nosy: Segev Finer, barry, r.david.murray
priority: normal
severity: normal
status: open
title: smtplib.send_message mishandles 8BITMIME RFC 6152
type: behavior
versions: Python 3.5, Python 3.6, Python 3.7, Python 3.8

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue32814>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30121] Windows: subprocess debug assertion on failure to execute the process

2018-01-09 Thread Segev Finer

Change by Segev Finer <segev...@gmail.com>:


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue30121>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32524] Python 2.7 leaks a packages __init__.py module object on SyntaxError

2018-01-09 Thread Segev Finer

Change by Segev Finer <segev...@gmail.com>:


--
keywords: +patch
pull_requests: +5001
stage:  -> patch review

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue32524>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32524] Python 2.7 leaks a packages __init__.py module object on SyntaxError

2018-01-09 Thread Segev Finer

New submission from Segev Finer <segev...@gmail.com>:

With the file hello/__init__.py:

ham = 123
spam()spam()

I get the following:

Python 2.7.14 (v2.7.14:84471935ed, Sep 16 2017, 20:19:30) [MSC v.1500 32 
bit (Intel)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import hello
Traceback (most recent call last):
  File "", line 1, in 
  File "hello\__init__.py", line 2
spam()spam()
 ^
SyntaxError: invalid syntax
>>> import hello
>>> print hello

>>> print dir(hello)
['__doc__', '__file__', '__name__', '__package__', '__path__']
>>>

I'd expect to get the SyntaxError twice, which is indeed what happens on at 
least Python 3.6 (Possibly earlier Python 3 versions).

Originally found here https://github.com/pallets/flask/issues/2423 & 
https://github.com/pallets/flask/pull/2588

I'm going to submit a PR with a fix.

--
components: Interpreter Core
messages: 309736
nosy: Segev Finer
priority: normal
severity: normal
status: open
title: Python 2.7 leaks a packages __init__.py module object on SyntaxError
type: behavior
versions: Python 2.7

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue32524>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18035] telnetlib incorrectly assumes that select.error has an errno attribute

2017-12-29 Thread Segev Finer

Change by Segev Finer <segev...@gmail.com>:


--
keywords: +patch
pull_requests: +4925
stage:  -> patch review

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue18035>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32370] Wrong ANSI encoding used by subprocess for some locales

2017-12-18 Thread Segev Finer

New submission from Segev Finer <segev...@gmail.com>:

The following test is failing randomly for me (python -m test test_uuid -v):
==
ERROR: test_ipconfig_getnode (test.test_uuid.TestInternalsWithoutExtModule)
--
Traceback (most recent call last):
  File "cpython\lib\test\test_uuid.py", line 551, in test_ipconfig_getnode
node = self.uuid._ipconfig_getnode()
  File "cpython\lib\uuid.py", line 487, in _ipconfig_getnode
for line in pipe:
  File "cpython\lib\encodings\cp1255.py", line 23, in decode
return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x8d in position 682: 
character maps to 

This is caused by trying to decode the output of "ipconfig" using cp1255, while 
the output really uses cp862 and annoyingly it started to print times using the 
current locale (Which displays broken in the console anyhow, question mark 
boxes... *sigh*) in some Windows version (Using Windows 10.0.16299 ATM).

--
components: Windows
messages: 308597
nosy: Segev Finer, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: Wrong ANSI encoding used by subprocess for some locales
type: behavior
versions: Python 3.7

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue32370>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32245] OSError: raw write() returned invalid length on latest Win 10 Consoles

2017-12-18 Thread Segev Finer

Segev Finer <segev...@gmail.com> added the comment:

Upstream issue https://github.com/Microsoft/console/issues/40, also has links 
to similar issues this caused in other projects.

--
nosy: +Segev Finer

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue32245>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19764] subprocess: use PROC_THREAD_ATTRIBUTE_HANDLE_LIST with STARTUPINFOEX on Windows Vista

2017-12-16 Thread Segev Finer

Segev Finer <segev...@gmail.com> added the comment:

The PR has been sitting there for quite a while now...

--

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue19764>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29843] errors raised by ctypes.Array for invalid _length_ attribute

2017-09-29 Thread Segev Finer

Change by Segev Finer <segev...@gmail.com>:


--
pull_requests: +3805

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue29843>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31634] Consider installing wheel in ensurepip by default

2017-09-29 Thread Segev Finer

Change by Segev Finer <segev...@gmail.com>:


--
keywords: +patch
pull_requests: +3802
stage:  -> patch review

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue31634>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31634] Consider installing wheel in ensurepip by default

2017-09-29 Thread Segev Finer

New submission from Segev Finer <segev...@gmail.com>:

wheel is quite prevalent nowadays. ensurepip even uses wheels of pip & 
setuptools itself. Installing wheel by default will bestow the following 
benefits:

1. pip's wheel cache will be enabled by default.
2. Users will be able to run setup.py bdist_wheel. Put simply, they will be 
able to build wheels.
3. Users will have access to the wheel command by default.

All those benefits will also apply in any created venv (Via the standard venv 
package). The external virtualenv package already does this 
https://github.com/pypa/virtualenv/tree/master/virtualenv_support. I often find 
myself installing wheel manually in any venv I create.

It shouldn't be too difficult to do, but it probably needs some agreement 
before being done.

--
components: Library (Lib)
messages: 303317
nosy: Segev Finer
priority: normal
severity: normal
status: open
title: Consider installing wheel in ensurepip by default
type: enhancement
versions: Python 2.7, Python 3.4, Python 3.5, Python 3.6, Python 3.7, Python 3.8

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue31634>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31328] _sha3 is missing from Setup.dist

2017-09-04 Thread Segev Finer

Changes by Segev Finer <segev...@gmail.com>:


--
pull_requests: +3324

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue31328>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31328] _sha3 is missing from Setup.dist

2017-09-01 Thread Segev Finer

Changes by Segev Finer <segev...@gmail.com>:


--
pull_requests: +3311

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue31328>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31328] _sha3 is missing from Setup.dist

2017-09-01 Thread Segev Finer

New submission from Segev Finer:

_sha3 is missing a commented out line from Setup.dist like the rest of the 
modules. It's really only used if someone wants to edit Setup.dist to build 
with the _sha3 module statically. Mostly a trivial change to add it in.

--
components: Build, Extension Modules
messages: 301144
nosy: Segev Finer
priority: normal
severity: normal
status: open
title: _sha3 is missing from Setup.dist
type: behavior
versions: Python 3.6, Python 3.7

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue31328>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue9566] Compilation warnings under x64 Windows

2017-08-18 Thread Segev Finer

Changes by Segev Finer <segev...@gmail.com>:


--
pull_requests: +3174

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue9566>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30747] _Py_atomic_* not actually atomic on Windows with MSVC

2017-08-18 Thread Segev Finer

Changes by Segev Finer <segev...@gmail.com>:


--
pull_requests: +3175

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30747>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue16865] ctypes arrays >=2GB in length causes exception

2017-08-05 Thread Segev Finer

Changes by Segev Finer <segev...@gmail.com>:


--
pull_requests: +3040

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue16865>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue26618] _overlapped extension module of asyncio uses deprecated WSAStringToAddressA() function

2017-08-04 Thread Segev Finer

Segev Finer added the comment:

It was fixed here: 
https://github.com/python/cpython/commit/cc16be85c0b7119854c00fb5c666825deef641cf#diff-1308fc2ab05154373172f10e931c78f0L986.
 So it's fixed for 3.6 and 3.7, but not in 3.5.

--
nosy: +Segev Finer

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue26618>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31078] pdb's debug command (Pdb.do_debug) doesn't use rawinput even if the parent pdb uses rawinput

2017-07-29 Thread Segev Finer

Changes by Segev Finer <segev...@gmail.com>:


--
pull_requests: +2996

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue31078>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue9325] Add an option to pdb/trace/profile to run library module as a script

2017-07-29 Thread Segev Finer

Changes by Segev Finer <segev...@gmail.com>:


--
nosy: +Segev Finer

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue9325>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31078] pdb's debug command (Pdb.do_debug) doesn't use rawinput even if the parent pdb uses rawinput

2017-07-29 Thread Segev Finer

New submission from Segev Finer:

This is caused by 
https://github.com/python/cpython/blob/caa1280d1ee5f828f346b585169a7592371d3faa/Lib/pdb.py#L1096
 which always passes our own current stdin and stdout, and this triggers the 
conditional in 
https://github.com/python/cpython/blob/caa1280d1ee5f828f346b585169a7592371d3faa/Lib/pdb.py#L144-L145.

self.stdin and self.stdout are initialized to sys.stdin and sys.stdout 
respectively when not passed explicitly: 
https://github.com/python/cpython/blob/caa1280d1ee5f828f346b585169a7592371d3faa/Lib/cmd.py#L87-L94.

See Also: https://github.com/ipython/ipython/pull/10721

--
components: Library (Lib)
messages: 299485
nosy: Segev Finer
priority: normal
severity: normal
status: open
title: pdb's debug command (Pdb.do_debug) doesn't use rawinput even if the 
parent pdb uses rawinput
type: behavior
versions: Python 2.7, Python 3.5, Python 3.6, Python 3.7

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue31078>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue9566] Compilation warnings under x64 Windows

2017-07-27 Thread Segev Finer

Segev Finer added the comment:

The only warnings that remain are:

1. The one from gcmodule.c due to dtrace, which is handled in PR 2852.
2. The peephole warnings which I'm not sure about. Are overflows possible there 
or not? That is, if there are already internal caps that prevent them. If they 
are possible, it might require a larger change to support EXTENDED_ARG in some 
places. i.e. can the consts table really grow larger than `unsigned int` or can 
a jump target be large enough to overflow?

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue9566>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30222] make_zip.py had a bug when setting up full 64 bit distribution.

2017-07-27 Thread Segev Finer

Segev Finer added the comment:

Since PR 2750 is merged, I think this can be closed.

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30222>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31048] ResourceWarning in test_asyncio.test_events.ProactorEventLoopTests.test_create_server_ssl_verify_failed

2017-07-27 Thread Segev Finer

Changes by Segev Finer <segev...@gmail.com>:


--
pull_requests: +2973

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue31048>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31048] ResourceWarning in test_asyncio.test_events.ProactorEventLoopTests.test_create_server_ssl_verify_failed

2017-07-27 Thread Segev Finer

Changes by Segev Finer <segev...@gmail.com>:


--
title: ResourceWarning in 
test_asyncio.test_events..ProactorEventLoopTests.test_create_server_ssl_verify_failed
 -> ResourceWarning in 
test_asyncio.test_events.ProactorEventLoopTests.test_create_server_ssl_verify_failed

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue31048>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31048] ResourceWarning in test_asyncio.test_events..ProactorEventLoopTests.test_create_server_ssl_verify_failed

2017-07-27 Thread Segev Finer

Changes by Segev Finer <segev...@gmail.com>:


--
components: +asyncio
nosy: +yselivanov

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue31048>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue9566] Compilation warnings under x64 Windows

2017-07-26 Thread Segev Finer

Segev Finer added the comment:

@haypo https://github.com/python/cpython/pull/2904

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue9566>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue9566] Compilation warnings under x64 Windows

2017-07-26 Thread Segev Finer

Changes by Segev Finer <segev...@gmail.com>:


--
pull_requests: +2955

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue9566>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30916] Pre-build OpenSSL and Tcl/Tk for Windows

2017-07-26 Thread Segev Finer

Changes by Segev Finer <segev...@gmail.com>:


--
pull_requests: +2953

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30916>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31048] ResourceWarning in test_asyncio.test_events..ProactorEventLoopTests.test_create_server_ssl_verify_failed

2017-07-26 Thread Segev Finer

New submission from Segev Finer:

>python -X tracemalloc=30 -m unittest 
>test.test_asyncio.test_events.ProactorEventLoopTests.test_create_server_ssl_verify_failed
Running Debug|x64 interpreter...
lib\asyncio\sslproto.py:330: ResourceWarning: unclosed transport 

  source=self)
Object allocated at (most recent call first):
  File "lib\asyncio\sslproto.py", lineno 435
self, self._app_protocol)
  File "lib\asyncio\proactor_events.py", lineno 401
server_side, server_hostname)
  File "lib\asyncio\proactor_events.py", lineno 507
extra={'peername': addr}, server=server)
  File "lib\asyncio\events.py", lineno 122
self._callback(*self._args)
  File "lib\asyncio\base_events.py", lineno 1413
handle._run()
  File "lib\asyncio\base_events.py", lineno 420
self._run_once()
  File "lib\asyncio\base_events.py", lineno 453
self.run_forever()
  File "lib\test\test_asyncio\test_events.py", lineno 1099
self.loop.run_until_complete(f_c)
  File "lib\unittest\case.py", lineno 615
testMethod()
  File "lib\unittest\case.py", lineno 663
return self.run(*args, **kwds)
  File "lib\unittest\suite.py", lineno 122
test(result)
  File "lib\unittest\suite.py", lineno 84
return self.run(*args, **kwds)
  File "lib\unittest\suite.py", lineno 122
test(result)
  File "lib\unittest\suite.py", lineno 84
return self.run(*args, **kwds)
  File "lib\unittest\runner.py", lineno 176
test(result)
  File "lib\unittest\main.py", lineno 256
self.result = testRunner.run(self.test)
  File "lib\unittest\main.py", lineno 95
self.runTests()
  File "lib\unittest\__main__.py", lineno 18
main(module=None)
  File "lib\runpy.py", lineno 85
exec(code, run_globals)
  File "lib\runpy.py", lineno 193
"__main__", mod_spec)
.
--
Ran 1 test in 1.408s

OK

--
components: Tests, Windows
messages: 299256
nosy: Segev Finer, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: ResourceWarning in 
test_asyncio.test_events..ProactorEventLoopTests.test_create_server_ssl_verify_failed
type: resource usage
versions: Python 3.7

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue31048>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue9566] Compilation warnings under x64 Windows

2017-07-26 Thread Segev Finer

Changes by Segev Finer <segev...@gmail.com>:


--
pull_requests: +2942

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue9566>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31018] _tracemalloc frame_t packing optimization not working in Windows x64

2017-07-25 Thread Segev Finer

Changes by Segev Finer <segev...@gmail.com>:


--
pull_requests: +2919

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue31018>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31018] _tracemalloc frame_t packing optimization not working in Windows x64

2017-07-25 Thread Segev Finer

Changes by Segev Finer <segev...@gmail.com>:


--
pull_requests: +2920

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue31018>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue9566] Compilation warnings under x64 Windows

2017-07-24 Thread Segev Finer

Changes by Segev Finer <segev...@gmail.com>:


--
pull_requests: +2902

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue9566>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31018] _tracemalloc frame_t packing optimization not working in Windows x64

2017-07-24 Thread Segev Finer

Changes by Segev Finer <segev...@gmail.com>:


--
pull_requests: +2897

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue31018>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31018] _tracemalloc frame_t packing optimization not working in Windows x64

2017-07-24 Thread Segev Finer

Changes by Segev Finer <segev...@gmail.com>:


--
pull_requests:  -2896

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue31018>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31018] _tracemalloc frame_t packing optimization not working in Windows x64

2017-07-24 Thread Segev Finer

Changes by Segev Finer <segev...@gmail.com>:


--
pull_requests: +2896

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue31018>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31018] _tracemalloc frame_t packing optimization not working in Windows x64

2017-07-24 Thread Segev Finer

Changes by Segev Finer <segev...@gmail.com>:


--
pull_requests: +2895

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue31018>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31018] _tracemalloc frame_t packing optimization not working in Windows x64

2017-07-24 Thread Segev Finer

New submission from Segev Finer:

..\Modules\_tracemalloc.c(88): warning C4359: '': Alignment 
specifier is less than actual alignment (8), and will be ignored.

For this to actually work we simply need to use #pragma pack instead.

--
components: Extension Modules, Windows
messages: 298999
nosy: Segev Finer, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: _tracemalloc frame_t packing optimization not working in Windows x64
type: enhancement
versions: Python 3.4, Python 3.5, Python 3.6, Python 3.7

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue31018>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30916] Pre-build OpenSSL and Tcl/Tk for Windows

2017-07-24 Thread Segev Finer

Changes by Segev Finer <segev...@gmail.com>:


--
pull_requests: +2894

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30916>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30222] make_zip.py had a bug when setting up full 64 bit distribution.

2017-07-22 Thread Segev Finer

Segev Finer added the comment:

I did make a PR which only changes -a/--arch to a choices argument. 
https://github.com/python/cpython/pull/2808

I guess the PR you are talking about is 
https://github.com/python/cpython/pull/2750/files which changes this entirely.

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30222>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30986] Add --include-py argument to Tools/msi/make_zip.py

2017-07-22 Thread Segev Finer

Segev Finer added the comment:

I used the full one. I doubt virtualenv (used by tox) will work with the 
embedding layout :P.

I remember getting an exception from something because it was missing the .py 
source files but I don't remember what it was and wasn't able to reproduce it 
now.

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30986>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27790] test_distutils spews linker messages on Windows

2017-07-22 Thread Segev Finer

Changes by Segev Finer <segev...@gmail.com>:


--
pull_requests: +2866

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue27790>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27790] test_distutils spews linker messages on Windows

2017-07-22 Thread Segev Finer

Segev Finer added the comment:

Investigated some more. We are adding /GL for release but not in debug. But 
adding /LTCG for both debug and release.

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue27790>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27790] test_distutils spews linker messages on Windows

2017-07-22 Thread Segev Finer

Segev Finer added the comment:

We are getting those warnings because distutils builds extension modules 
without /GL (https://msdn.microsoft.com/en-us/library/0zza0de8.aspx) but with 
/LTCG (https://msdn.microsoft.com/en-us/library/xbf3tbeh.aspx). We should 
either add /GL to truly enable whole program optimizations/link-time code 
generation or remove it.

It is added in 
https://github.com/python/cpython/blob/896145d9d266ee2758cfcd7691238cbc1f9e1ab8/Lib/distutils/_msvccompiler.py#L233-L241.

--
nosy: +Segev Finer
type:  -> behavior
versions: +Python 3.5, Python 3.6, Python 3.7

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue27790>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30222] make_zip.py had a bug when setting up full 64 bit distribution.

2017-07-21 Thread Segev Finer

Changes by Segev Finer <segev...@gmail.com>:


--
pull_requests: +2859

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30222>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30986] Add --include-py argument to Tools/msi/make_zip.py

2017-07-21 Thread Segev Finer

Changes by Segev Finer <segev...@gmail.com>:


--
pull_requests: +2857

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30986>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30986] Add --include-py argument to Tools/msi/make_zip.py

2017-07-21 Thread Segev Finer

New submission from Segev Finer:

Add an argument --include-py to Tools/msi/make_zip.py that allows including the 
Python modules sources and not only bytecode.

I found it useful while running Twisted's test suite in PR 2318, since I got an 
error otherwise. I don't remember what that error was and wasn't able to 
reproduce it while trying to run Twisted's test suite again.

--
components: Windows
messages: 298826
nosy: Segev Finer, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: Add --include-py argument to Tools/msi/make_zip.py
type: enhancement
versions: Python 3.7

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30986>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30222] make_zip.py had a bug when setting up full 64 bit distribution.

2017-07-21 Thread Segev Finer

Segev Finer added the comment:

Try with:

.\python.bat Tools\msi\make_zip.py -a amd64 -o py37-amd64.zip

It requires amd64 instead of x64. Probably can add a choices 
(https://docs.python.org/3/library/argparse.html#choices) argument there to 
make it more robust.

--
nosy: +Segev Finer

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30222>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29672] `catch_warnings` context manager causes all warnings to be printed every time, even after exiting

2017-07-21 Thread Segev Finer

Segev Finer added the comment:

I think you will need to save and restore _filters_version and _onceregistry. 
Since _filters_version is a static variable in _warnings.c you will probably 
also have to modify it somehow to make it accessible to warnings.py.

--
components: +Library (Lib)
nosy: +Segev Finer
type:  -> behavior
versions: +Python 3.6, Python 3.7

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29672>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30911] Warning in _json.c on platforms where char is unsigned

2017-07-15 Thread Segev Finer

Segev Finer added the comment:

Created http://bugs.python.org/issue30936

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30911>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30936] json module ref leaks detected by test_json

2017-07-15 Thread Segev Finer

New submission from Segev Finer:

>From builtbots:

test_json leaked [4, 4, 4] references, sum=12
test_json leaked [3, 3, 3] memory blocks, sum=9
1 test failed again:
test_json

Probably unearthed by:
https://github.com/python/cpython/pull/2692
https://github.com/python/cpython/pull/2693

--
components: Extension Modules
messages: 298391
nosy: Segev Finer, haypo, serhiy.storchaka
priority: normal
severity: normal
status: open
title: json module ref leaks detected by test_json
type: resource usage
versions: Python 3.5, Python 3.6

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30936>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30911] Warning in _json.c on platforms where char is unsigned

2017-07-15 Thread Segev Finer

Segev Finer added the comment:

Serhiy's change added tests to test_json, so you can say this unearthed ref 
leaks rather than introduced them. Probably needs a separate bpo issue and fix.

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30911>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30911] Warning in _json.c on platforms where char is unsigned

2017-07-13 Thread Segev Finer

Segev Finer added the comment:

Introduced in 
https://github.com/python/cpython/commit/ac5bbd43bc7b769c13ae0412cb28a3521f4d4ff1
 which is only in 3.7 that means this wasn't ever released. I can send a PR 
with a NEWS entry if it still needs one?

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30911>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30911] Warning in _json.c on platforms where char is unsigned

2017-07-12 Thread Segev Finer

Changes by Segev Finer <segev...@gmail.com>:


--
pull_requests: +2749

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30911>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30911] Warning in _json.c on platforms where char is unsigned

2017-07-12 Thread Segev Finer

New submission from Segev Finer:

Shows in buildbots:

/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Modules/_json.c: In 
function ‘scanner_new’:
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Modules/_json.c:1212:5: 
warning: comparison is always false due to limited range of data type 
[-Wtype-limits]
 if (s->strict < 0)
 ^

This means that the error check doesn't work right.

--
components: Extension Modules
messages: 298239
nosy: Segev Finer
priority: normal
severity: normal
status: open
title: Warning in _json.c on platforms where char is unsigned
type: compile error
versions: Python 3.7

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30911>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30797] ./pyconfig.h:1438:0: warning: "_GNU_SOURCE" redefined [enabled by default]

2017-07-12 Thread Segev Finer

Segev Finer added the comment:

The fix is now in 3.5-3.7 and 2.7, unless you intend to also back port to 3.4 
and 3.3, this can be closed.

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30797>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30797] ./pyconfig.h:1438:0: warning: "_GNU_SOURCE" redefined [enabled by default]

2017-07-11 Thread Segev Finer

Changes by Segev Finer <segev...@gmail.com>:


--
pull_requests: +2740

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30797>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30797] ./pyconfig.h:1438:0: warning: "_GNU_SOURCE" redefined [enabled by default]

2017-07-11 Thread Segev Finer

Changes by Segev Finer <segev...@gmail.com>:


--
pull_requests: +2739

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30797>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30797] ./pyconfig.h:1438:0: warning: "_GNU_SOURCE" redefined [enabled by default]

2017-07-11 Thread Segev Finer

Changes by Segev Finer <segev...@gmail.com>:


--
pull_requests: +2736

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30797>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30726] [Windows] Warnings in elementtree due to new expat

2017-07-04 Thread Segev Finer

Segev Finer added the comment:

> The approach used to suppress this warning will also suppress other warnings 
> that might be fixable. Hard to say it's definitely a good thing in this case, 
> though in general I agree that selectively suppressing warnings that cannot 
> be fixed is a good thing.

Most secure CRT warnings are a bit useless in portable code since you are 
unlikely to really use strcpy_s and friends...

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30726>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30726] [Windows] Warnings in elementtree due to new expat

2017-07-04 Thread Segev Finer

Changes by Segev Finer <segev...@gmail.com>:


--
pull_requests: +2643

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30726>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30726] [Windows] Warnings in elementtree due to new expat

2017-07-04 Thread Segev Finer

Segev Finer added the comment:

Python 2.7 diverged 
https://github.com/python/cpython/commit/ab3b0ade505ce07a3d5ec4fbc991a154242732e6.
 It's only missing _CRT_SECURE_NO_WARNINGS. :P

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30726>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30726] [Windows] Warnings in elementtree due to new expat

2017-07-04 Thread Segev Finer

Changes by Segev Finer <segev...@gmail.com>:


--
pull_requests: +2641

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30726>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30726] [Windows] Warnings in elementtree due to new expat

2017-07-04 Thread Segev Finer

Changes by Segev Finer <segev...@gmail.com>:


--
pull_requests: +2642

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30726>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue9566] Compilation warnings under x64 Windows

2017-06-29 Thread Segev Finer

Changes by Segev Finer <segev...@gmail.com>:


--
pull_requests: +2556

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue9566>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue9566] Compilation warnings under x64 Windows

2017-06-29 Thread Segev Finer

Segev Finer added the comment:

I submitted a PR which fixes some more warnings. The ones I haven't fixed are 
detailed in the PR description.

--
nosy: +Segev Finer
versions: +Python 3.7

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue9566>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue9566] Compilation warnings under x64 Windows

2017-06-29 Thread Segev Finer

Changes by Segev Finer <segev...@gmail.com>:


--
pull_requests: +2551

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue9566>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30726] [Windows] Warnings in elementtree due to new expat

2017-06-29 Thread Segev Finer

Segev Finer added the comment:

All that remains is back porting https://github.com/python/cpython/pull/2375 
and than this issue is fixed.

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30726>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30797] ./pyconfig.h:1438:0: warning: "_GNU_SOURCE" redefined [enabled by default]

2017-06-28 Thread Segev Finer

New submission from Segev Finer:

This is caused by _GNU_SOURCE being defined here: 
https://github.com/python/cpython/blob/c08177a1ccad2ed0d50898c2731b518c631aed14/configure.ac#L124,
 But also getting defined by AC_USE_SYSTEM_EXTENSIONS 
(https://github.com/python/cpython/blob/c08177a1ccad2ed0d50898c2731b518c631aed14/configure.ac#L906).

AC_USE_SYSTEM_EXTENSIONS does use an #ifndef but Python's AC_DEFINE seems to be 
getting order after it.

--
components: Build
messages: 297238
nosy: Segev Finer
priority: normal
severity: normal
status: open
title: ./pyconfig.h:1438:0: warning: "_GNU_SOURCE" redefined [enabled by 
default]
type: compile error
versions: Python 3.7

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30797>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30745] Warnings in Modules/_winapi.c

2017-06-24 Thread Segev Finer

Segev Finer added the comment:

I tried the PR locally and I didn't get the warnings. :)

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30745>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30726] [Windows] Warnings in elementtree due to new expat

2017-06-24 Thread Segev Finer

Changes by Segev Finer <segev...@gmail.com>:


--
versions: +Python 3.5, Python 3.6

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30726>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30726] [Windows] Warnings in elementtree due to new expat

2017-06-24 Thread Segev Finer

Segev Finer added the comment:

It seems that the issue repeats in pyexpat.vcxproj. I submitted a PR for that 
one as well.

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30726>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30726] [Windows] Warnings in elementtree due to new expat

2017-06-24 Thread Segev Finer

Changes by Segev Finer <segev...@gmail.com>:


--
pull_requests: +2422

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30726>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30745] Warnings in Modules/_winapi.c

2017-06-24 Thread Segev Finer

New submission from Segev Finer:

..\Modules\_winapi.c(886): warning C4090: 'function': different 'const' 
qualifiers
..\Modules\_winapi.c(848): warning C4101: 'wenvironment_size': unreferenced 
local variable

Added in d174d24a5d37d1516b885dc7c82f71ecd5930700

--
components: Windows
messages: 296761
nosy: Segev Finer, paul.moore, serhiy.storchaka, steve.dower, tim.golden, 
zach.ware
priority: normal
severity: normal
status: open
title: Warnings in Modules/_winapi.c
type: compile error
versions: Python 3.7

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30745>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30731] Use correct executable manifest for windows

2017-06-22 Thread Segev Finer

Changes by Segev Finer <segev...@gmail.com>:


--
pull_requests: +2377

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30731>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



  1   2   >