Re: [Qbs] Install/Depends resolution changed from qbs 1.12.2 to qbs 1.13.0?
On Mon, 20 May 2019 09:01:02 +0200 Richard Weickelt wrote: > > Oh yeah, it has been an unsatisfying surprise that default installation > > prefix changed from empty string to "usr/local/" on Linux. All builds > > are broken, all scripts working on the results are broken. Not > > hardcoding is not an option when it comes to CI integration etc. > > > > Next time I will be happy if such a change is announced in capital > > letters. > > This was also an unpleasant surprise for me. Note that > https://doc.qt.io/qbs/qml-qbsmodules-qbs.html#installPrefix-prop does not > reflect this change. That's an oversight. > Thus, instead of going over the docs, I'd rather like > to set installPrefix back to undefined on all platforms for Qbs 1.13.1. > > Anything that speaks against that? I think it is sensible to have proper default values. It also helps making the install prefix concept more visible, so users won't so easily make the mistake of putting e.g. /usr/local into the install dir. Christian ___ Qbs mailing list Qbs@qt-project.org https://lists.qt-project.org/listinfo/qbs
Re: [Qbs] Install/Depends resolution changed from qbs 1.12.2 to qbs 1.13.0?
Funny fact, but Qbs tests on were failing on macOS because of this change:) However, I am not sure that we should roll it back, we can break something *again* The original motivation for this change is that Qbs used to misinterpret install-root and install-prefix paths. Now it is consistent with other build systems: install-root/install-prefix/your/directory/structure The reason is that prefix may be hardcoded in the binary like it is done for qmake and setting install-root to /usr/local is wrong, install-root should be /. Well, yes, in most cases, when app is portable it doesn't make any difference so I understand that change is annoying (I was the one who could not run tests on macOS) But the doc should be updated... Иван Комиссаров 20 мая 2019 г., в 9:01, Richard Weickelt написал(а): >> Oh yeah, it has been an unsatisfying surprise that default installation >> prefix changed from empty string to "usr/local/" on Linux. All builds >> are broken, all scripts working on the results are broken. Not >> hardcoding is not an option when it comes to CI integration etc. >> >> Next time I will be happy if such a change is announced in capital >> letters. > > This was also an unpleasant surprise for me. Note that > https://doc.qt.io/qbs/qml-qbsmodules-qbs.html#installPrefix-prop does not > reflect this change. Thus, instead of going over the docs, I'd rather like > to set installPrefix back to undefined on all platforms for Qbs 1.13.1. > > Anything that speaks against that? > > Richard > ___ > Qbs mailing list > Qbs@qt-project.org > https://lists.qt-project.org/listinfo/qbs ___ Qbs mailing list Qbs@qt-project.org https://lists.qt-project.org/listinfo/qbs
Re: [Qbs] Install/Depends resolution changed from qbs 1.12.2 to qbs 1.13.0?
> Oh yeah, it has been an unsatisfying surprise that default installation > prefix changed from empty string to "usr/local/" on Linux. All builds > are broken, all scripts working on the results are broken. Not > hardcoding is not an option when it comes to CI integration etc. > > Next time I will be happy if such a change is announced in capital > letters. This was also an unpleasant surprise for me. Note that https://doc.qt.io/qbs/qml-qbsmodules-qbs.html#installPrefix-prop does not reflect this change. Thus, instead of going over the docs, I'd rather like to set installPrefix back to undefined on all platforms for Qbs 1.13.1. Anything that speaks against that? Richard ___ Qbs mailing list Qbs@qt-project.org https://lists.qt-project.org/listinfo/qbs
