Re: [PATCH] iotests: Add copyright line in qcow2.py
Am 09.06.2020 um 22:59 hat Eric Blake geschrieben: > The file qcow2.py was originally contributed in 2012 by Kevin Wolf, > but was not given traditional boilerplate headers at the time. The > missing license was just rectified (commit 16306a7b39) using the > project-default GPLv2+, but as Vladimir is not at Red Hat, he did not > add a Copyright line. All earlier contributions have come from CC'd > authors, where all but Stefan used a Red Hat address at the time of > the contribution, and that copyright carries over to the split to > qcow2_format.py (d5262c7124). > > CC: Kevin Wolf > CC: Stefan Hajnoczi > CC: Eduardo Habkost > CC: Max Reitz > CC: Philippe Mathieu-Daudé > CC: Paolo Bonzini > Signed-off-by: Eric Blake Thanks, applied to the block branch. Kevin
Re: [PATCH] iotests: Add copyright line in qcow2.py
On Tue, Jun 09, 2020 at 03:59:44PM -0500, Eric Blake wrote: > The file qcow2.py was originally contributed in 2012 by Kevin Wolf, > but was not given traditional boilerplate headers at the time. The > missing license was just rectified (commit 16306a7b39) using the > project-default GPLv2+, but as Vladimir is not at Red Hat, he did not > add a Copyright line. All earlier contributions have come from CC'd > authors, where all but Stefan used a Red Hat address at the time of > the contribution, and that copyright carries over to the split to > qcow2_format.py (d5262c7124). > > CC: Kevin Wolf > CC: Stefan Hajnoczi > CC: Eduardo Habkost > CC: Max Reitz > CC: Philippe Mathieu-Daudé > CC: Paolo Bonzini > Signed-off-by: Eric Blake > > --- > Commit ids above assume my bitmaps pull request does not have to be respun... > Based-on: <20200609205245.3548257-1-ebl...@redhat.com> > --- > tests/qemu-iotests/qcow2.py| 2 ++ > tests/qemu-iotests/qcow2_format.py | 1 + > 2 files changed, 3 insertions(+) The git history shows which lines were contributed by IBM and is more detailed than a single copyright line at the top of the file. It's also common to make smaller contributions, like the one I made here, without adding a copyright line. In light of this I see no issue with adding a Red Hat copyright line and there is no need to add one for IBM: Acked-by: Stefan Hajnoczi signature.asc Description: PGP signature
Re: [PATCH] iotests: Add copyright line in qcow2.py
On 6/9/20 10:59 PM, Eric Blake wrote: > The file qcow2.py was originally contributed in 2012 by Kevin Wolf, > but was not given traditional boilerplate headers at the time. The > missing license was just rectified (commit 16306a7b39) using the > project-default GPLv2+, but as Vladimir is not at Red Hat, he did not > add a Copyright line. All earlier contributions have come from CC'd > authors, where all but Stefan used a Red Hat address at the time of > the contribution, and that copyright carries over to the split to > qcow2_format.py (d5262c7124). > > CC: Kevin Wolf > CC: Stefan Hajnoczi > CC: Eduardo Habkost > CC: Max Reitz > CC: Philippe Mathieu-Daudé > CC: Paolo Bonzini > Signed-off-by: Eric Blake Acked-by: Philippe Mathieu-Daudé > --- > Commit ids above assume my bitmaps pull request does not have to be respun... > Based-on: <20200609205245.3548257-1-ebl...@redhat.com> > --- > tests/qemu-iotests/qcow2.py| 2 ++ > tests/qemu-iotests/qcow2_format.py | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/tests/qemu-iotests/qcow2.py b/tests/qemu-iotests/qcow2.py > index 8c187e9a7292..0910e6ac0705 100755 > --- a/tests/qemu-iotests/qcow2.py > +++ b/tests/qemu-iotests/qcow2.py > @@ -2,6 +2,8 @@ > # > # Manipulations with qcow2 image > # > +# Copyright (C) 2012 Red Hat, Inc. > +# > # This program is free software; you can redistribute it and/or modify > # it under the terms of the GNU General Public License as published by > # the Free Software Foundation; either version 2 of the License, or > diff --git a/tests/qemu-iotests/qcow2_format.py > b/tests/qemu-iotests/qcow2_format.py > index 0f65fd161d5b..cc432e7ae06c 100644 > --- a/tests/qemu-iotests/qcow2_format.py > +++ b/tests/qemu-iotests/qcow2_format.py > @@ -1,6 +1,7 @@ > # Library for manipulations with qcow2 image > # > # Copyright (c) 2020 Virtuozzo International GmbH. > +# Copyright (C) 2012 Red Hat, Inc. > # > # This program is free software; you can redistribute it and/or modify > # it under the terms of the GNU General Public License as published by >
